Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Verify namespaced package dependencies and isolate consumer builds

Yuechen Li39f2be3f538c
diff --git a/docs/development/reports/2026-10/RELEASE-2.0.0-CLOSEOUT.md b/docs/development/reports/2026-10/RELEASE-2.0.0-CLOSEOUT.md
index 49fb751d..eb086275 100644
--- a/docs/development/reports/2026-10/RELEASE-2.0.0-CLOSEOUT.md
+++ b/docs/development/reports/2026-10/RELEASE-2.0.0-CLOSEOUT.md
@@ -71,6 +71,11 @@ and Termination/Extent, reject conflicts, and require whole-field consumption.
No geometry algorithm, fillet planner, tessellator or STEP orientation resolver
was changed.
+The final owner review also reproduced a malformed `StartFrame Empty;` crash.
+It now rejects with `wireform-start-frame-invalid` in both real CLI commands,
+retaining an explanation and producing no STEP. This is a reader guard, not a
+new fallback or recovery interpretation.
+
CLI diagnostics carry code, severity, explanation, source file, stage and source
location when available. Missing-file diagnostics have no invented span. Legacy
and expanded producers still disclose enclosing locations where exact provenance
@@ -127,3 +132,19 @@ byte-identical STEP witness cover the repair. The key-order test normalizes its
own mutation input. Hosted qualification also serializes xUnit collections (in
addition to test assemblies), so independent corpus tessellations do not contend
against one another's bounded execution budgets. No product budget is enlarged.
+
+## Code-quality review
+
+Consumption was checked at the existing field readers before their rewrites.
+There is no new error-code fatality list, whole-document parser dispatch or
+geometry strategy. Command routing is shared and delegates to existing owners;
+spatial fields reuse existing metadata. Temporary probe files are cleaned in
+finally blocks; parse state and product runtime state were not made global.
+
+The package verifier now reads dependency nodes regardless of the NuGet XML
+namespace. A real package manifest mutated to depend on `Aetheris.NotPublished`
+is rejected; the real 25-package graph passes. The consumer smoke disables
+repository Directory.Build props/targets, uses only staged packages plus
+nuget.org and an empty cache, then invokes the public Forge API and reimports
+its STEP. This prevents a repository-local build from masquerading as package
+qualification. The desktop smoke also invokes the actual NativeAOT host.
diff --git a/scripts/Test-PublicPackageConsumer.ps1 b/scripts/Test-PublicPackageConsumer.ps1
index f6aaccf6..630543b6 100644
--- a/scripts/Test-PublicPackageConsumer.ps1
+++ b/scripts/Test-PublicPackageConsumer.ps1
@@ -17,9 +17,9 @@ $escaped = [Security.SecurityElement]::Escape($feed)
[IO.File]::WriteAllText((Join-Path $output 'NuGet.Config'), "<configuration><packageSources><clear/><add key='candidate' value='$escaped'/><add key='nuget.org' value='https://api.nuget.org/v3/index.json'/></packageSources></configuration>")
$cache = Join-Path $output 'packages'
$project = Join-Path $output 'PublicPackageSmoke.csproj'
-dotnet restore $project --configfile (Join-Path $output 'NuGet.Config') --packages $cache --no-cache -m:1 -nr:false -p:AetherisReleaseVersion=$Version
+dotnet restore $project --configfile (Join-Path $output 'NuGet.Config') --packages $cache --no-cache -m:1 -nr:false -p:ImportDirectoryBuildProps=false -p:ImportDirectoryBuildTargets=false -p:AetherisReleaseVersion=$Version
if ($LASTEXITCODE -ne 0) { throw 'Empty-cache public consumer restore failed.' }
-dotnet build $project -c Release --no-restore -m:1 -nr:false -p:UseSharedCompilation=false -p:RestorePackagesPath=$cache -p:AetherisReleaseVersion=$Version
+dotnet build $project -c Release --no-restore -m:1 -nr:false -p:UseSharedCompilation=false -p:ImportDirectoryBuildProps=false -p:ImportDirectoryBuildTargets=false -p:RestorePackagesPath=$cache -p:AetherisReleaseVersion=$Version
if ($LASTEXITCODE -ne 0) { throw 'Public consumer build failed.' }
$previousVersion = $env:AETHERIS_RELEASE_VERSION
try {
diff --git a/scripts/Test-PublicPackageGraph.ps1 b/scripts/Test-PublicPackageGraph.ps1
index 779160ae..76b3b73d 100644
--- a/scripts/Test-PublicPackageGraph.ps1
+++ b/scripts/Test-PublicPackageGraph.ps1
@@ -27,7 +27,7 @@ if ($available.Count -ne $order.Count) { throw 'Manifest count differs from pack
$visited = [Collections.Generic.HashSet[string]]::new([StringComparer]::Ordinal)
foreach ($id in $order) {
if (-not $available.ContainsKey($id)) { throw "Missing public package $id." }
- foreach ($dependency in $available[$id].SelectNodes('.//dependency')) {
+ foreach ($dependency in $available[$id].SelectNodes(".//*[local-name()='dependency']")) {
if ($dependency.id -notlike 'Aetheris.*') { continue }
if (-not $visited.Contains($dependency.id)) { throw "$id depends on missing or unordered package $($dependency.id)." }
if ($dependency.version -ne $Version) { throw "$id has a mismatched dependency: $($dependency.id) $($dependency.version)." }