Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Add controlled Firmament V2 Y-axis side-hole route

Yuechen Li3c26203eedc5
diff --git a/Aetheris.CLI.Tests/AirTraceCommandTests.cs b/Aetheris.CLI.Tests/AirTraceCommandTests.cs
index 7afe16dd..d6ca3e14 100644
--- a/Aetheris.CLI.Tests/AirTraceCommandTests.cs
+++ b/Aetheris.CLI.Tests/AirTraceCommandTests.cs
@@ -1300,6 +1300,44 @@ public sealed class AirTraceCommandTests
private static string RegionFixture(string relative) => Path.GetFullPath(Path.Combine(AppContext.BaseDirectory, "../../../../fixtures/Firmament/Region", relative));
private static string FirmamentV2Fixture(string relative) => Path.GetFullPath(Path.Combine(AppContext.BaseDirectory, "../../../../fixtures/FirmamentV2", relative));
+ [Fact]
+ public void FirmamentV2SideHoleYAxis_TraceJsonContainsRouteEvidence()
+ {
+ var (_, output, _) = Run("trace", "--fixture", FirmamentV2Fixture("Region/valid/side-hole-y-axis-v2.valid.firmfixture"), "--json");
+ using var doc = JsonDocument.Parse(output);
+ var intent = doc.RootElement.GetProperty("firmamentV2").GetProperty("semanticIntent");
+ var route = intent.GetProperty("routeEvidence");
+ Assert.Equal("Y", route.GetProperty("axis").GetString());
+ Assert.Equal("+Y->-Y", route.GetProperty("direction").GetString());
+ Assert.Equal("+Y", route.GetProperty("attachFace").GetString());
+ Assert.Equal("-Y", route.GetProperty("throughFace").GetString());
+ Assert.Equal("face(+Y):u=+X,v=+Z", intent.GetProperty("centerSelectorFrame").GetString());
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleYAxis_TraceTextContainsRouteEvidence()
+ {
+ var (_, output, _) = Run("trace", "--fixture", FirmamentV2Fixture("Region/valid/side-hole-y-axis-v2.valid.firmfixture"));
+ Assert.Contains("On: face(+Y)", output);
+ Assert.Contains("Through: face(-Y)", output);
+ Assert.Contains("Route: +Y -> -Y", output);
+ Assert.Contains("Center frame: face(+Y) local u=+X, v=+Z", output);
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleYAxis_ArtifactsEmit()
+ {
+ var dir = Path.Combine(Path.GetTempPath(), "aetheris-trace-tests", Guid.NewGuid().ToString("N"));
+ Assert.Equal(0, Run("trace", "--fixture", FirmamentV2Fixture("Region/valid/side-hole-y-axis-v2.valid.firmfixture"), "--out-dir", dir).ExitCode);
+ Assert.All(new[] { "side-hole-y-axis-v2.step", "side-hole-y-axis-v2.trace.json", "side-hole-y-axis-v2.trace.txt", "manifest.json" }, name => Assert.True(new FileInfo(Path.Combine(dir, name)).Length > 0, name));
+ using var doc = JsonDocument.Parse(File.ReadAllText(Path.Combine(dir, "manifest.json")));
+ var route = doc.RootElement.GetProperty("route");
+ Assert.Equal("Y", route.GetProperty("axis").GetString());
+ Assert.Equal("+Y->-Y", route.GetProperty("direction").GetString());
+ Assert.Equal("+Y", route.GetProperty("attachFace").GetString());
+ Assert.Equal("-Y", route.GetProperty("throughFace").GetString());
+ }
+
private static (int ExitCode, string Stdout, string Stderr) Run(params string[] args)
{
var stdout = new StringWriter(); var stderr = new StringWriter();
diff --git a/Aetheris.CLI/AirTrace.cs b/Aetheris.CLI/AirTrace.cs
index dcf6f294..1e84510e 100644
--- a/Aetheris.CLI/AirTrace.cs
+++ b/Aetheris.CLI/AirTrace.cs
@@ -148,7 +148,7 @@ internal static class AirTraceReportBuilder
? null
: new AirTraceConstructiveAirSummary(frontend.ConstructiveAir.NodeKind, frontend.ConstructiveAir.CanonicalForm, frontend.ConstructiveAir.SourceFeatureAirNodeKind, frontend.ConstructiveAir.ProfileKind, frontend.ConstructiveAir.Dimensions.Width, frontend.ConstructiveAir.Dimensions.Depth, frontend.ConstructiveAir.Dimensions.Height, frontend.ConstructiveAir.ExtrusionAxis, frontend.ConstructiveAir.ConstructionIntent, frontend.ConstructiveAir.RouteKind, frontend.ConstructiveAir.StageReached, frontend.ConstructiveAir.Diagnostics, frontend.ConstructiveAir.Guarantees);
- var regions = frontend.FirmamentV2?.SemanticIntent is not null ? AirRegionTraceFactory.ForFaceAttachedSideHoleDeferred(frontend.FirmamentV2.SemanticIntent.Radius, frontend.FirmamentV2.SemanticIntent.CenterU, frontend.FirmamentV2.SemanticIntent.CenterV) : AirRegionTraceFactory.ForRootBody(actualStage ?? "emitted-brep");
+ var regions = frontend.FirmamentV2?.SemanticIntent is not null ? AirRegionTraceFactory.ForFaceAttachedSideHoleDeferred(frontend.FirmamentV2.SemanticIntent.Radius, frontend.FirmamentV2.SemanticIntent.CenterU, frontend.FirmamentV2.SemanticIntent.CenterV, frontend.FirmamentV2.SemanticIntent.AttachFace, frontend.FirmamentV2.SemanticIntent.ThroughFace, frontend.FirmamentV2.SemanticIntent.CenterSelectorFrame) : AirRegionTraceFactory.ForRootBody(actualStage ?? "emitted-brep");
fxDiagnostics = Stable([.. fxDiagnostics, .. regions.Diagnostics]).ToArray();
var profileEmission = profileEmissionProbe is null ? null : new AirTraceProfileEmissionSummary(
profileEmissionProbe.WrapperInvoked,
@@ -363,7 +363,8 @@ internal static class AirTraceTextRenderer
b.AppendLine($" Radius: {region.Radius:g}");
var cu = region.Center?.U ?? 0; var cv = region.Center?.V ?? 0;
b.AppendLine($" Center: [{cu:g}, {cv:g}]");
- b.AppendLine($" Center frame: {((region.ResolvedOn.Contains("-X", StringComparison.Ordinal) ? "face(-X):u=+Y,v=+Z" : "face(+X):u=+Y,v=+Z").Replace(":u=", " local u=").Replace(",v=", ", v="))}");
+ var frame = FirmamentV2FaceLocalPoint2D.ConventionFor(region.ResolvedOn.Contains("-X", StringComparison.Ordinal) ? "-X" : region.ResolvedOn.Contains("+Y", StringComparison.Ordinal) ? "+Y" : region.ResolvedOn.Contains("-Y", StringComparison.Ordinal) ? "-Y" : "+X");
+ b.AppendLine($" Center frame: {frame.Replace(":u=", " local u=").Replace(",v=", ", v=")}");
b.AppendLine($" Through: {region.Through}");
if (!string.Equals(region.Through, region.ResolvedThrough, StringComparison.Ordinal)) b.AppendLine($" Resolved through: {region.ResolvedThrough}");
}
diff --git a/Aetheris.CLI/CliRunner.cs b/Aetheris.CLI/CliRunner.cs
index e83965d8..f23246f1 100644
--- a/Aetheris.CLI/CliRunner.cs
+++ b/Aetheris.CLI/CliRunner.cs
@@ -35,7 +35,7 @@ internal static class SideHoleGoldenPathArtifacts
parentIntegration = report.FirmamentV2?.ParentIntegration ?? "Integrated",
shellClosure = report.FirmamentV2?.ShellClosure ?? "Closed",
stepSmoke = report.FirmamentV2?.StepSmoke ?? "Succeeded",
- route = report.FirmamentV2?.SemanticIntent is null ? null : new { axis = "X", direction = report.FirmamentV2.SemanticIntent.Route, attachFace = report.FirmamentV2.SemanticIntent.AttachFace, throughFace = report.FirmamentV2.SemanticIntent.ThroughFace },
+ route = report.FirmamentV2?.SemanticIntent?.RouteEvidence,
radius = report.FirmamentV2?.SemanticIntent?.Radius,
tool = report.FirmamentV2?.SemanticIntent?.Tool,
attachTargetSource = report.FirmamentV2?.SemanticIntent?.AttachTargetSource,
@@ -62,6 +62,9 @@ internal static class SideHoleGoldenPathArtifacts
var centerV = report.FirmamentV2!.SemanticIntent!.CenterV;
if (report.FirmamentV2!.SemanticIntent!.Route == "-X->+X" && (report.FirmamentV2!.SemanticIntent!.AttachTargetKind == "Alias" || report.FirmamentV2!.SemanticIntent!.ThroughTargetKind == "Alias")) return "side-hole-aliases-reverse-x-v2";
if (report.FirmamentV2!.SemanticIntent!.Route == "-X->+X") return "side-hole-reverse-x-v2";
+ if (report.FirmamentV2!.SemanticIntent!.Route == "+Y->-Y" && (report.FirmamentV2!.SemanticIntent!.AttachTargetKind == "Alias" || report.FirmamentV2!.SemanticIntent!.ThroughTargetKind == "Alias")) return "side-hole-aliases-y-axis-v2";
+ if (report.FirmamentV2!.SemanticIntent!.Route == "+Y->-Y") return "side-hole-y-axis-v2";
+ if (report.FirmamentV2!.SemanticIntent!.Route == "-Y->+Y") return "side-hole-reverse-y-v2";
if (report.FirmamentV2!.SemanticIntent!.AttachTargetKind == "Alias" || report.FirmamentV2!.SemanticIntent!.ThroughTargetKind == "Alias") return "side-hole-aliases-v2";
if (Math.Abs(centerU) > 1e-12 || Math.Abs(centerV) > 1e-12)
{
diff --git a/Aetheris.Kernel.Core/Air/AirRegions.cs b/Aetheris.Kernel.Core/Air/AirRegions.cs
index 8b46cd76..b068a6e4 100644
--- a/Aetheris.Kernel.Core/Air/AirRegions.cs
+++ b/Aetheris.Kernel.Core/Air/AirRegions.cs
@@ -303,17 +303,17 @@ internal static class AirRegionTraceFactory
return Summary([root], ["air-region-x1-region-trace-created", "air-region-x1-root-region-created", "air-region-x1-world-root-frame-created"], ["AIR Region trace-only summary", "root region does not change BRepPlan semantics"]);
}
- public static AirRegionTraceSummary ForFaceAttachedSideHoleDeferred(double radius = 1, double centerU = 0, double centerV = 0)
+ public static AirRegionTraceSummary ForFaceAttachedSideHoleDeferred(double radius = 1, double centerU = 0, double centerV = 0, string attachFace = "+X", string throughFace = "-X", string centerFrame = "face(+X):u=+Y,v=+Z")
{
var root = RootRegion("region-created");
AirRegionSummary sideBase = new(
- "region:side-hole:+x",
+ $"region:side-hole:{attachFace.ToLowerInvariant()}",
AirRegionKind.FaceAttachedRegion,
root.RegionId,
AirRegionEffectKind.Subtractive,
AirRegionYieldKind.YieldSubtractiveVolume,
AirRegionBoundaryContractKind.YieldsCutVolume,
- new AirLocalFrameSummary("frame:side-hole:+x", AirLocalFrameKind.FaceAttached, new(5, 0, 0), new(0, 1, 0), new(0, 0, 1), new(1, 0, 0), AirLocalFrameHandedness.RightHanded, "box.face(\"+X\")", "+X", "+Z", true, ["air-region-x1-face-attached-frame-created"]),
+ FrameForSideHole(attachFace),
AirRegionIntegrationStatus.Deferred,
"deferred:no-geometry-integration",
"region-integration-deferred",
@@ -321,7 +321,7 @@ internal static class AirRegionTraceFactory
["air-region-x1-face-attached-region-created", "air-region-x1-region-effect-declared", "air-region-x1-region-yield-declared", "air-region-x1-boundary-contract-declared", "air-region-x1-parent-integration-deferred", "air-region-x2-yield-contract-created", "air-region-x2-side-hole-yield-created", "air-region-x2-face-attachment-recorded", "air-region-x2-local-profile-recorded", "air-region-x2-circle-profile-recorded", "air-region-x2-through-direction-recorded", "air-region-x2-affected-scope-recorded", "air-region-x2-boundary-intent-recorded", "air-region-x2-entry-loop-intent-recorded", "air-region-x2-exit-boundary-deferred", "air-region-x2-region-locality-enforced", "air-region-x2-explicit-yield-only", "air-region-x2-parent-integration-deferred", "air-region-x2-no-implicit-parent-mutation", "air-region-x2-no-boolean", "air-region-x2-no-brep-emission", "air-region-x2-no-step-smoke", "air-region-x2-no-cir-mirror", "air-region-x2-trace-only"],
["side-hole geometry integration not implemented", "concrete through depth deferred", "opposite-side exit boundary deferred"],
["escapes only through explicit yield", "no implicit parent mutation", "no Boolean", "no BRep emission", "no production route replacement", "trace-only"],
- SideHoleYield(root.RegionId, radius, centerU, centerV));
+ SideHoleYield(root.RegionId, radius, centerU, centerV, attachFace, throughFace, centerFrame));
var mirror = AirSideHoleRegionCirMirrorAdapter.Admit(sideBase);
var boundary = SideHoleBRepBoundary(sideBase);
var decision = AirSideHoleRegionIntegrationSelector.Decide(sideBase, mirror.Summary, boundary);
@@ -332,7 +332,7 @@ internal static class AirRegionTraceFactory
var parentIntegration = AirSideHoleParentBRepIntegrationPrototype.AttemptCutWallAttachment(sideBase, boundary, placeholders, materialization, faceSplit, exitLoop);
var cutWallAttachment = AirSideHoleParentBRepIntegrationPrototype.AttachCutWall(sideBase, placeholders, faceSplit, exitLoop);
var shellClosure = AirSideHoleParentBRepIntegrationPrototype.AttemptShellClosure(sideBase, placeholders, cutWallAttachment);
- var x10Decision = decision with { SelectedRouteKind = AirRegionIntegrationRouteKind.ControlledSideHoleParentBRepIntegration, SelectedStatus = AirRegionIntegrationStatus.Integrated, Recommendation = $"controlled parent BRep integration succeeded for the +X/-X/radius={radius:g}/center=({centerU:g},{centerV:g}) fixture; entry loop, exit loop, cylindrical cut wall, and RegionIntegrationPatch are consumed into closed shell evidence", Diagnostics = Stable([.. decision.Diagnostics, .. materialization.Diagnostics, .. parentIntegration.Diagnostics, .. faceSplit.Diagnostics, .. exitLoop.Diagnostics, .. cutWallAttachment.Diagnostics, .. shellClosure.Diagnostics]).ToArray(), KnownLosses = Stable([.. decision.KnownLosses, .. materialization.KnownLosses, .. parentIntegration.KnownLosses]).ToArray(), Guarantees = Stable([.. decision.Guarantees, .. materialization.Guarantees, .. parentIntegration.Guarantees, .. faceSplit.Guarantees, .. exitLoop.Guarantees, .. cutWallAttachment.Guarantees, .. shellClosure.Guarantees]).ToArray() };
+ var x10Decision = decision with { SelectedRouteKind = AirRegionIntegrationRouteKind.ControlledSideHoleParentBRepIntegration, SelectedStatus = AirRegionIntegrationStatus.Integrated, Recommendation = $"controlled parent BRep integration succeeded for the {attachFace}/{throughFace}/radius={radius:g}/center=({centerU:g},{centerV:g}) fixture; entry loop, exit loop, cylindrical cut wall, and RegionIntegrationPatch are consumed into closed shell evidence", Diagnostics = Stable([.. decision.Diagnostics, .. materialization.Diagnostics, .. parentIntegration.Diagnostics, .. faceSplit.Diagnostics, .. exitLoop.Diagnostics, .. cutWallAttachment.Diagnostics, .. shellClosure.Diagnostics]).ToArray(), KnownLosses = Stable([.. decision.KnownLosses, .. materialization.KnownLosses, .. parentIntegration.KnownLosses]).ToArray(), Guarantees = Stable([.. decision.Guarantees, .. materialization.Guarantees, .. parentIntegration.Guarantees, .. faceSplit.Guarantees, .. exitLoop.Guarantees, .. cutWallAttachment.Guarantees, .. shellClosure.Guarantees]).ToArray() };
var side = sideBase with
{
StageReached = "region-parent-integrated",
@@ -362,12 +362,20 @@ internal static class AirRegionTraceFactory
return Summary([root, bad], ["air-region-x1-region-trace-created", "air-region-x1-implicit-parent-mutation-rejected", "air-region-x1-no-brep-emission", "air-region-x1-no-boolean", "air-region-x2-implicit-parent-mutation-rejected", "air-region-x2-missing-explicit-yield-rejected", "air-region-x2-boundary-contract-required"], ["no Boolean", "no geometry", "no BRep emission"]);
}
- private static AirRegionYieldSummary SideHoleYield(string parentRegionId, double radius = 1, double centerU = 0, double centerV = 0) => new(
- "yield:side-hole:+x:subtractive-volume", AirRegionYieldKind.YieldSubtractiveVolume, "SideHole", AirRegionEffectKind.Subtractive, "frame:side-hole:+x", parentRegionId,
- new("Face", parentRegionId, "parser-backed/root box fixture", "+X", "SideFace", "frame:side-hole:+x", ["air-region-x2-face-attachment-recorded"]),
- new("Circle", new(centerU, centerV), radius, "CircularEntryLoop", "face(+X):u=+Y,v=+Z"),
+ private static AirLocalFrameSummary FrameForSideHole(string attachFace) => attachFace switch
+ {
+ "+Y" => new("frame:side-hole:+y", AirLocalFrameKind.FaceAttached, new(0, 4, 0), new(1, 0, 0), new(0, 0, 1), new(0, 1, 0), AirLocalFrameHandedness.RightHanded, "box.face(\"+Y\")", "+Y", "+Z", true, ["air-region-x1-face-attached-frame-created"]),
+ "-Y" => new("frame:side-hole:-y", AirLocalFrameKind.FaceAttached, new(0, -4, 0), new(1, 0, 0), new(0, 0, 1), new(0, -1, 0), AirLocalFrameHandedness.RightHanded, "box.face(\"-Y\")", "-Y", "+Z", true, ["air-region-x1-face-attached-frame-created"]),
+ "-X" => new("frame:side-hole:-x", AirLocalFrameKind.FaceAttached, new(-5, 0, 0), new(0, 1, 0), new(0, 0, 1), new(-1, 0, 0), AirLocalFrameHandedness.RightHanded, "box.face(\"-X\")", "-X", "+Z", true, ["air-region-x1-face-attached-frame-created"]),
+ _ => new("frame:side-hole:+x", AirLocalFrameKind.FaceAttached, new(5, 0, 0), new(0, 1, 0), new(0, 0, 1), new(1, 0, 0), AirLocalFrameHandedness.RightHanded, "box.face(\"+X\")", "+X", "+Z", true, ["air-region-x1-face-attached-frame-created"])
+ };
+
+ private static AirRegionYieldSummary SideHoleYield(string parentRegionId, double radius = 1, double centerU = 0, double centerV = 0, string attachFace = "+X", string throughFace = "-X", string centerFrame = "face(+X):u=+Y,v=+Z") => new(
+ $"yield:side-hole:{attachFace.ToLowerInvariant()}:subtractive-volume", AirRegionYieldKind.YieldSubtractiveVolume, "SideHole", AirRegionEffectKind.Subtractive, $"frame:side-hole:{attachFace.ToLowerInvariant()}", parentRegionId,
+ new("Face", parentRegionId, "parser-backed/root box fixture", attachFace, "SideFace", $"frame:side-hole:{attachFace.ToLowerInvariant()}", ["air-region-x2-face-attachment-recorded"]),
+ new("Circle", new(centerU, centerV), radius, "CircularEntryLoop", centerFrame),
new("FaceNormal", "LocalZ", "Inward", true, "Through", ["air-region-x2-through-direction-recorded"]),
- new("ParentBodyLocalFeature", true, "+X", false, true, ["air-region-x2-affected-scope-recorded", "air-region-x2-explicit-yield-only"]),
+ new("ParentBodyLocalFeature", true, attachFace, false, true, ["air-region-x2-affected-scope-recorded", "air-region-x2-explicit-yield-only"]),
new("ThroughCut", "CircularEntryLoop", "Deferred", "CircularRimIntent", "Deferred", ["air-region-x2-boundary-intent-recorded", "air-region-x2-entry-loop-intent-recorded", "air-region-x2-exit-boundary-deferred"]),
AirRegionIntegrationStatus.Deferred,
["air-region-x2-yield-contract-created", "air-region-x2-side-hole-yield-created", "air-region-x2-region-locality-enforced"],
diff --git a/Aetheris.Kernel.Firmament.Tests/FirmamentV2ParserTests.cs b/Aetheris.Kernel.Firmament.Tests/FirmamentV2ParserTests.cs
index 3f8fcb9a..7fc16a08 100644
--- a/Aetheris.Kernel.Firmament.Tests/FirmamentV2ParserTests.cs
+++ b/Aetheris.Kernel.Firmament.Tests/FirmamentV2ParserTests.cs
@@ -407,7 +407,7 @@ public sealed class FirmamentV2ParserTests
{
Assert.Contains(FirmamentV2Parser.SideHoleSameFaceUnsupported, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-same-face-x-v2.invalid.firmfixture")).Diagnostics);
Assert.Contains(FirmamentV2Parser.SideHoleRouteUnsupported, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-mixed-axis-x-to-y-v2.invalid.firmfixture")).Diagnostics);
- Assert.Contains(FirmamentV2Parser.SideHoleAxisNotYetSupported, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-y-axis-not-yet-supported-v2.invalid.firmfixture")).Diagnostics);
+ Assert.Contains(FirmamentV2Parser.SideHoleAxisNotYetSupported, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-z-axis-not-yet-supported-v2.invalid.firmfixture")).Diagnostics);
Assert.Contains(FirmamentV2Parser.SideHoleRouteUnsupported, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-alias-reverse-x-wrong-through-v2.invalid.firmfixture")).Diagnostics);
}
@@ -474,6 +474,61 @@ public sealed class FirmamentV2ParserTests
Assert.Contains(FirmamentV2Parser.SideHoleAliasResolvesToUnsupportedFace, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-alias-wrong-face-v2.invalid.firmfixture")).Diagnostics);
}
+ [Fact]
+ public void FirmamentV2SideHoleYAxis_ParsesDirectYRoute()
+ {
+ var intent = FirmamentV2Parser.Parse(Source("Region/valid/side-hole-y-axis-v2.valid.firmfixture")).Document!.SideHoleIntent!;
+ Assert.Equal("+Y", intent.AttachFace);
+ Assert.Equal("-Y", intent.ThroughFace);
+ Assert.Equal("+Y->-Y", intent.Route);
+ Assert.Equal("Y", intent.RouteEvidence.Axis);
+ Assert.Equal("face(+Y):u=+X,v=+Z", intent.CenterSelectorFrame);
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleYAxis_DirectYReachesGoldenPath()
+ {
+ var result = FirmamentFrontendTraceProbe.ParseV2Only(Source("Region/valid/side-hole-y-axis-v2.valid.firmfixture"));
+ Assert.True(result.ParseSucceeded, string.Join(", ", result.Diagnostics));
+ Assert.Equal("region-parent-integrated", result.FirmamentV2!.StageReached);
+ Assert.Equal("Integrated", result.FirmamentV2.ParentIntegration);
+ Assert.Equal("Closed", result.FirmamentV2.ShellClosure);
+ Assert.Equal("Succeeded", result.FirmamentV2.StepSmoke);
+ Assert.Null(result.FirmamentV2.Blocker);
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleYAxis_ParsesReverseYRoute()
+ {
+ var intent = FirmamentV2Parser.Parse(Source("Region/valid/side-hole-reverse-y-v2.valid.firmfixture")).Document!.SideHoleIntent!;
+ Assert.Equal("-Y", intent.AttachFace);
+ Assert.Equal("+Y", intent.ThroughFace);
+ Assert.Equal("-Y->+Y", intent.Route);
+ Assert.Equal("face(-Y):u=+X,v=+Z", intent.CenterSelectorFrame);
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleYAxis_ParsesAliasYRoute()
+ {
+ var doc = FirmamentV2Parser.Parse(Source("Region/valid/side-hole-aliases-y-axis-v2.valid.firmfixture")).Document!;
+ Assert.Contains(doc.Solid.Box.Exposures, e => e.Alias == "front" && e.Selector == "face(+Y)");
+ Assert.Contains(doc.Solid.Box.Exposures, e => e.Alias == "back" && e.Selector == "face(-Y)");
+ var intent = doc.SideHoleIntent!;
+ Assert.Equal("front", intent.AttachTargetSource);
+ Assert.Equal("back", intent.ThroughTargetSource);
+ Assert.Equal("+Y->-Y", intent.Route);
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleYAxis_InvalidRoutesRejected()
+ {
+ Assert.Contains(FirmamentV2Parser.SideHoleAxisNotYetSupported, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-z-axis-not-yet-supported-v2.invalid.firmfixture")).Diagnostics);
+ Assert.Contains(FirmamentV2Parser.SideHoleRouteUnsupported, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-mixed-axis-y-to-x-v2.invalid.firmfixture")).Diagnostics);
+ Assert.Contains(FirmamentV2Parser.SideHoleCenterExceedsClearance, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-y-center-x-boundary-v2.invalid.firmfixture")).Diagnostics);
+ Assert.Contains(FirmamentV2Parser.SideHoleCenterExceedsClearance, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-y-center-z-boundary-v2.invalid.firmfixture")).Diagnostics);
+ Assert.Contains(FirmamentV2Parser.SideHoleRouteUnsupported, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-alias-y-wrong-through-v2.invalid.firmfixture")).Diagnostics);
+ }
+
private static string Source(string relative)
{
var path = Path.GetFullPath(Path.Combine(AppContext.BaseDirectory, "../../../../fixtures/FirmamentV2", relative));
diff --git a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs
index 143d4aec..f91b424d 100644
--- a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs
+++ b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs
@@ -31,12 +31,20 @@ public sealed record FirmamentV2FaceLocalPoint2D(double U, double V, string Conv
{
public const string PlusXConvention = "face(+X):u=+Y,v=+Z";
public const string MinusXConvention = "face(-X):u=+Y,v=+Z";
- public static string ConventionFor(string attachFace) => attachFace == "-X" ? MinusXConvention : PlusXConvention;
+ public const string PlusYConvention = "face(+Y):u=+X,v=+Z";
+ public const string MinusYConvention = "face(-Y):u=+X,v=+Z";
+ public static string ConventionFor(string attachFace) => attachFace switch
+ {
+ "-X" => MinusXConvention,
+ "+Y" => PlusYConvention,
+ "-Y" => MinusYConvention,
+ _ => PlusXConvention
+ };
}
public sealed record FirmamentV2SideHoleIntent(string TargetSolid, string RegionName, string AttachTargetSource, string AttachTargetKind, string AttachFace, string ThroughTargetSource, string ThroughTargetKind, string ThroughFace, string Tool, double Radius, double CenterU, double CenterV, bool CenterExplicit, string CenterSelectorFrame, string Units)
{
public string Route => $"{AttachFace}->{ThroughFace}";
- public FirmamentV2SideHoleRouteEvidence RouteEvidence => new("X", Route, AttachFace, ThroughFace);
+ public FirmamentV2SideHoleRouteEvidence RouteEvidence => new(AttachFace.Length == 2 ? AttachFace[1].ToString() : string.Empty, Route, AttachFace, ThroughFace);
}
public sealed record FirmamentV2SideHoleRouteEvidence(string Axis, string Direction, string AttachFace, string ThroughFace);
public sealed record FirmamentV2ParseResult(bool IsSuccess, FirmamentV2Document? Document, IReadOnlyList<string> Diagnostics)
diff --git a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs
index 7697b82b..caade823 100644
--- a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs
+++ b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs
@@ -239,21 +239,22 @@ public static class FirmamentV2Parser
if (attach is null || cut is null) return null;
var supportedCanonical = attach.Axis == "+X" && cut.Tool.Through.Axis == "-X";
var supportedReverseX = attach.Axis == "-X" && cut.Tool.Through.Axis == "+X";
- if (!supportedCanonical && !supportedReverseX)
+ var supportedY = (attach.Axis == "+Y" && cut.Tool.Through.Axis == "-Y") || (attach.Axis == "-Y" && cut.Tool.Through.Axis == "+Y");
+ if (!supportedCanonical && !supportedReverseX && !supportedY)
{
if (attach.Axis == cut.Tool.Through.Axis) diagnostics.Add(SideHoleSameFaceUnsupported);
else if (AxisName(attach.Axis) != AxisName(cut.Tool.Through.Axis)) diagnostics.Add(SideHoleRouteUnsupported);
- else if (AxisName(attach.Axis) is "Y" or "Z") diagnostics.Add(SideHoleAxisNotYetSupported);
+ else if (AxisName(attach.Axis) is "Z") diagnostics.Add(SideHoleAxisNotYetSupported);
else diagnostics.Add(SideHoleRouteUnsupported);
if (attach.Kind == "Alias" || cut.Tool.Through.Kind == "Alias") diagnostics.Add(SideHoleAliasResolvesToUnsupportedFace);
diagnostics.Add(SideHoleOnlyPlusXMinusXSupported);
}
- var yHalfExtent = solid.Box.Size[1] / 2.0;
- var zHalfExtent = solid.Box.Size[2] / 2.0;
- if (cut.Tool.Radius >= Math.Min(yHalfExtent, zHalfExtent)) diagnostics.Add(SideHoleRadiusExceedsClearance);
+ var uHalfExtent = AxisName(attach.Axis) == "Y" ? solid.Box.Size[0] / 2.0 : solid.Box.Size[1] / 2.0;
+ var vHalfExtent = solid.Box.Size[2] / 2.0;
+ if (cut.Tool.Radius >= Math.Min(uHalfExtent, vHalfExtent)) diagnostics.Add(SideHoleRadiusExceedsClearance);
var centerU = cut.Tool.Center?.U ?? 0;
var centerV = cut.Tool.Center?.V ?? 0;
- if (Math.Abs(centerU) + cut.Tool.Radius >= yHalfExtent || Math.Abs(centerV) + cut.Tool.Radius >= zHalfExtent) diagnostics.Add(SideHoleCenterExceedsClearance);
+ if (Math.Abs(centerU) + cut.Tool.Radius >= uHalfExtent || Math.Abs(centerV) + cut.Tool.Radius >= vHalfExtent) diagnostics.Add(SideHoleCenterExceedsClearance);
return diagnostics.Any(IsFatalDiagnostic) ? null : new(rm.Groups["name"].Value, "FaceAttachedRegion", attach, cut);
}
@@ -287,7 +288,7 @@ public static class FirmamentV2Parser
if (parts.Length != 2) { diagnostics.Add(CylinderCenterArityInvalid); return null; }
if (!double.TryParse(parts[0], NumberStyles.Float, CultureInfo.InvariantCulture, out var u) || !double.TryParse(parts[1], NumberStyles.Float, CultureInfo.InvariantCulture, out var v)) { diagnostics.Add(CylinderCenterInvalid); return null; }
if (!double.IsFinite(u) || !double.IsFinite(v)) { diagnostics.Add(CylinderCenterNotFinite); return null; }
- return new FirmamentV2FaceLocalPoint2D(u, v, FirmamentV2FaceLocalPoint2D.PlusXConvention);
+ return new FirmamentV2FaceLocalPoint2D(u, v, string.Empty);
}
private static string AxisName(string faceAxis) => faceAxis.Length == 2 ? faceAxis[1].ToString() : string.Empty;
diff --git a/docs/air-firmament-a1-firmament-fixture-corpus.md b/docs/air-firmament-a1-firmament-fixture-corpus.md
index 052c4c18..94b984d4 100644
--- a/docs/air-firmament-a1-firmament-fixture-corpus.md
+++ b/docs/air-firmament-a1-firmament-fixture-corpus.md
@@ -200,3 +200,6 @@ X7 adds controlled Firmament V2 Region side-hole center-offset fixtures under `f
## AIR-FIRMAMENT-X9 fixture taxonomy note
The Firmament V2 region fixture set now includes controlled reverse-X side-hole valid fixtures (`side-hole-reverse-x-v2`, `side-hole-aliases-reverse-x-v2`) and invalid route fixtures for same-face, mixed-axis, Y-axis-not-yet-supported, and alias wrong-through cases.
+
+
+X10 fixture taxonomy note: Firmament V2 Region valid fixtures now include controlled Y-axis side-hole route fixtures, and invalid fixtures include Z-axis, mixed-axis, Y-clearance-boundary, and alias wrong-through rejections.
diff --git a/docs/air-firmament-x10-v2-side-hole-y-axis.md b/docs/air-firmament-x10-v2-side-hole-y-axis.md
new file mode 100644
index 00000000..cbedaaee
--- /dev/null
+++ b/docs/air-firmament-x10-v2-side-hole-y-axis.md
@@ -0,0 +1,92 @@
+# AIR-FIRMAMENT-X10 — V2 side-hole Y-axis face-pair variation
+
+## Purpose and scope
+
+X10 expands the parser-backed Firmament V2 controlled side-hole path from X-only opposite-face routes to include Y-axis opposite-face routes. This is still a controlled fixture path, not general side-hole support.
+
+## Relationship to X4-X9
+
+X4 introduced direct `+X -> -X` syntax, X5 locked artifacts/parity, X6 varied radius, X7 added face-local center offsets, X8 added aliases, and X9 added `-X -> +X`. X10 adds `+Y -> -Y` and `-Y -> +Y` using the same parser-backed semantic intent and AIR Region golden trace chain.
+
+## Supported route set
+
+* `+X -> -X`
+* `-X -> +X`
+* `+Y -> -Y`
+* `-Y -> +Y`
+
+## Unsupported routes
+
+Z-axis, mixed-axis, same-face, blind, and arbitrary face-pair paths remain unsupported.
+
+## Source syntax examples
+
+Direct `+Y -> -Y`:
+
+```firmament
+region sideHole on face(+Y) {
+ cut Cylinder { radius: 1 center: [1, 0] through: face(-Y) }
+}
+```
+
+Direct `-Y -> +Y`:
+
+```firmament
+region sideHole on face(-Y) {
+ cut Cylinder { radius: 1 center: [1, 0] through: face(+Y) }
+}
+```
+
+Alias `+Y -> -Y`:
+
+```firmament
+expose { face(+Y) => front; face(-Y) => back }
+region sideHole on front {
+ cut Cylinder { radius: 1 center: [1, 0] through: back }
+}
+```
+
+## Face-local coordinate convention
+
+* `face(+X): u=+Y, v=+Z`
+* `face(-X): u=+Y, v=+Z`
+* `face(+Y): u=+X, v=+Z`
+* `face(-Y): u=+X, v=+Z`
+
+For Y faces, `[1, 0]` offsets toward `+X`; `[0, 1]` offsets toward `+Z`.
+
+## Route admissibility
+
+Only opposite faces on X or Y are admitted. Same-face routes report same-face unsupported; mixed-axis routes report route unsupported; Z-axis reports axis-not-yet-supported.
+
+## Center/radius clearance rules
+
+For `Box [10, 8, 6]`, X-axis routes use transverse half-extents `Y=4`, `Z=3`: `abs(u)+radius < 4` and `abs(v)+radius < 3`. Y-axis routes use `X=5`, `Z=3`: `abs(u)+radius < 5` and `abs(v)+radius < 3`. The comparison is strict.
+
+## Trace JSON/text route evidence
+
+Trace JSON exposes semantic intent route evidence with axis, direction, attach face, through face, source target kind, center, radius, and center frame. Trace text prints attach/through selectors, alias resolution when present, route direction, and the face-local frame.
+
+## Artifact/manifest behavior
+
+Y-axis valid fixtures emit STEP, trace JSON, trace text, and `manifest.json` using fixture stems such as `side-hole-y-axis-v2`. The manifest includes route evidence, target sources, resolved selectors, radius, center, center frame, `controlledFixtureOnly=true`, and `generalSideHoleSupport=false`.
+
+## Valid and invalid fixtures
+
+Valid fixtures added: direct `side-hole-y-axis-v2`, direct `side-hole-reverse-y-v2`, and alias `side-hole-aliases-y-axis-v2`. Invalid fixtures cover Z-axis unsupported, mixed Y-to-X, Y-axis X/Z clearance boundaries, and alias wrong-through.
+
+## What this proves
+
+The parser-backed controlled side-hole lowering can preserve and report a second controlled axis through the existing AIR Region golden path.
+
+## What this does not prove
+
+No Z-axis, mixed-axis, arbitrary face-pair, arbitrary local frame, blind hole, generic Boolean admission, CIR topology authority, shell, fillet, chamfer, surfacing, pattern, material/FEA, templates/concepts/PMI/where parser, STEP PMI export, or STEP importer/exporter behavior is introduced.
+
+## Tests run
+
+Run the active .NET build/test and targeted Firmament V2 side-hole tests for this milestone.
+
+## Next milestone recommendation
+
+AIR-FIRMAMENT-X11 — controlled V2 side-hole Z-axis face-pair variation. X11 must define `face(+Z)` and `face(-Z)` local frames before implementation; likely `u=+X, v=+Y` for both faces.
diff --git a/docs/air-firmament-x7-v2-side-hole-center-offset.md b/docs/air-firmament-x7-v2-side-hole-center-offset.md
index 1c0ebb9f..36d7152e 100644
--- a/docs/air-firmament-x7-v2-side-hole-center-offset.md
+++ b/docs/air-firmament-x7-v2-side-hole-center-offset.md
@@ -71,3 +71,6 @@ Run the active .NET build/test commands for X7 changes, including targeted Firma
AIR-FIRMAMENT-X8 — controlled V2 side-hole selector aliases using X3 exposures, for example `face(+X) => right` and `face(-X) => left`.
+
+
+X10 note: controlled Y-face frames are now `face(+Y): u=+X, v=+Z` and `face(-Y): u=+X, v=+Z`; X-face frames remain unchanged.
diff --git a/docs/air-firmament-x9-v2-side-hole-reverse-x.md b/docs/air-firmament-x9-v2-side-hole-reverse-x.md
index e5fca074..9224848a 100644
--- a/docs/air-firmament-x9-v2-side-hole-reverse-x.md
+++ b/docs/air-firmament-x9-v2-side-hole-reverse-x.md
@@ -103,3 +103,6 @@ Use the active suite and targeted parser/CLI tests for reverse-X, aliases, radiu
## Next milestone recommendation
AIR-FIRMAMENT-X10 — controlled V2 side-hole Y-axis face-pair variation. X10 must define `face(+Y)` and `face(-Y)` local frames before implementation; a possible policy is `u=+X`, `v=+Z` for both Y faces.
+
+
+Update: AIR-FIRMAMENT-X10 extends the controlled side-hole route set to Y-axis opposite faces; see `docs/air-firmament-x10-v2-side-hole-y-axis.md`.
diff --git a/fixtures/FirmamentV2/Region/invalid/side-hole-alias-y-wrong-through-v2.invalid.firmfixture b/fixtures/FirmamentV2/Region/invalid/side-hole-alias-y-wrong-through-v2.invalid.firmfixture
new file mode 100644
index 00000000..db977646
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/invalid/side-hole-alias-y-wrong-through-v2.invalid.firmfixture
@@ -0,0 +1,16 @@
+// fixture-id: side-hole-alias-y-wrong-through-v2
+// case: firmament-v2-side-hole-alias-y-wrong-through
+// category: Region
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: parser-backed
+// expected: invalid
+// expected-stage: parsed
+// expected-diagnostic: firmament-v2-side-hole-route-unsupported
+
+model SideHoleAliasYWrongThroughV2 {
+ units mm
+ solid base: Box { size: [10, 8, 6] expose { face(+Y) => front
+ face(+X) => right } }
+ modify base { region sideHole on front { cut Cylinder { radius: 1 through: right } } }
+}
diff --git a/fixtures/FirmamentV2/Region/invalid/side-hole-mixed-axis-y-to-x-v2.invalid.firmfixture b/fixtures/FirmamentV2/Region/invalid/side-hole-mixed-axis-y-to-x-v2.invalid.firmfixture
new file mode 100644
index 00000000..41005d0d
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/invalid/side-hole-mixed-axis-y-to-x-v2.invalid.firmfixture
@@ -0,0 +1,15 @@
+// fixture-id: side-hole-mixed-axis-y-to-x-v2
+// case: firmament-v2-side-hole-mixed-axis-y-to-x
+// category: Region
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: parser-backed
+// expected: invalid
+// expected-stage: parsed
+// expected-diagnostic: firmament-v2-side-hole-route-unsupported
+
+model SideHoleMixedAxisYToXV2 {
+ units mm
+ solid base: Box { size: [10, 8, 6] }
+ modify base { region sideHole on face(+Y) { cut Cylinder { radius: 1 through: face(-X) } } }
+}
diff --git a/fixtures/FirmamentV2/Region/invalid/side-hole-y-axis-not-yet-supported-v2.invalid.firmfixture b/fixtures/FirmamentV2/Region/invalid/side-hole-y-axis-not-yet-supported-v2.invalid.firmfixture
index b2024da6..69cf0b81 100644
--- a/fixtures/FirmamentV2/Region/invalid/side-hole-y-axis-not-yet-supported-v2.invalid.firmfixture
+++ b/fixtures/FirmamentV2/Region/invalid/side-hole-y-axis-not-yet-supported-v2.invalid.firmfixture
@@ -1,5 +1,5 @@
// fixture-id: side-hole-y-axis-not-yet-supported-v2
-// case: firmament-v2-side-hole-y-axis-not-yet-supported-invalid
+// case: firmament-v2-side-hole-historical-y-now-z-axis-invalid
// category: Region
// syntax-version: FirmamentV2
// validity: invalid
@@ -7,9 +7,10 @@
// expected: invalid
// expected-stage: parsed
// expected-diagnostic: firmament-v2-side-hole-axis-not-yet-supported
+// notes: Historical pre-X10 fixture path retained for corpus compatibility; X10 supports Y and uses this file as an unsupported Z-axis rejection.
-model SideHoleYAxisNotYetSupportedV2 {
+model SideHoleHistoricalAxisNotYetSupportedV2 {
units mm
solid base: Box { size: [10, 8, 6] }
- modify base { region sideHole on face(+Y) { cut Cylinder { radius: 1 through: face(-Y) } } }
+ modify base { region sideHole on face(+Z) { cut Cylinder { radius: 1 through: face(-Z) } } }
}
diff --git a/fixtures/FirmamentV2/Region/invalid/side-hole-y-center-x-boundary-v2.invalid.firmfixture b/fixtures/FirmamentV2/Region/invalid/side-hole-y-center-x-boundary-v2.invalid.firmfixture
new file mode 100644
index 00000000..ed3a8707
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/invalid/side-hole-y-center-x-boundary-v2.invalid.firmfixture
@@ -0,0 +1,15 @@
+// fixture-id: side-hole-y-center-x-boundary-v2
+// case: firmament-v2-side-hole-y-center-x-boundary
+// category: Region
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: parser-backed
+// expected: invalid
+// expected-stage: parsed
+// expected-diagnostic: firmament-v2-side-hole-center-exceeds-clearance
+
+model SideHoleYCenterXBoundaryV2 {
+ units mm
+ solid base: Box { size: [10, 8, 6] }
+ modify base { region sideHole on face(+Y) { cut Cylinder { radius: 1 center: [4, 0] through: face(-Y) } } }
+}
diff --git a/fixtures/FirmamentV2/Region/invalid/side-hole-y-center-z-boundary-v2.invalid.firmfixture b/fixtures/FirmamentV2/Region/invalid/side-hole-y-center-z-boundary-v2.invalid.firmfixture
new file mode 100644
index 00000000..4d8af2d7
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/invalid/side-hole-y-center-z-boundary-v2.invalid.firmfixture
@@ -0,0 +1,15 @@
+// fixture-id: side-hole-y-center-z-boundary-v2
+// case: firmament-v2-side-hole-y-center-z-boundary
+// category: Region
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: parser-backed
+// expected: invalid
+// expected-stage: parsed
+// expected-diagnostic: firmament-v2-side-hole-center-exceeds-clearance
+
+model SideHoleYCenterZBoundaryV2 {
+ units mm
+ solid base: Box { size: [10, 8, 6] }
+ modify base { region sideHole on face(+Y) { cut Cylinder { radius: 1 center: [0, 2] through: face(-Y) } } }
+}
diff --git a/fixtures/FirmamentV2/Region/invalid/side-hole-z-axis-not-yet-supported-v2.invalid.firmfixture b/fixtures/FirmamentV2/Region/invalid/side-hole-z-axis-not-yet-supported-v2.invalid.firmfixture
new file mode 100644
index 00000000..0b44a6a9
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/invalid/side-hole-z-axis-not-yet-supported-v2.invalid.firmfixture
@@ -0,0 +1,15 @@
+// fixture-id: side-hole-z-axis-not-yet-supported-v2
+// case: firmament-v2-side-hole-z-axis-not-yet-supported
+// category: Region
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: parser-backed
+// expected: invalid
+// expected-stage: parsed
+// expected-diagnostic: firmament-v2-side-hole-axis-not-yet-supported
+
+model SideHoleZAxisNotYetSupportedV2 {
+ units mm
+ solid base: Box { size: [10, 8, 6] }
+ modify base { region sideHole on face(+Z) { cut Cylinder { radius: 1 through: face(-Z) } } }
+}
diff --git a/fixtures/FirmamentV2/Region/valid/side-hole-aliases-y-axis-v2.valid.firmfixture b/fixtures/FirmamentV2/Region/valid/side-hole-aliases-y-axis-v2.valid.firmfixture
new file mode 100644
index 00000000..80b4af6d
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/valid/side-hole-aliases-y-axis-v2.valid.firmfixture
@@ -0,0 +1,31 @@
+// fixture-id: side-hole-aliases-y-axis-v2
+// case: firmament-v2-side-hole-alias-y-axis
+// category: Region
+// syntax-version: FirmamentV2
+// validity: valid
+// implementation: parser-backed
+// expected: valid
+// expected-stage: region-parent-integrated
+
+model SideHoleAliasYAxisV2 {
+ units mm
+
+ solid base: Box {
+ size: [10, 8, 6]
+
+ expose {
+ face(+Y) => front
+ face(-Y) => back
+ }
+ }
+
+ modify base {
+ region sideHole on front {
+ cut Cylinder {
+ radius: 1
+ center: [1, 0]
+ through: back
+ }
+ }
+ }
+}
diff --git a/fixtures/FirmamentV2/Region/valid/side-hole-reverse-y-v2.valid.firmfixture b/fixtures/FirmamentV2/Region/valid/side-hole-reverse-y-v2.valid.firmfixture
new file mode 100644
index 00000000..6a547a1c
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/valid/side-hole-reverse-y-v2.valid.firmfixture
@@ -0,0 +1,26 @@
+// fixture-id: side-hole-reverse-y-v2
+// case: firmament-v2-side-hole-reverse-y
+// category: Region
+// syntax-version: FirmamentV2
+// validity: valid
+// implementation: parser-backed
+// expected: valid
+// expected-stage: region-parent-integrated
+
+model SideHoleReverseYV2 {
+ units mm
+
+ solid base: Box {
+ size: [10, 8, 6]
+ }
+
+ modify base {
+ region sideHole on face(-Y) {
+ cut Cylinder {
+ radius: 1
+ center: [1, 0]
+ through: face(+Y)
+ }
+ }
+ }
+}
diff --git a/fixtures/FirmamentV2/Region/valid/side-hole-y-axis-v2.valid.firmfixture b/fixtures/FirmamentV2/Region/valid/side-hole-y-axis-v2.valid.firmfixture
new file mode 100644
index 00000000..30c1118c
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/valid/side-hole-y-axis-v2.valid.firmfixture
@@ -0,0 +1,26 @@
+// fixture-id: side-hole-y-axis-v2
+// case: firmament-v2-side-hole-y-axis
+// category: Region
+// syntax-version: FirmamentV2
+// validity: valid
+// implementation: parser-backed
+// expected: valid
+// expected-stage: region-parent-integrated
+
+model SideHoleYAxisV2 {
+ units mm
+
+ solid base: Box {
+ size: [10, 8, 6]
+ }
+
+ modify base {
+ region sideHole on face(+Y) {
+ cut Cylinder {
+ radius: 1
+ center: [1, 0]
+ through: face(-Y)
+ }
+ }
+ }
+}