Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel
Tests stop rewriting a tracked STEP fixture; ignore backslash build dirs
Claude44759271cda4
diff --git a/.gitignore b/.gitignoreindex d386e09a..0a2c430b 100644--- a/.gitignore+++ b/.gitignore@@ -433,3 +433,8 @@ FodyWeavers.xsd/testdata/step214/handcrafted/baseline/stair.STEP/Aetheris.Kernel.Core.Tests/TessellationHoleDiagnosticsTests.cs/Aetheris.Kernel.Core/Brep/Boolean/Aetheris Boolean Gemini Action Packet.zip++# The MSBuild JavaScript project SDK (aetheris.client.esproj) writes Windows-style intermediate+# paths as literal directory names on Linux/macOS, e.g. "obj\Release/".+obj\\*+bin\\*diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242LinearExtrusionSurfaceProductionTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242LinearExtrusionSurfaceProductionTests.csindex 22dab84f..6f27c6f9 100644--- a/Aetheris.Kernel.Core.Tests/Step242/Step242LinearExtrusionSurfaceProductionTests.cs+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242LinearExtrusionSurfaceProductionTests.cs@@ -21,8 +21,7 @@ public sealed class Step242LinearExtrusionSurfaceProductionTestsAssert.Contains("ELLIPSE", export.Value, StringComparison.Ordinal);Assert.DoesNotContain("B_SPLINE_SURFACE_WITH_KNOTS", export.Value, StringComparison.Ordinal);- var artifactPath = WriteArtifact(export.Value);- Assert.True(File.Exists(artifactPath));+ AssertCheckedInArtifactCurrent(export.Value);var reimport = Step242Importer.ImportBody(export.Value);Assert.True(reimport.IsSuccess, string.Join(Environment.NewLine, reimport.Diagnostics.Select(d => d.Message)));@@ -106,11 +105,19 @@ public sealed class Step242LinearExtrusionSurfaceProductionTestsreturn new BrepBody(builder.Model, geometry, bindings, vertexPoints);}- private static string WriteArtifact(string stepText)+ // The checked-in STEP file is a fixture other suites (CLI baselines, ruled probe) read. The test+ // used to rewrite it on every run, dirtying the working tree and making those suites depend on+ // test order. It now asserts the fixture is current; set AETHERIS_REFRESH_FIXTURES=1 to rewrite it.+ private static void AssertCheckedInArtifactCurrent(string stepText){var path = Path.Combine(Step242CorpusManifestRunner.RepoRoot(), "testdata", "step242", "generated", "ruled-a2", "ellipse-linear-extrusion-production.step");- Directory.CreateDirectory(Path.GetDirectoryName(path)!);- File.WriteAllText(path, stepText);- return path;+ if (Environment.GetEnvironmentVariable("AETHERIS_REFRESH_FIXTURES") == "1")+ {+ Directory.CreateDirectory(Path.GetDirectoryName(path)!);+ File.WriteAllText(path, stepText);+ return;+ }+ Assert.True(File.Exists(path), $"Missing fixture {path}; run with AETHERIS_REFRESH_FIXTURES=1.");+ Assert.Equal(stepText.Replace("\r\n", "\n"), File.ReadAllText(path).Replace("\r\n", "\n"));}}diff --git a/testdata/step242/generated/ruled-a2/ellipse-linear-extrusion-production.step b/testdata/step242/generated/ruled-a2/ellipse-linear-extrusion-production.stepindex 800ad91c..68a23e2f 100644--- a/testdata/step242/generated/ruled-a2/ellipse-linear-extrusion-production.step+++ b/testdata/step242/generated/ruled-a2/ellipse-linear-extrusion-production.step@@ -10,60 +10,47 @@ DATA;#3=DIRECTION($,(1,0,0));#4=AXIS2_PLACEMENT_3D($,#1,#2,#3);#5=ELLIPSE($,#4,4,2);-#6=DIRECTION($,(0,0,1));-#7=VECTOR($,#6,5);-#8=SURFACE_OF_LINEAR_EXTRUSION($,#5,#7);-#9=CARTESIAN_POINT($,(4,0,0));-#10=VERTEX_POINT($,#9);-#11=CARTESIAN_POINT($,(-4,0,0));-#12=VERTEX_POINT($,#11);-#13=CARTESIAN_POINT($,(0,0,0));-#14=DIRECTION($,(0,0,1));-#15=DIRECTION($,(1,0,0));-#16=AXIS2_PLACEMENT_3D($,#13,#14,#15);-#17=ELLIPSE($,#16,4,2);-#18=EDGE_CURVE($,#10,#12,#17,.T.);+#6=VECTOR($,#2,5);+#7=SURFACE_OF_LINEAR_EXTRUSION($,#5,#6);+#8=CARTESIAN_POINT($,(4,0,0));+#9=VERTEX_POINT($,#8);+#10=CARTESIAN_POINT($,(-4,0,0));+#11=VERTEX_POINT($,#10);+#12=EDGE_CURVE($,#9,#11,#5,.T.);+#13=ORIENTED_EDGE($,$,$,#12,.T.);+#14=CARTESIAN_POINT($,(-4,0,5));+#15=VERTEX_POINT($,#14);+#16=VECTOR($,#2,1);+#17=LINE($,#10,#16);+#18=EDGE_CURVE($,#11,#15,#17,.T.);#19=ORIENTED_EDGE($,$,$,#18,.T.);-#20=CARTESIAN_POINT($,(-4,0,5));+#20=CARTESIAN_POINT($,(4,0,5));#21=VERTEX_POINT($,#20);-#22=CARTESIAN_POINT($,(-4,0,0));-#23=DIRECTION($,(0,0,1));-#24=VECTOR($,#23,1);-#25=LINE($,#22,#24);-#26=EDGE_CURVE($,#12,#21,#25,.T.);-#27=ORIENTED_EDGE($,$,$,#26,.T.);-#28=CARTESIAN_POINT($,(4,0,5));-#29=VERTEX_POINT($,#28);-#30=CARTESIAN_POINT($,(0,0,5));-#31=DIRECTION($,(0,0,1));-#32=DIRECTION($,(1,0,0));-#33=AXIS2_PLACEMENT_3D($,#30,#31,#32);-#34=ELLIPSE($,#33,4,2);-#35=EDGE_CURVE($,#29,#21,#34,.T.);-#36=ORIENTED_EDGE($,$,$,#35,.F.);-#37=CARTESIAN_POINT($,(4,0,0));-#38=DIRECTION($,(0,0,1));-#39=VECTOR($,#38,1);-#40=LINE($,#37,#39);-#41=EDGE_CURVE($,#10,#29,#40,.T.);-#42=ORIENTED_EDGE($,$,$,#41,.F.);-#43=EDGE_LOOP($,(#19,#27,#36,#42));-#44=FACE_OUTER_BOUND('',#43,.T.);-#45=ADVANCED_FACE('',(#44),#8,.T.);-#46=CLOSED_SHELL($,(#45));-#47=MANIFOLD_SOLID_BREP('RULED-A2 elliptic linear-extrusion strip',#46);-#48=APPLICATION_CONTEXT('mechanical design');-#49=PRODUCT_CONTEXT('',#48,'mechanical');-#50=PRODUCT('AETHERIS','RULED-A2 elliptic linear-extrusion strip','',(#49));-#51=PRODUCT_DEFINITION_FORMATION('','',#50);-#52=PRODUCT_DEFINITION_CONTEXT('design',#48,'design');-#53=PRODUCT_DEFINITION('','',#51,#52);-#54=PRODUCT_DEFINITION_SHAPE('','',#53);-#55=(LENGTH_UNIT()NAMED_UNIT(*)SI_UNIT(.MILLI.,.METRE.));-#56=(NAMED_UNIT(*)PLANE_ANGLE_UNIT()SI_UNIT($,.RADIAN.));-#57=(NAMED_UNIT(*)SI_UNIT($,.STERADIAN.)SOLID_ANGLE_UNIT());-#58=(GEOMETRIC_REPRESENTATION_CONTEXT(3)GLOBAL_UNIT_ASSIGNED_CONTEXT((#55,#56,#57))REPRESENTATION_CONTEXT('3','3D'));-#59=SHAPE_REPRESENTATION('RULED-A2 elliptic linear-extrusion strip',(#47),#58);-#60=SHAPE_DEFINITION_REPRESENTATION(#54,#59);+#22=CARTESIAN_POINT($,(0,0,5));+#23=AXIS2_PLACEMENT_3D($,#22,#2,#3);+#24=ELLIPSE($,#23,4,2);+#25=EDGE_CURVE($,#21,#15,#24,.T.);+#26=ORIENTED_EDGE($,$,$,#25,.F.);+#27=LINE($,#8,#16);+#28=EDGE_CURVE($,#9,#21,#27,.T.);+#29=ORIENTED_EDGE($,$,$,#28,.F.);+#30=EDGE_LOOP($,(#13,#19,#26,#29));+#31=FACE_OUTER_BOUND('',#30,.T.);+#32=ADVANCED_FACE('',(#31),#7,.T.);+#33=CLOSED_SHELL($,(#32));+#34=MANIFOLD_SOLID_BREP('RULED-A2 elliptic linear-extrusion strip',#33);+#35=APPLICATION_CONTEXT('mechanical design');+#36=PRODUCT_CONTEXT('',#35,'mechanical');+#37=PRODUCT('AETHERIS','RULED-A2 elliptic linear-extrusion strip','',(#36));+#38=PRODUCT_DEFINITION_FORMATION('','',#37);+#39=PRODUCT_DEFINITION_CONTEXT('design',#35,'design');+#40=PRODUCT_DEFINITION('','',#38,#39);+#41=PRODUCT_DEFINITION_SHAPE('','',#40);+#42=(LENGTH_UNIT()NAMED_UNIT(*)SI_UNIT(.MILLI.,.METRE.));+#43=(NAMED_UNIT(*)PLANE_ANGLE_UNIT()SI_UNIT($,.RADIAN.));+#44=(NAMED_UNIT(*)SI_UNIT($,.STERADIAN.)SOLID_ANGLE_UNIT());+#45=(GEOMETRIC_REPRESENTATION_CONTEXT(3)GLOBAL_UNIT_ASSIGNED_CONTEXT((#42,#43,#44))REPRESENTATION_CONTEXT('3','3D'));+#46=SHAPE_REPRESENTATION('RULED-A2 elliptic linear-extrusion strip',(#34),#45);+#47=SHAPE_DEFINITION_REPRESENTATION(#41,#46);ENDSEC;END-ISO-10303-21;