Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Fix bow-tie profile expectation in M10 tests

Yuechen Li70391b0610fa
diff --git a/Aetheris.Kernel.Core.Tests/Brep/Features/BrepExtrudeTests.cs b/Aetheris.Kernel.Core.Tests/Brep/Features/BrepExtrudeTests.cs
index e9c080e6..cc18b945 100644
--- a/Aetheris.Kernel.Core.Tests/Brep/Features/BrepExtrudeTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Brep/Features/BrepExtrudeTests.cs
@@ -113,7 +113,7 @@ public sealed class BrepExtrudeTests
}
[Fact]
- public void Create_SelfIntersectingProfile_CurrentlyNotRejectedInM10()
+ public void Create_BowTieProfile_FailsValidation_CurrentBehavior()
{
var bowTie = PolylineProfile2D.Create(
[
@@ -123,15 +123,7 @@ public sealed class BrepExtrudeTests
new ProfilePoint2D(2d, 0d),
]);
- Assert.True(bowTie.IsSuccess);
-
- var frame = new ExtrudeFrame3D(
- Point3D.Origin,
- Direction3D.Create(new Vector3D(0d, 0d, 1d)),
- Direction3D.Create(new Vector3D(1d, 0d, 0d)));
-
- var result = BrepExtrude.Create(bowTie.Value, frame, 1d);
-
- Assert.True(result.IsSuccess);
+ Assert.False(bowTie.IsSuccess);
+ Assert.Contains(bowTie.Diagnostics, d => d.Code == KernelDiagnosticCode.InvalidArgument);
}
}
diff --git a/docs/milestones.md b/docs/milestones.md
index 01bec09b..37e520b1 100644
--- a/docs/milestones.md
+++ b/docs/milestones.md
@@ -82,7 +82,7 @@
## M10 — Programmatic Extrude Framework v1 (No Sketcher)
- [x] Add a minimal programmatic profile model for extrusion input using local 2D planar coordinates (single outer closed loop, line segments only).
-- [x] M10 profile validation intentionally does not yet perform full polygon self-intersection rejection (deferred to a later milestone).
+- [x] M10 profile validation intentionally remains basic and not a full polygon-simplicity/self-intersection solver; some invalid polygons are rejected by existing degeneracy checks, but robust simple-polygon validation is deferred.
- [x] Add an explicit extrusion API (`BrepExtrude.Create`) returning `KernelResult<BrepBody>` with strict validator-backed output checks.
- [x] Support constant-depth linear extrusion along +normal of an explicit frame, producing top/bottom caps and planar side faces.
- [x] Add focused unit tests for profile/extrude validation, topology and binding expectations, traversal safety, depth-direction convention, and winding behavior.