Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel
test: clear remaining WARN-CLEAN-A2 test warnings
Yuechen Li70f99d456290
diff --git a/Aetheris.Kernel.Core.Tests/Brep/Boolean/BrepBooleanTests.cs b/Aetheris.Kernel.Core.Tests/Brep/Boolean/BrepBooleanTests.csindex 37fea505..0ebbb524 100644--- a/Aetheris.Kernel.Core.Tests/Brep/Boolean/BrepBooleanTests.cs+++ b/Aetheris.Kernel.Core.Tests/Brep/Boolean/BrepBooleanTests.cs@@ -180,6 +180,8 @@ public sealed class BrepBooleanTestsAssert.True(body.Value.Bindings.TryGetEdgeBinding(edge.Id, out var binding));Assert.NotNull(binding.TrimInterval);Assert.True(body.Value.Geometry.TryGetCurve(binding.CurveGeometryId, out var curve));+ Assert.NotNull(curve);+ Assert.NotNull(curve.Line3);Assert.Equal(CurveGeometryKind.Line3, curve.Kind);Assert.True(body.Value.TryGetVertexPoint(edge.StartVertexId, out var startVertexPoint));@@ -189,7 +191,7 @@ public sealed class BrepBooleanTestsAssert.Equal(0d, binding.TrimInterval!.Value.Start, 6);Assert.Equal(expectedLength, binding.TrimInterval.Value.End, 6);- var line = curve.Line3!.Value;+ var line = curve.Line3.Value;var startParameter = binding.OrientedEdgeSense ? binding.TrimInterval.Value.Start : binding.TrimInterval.Value.End;var endParameter = binding.OrientedEdgeSense ? binding.TrimInterval.Value.End : binding.TrimInterval.Value.Start;var startFromCurve = line.Evaluate(startParameter);@@ -1970,12 +1972,13 @@ public sealed class BrepBooleanTests=> body.Topology.Faces.Where(face =>{- if (!body.TryGetFaceSurfaceGeometry(face.Id, out var surface) || surface.Kind != SurfaceGeometryKind.Plane)+ if (!body.TryGetFaceSurfaceGeometry(face.Id, out var surface) || surface is null || surface.Kind != SurfaceGeometryKind.Plane){return false;}- var plane = surface.Plane!.Value;+ Assert.NotNull(surface.Plane);+ var plane = surface.Plane.Value;var normal = plane.Normal.ToVector();return (normalX is null || System.Math.Abs(normal.X - normalX.Value) <= 1e-6d)&& (normalY is null || System.Math.Abs(normal.Y - normalY.Value) <= 1e-6d)diff --git a/Aetheris.Kernel.Core.Tests/Brep/Queries/BrepCncManufacturabilitySchemaTests.cs b/Aetheris.Kernel.Core.Tests/Brep/Queries/BrepCncManufacturabilitySchemaTests.csindex 22605e91..a59973be 100644--- a/Aetheris.Kernel.Core.Tests/Brep/Queries/BrepCncManufacturabilitySchemaTests.cs+++ b/Aetheris.Kernel.Core.Tests/Brep/Queries/BrepCncManufacturabilitySchemaTests.cs@@ -32,7 +32,7 @@ public sealed class BrepCncManufacturabilitySchemaTestsvar result = BrepCncManufacturabilitySchema.Evaluate(body, new CncManufacturabilitySchemaInput(0.75d, 0.5d));Assert.False(result.IsPass);- var violation = Assert.Single(result.Issues.Where(issue => issue.Kind == CncManufacturabilityIssueKind.Violation && issue.RuleId == CncManufacturabilityRuleIds.MinimumInternalCornerRadius));+ var violation = Assert.Single(result.Issues, issue => issue.Kind == CncManufacturabilityIssueKind.Violation && issue.RuleId == CncManufacturabilityRuleIds.MinimumInternalCornerRadius);Assert.Equal(0d, violation.MeasuredValue);Assert.Equal(0.75d, violation.RequiredThreshold);Assert.StartsWith("edge:", violation.Location, StringComparison.Ordinal);diff --git a/Aetheris.Kernel.Firmament.Tests/Assembly/FirmasmAssemblyExecutorTests.cs b/Aetheris.Kernel.Firmament.Tests/Assembly/FirmasmAssemblyExecutorTests.csindex 81d37f3a..0b8f1976 100644--- a/Aetheris.Kernel.Firmament.Tests/Assembly/FirmasmAssemblyExecutorTests.cs+++ b/Aetheris.Kernel.Firmament.Tests/Assembly/FirmasmAssemblyExecutorTests.cs@@ -59,6 +59,6 @@ public sealed class FirmasmAssemblyExecutorTestsAssert.Equal(2, minByInstance.Length);Assert.NotEqual(minByInstance[0].MinX, minByInstance[1].MinX);- Assert.True(minByInstance.Any(x => Math.Abs(x.MinX) > 1e-3d));+ Assert.Contains(minByInstance, x => Math.Abs(x.MinX) > 1e-3d);}}