Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Add bounded B6a recognition profile probe for boolean recognizers

Yuechen Li77c0167f0209
diff --git a/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanAnalyticSurfaceRecognition.cs b/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanAnalyticSurfaceRecognition.cs
index 8e4b7d90..f47d5601 100644
--- a/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanAnalyticSurfaceRecognition.cs
+++ b/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanAnalyticSurfaceRecognition.cs
@@ -63,8 +63,14 @@ public static class BrepBooleanAnalyticSurfaceRecognition
surface = default;
reason = string.Empty;
- var faceBindings = body.Bindings.FaceBindings.ToArray();
- if (faceBindings.Length < 2 || faceBindings.Length > 3)
+ var profile = BrepRecognitionProfile.Scan(body, tolerance);
+ if (profile.FaceCount < 2 || profile.FaceCount > 3)
+ {
+ reason = "cone recognition requires one conical face plus one or two planar cap faces.";
+ return false;
+ }
+
+ if (profile.ConeFaceCount != 1 || profile.PlaneFaceCount is < 1 or > 2)
{
reason = "cone recognition requires one conical face plus one or two planar cap faces.";
return false;
@@ -79,7 +85,7 @@ public static class BrepBooleanAnalyticSurfaceRecognition
var coneBindings = new List<FaceGeometryBinding>(1);
var planeBindings = new List<(FaceGeometryBinding Binding, PlaneSurface Plane)>(2);
- foreach (var binding in faceBindings)
+ foreach (var binding in body.Bindings.FaceBindings)
{
var currentSurface = body.Geometry.GetSurface(binding.SurfaceGeometryId);
switch (currentSurface.Kind)
@@ -192,15 +198,28 @@ public static class BrepBooleanAnalyticSurfaceRecognition
surface = default;
reason = string.Empty;
- var faceBindings = body.Bindings.FaceBindings.ToArray();
- if (faceBindings.Length != 1)
+ var profile = BrepRecognitionProfile.Scan(body, _);
+ if (profile.FaceCount != 1 || !profile.IsSingleSurface || profile.PrimarySurfaceKind != SurfaceGeometryKind.Sphere)
+ {
+ reason = "sphere recognition requires exactly one spherical face.";
+ return false;
+ }
+
+ FaceGeometryBinding? faceBinding = null;
+ foreach (var binding in body.Bindings.FaceBindings)
+ {
+ faceBinding = binding;
+ break;
+ }
+
+ if (faceBinding is null)
{
reason = "sphere recognition requires exactly one spherical face.";
return false;
}
- var recognizedSurface = body.Geometry.GetSurface(faceBindings[0].SurfaceGeometryId);
- if (recognizedSurface.Kind != SurfaceGeometryKind.Sphere || recognizedSurface.Sphere is not SphereSurface sphere)
+ var recognizedSurface = body.Geometry.GetSurface(faceBinding.Value.SurfaceGeometryId);
+ if (recognizedSurface.Sphere is not SphereSurface sphere)
{
reason = "sphere recognition requires a spherical face binding.";
return false;
@@ -215,15 +234,28 @@ public static class BrepBooleanAnalyticSurfaceRecognition
surface = default;
reason = string.Empty;
- var faceBindings = body.Bindings.FaceBindings.ToArray();
- if (faceBindings.Length != 1)
+ var profile = BrepRecognitionProfile.Scan(body, _);
+ if (profile.FaceCount != 1 || !profile.IsSingleSurface || profile.PrimarySurfaceKind != SurfaceGeometryKind.Torus)
+ {
+ reason = "torus recognition requires exactly one toroidal face.";
+ return false;
+ }
+
+ FaceGeometryBinding? faceBinding = null;
+ foreach (var binding in body.Bindings.FaceBindings)
+ {
+ faceBinding = binding;
+ break;
+ }
+
+ if (faceBinding is null)
{
reason = "torus recognition requires exactly one toroidal face.";
return false;
}
- var recognizedSurface = body.Geometry.GetSurface(faceBindings[0].SurfaceGeometryId);
- if (recognizedSurface.Kind != SurfaceGeometryKind.Torus || recognizedSurface.Torus is not TorusSurface torus)
+ var recognizedSurface = body.Geometry.GetSurface(faceBinding.Value.SurfaceGeometryId);
+ if (recognizedSurface.Torus is not TorusSurface torus)
{
reason = "torus recognition requires a toroidal face binding.";
return false;
diff --git a/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanBoxRecognition.cs b/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanBoxRecognition.cs
index 05e0da39..8a2ba43b 100644
--- a/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanBoxRecognition.cs
+++ b/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanBoxRecognition.cs
@@ -106,12 +106,18 @@ public static class BrepBooleanBoxRecognition
return false;
}
- var faceBindings = body.Bindings.FaceBindings.ToArray();
- if (faceBindings.Length != 6)
+ var profile = BrepRecognitionProfile.Scan(body, tolerance);
+ if (profile.FaceCount != 6)
{
reason = "box recognition requires exactly six face bindings.";
return false;
}
+
+ if (!profile.IsSingleSurface || profile.PrimarySurfaceKind != SurfaceGeometryKind.Plane)
+ {
+ reason = "box recognition requires planar surfaces for all faces.";
+ return false;
+ }
if (body.Bindings.EdgeBindings.Count() != 12)
{
@@ -143,10 +149,10 @@ public static class BrepBooleanBoxRecognition
var minZ = 0d;
var maxZ = 0d;
- foreach (var binding in faceBindings)
+ foreach (var binding in body.Bindings.FaceBindings)
{
var surface = body.Geometry.GetSurface(binding.SurfaceGeometryId);
- if (surface.Kind != SurfaceGeometryKind.Plane || surface.Plane is null)
+ if (surface.Plane is null)
{
reason = "box recognition requires planar surfaces for all faces.";
return false;
diff --git a/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanCylinderRecognition.cs b/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanCylinderRecognition.cs
index 4d9b06f1..e02ff172 100644
--- a/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanCylinderRecognition.cs
+++ b/Aetheris.Kernel.Core/Brep/Boolean/BrepBooleanCylinderRecognition.cs
@@ -47,12 +47,18 @@ public static class BrepBooleanCylinderRecognition
return false;
}
- var faceBindings = body.Bindings.FaceBindings.ToArray();
- if (faceBindings.Length != 3)
+ var profile = BrepRecognitionProfile.Scan(body, tolerance);
+ if (profile.FaceCount != 3)
{
reason = "cylinder recognition requires exactly three face bindings.";
return false;
}
+
+ if (profile.CylinderFaceCount != 1 || profile.PlaneFaceCount != 2)
+ {
+ reason = "cylinder recognition requires exactly one cylindrical face and two planar cap faces.";
+ return false;
+ }
if (body.Bindings.EdgeBindings.Count() != 3)
{
@@ -60,16 +66,16 @@ public static class BrepBooleanCylinderRecognition
return false;
}
- var cylinderBindings = new List<FaceGeometryBinding>(1);
+ CylinderSurface? cylinderSurface = null;
var planeBindings = new List<(FaceGeometryBinding Binding, PlaneSurface Plane)>(2);
- foreach (var binding in faceBindings)
+ foreach (var binding in body.Bindings.FaceBindings)
{
var surface = body.Geometry.GetSurface(binding.SurfaceGeometryId);
switch (surface.Kind)
{
case SurfaceGeometryKind.Cylinder when surface.Cylinder is CylinderSurface:
- cylinderBindings.Add(binding);
+ cylinderSurface = surface.Cylinder.Value;
break;
case SurfaceGeometryKind.Plane when surface.Plane is PlaneSurface plane:
planeBindings.Add((binding, plane));
@@ -80,14 +86,13 @@ public static class BrepBooleanCylinderRecognition
}
}
- if (cylinderBindings.Count != 1 || planeBindings.Count != 2)
+ if (cylinderSurface is null || planeBindings.Count != 2)
{
reason = "cylinder recognition requires exactly one cylindrical face and two planar cap faces.";
return false;
}
- var cylinderSurface = body.Geometry.GetSurface(cylinderBindings[0].SurfaceGeometryId).Cylinder!.Value;
- var axis = cylinderSurface.Axis;
+ var axis = cylinderSurface.Value.Axis;
var axisVector = axis.ToVector();
foreach (var edgeBinding in body.Bindings.EdgeBindings)
@@ -123,7 +128,7 @@ public static class BrepBooleanCylinderRecognition
sawNegativeCap = true;
}
- var centerOffset = plane.Origin - cylinderSurface.Origin;
+ var centerOffset = plane.Origin - cylinderSurface.Value.Origin;
var axisParameter = centerOffset.Dot(axisVector);
var radialOffset = centerOffset - (axisVector * axisParameter);
if (radialOffset.Length > tolerance.Linear)
@@ -149,9 +154,9 @@ public static class BrepBooleanCylinderRecognition
}
cylinder = new RecognizedCylinder(
- cylinderSurface.Origin,
+ cylinderSurface.Value.Origin,
axis,
- cylinderSurface.Radius,
+ cylinderSurface.Value.Radius,
axisParameters[0],
axisParameters[1]);
return true;
diff --git a/Aetheris.Kernel.Core/Brep/Boolean/BrepRecognitionProfile.cs b/Aetheris.Kernel.Core/Brep/Boolean/BrepRecognitionProfile.cs
new file mode 100644
index 00000000..13e24ae5
--- /dev/null
+++ b/Aetheris.Kernel.Core/Brep/Boolean/BrepRecognitionProfile.cs
@@ -0,0 +1,58 @@
+using Aetheris.Kernel.Core.Geometry;
+using Aetheris.Kernel.Core.Numerics;
+
+namespace Aetheris.Kernel.Core.Brep.Boolean;
+
+public readonly record struct BrepRecognitionProfile(
+ int FaceCount,
+ bool IsSingleSurface,
+ SurfaceGeometryKind? PrimarySurfaceKind,
+ int PlaneFaceCount,
+ int CylinderFaceCount,
+ int ConeFaceCount)
+{
+ public static BrepRecognitionProfile Scan(BrepBody body, ToleranceContext _)
+ {
+ var faceCount = 0;
+ var planeFaceCount = 0;
+ var cylinderFaceCount = 0;
+ var coneFaceCount = 0;
+ var isSingleSurface = true;
+ SurfaceGeometryKind? primarySurfaceKind = null;
+
+ foreach (var binding in body.Bindings.FaceBindings)
+ {
+ faceCount++;
+ var kind = body.Geometry.GetSurface(binding.SurfaceGeometryId).Kind;
+ if (primarySurfaceKind is null)
+ {
+ primarySurfaceKind = kind;
+ }
+ else if (primarySurfaceKind != kind)
+ {
+ isSingleSurface = false;
+ }
+
+ switch (kind)
+ {
+ case SurfaceGeometryKind.Plane:
+ planeFaceCount++;
+ break;
+ case SurfaceGeometryKind.Cylinder:
+ cylinderFaceCount++;
+ break;
+ case SurfaceGeometryKind.Cone:
+ coneFaceCount++;
+ break;
+ }
+ }
+
+ return new BrepRecognitionProfile(
+ faceCount,
+ faceCount > 0 && isSingleSurface,
+ primarySurfaceKind,
+ planeFaceCount,
+ cylinderFaceCount,
+ coneFaceCount);
+ }
+}