Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Validate traversalSwapped fix with .NET 8 regressions

Yuechen Li79a8334f3046
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242ConicalSurfaceRegressionTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242ConicalSurfaceRegressionTests.cs
index 15823e6a..a243618e 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242ConicalSurfaceRegressionTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242ConicalSurfaceRegressionTests.cs
@@ -152,7 +152,7 @@ public sealed class Step242ConicalSurfaceRegressionTests
"testdata/step242/nist/STC/nist_stc_10_asme1_ap242-e2.stp",
"tessellator",
"Viewer.Tessellation.PlanarNonConvexTriangulationFailed",
- "Face 11 planar loop triangulation failed")]
+ "Face 221 planar loop triangulation failed")]
public void Step242_NistTargets_AdvancePastCircleTrim_AndKeepDeterministicNextBlocker(
string relativePath,
string expectedLayer,
diff --git a/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs b/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs
index 596d0248..16cef763 100644
--- a/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs
+++ b/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs
@@ -2529,12 +2529,13 @@ public static class BrepDisplayTessellator
PlaneSurface plane,
FaceId faceId)
{
+ var effectiveIsReversed = coedge.IsReversed ^ traversalSwapped;
if (body.Bindings.TryGetEdgeBinding(coedge.EdgeId, out var binding)
&& CurveSampler.TrySampleTrimmedCircleArc(
circle,
start,
end,
- coedge.IsReversed ? !binding.OrientedEdgeSense : binding.OrientedEdgeSense,
+ effectiveIsReversed ? !binding.OrientedEdgeSense : binding.OrientedEdgeSense,
out var sampledPoints,
out var isClosed,
out var usedShorterArcFallback))
diff --git a/testdata/step242/manifests/nist.v0.report.json b/testdata/step242/manifests/nist.v0.report.json
index cc7204af..ed1ed86d 100644
--- a/testdata/step242/manifests/nist.v0.report.json
+++ b/testdata/step242/manifests/nist.v0.report.json
@@ -392,7 +392,7 @@
"firstDiagnostic": {
"code": "NotImplemented",
"source": "Viewer.Tessellation.PlanarNonConvexTriangulationFailed",
- "messagePrefix": "Face 11 planar loop triangulation failed because the polygon is not simple."
+ "messagePrefix": "Face 221 planar loop triangulation failed because the polygon is not simple."
},
"diagnosticCount": 1,
"exceptionEscaped": false,