Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Update ftc_11 regressions to new tessellation blocker

Yuechen Li7a1ab6c23952
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTests.cs
index 3f9fd51c..1c8ee0be 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTests.cs
@@ -52,8 +52,7 @@ public sealed class Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTes
Assert.Equal("tessellator", first.FirstFailureLayer);
Assert.NotEqual("Viewer.Tessellation.CylinderTrimDegenerate", first.FirstDiagnostic.Source);
- Assert.Equal("Viewer.Tessellation.PlanarPolygonDegenerate", first.FirstDiagnostic.Source);
- Assert.StartsWith("Face 10 planar loop is degenerate and cannot be triangulated.", first.FirstDiagnostic.MessagePrefix, StringComparison.Ordinal);
+ Assert.Equal("Viewer.Tessellation.PlanarCurveFlatteningFailed", first.FirstDiagnostic.Source);
Assert.Equal(first.FirstFailureLayer, second.FirstFailureLayer);
Assert.Equal(first.FirstDiagnostic.Source, second.FirstDiagnostic.Source);
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242UnsupportedSurfaceForHolesRegressionTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242UnsupportedSurfaceForHolesRegressionTests.cs
index 44d1ef20..5d1130eb 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242UnsupportedSurfaceForHolesRegressionTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242UnsupportedSurfaceForHolesRegressionTests.cs
@@ -15,8 +15,8 @@ public sealed class Step242UnsupportedSurfaceForHolesRegressionTests
"testdata/step242/nist/FTC/nist_ftc_11_asme1_ap242-e2.stp",
"tessellator",
"Topology.GraphValidator",
- "Viewer.Tessellation.PlanarPolygonDegenerate",
- "Face 10 planar loop is degenerate and cannot be triangulated.")]
+ "Viewer.Tessellation.PlanarCurveFlatteningFailed",
+ null)]
public void Step242_NistTargets_AdvancePastGenericUnsupportedSurfaceForHoles_Deterministically(
string relativePath,
diff --git a/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs b/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs
index 0577ec61..234032f1 100644
--- a/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs
+++ b/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs
@@ -2979,7 +2979,8 @@ public static class BrepDisplayTessellator
}
var interval = binding.TrimInterval ?? new ParameterInterval(0d, 1d);
- var parameter = useStart ? interval.Start : interval.End;
+ var useTrimStart = useStart == binding.OrientedEdgeSense;
+ var parameter = useTrimStart ? interval.Start : interval.End;
return curve.Kind switch
{
CurveGeometryKind.Line3 => KernelResult<Point3D>.Success(curve.Line3!.Value.Evaluate(parameter)),
diff --git a/testdata/step242/manifests/nist.v0.report.json b/testdata/step242/manifests/nist.v0.report.json
index f6099dfa..68d755e0 100644
--- a/testdata/step242/manifests/nist.v0.report.json
+++ b/testdata/step242/manifests/nist.v0.report.json
@@ -271,8 +271,8 @@
"firstFailureLayer": "tessellator",
"firstDiagnostic": {
"code": "InvalidArgument",
- "source": "Viewer.Tessellation.PlanarPolygonDegenerate",
- "messagePrefix": "Face 10 planar loop is degenerate and cannot be triangulated."
+ "source": "Viewer.Tessellation.PlanarCurveFlatteningFailed",
+ "messagePrefix": "Face 21 planar loop coedges do not form a contiguous chain."
},
"diagnosticCount": 1,
"exceptionEscaped": false,