Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

M20: add deterministic scaffold acceptance evaluator

Yuechen Li80d7ca157bf5
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242BsplineUvGridScaffoldBuilderTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242BsplineUvGridScaffoldBuilderTests.cs
index c44031ac..1928e57c 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242BsplineUvGridScaffoldBuilderTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242BsplineUvGridScaffoldBuilderTests.cs
@@ -26,8 +26,9 @@ public sealed class Step242BsplineUvGridScaffoldBuilderTests
VSegments: 12,
ReferencePositions: referencePatch.Positions,
ReferenceTriangleCount: referencePatch.TriangleIndices.Count / 3,
- MaxFidelityError: 0.08d,
- MaxTriangleDensityRatioVsFallback: 1.10d);
+ Acceptance: new BsplineUvGridScaffoldAcceptanceThresholds(
+ MaxFidelityError: 0.08d,
+ MaxTriangleDensityRatioVsFallback: 1.10d));
var first = Builder.Build(surface, request);
var second = Builder.Build(surface, request);
@@ -37,6 +38,7 @@ public sealed class Step242BsplineUvGridScaffoldBuilderTests
Assert.NotNull(first.Mesh);
Assert.Equal(first.Mesh!.Positions, second.Mesh!.Positions);
Assert.Equal(first.Mesh.TriangleIndices, second.Mesh.TriangleIndices);
+ Assert.Equal(first.Metrics, second.Metrics);
Assert.Equal(first.Acceptance, second.Acceptance);
Assert.Equal(first.RejectionReason, second.RejectionReason);
}
@@ -56,8 +58,9 @@ public sealed class Step242BsplineUvGridScaffoldBuilderTests
VSegments: 16,
ReferencePositions: referencePatch.Positions,
ReferenceTriangleCount: referencePatch.TriangleIndices.Count / 3,
- MaxFidelityError: 0.08d,
- MaxTriangleDensityRatioVsFallback: 1.10d));
+ Acceptance: new BsplineUvGridScaffoldAcceptanceThresholds(
+ MaxFidelityError: 0.08d,
+ MaxTriangleDensityRatioVsFallback: 1.10d)));
Assert.Equal(BsplineUvGridScaffoldAcceptance.Accepted, result.Acceptance);
Assert.Equal(BsplineUvGridScaffoldRejectionReason.None, result.RejectionReason);
@@ -81,9 +84,10 @@ public sealed class Step242BsplineUvGridScaffoldBuilderTests
TrimMask: trimMask,
ReferencePositions: referencePatch.Positions,
ReferenceTriangleCount: referencePatch.TriangleIndices.Count / 3,
- MaxFidelityError: 0.10d,
- MaxBoundaryDeviationUv: 0.051d,
- MaxTriangleDensityRatioVsFallback: 1.10d));
+ Acceptance: new BsplineUvGridScaffoldAcceptanceThresholds(
+ MaxFidelityError: 0.10d,
+ MaxBoundaryDeviationUv: 0.051d,
+ MaxTriangleDensityRatioVsFallback: 1.10d)));
Assert.Equal(BsplineUvGridScaffoldAcceptance.Accepted, result.Acceptance);
Assert.Equal(BsplineUvGridScaffoldRejectionReason.None, result.RejectionReason);
@@ -105,8 +109,9 @@ public sealed class Step242BsplineUvGridScaffoldBuilderTests
VSegments: 12,
ReferencePositions: referencePatch.Positions,
ReferenceTriangleCount: referencePatch.TriangleIndices.Count / 3,
- MaxFidelityError: 0.08d,
- MaxTriangleDensityRatioVsFallback: 1.10d));
+ Acceptance: new BsplineUvGridScaffoldAcceptanceThresholds(
+ MaxFidelityError: 0.08d,
+ MaxTriangleDensityRatioVsFallback: 1.10d)));
var rejected = Builder.Build(
surface,
@@ -115,14 +120,58 @@ public sealed class Step242BsplineUvGridScaffoldBuilderTests
VSegments: 12,
ReferencePositions: referencePatch.Positions,
ReferenceTriangleCount: referencePatch.TriangleIndices.Count / 3,
- MaxFidelityError: 0.08d,
- MaxTriangleDensityRatioVsFallback: 0.10d));
+ Acceptance: new BsplineUvGridScaffoldAcceptanceThresholds(
+ MaxFidelityError: 0.08d,
+ MaxTriangleDensityRatioVsFallback: 0.10d)));
Assert.Equal(BsplineUvGridScaffoldAcceptance.Accepted, accepted.Acceptance);
Assert.Equal(BsplineUvGridScaffoldAcceptance.Rejected, rejected.Acceptance);
Assert.Equal(BsplineUvGridScaffoldRejectionReason.TooDenseVsFallback, rejected.RejectionReason);
}
+ [Fact]
+ public void M20_Rejects_WhenFidelityThresholdIsImpossible_AndReasonIsDeterministic()
+ {
+ var body = ImportRepresentativeBsplineBody();
+ var face = Assert.Single(body.Topology.Faces);
+ var surface = GetBsplineSurface(body, face.Id);
+ var referencePatch = GetReferencePatch(body, face.Id);
+
+ var request = new BsplineUvGridScaffoldBuildRequest(
+ USegments: 12,
+ VSegments: 12,
+ ReferencePositions: referencePatch.Positions,
+ ReferenceTriangleCount: referencePatch.TriangleIndices.Count / 3,
+ Acceptance: new BsplineUvGridScaffoldAcceptanceThresholds(
+ MaxFidelityError: 0d,
+ MaxTriangleDensityRatioVsFallback: 10d));
+
+ var first = Builder.Build(surface, request);
+ var second = Builder.Build(surface, request);
+
+ Assert.Equal(BsplineUvGridScaffoldAcceptance.Rejected, first.Acceptance);
+ Assert.Equal(BsplineUvGridScaffoldRejectionReason.FidelityTooLow, first.RejectionReason);
+ Assert.Equal(first.Acceptance, second.Acceptance);
+ Assert.Equal(first.RejectionReason, second.RejectionReason);
+ Assert.Equal(first.Metrics, second.Metrics);
+ }
+
+ [Fact]
+ public void M20_RejectsUnsupportedInput_BeforeMetricEvaluation()
+ {
+ var body = ImportRepresentativeBsplineBody();
+ var face = Assert.Single(body.Topology.Faces);
+ var surface = GetBsplineSurface(body, face.Id);
+
+ var result = Builder.Build(
+ surface,
+ new BsplineUvGridScaffoldBuildRequest(USegments: 0, VSegments: 12));
+
+ Assert.Equal(BsplineUvGridScaffoldAcceptance.Rejected, result.Acceptance);
+ Assert.Equal(BsplineUvGridScaffoldRejectionReason.UnsupportedInput, result.RejectionReason);
+ Assert.Equal(BsplineUvGridScaffoldMetrics.Empty, result.Metrics);
+ }
+
private static DisplayFaceMeshPatch GetReferencePatch(BrepBody body, FaceId faceId)
{
var tessellation = BrepDisplayTessellator.Tessellate(body);
diff --git a/Aetheris.Kernel.Core/Brep/Tessellation/BsplineUvGridScaffoldBuilder.cs b/Aetheris.Kernel.Core/Brep/Tessellation/BsplineUvGridScaffoldBuilder.cs
index 861d9c38..9f3b442d 100644
--- a/Aetheris.Kernel.Core/Brep/Tessellation/BsplineUvGridScaffoldBuilder.cs
+++ b/Aetheris.Kernel.Core/Brep/Tessellation/BsplineUvGridScaffoldBuilder.cs
@@ -49,54 +49,52 @@ internal sealed class BsplineUvGridScaffoldBuilder
return BsplineUvGridScaffoldResult.Rejected(BsplineUvGridScaffoldRejectionReason.UnsupportedInput, BsplineUvGridScaffoldMetrics.Empty, mesh);
}
- var degenerateRatio = ComputeDegenerateTriangleRatio(mesh, request.DegenerateTriangleAreaTolerance);
- if (degenerateRatio > request.MaxDegenerateTriangleRatio)
+ var metrics = new BsplineUvGridScaffoldMetrics(
+ ComputeDegenerateTriangleRatio(mesh, (request.Acceptance ?? BsplineUvGridScaffoldAcceptanceThresholds.ConservativeDefaults).DegenerateTriangleAreaTolerance),
+ ComputeTrimLeakageCount(mesh, request.TrimMask),
+ ComputeBoundaryDeviation(mesh, request.TrimMask),
+ ComputeFidelityError(mesh, request.ReferencePositions),
+ ComputeDensityRatio(mesh, request.ReferenceTriangleCount));
+
+ var rejectionReason = EvaluateAcceptance(metrics, request.Acceptance ?? BsplineUvGridScaffoldAcceptanceThresholds.ConservativeDefaults);
+ if (rejectionReason != BsplineUvGridScaffoldRejectionReason.None)
{
- return BsplineUvGridScaffoldResult.Rejected(
- BsplineUvGridScaffoldRejectionReason.ExcessiveDegenerateTriangles,
- new BsplineUvGridScaffoldMetrics(degenerateRatio, 0, 0d, 0d, 1d),
- mesh);
+ return BsplineUvGridScaffoldResult.Rejected(rejectionReason, metrics, mesh);
}
- var leakageCount = ComputeTrimLeakageCount(mesh, request.TrimMask);
- if (leakageCount > 0)
+ return BsplineUvGridScaffoldResult.Accepted(mesh, metrics);
+ }
+
+ private static BsplineUvGridScaffoldRejectionReason EvaluateAcceptance(
+ BsplineUvGridScaffoldMetrics metrics,
+ BsplineUvGridScaffoldAcceptanceThresholds thresholds)
+ {
+ if (metrics.DegenerateTriangleRatio > thresholds.MaxDegenerateTriangleRatio)
{
- return BsplineUvGridScaffoldResult.Rejected(
- BsplineUvGridScaffoldRejectionReason.TrimLeakage,
- new BsplineUvGridScaffoldMetrics(degenerateRatio, leakageCount, 0d, 0d, 1d),
- mesh);
+ return BsplineUvGridScaffoldRejectionReason.ExcessiveDegenerateTriangles;
}
- var boundaryDeviation = ComputeBoundaryDeviation(mesh, request.TrimMask);
- if (boundaryDeviation > request.MaxBoundaryDeviationUv)
+ if (metrics.LeakageTriangleCount > 0)
{
- return BsplineUvGridScaffoldResult.Rejected(
- BsplineUvGridScaffoldRejectionReason.BoundaryDeviationTooHigh,
- new BsplineUvGridScaffoldMetrics(degenerateRatio, leakageCount, boundaryDeviation, 0d, 1d),
- mesh);
+ return BsplineUvGridScaffoldRejectionReason.TrimLeakage;
}
- var fidelityError = ComputeFidelityError(mesh, request.ReferencePositions);
- if (fidelityError > request.MaxFidelityError)
+ if (metrics.BoundaryDeviationUv > thresholds.MaxBoundaryDeviationUv)
{
- return BsplineUvGridScaffoldResult.Rejected(
- BsplineUvGridScaffoldRejectionReason.FidelityTooLow,
- new BsplineUvGridScaffoldMetrics(degenerateRatio, leakageCount, boundaryDeviation, fidelityError, 1d),
- mesh);
+ return BsplineUvGridScaffoldRejectionReason.BoundaryDeviationTooHigh;
}
- var densityRatio = ComputeDensityRatio(mesh, request.ReferenceTriangleCount);
- if (densityRatio > request.MaxTriangleDensityRatioVsFallback)
+ if (metrics.FidelityError > thresholds.MaxFidelityError)
{
- return BsplineUvGridScaffoldResult.Rejected(
- BsplineUvGridScaffoldRejectionReason.TooDenseVsFallback,
- new BsplineUvGridScaffoldMetrics(degenerateRatio, leakageCount, boundaryDeviation, fidelityError, densityRatio),
- mesh);
+ return BsplineUvGridScaffoldRejectionReason.FidelityTooLow;
}
- return BsplineUvGridScaffoldResult.Accepted(
- mesh,
- new BsplineUvGridScaffoldMetrics(degenerateRatio, leakageCount, boundaryDeviation, fidelityError, densityRatio));
+ if (metrics.TriangleDensityRatio > thresholds.MaxTriangleDensityRatioVsFallback)
+ {
+ return BsplineUvGridScaffoldRejectionReason.TooDenseVsFallback;
+ }
+
+ return BsplineUvGridScaffoldRejectionReason.None;
}
private static List<int> BuildTriangles(BsplineUvGridScaffoldBuildRequest request, IReadOnlyList<UvPoint> uvPoints, int columns)
@@ -306,11 +304,17 @@ internal sealed record BsplineUvGridScaffoldBuildRequest(
UvTrimMask? TrimMask = null,
IReadOnlyList<Point3D>? ReferencePositions = null,
int? ReferenceTriangleCount = null,
+ BsplineUvGridScaffoldAcceptanceThresholds? Acceptance = null);
+
+internal sealed record BsplineUvGridScaffoldAcceptanceThresholds(
double MaxDegenerateTriangleRatio = 0.15d,
double DegenerateTriangleAreaTolerance = 1e-12d,
double MaxBoundaryDeviationUv = 0.06d,
double MaxFidelityError = 0.10d,
- double MaxTriangleDensityRatioVsFallback = 1.10d);
+ double MaxTriangleDensityRatioVsFallback = 1.10d)
+{
+ internal static BsplineUvGridScaffoldAcceptanceThresholds ConservativeDefaults { get; } = new();
+}
internal sealed record BsplineUvGridScaffoldMesh(
IReadOnlyList<Point3D> Positions,