Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Add AIR-V5.1 CLI primitive routing validation coverage

Yuechen Li831e79803385
diff --git a/Aetheris.CLI.Tests/CliBaselineTests.cs b/Aetheris.CLI.Tests/CliBaselineTests.cs
index 63034547..74e3e836 100644
--- a/Aetheris.CLI.Tests/CliBaselineTests.cs
+++ b/Aetheris.CLI.Tests/CliBaselineTests.cs
@@ -188,6 +188,96 @@ public sealed class CliBaselineTests
Assert.True(vertexIds.GetProperty("contiguous").GetBoolean());
}
+ [Theory]
+ [InlineData("air-v5-1-box-10-10-10", "box", 10d, 10d, 10d, 6, 0, 0, true, false)]
+ [InlineData("air-v5-1-box-12-8-6", "box", 12d, 8d, 6d, 6, 0, 0, true, false)]
+ [InlineData("air-v5-1-cylinder-5-10", "cylinder", 5d, 0d, 10d, 2, 1, 0, true, false)]
+ [InlineData("air-v5-1-cylinder-3-12", "cylinder", 3d, 0d, 12d, 2, 1, 0, true, false)]
+ [InlineData("air-v5-1-frustum-5-2-10", "cone", 5d, 2d, 10d, 2, 0, 1, true, false)]
+ [InlineData("air-v5-1-frustum-3-1-12", "cone", 3d, 1d, 12d, 2, 0, 1, true, false)]
+ [InlineData("air-v5-1-frustum-inverted-2-5-10", "cone", 2d, 5d, 10d, 2, 0, 1, true, false)]
+ [InlineData("air-v5-1-apex-bottom-5", "cone", 5d, 0d, 10d, 1, 0, 1, true, false)]
+ [InlineData("air-v5-1-apex-top-5", "cone", 0d, 5d, 10d, 1, 0, 1, true, false)]
+ public void Build_And_Analyze_Primitives_Preserve_AIR_V5_1_Visible_Contracts(
+ string name,
+ string op,
+ double primary,
+ double secondary,
+ double heightOrDepth,
+ int expectedPlanarFaces,
+ int expectedCylindricalFaces,
+ int expectedConicalFaces,
+ bool expectManifoldSolid,
+ bool expectBrepWithVoids)
+ {
+ var sourcePath = WriteSingleOpFirmamentFixture(name, op, primary, secondary, heightOrDepth);
+ var outputPath = Path.Combine(Path.GetTempPath(), $"{name}-{Guid.NewGuid():N}.step");
+
+ try
+ {
+ var buildStdout = new StringWriter();
+ var buildStderr = new StringWriter();
+ var buildExitCode = Aetheris.CLI.CliRunner.Run(["build", sourcePath, "--out", outputPath], buildStdout, buildStderr);
+ Assert.Equal(0, buildExitCode);
+ Assert.True(File.Exists(outputPath), buildStderr.ToString());
+
+ var summary = AnalyzeSummary(outputPath);
+ Assert.Equal(1, summary.GetProperty("bodyCount").GetInt32());
+ Assert.Equal("enclosed-manifold", summary.GetProperty("structuralAssessment").GetString());
+ Assert.Equal(expectedPlanarFaces, summary.GetProperty("surfaceFamilies").GetProperty("plane").GetInt32());
+ Assert.Equal(expectedCylindricalFaces, summary.GetProperty("surfaceFamilies").GetProperty("cylinder").GetInt32());
+ Assert.Equal(expectedConicalFaces, summary.GetProperty("surfaceFamilies").GetProperty("cone").GetInt32());
+
+ var stepText = File.ReadAllText(outputPath);
+ Assert.Contains("ISO-10303-21", stepText, StringComparison.Ordinal);
+ Assert.Equal(expectManifoldSolid, stepText.Contains("MANIFOLD_SOLID_BREP", StringComparison.Ordinal));
+ Assert.Contains("ADVANCED_FACE", stepText, StringComparison.Ordinal);
+ Assert.Equal(expectedPlanarFaces > 0, stepText.Contains("PLANE", StringComparison.Ordinal));
+ Assert.Equal(expectedCylindricalFaces > 0, stepText.Contains("CYLINDRICAL_SURFACE", StringComparison.Ordinal));
+ Assert.Equal(expectedConicalFaces > 0, stepText.Contains("CONICAL_SURFACE", StringComparison.Ordinal));
+ Assert.Equal(expectBrepWithVoids, stepText.Contains("BREP_WITH_VOIDS", StringComparison.Ordinal));
+ }
+ finally
+ {
+ File.Delete(sourcePath);
+ if (File.Exists(outputPath))
+ {
+ File.Delete(outputPath);
+ }
+ }
+ }
+
+ [Theory]
+ [InlineData("box", 0d, 5d, 6d)]
+ [InlineData("box", -1d, 5d, 6d)]
+ [InlineData("cylinder", -2d, 0d, 10d)]
+ [InlineData("cylinder", 3d, 0d, 0d)]
+ [InlineData("cone", 5d, 2d, -8d)]
+ [InlineData("cone", 4d, 4d, 10d)]
+ public void Build_Command_Invalid_Primitive_Inputs_Fail_Deterministically(string op, double primary, double secondary, double heightOrDepth)
+ {
+ var sourcePath = WriteSingleOpFirmamentFixture($"air-v5-1-invalid-{op}-{Guid.NewGuid():N}", op, primary, secondary, heightOrDepth);
+ var outputPath = Path.Combine(Path.GetTempPath(), $"air-v5-1-invalid-{Guid.NewGuid():N}.step");
+
+ try
+ {
+ var stdout = new StringWriter();
+ var stderr = new StringWriter();
+ var exitCode = Aetheris.CLI.CliRunner.Run(["build", sourcePath, "--out", outputPath], stdout, stderr);
+ Assert.Equal(1, exitCode);
+ Assert.False(File.Exists(outputPath));
+ Assert.Contains("build failed", stderr.ToString(), StringComparison.OrdinalIgnoreCase);
+ }
+ finally
+ {
+ File.Delete(sourcePath);
+ if (File.Exists(outputPath))
+ {
+ File.Delete(outputPath);
+ }
+ }
+ }
+
[Fact]
public void Analyze_Command_Provides_Numeric_Face_Detail_Anchors()
{
@@ -1097,6 +1187,65 @@ public sealed class CliBaselineTests
return outputPath;
}
+ private static string WriteSingleOpFirmamentFixture(string name, string op, double primary, double secondary, double heightOrDepth)
+ {
+ var outputPath = Path.Combine(Path.GetTempPath(), $"{name}-{Guid.NewGuid():N}.firmament");
+ var source = op switch
+ { "box" => $"""
+firmament:
+ version: 1
+
+model:
+ name: {name}
+ units: mm
+
+ops[1]:
+ -
+ op: box
+ id: body1
+ size[3]:
+ {primary}
+ {secondary}
+ {heightOrDepth}
+""",
+ "cylinder" => $"""
+firmament:
+ version: 1
+
+model:
+ name: {name}
+ units: mm
+
+ops[1]:
+ -
+ op: cylinder
+ id: body1
+ radius: {primary}
+ height: {heightOrDepth}
+""",
+ "cone" => $"""
+firmament:
+ version: 1
+
+model:
+ name: {name}
+ units: mm
+
+ops[1]:
+ -
+ op: cone
+ id: body1
+ bottom_radius: {primary}
+ top_radius: {secondary}
+ height: {heightOrDepth}
+""",
+ _ => throw new InvalidOperationException($"Unsupported op '{op}'.")
+ };
+
+ File.WriteAllText(outputPath, source);
+ return outputPath;
+ }
+
private static void AssertPoint(JsonElement point, double x, double y, double z)
{
Assert.Equal(x, point.GetProperty("x").GetDouble(), 8);
diff --git a/docs/air-v3-box-as-air-extrude-production.md b/docs/air-v3-box-as-air-extrude-production.md
index bace4290..f40338ee 100644
--- a/docs/air-v3-box-as-air-extrude-production.md
+++ b/docs/air-v3-box-as-air-extrude-production.md
@@ -56,3 +56,6 @@ Box was selected as the lowest-risk first primitive because it is bounded, analy
## Next recommended milestone
Proceed to the next bounded primitive candidate only after introducing an equivalent pre-migration evidence lane and parity contract (topology + STEP smoke) for that primitive.
+
+## AIR-V5.1 follow-up
+- CLI external validation coverage for AIR-routed box behavior was added in `docs/air-v5-1-cli-validation.md`.
diff --git a/docs/air-v4-cylinder-as-air-revolve-production.md b/docs/air-v4-cylinder-as-air-revolve-production.md
index c4a058fc..cf269d21 100644
--- a/docs/air-v4-cylinder-as-air-revolve-production.md
+++ b/docs/air-v4-cylinder-as-air-revolve-production.md
@@ -48,3 +48,6 @@ AIR-V4 preserves the observable cylinder contract:
## Next recommended primitive migration step
Given AIR-X5 readiness, next bounded candidate remains cone/frustum production-route hardening through existing revolve lane while preserving emitter/topology parity constraints.
+
+## AIR-V5.1 follow-up
+- CLI external validation coverage for AIR-routed cylinder behavior was added in `docs/air-v5-1-cli-validation.md`.
diff --git a/docs/air-v5-1-cli-validation.md b/docs/air-v5-1-cli-validation.md
new file mode 100644
index 00000000..09e4caec
--- /dev/null
+++ b/docs/air-v5-1-cli-validation.md
@@ -0,0 +1,43 @@
+# AIR-V5.1 CLI validation
+
+## Purpose and scope
+This milestone validates that AIR-routed production changes for box (AIR-V3), cylinder (AIR-V4), and cone/frustum routing (AIR-V5) preserve externally visible Aetheris CLI behavior.
+
+Validation is intentionally CLI-first: build through `aetheris build`, inspect through `aetheris analyze --json`, and verify generated STEP text markers.
+
+## CLI commands/features inspected
+- `dotnet run --project Aetheris.CLI --framework net10.0 -- --help`
+- `aetheris build <fixture.firmament> --out <shape.step>`
+- `aetheris analyze <shape.step> --json`
+
+Checked contracts:
+- build success/failure behavior,
+- summary/topology envelope (`bodyCount`, `structuralAssessment`),
+- analytic surface-family reporting (`plane`, `cylinder`, `cone`),
+- STEP marker presence/absence (`ISO-10303-21`, `MANIFOLD_SOLID_BREP`, `ADVANCED_FACE`, analytic surface markers, no `BREP_WITH_VOIDS`).
+
+## Cases validated
+- Box: `10,10,10` and `12,8,6`.
+- Cylinder: `r=5,h=10` and `r=3,h=12`.
+- Non-apex frustum: `(5,2,10)`, `(3,1,12)`, and inverted taper `(2,5,10)`.
+- Apex cones: `(5,0,10)` and `(0,5,10)`.
+- Equal-radius cone/frustum: `(4,4,10)`.
+- Invalid input probes: zero/negative dimensions and heights, negative radii.
+
+## Expected marker/contracts asserted
+- Boxes export planar faces and `PLANE` markers.
+- Cylinders export one cylindrical family + two planar caps and include `CYLINDRICAL_SURFACE` and `PLANE`.
+- Non-apex and apex cones/frusta export `CONICAL_SURFACE` with planar caps where expected.
+- Equal-radius cone/frustum remains cylinder-like (`CYLINDRICAL_SURFACE`, not `CONICAL_SURFACE`).
+- Valid solids include `MANIFOLD_SOLID_BREP`; all validated cases exclude `BREP_WITH_VOIDS`.
+
+## Baseline impact
+No external fixture/baseline files were regenerated. Validation coverage was added as deterministic CLI tests using ephemeral per-test temporary fixtures/STEP outputs.
+
+## Tests run
+- Focused CLI and kernel/firmament test filters for primitive and STEP behavior.
+- Full repo gate via `./scripts/test-all.sh` after focused checks.
+
+## Remaining limitations
+- Validation remains external/black-box at CLI level and does not assert internal AIR route-selection traces directly.
+- Assertions intentionally avoid face/edge hard-coded IDs for routed primitives; analytic-family and marker contracts are used instead.
diff --git a/docs/air-v5-frustum-ruled-transition-production.md b/docs/air-v5-frustum-ruled-transition-production.md
index 169afd60..541424d6 100644
--- a/docs/air-v5-frustum-ruled-transition-production.md
+++ b/docs/air-v5-frustum-ruled-transition-production.md
@@ -51,3 +51,6 @@ For migrated non-apex frustums, production behavior remains parity-aligned with
## Next recommended milestone
- Bounded square-to-round adapter lab with explicit admissibility, scoring, and topology/STEP parity gates before any production routing.
+
+## AIR-V5.1 follow-up
+- CLI external validation coverage for ruled-transition frustum routing, apex cone routing, and equal-radius cone/frustum semantics was added in `docs/air-v5-1-cli-validation.md`.