Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Fix hardening corpus fixtures for revolve and L-shape boolean cases

Yuechen Li850f050e370c
diff --git a/Aetheris.Kernel.Core.Tests/Brep/HardeningRegressionCorpusTests.cs b/Aetheris.Kernel.Core.Tests/Brep/HardeningRegressionCorpusTests.cs
index 5920d881..e2c884a7 100644
--- a/Aetheris.Kernel.Core.Tests/Brep/HardeningRegressionCorpusTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Brep/HardeningRegressionCorpusTests.cs
@@ -36,8 +36,8 @@ public sealed class HardeningRegressionCorpusTests
var frame = HardeningRegressionFixtures.CanonicalFrame();
var axis = new RevolveAxis3D(frame.Origin, frame.Normal.ToVector());
- var supported = BrepRevolve.Create(HardeningRegressionFixtures.CanonicalRevolveProfile, frame, axis, System.Math.PI * 2d);
- var unsupported = BrepRevolve.Create(HardeningRegressionFixtures.CanonicalRevolveProfile, frame, axis, System.Math.PI);
+ var supported = BrepRevolve.Create(HardeningRegressionFixtures.CanonicalRevolveSupportedProfile, frame, axis, System.Math.PI * 2d);
+ var unsupported = BrepRevolve.Create(HardeningRegressionFixtures.CanonicalRevolveUnsupportedProfile, frame, axis, System.Math.PI);
Assert.True(supported.IsSuccess);
Assert.False(unsupported.IsSuccess);
@@ -50,12 +50,13 @@ public sealed class HardeningRegressionCorpusTests
var left = HardeningRegressionFixtures.OverlapLeftBox();
var overlapRight = HardeningRegressionFixtures.OverlapRightBox();
var touchingRight = HardeningRegressionFixtures.TouchingOnlyBox();
+ var lShapeLeft = HardeningRegressionFixtures.LShapeUnionLeftBox();
var lShapeRight = HardeningRegressionFixtures.LShapeUnionRightBox();
var contained = HardeningRegressionFixtures.ContainedBox();
Assert.True(BrepBoolean.Intersect(left, overlapRight).IsSuccess);
Assert.False(BrepBoolean.Intersect(left, touchingRight).IsSuccess);
- Assert.False(BrepBoolean.Union(left, lShapeRight).IsSuccess);
+ Assert.False(BrepBoolean.Union(lShapeLeft, lShapeRight).IsSuccess);
var containmentUnion = BrepBoolean.Union(left, contained);
Assert.True(containmentUnion.IsSuccess);
diff --git a/Aetheris.Kernel.Core.Tests/Brep/HardeningRegressionFixtures.cs b/Aetheris.Kernel.Core.Tests/Brep/HardeningRegressionFixtures.cs
index 625094e9..0916752c 100644
--- a/Aetheris.Kernel.Core.Tests/Brep/HardeningRegressionFixtures.cs
+++ b/Aetheris.Kernel.Core.Tests/Brep/HardeningRegressionFixtures.cs
@@ -13,20 +13,26 @@ internal static class HardeningRegressionFixtures
internal static BrepBody TouchingOnlyBox() => BrepBooleanBoxRecognition.CreateBoxFromExtents(new AxisAlignedBoxExtents(4d, 6d, 0d, 4d, 0d, 4d)).Value;
- internal static BrepBody LShapeUnionRightBox() => BrepBooleanBoxRecognition.CreateBoxFromExtents(new AxisAlignedBoxExtents(2d, 4d, 0d, 2d, 0d, 2d)).Value;
-
internal static BrepBody ContainedBox() => BrepBooleanBoxRecognition.CreateBoxFromExtents(new AxisAlignedBoxExtents(1d, 2d, 1d, 2d, 1d, 2d)).Value;
internal static PolylineProfile2D CanonicalExtrudeProfile() => PolylineProfile2D.Rectangle(2d, 2d);
- internal static IReadOnlyList<ProfilePoint2D> CanonicalRevolveProfile =>
+ internal static IReadOnlyList<ProfilePoint2D> CanonicalRevolveSupportedProfile =>
+ [
+ new ProfilePoint2D(2d, 0d),
+ new ProfilePoint2D(2d, 5d),
+ ];
+
+ internal static IReadOnlyList<ProfilePoint2D> CanonicalRevolveUnsupportedProfile =>
[
new ProfilePoint2D(1d, 0d),
new ProfilePoint2D(1d, 2d),
- new ProfilePoint2D(0d, 2d),
- new ProfilePoint2D(0d, 0d),
];
+ internal static BrepBody LShapeUnionLeftBox() => BrepBooleanBoxRecognition.CreateBoxFromExtents(new AxisAlignedBoxExtents(0d, 2d, 0d, 4d, 0d, 2d)).Value;
+
+ internal static BrepBody LShapeUnionRightBox() => BrepBooleanBoxRecognition.CreateBoxFromExtents(new AxisAlignedBoxExtents(2d, 4d, 0d, 2d, 0d, 2d)).Value;
+
internal static ExtrudeFrame3D CanonicalFrame() =>
new(
Point3D.Origin,