Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Repair canonical through-hole STEP orientation and seam topology

Yuechen Lia40c8f63e62b
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242DerivedFaceOrientationTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242DerivedFaceOrientationTests.cs
index 99a7b84c..2de255d6 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242DerivedFaceOrientationTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242DerivedFaceOrientationTests.cs
@@ -2,12 +2,43 @@ using System.Text.RegularExpressions;
using Aetheris.Kernel.Core.Brep;
using Aetheris.Kernel.Core.Brep.Boolean;
using Aetheris.Kernel.Core.Brep.Verification;
+using Aetheris.Kernel.Core.Import;
using Aetheris.Kernel.Core.Step242;
namespace Aetheris.Kernel.Core.Tests.Step242;
public sealed class Step242DerivedFaceOrientationTests
{
+ [Fact]
+ public void CanonicalThroughHole_IsQuietQualifiedAndKeepsItsGeometryAndPmiIdentity()
+ {
+ var import = Step242Corpus.Import("testdata/firmament/inline-step/canonical-through-hole.step");
+ Assert.True(import.IsSuccess);
+ Assert.Empty(import.Diagnostics);
+ var body = import.Value;
+ Assert.Equal(7, body.Topology.Faces.Count());
+ Assert.Equal(15, body.Topology.Edges.Count());
+ Assert.Equal(10, body.Topology.Vertices.Count()); // Seam shares the two circular boundary vertices.
+ Assert.Equal(0, body.FaceOrientationReport!.SourceMismatchCount);
+ var qualification = Assert.IsType<BrepImportQualificationReport>(body.ImportQualification);
+ Assert.Equal(ImportQualificationStatus.Qualified, qualification.Status);
+ Assert.Empty(qualification.Reasons);
+ Assert.True(qualification.PcurveEvidence.LoopClosureValid);
+ Assert.True(Assert.Single(qualification.Shells).Enclosed);
+ var cavity = Assert.Single(body.Bindings.FaceBindings, binding => binding.SourceStepEntityId == 191);
+ Assert.False(cavity.Orientation.IsAlignedWithSurface);
+ Assert.True(body.TryGetFaceSurfaceGeometry(cavity.FaceId, out var surface));
+ Assert.Equal(1d, surface!.Cylinder!.Value.Radius);
+ var points = body.Topology.Vertices.Select(vertex =>
+ {
+ Assert.True(body.TryGetVertexPoint(vertex.Id, out var point));
+ return point;
+ }).ToArray();
+ Assert.Equal((-5d, 5d), (points.Min(point => point.X), points.Max(point => point.X)));
+ Assert.Equal((-4d, 4d), (points.Min(point => point.Y), points.Max(point => point.Y)));
+ Assert.Equal((-3d, 3d), (points.Min(point => point.Z), points.Max(point => point.Z)));
+ }
+
[Fact]
public void ClosedBox_OneHostileSameSenseFlag_DerivesIdenticalCanonicalBodyAndReportsMismatch()
{
diff --git a/docs/development/reports/2026-10/RELEASE-2.0.0-CLOSEOUT.md b/docs/development/reports/2026-10/RELEASE-2.0.0-CLOSEOUT.md
index 530c1705..dcf118a4 100644
--- a/docs/development/reports/2026-10/RELEASE-2.0.0-CLOSEOUT.md
+++ b/docs/development/reports/2026-10/RELEASE-2.0.0-CLOSEOUT.md
@@ -31,6 +31,24 @@ Full requalification of a freshly rebuilt ZIP is still pending. The previous
133 MB ZIP omitted the actual desktop/browser; its size and hashes below must
not be assigned to the corrected distribution.
+The subsequent canonical-box warning hotfix corrects four STEP records in
+testdata/firmament/inline-step/canonical-through-hole.step: the cavity sense,
+seam vertex references and bottom/top circular edge uses. The nominal 10x8x6 mm
+body, 2 mm bore and all face entity IDs are preserved. Duplicate seam vertices
+are no longer referenced; import topology has ten vertices rather than twelve,
+with seven faces and fifteen edges. It now has connected trim loops, Qualified
+pcurves and zero source-orientation mismatches. The importer warning is retained
+for genuinely inconsistent source. Canonical import/Pmi regressions cover the
+fix; STEP bytes involving this corrected fixture are intentionally changed.
+The repaired canonical fixture also passes the actual packaged WebView2 import,
+export/reimport, selection, invalid-file retention and native-close workflow
+(desktop-repair/canonical-hole-ui/qualification.json). The new clean-import
+regression and 63 InlineStep/Pmi tests pass. Before this fixture addition, the
+local full suite passed 6,007 tests with two optional external-PDF witnesses
+skipped. An earlier concurrent UI/full-suite run exceeded an existing imported
+rod tessellation time budget; that exact case and the entire suite both pass
+when rerun without concurrent UI qualification. No budget was increased.
+
Distribution candidate: `69bcc6bbd839fe2ce2a4e1bbd9231f28cd719286`.
Baseline: `b05cca40ec3efd7540c647398892953299d2c136`.
TSPack: `01051b791cf83757a1c419ef7bc276d9de787a9d`.
diff --git a/testdata/firmament/inline-step/canonical-through-hole.step b/testdata/firmament/inline-step/canonical-through-hole.step
index 0a677f81..a7b7de1f 100644
--- a/testdata/firmament/inline-step/canonical-through-hole.step
+++ b/testdata/firmament/inline-step/canonical-through-hole.step
@@ -188,14 +188,14 @@ DATA;
#181=DIRECTION($,(0,0,-1));
#182=VECTOR($,#181,1);
#183=LINE($,#180,#182);
-#184=EDGE_CURVE($,#177,#179,#183,.T.);
+#184=EDGE_CURVE($,#92,#41,#183,.T.);
#185=ORIENTED_EDGE($,$,$,#184,.T.);
-#186=ORIENTED_EDGE($,$,$,#98,.F.);
+#186=ORIENTED_EDGE($,$,$,#47,.T.);
#187=ORIENTED_EDGE($,$,$,#184,.F.);
-#188=ORIENTED_EDGE($,$,$,#47,.T.);
+#188=ORIENTED_EDGE($,$,$,#98,.F.);
#189=EDGE_LOOP($,(#185,#186,#187,#188));
#190=FACE_OUTER_BOUND('',#189,.T.);
-#191=ADVANCED_FACE('',(#190),#175,.T.);
+#191=ADVANCED_FACE('',(#190),#175,.F.);
#192=CLOSED_SHELL($,(#51,#102,#124,#141,#158,#170,#191));
#193=MANIFOLD_SOLID_BREP('AetherisBody',#192);
#194=APPLICATION_CONTEXT('mechanical design');