Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel
H2: classify picker no-hit after tessellation skip distinctly
Yuechen Lib7d4dd37c6d4
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242CorpusManifestGateTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242CorpusManifestGateTests.csindex 931c8fb7..e996bcf8 100644--- a/Aetheris.Kernel.Core.Tests/Step242/Step242CorpusManifestGateTests.cs+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242CorpusManifestGateTests.cs@@ -80,4 +80,20 @@ public sealed class Step242CorpusManifestGateTestsAssert.Contains("MANIFOLD_SOLID_BREP", text, StringComparison.Ordinal);}}++ [Fact]+ public void V0CorpusManifest_StatusContract_DistinguishesPickerBlockerFromSuccess()+ {+ var manifest = Step242CorpusManifestRunner.LoadManifest("testdata/step242/manifests/v0.corpus.json");+ var blockerEntry = manifest.Entries.Single(e => e.Id == "exp_cylinder_hole_unsupported");+ var blockerReport = Step242CorpusManifestRunner.RunOne(blockerEntry);+ Assert.Equal("pickerBlockedByTessellationSkip", blockerReport.Status);+ Assert.Equal("picker", blockerReport.FirstFailureLayer);+ Assert.Equal("Audit.Picker", blockerReport.FirstDiagnostic.Source);++ var successEntry = manifest.Entries.Single(e => e.Id == "gen_box_v0");+ var successReport = Step242CorpusManifestRunner.RunOne(successEntry);+ Assert.Equal("success", successReport.Status);+ Assert.Equal(string.Empty, successReport.FirstFailureLayer);+ }}diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242CorpusManifestRunner.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242CorpusManifestRunner.csindex 213d8f8d..c4287193 100644--- a/Aetheris.Kernel.Core.Tests/Step242/Step242CorpusManifestRunner.cs+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242CorpusManifestRunner.cs@@ -76,7 +76,7 @@ internal static class Step242CorpusManifestRunnervar pick = TryPickSmoke(body, tessellation.Value);if (!pick.IsSuccess){- return BuildFailure(entry, sizeBytes, "picker", pick.Diagnostics, body, tessellation.Value);+ return BuildFailure(entry, sizeBytes, "picker", pick.Diagnostics, body, tessellation.Value, tessellation.Diagnostics);}var export = Step242Exporter.ExportBody(body);@@ -211,14 +211,15 @@ internal static class Step242CorpusManifestRunnerstring layer,IReadOnlyList<KernelDiagnostic> diagnostics,BrepBody? body = null,- DisplayTessellationResult? tessellation = null)+ DisplayTessellationResult? tessellation = null,+ IReadOnlyList<KernelDiagnostic>? tessellationDiagnostics = null){return new Step242CorpusReportEntry(entry.Id,entry.Path,entry.Group,sizeBytes,- Status: string.Equals(layer, "parser", StringComparison.Ordinal) ? "parseFail" : "importFail",+ Status: ClassifyStatus(layer, tessellationDiagnostics),FirstFailureLayer: layer,FirstDiagnostic: FirstDiagnostic(diagnostics),DiagnosticCount: diagnostics.Count,@@ -229,6 +230,26 @@ internal static class Step242CorpusManifestRunnerExportedCanonicalText: null);}+ private static string ClassifyStatus(string layer, IReadOnlyList<KernelDiagnostic>? tessellationDiagnostics)+ {+ if (string.Equals(layer, "parser", StringComparison.Ordinal))+ {+ return "parseFail";+ }++ if (string.Equals(layer, "picker", StringComparison.Ordinal))+ {+ return HasTruthfulTessellationSkip(tessellationDiagnostics)+ ? "pickerBlockedByTessellationSkip"+ : "pickerFail";+ }++ return "importFail";+ }++ private static bool HasTruthfulTessellationSkip(IReadOnlyList<KernelDiagnostic>? tessellationDiagnostics)+ => tessellationDiagnostics?.Any(d => string.Equals(d.Source, "Viewer.Tessellation.TrimEvaluationFailed", StringComparison.Ordinal)) == true;+private static Step242AuditDiagnostic FirstDiagnostic(IReadOnlyList<KernelDiagnostic> diagnostics){if (diagnostics.Count == 0)diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTests.csindex 113f7bf5..20664920 100644--- a/Aetheris.Kernel.Core.Tests/Step242/Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTests.cs+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTests.cs@@ -50,7 +50,7 @@ public sealed class Step242CylinderTrimDualSingleCoedgeClosedCircleRegressionTesvar first = Step242CorpusManifestRunner.RunOne(new Step242CorpusManifestEntry("ftc11", relativePath, "nist-regression", null, null, null, null, null));var second = Step242CorpusManifestRunner.RunOne(new Step242CorpusManifestEntry("ftc11", relativePath, "nist-regression", null, null, null, null, null));- Assert.Equal("importFail", first.Status);+ Assert.Equal("pickerBlockedByTessellationSkip", first.Status);Assert.Equal("picker", first.FirstFailureLayer);Assert.Equal("Audit.Picker", first.FirstDiagnostic.Source);Assert.Equal("Picker smoke ray produced no hit.", first.FirstDiagnostic.MessagePrefix);