Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Add controlled V2 side-hole radius variation

Yuechen Lib9666ae2552d
diff --git a/Aetheris.CLI.Tests/AirTraceCommandTests.cs b/Aetheris.CLI.Tests/AirTraceCommandTests.cs
index d4dcc969..d41a0835 100644
--- a/Aetheris.CLI.Tests/AirTraceCommandTests.cs
+++ b/Aetheris.CLI.Tests/AirTraceCommandTests.cs
@@ -998,6 +998,64 @@ public sealed class AirTraceCommandTests
Assert.Contains("firmament-v2-unknown-record-type", output);
}
+
+
+ [Fact]
+ public void FirmamentV2SideHoleRadius_TraceJsonPreservesRadius()
+ {
+ foreach (var (fixture, expected) in new[] { ("Region/valid/side-hole-radius-0_5-v2.valid.firmfixture", 0.5), ("Region/valid/side-hole-radius-1_5-v2.valid.firmfixture", 1.5) })
+ {
+ var (exitCode, output, _) = Run("trace", "--fixture", FirmamentV2Fixture(fixture), "--json");
+ Assert.Equal(0, exitCode);
+ using var doc = JsonDocument.Parse(output);
+ var v2 = doc.RootElement.GetProperty("firmamentV2");
+ Assert.Equal(expected, v2.GetProperty("semanticIntent").GetProperty("radius").GetDouble());
+ Assert.Equal(expected, v2.GetProperty("modifyBlocks")[0].GetProperty("regions")[0].GetProperty("radius").GetDouble());
+ Assert.Contains($"\"radius\": {expected.ToString(System.Globalization.CultureInfo.InvariantCulture)}", doc.RootElement.GetProperty("regions").GetRawText(), StringComparison.Ordinal);
+ }
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleRadius_TraceTextPreservesRadius()
+ {
+ var (_, radius05, _) = Run("trace", "--fixture", FirmamentV2Fixture("Region/valid/side-hole-radius-0_5-v2.valid.firmfixture"));
+ var (_, radius15, _) = Run("trace", "--fixture", FirmamentV2Fixture("Region/valid/side-hole-radius-1_5-v2.valid.firmfixture"));
+ Assert.Contains("Tool: Cylinder", radius05);
+ Assert.Contains("Radius: 0.5", radius05);
+ Assert.Contains("Through: face(-X)", radius05);
+ Assert.Contains("Stage: region-parent-integrated", radius05);
+ Assert.Contains("Parent integration: Integrated", radius05);
+ Assert.Contains("Shell closure: Closed", radius05);
+ Assert.Contains("STEP smoke: Succeeded", radius05);
+ Assert.Contains("Radius: 1.5", radius15);
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleRadius_ArtifactsEmitForVariation()
+ {
+ var dir = Path.Combine(Path.GetTempPath(), "aetheris-trace-tests", Guid.NewGuid().ToString("N"));
+ Assert.Equal(0, Run("trace", "--fixture", FirmamentV2Fixture("Region/valid/side-hole-radius-0_5-v2.valid.firmfixture"), "--out-dir", dir).ExitCode);
+ foreach (var name in new[] { "side-hole-radius-0_5-v2.step", "side-hole-radius-0_5-v2.trace.json", "side-hole-radius-0_5-v2.trace.txt", "manifest.json" })
+ {
+ var path = Path.Combine(dir, name);
+ Assert.True(File.Exists(path), path);
+ Assert.True(new FileInfo(path).Length > 0, path);
+ }
+ using var manifest = JsonDocument.Parse(File.ReadAllText(Path.Combine(dir, "manifest.json")));
+ Assert.Equal(0.5, manifest.RootElement.GetProperty("radius").GetDouble());
+ Assert.Equal("Cylinder", manifest.RootElement.GetProperty("tool").GetString());
+ Assert.Equal("face(-X)", manifest.RootElement.GetProperty("throughSelector").GetString());
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleRadius_InvalidDiagnostics()
+ {
+ Assert.Contains("firmament-v2-cylinder-radius-invalid", Run("trace", "--fixture", FirmamentV2Fixture("Region/invalid/side-hole-radius-zero-v2.invalid.firmfixture"), "--json").Stdout);
+ Assert.Contains("firmament-v2-cylinder-radius-invalid", Run("trace", "--fixture", FirmamentV2Fixture("Region/invalid/side-hole-radius-negative-v2.invalid.firmfixture"), "--json").Stdout);
+ Assert.Contains("firmament-v2-side-hole-radius-exceeds-clearance", Run("trace", "--fixture", FirmamentV2Fixture("Region/invalid/side-hole-radius-too-large-v2.invalid.firmfixture"), "--json").Stdout);
+ }
+
+
[Fact]
public void FirmamentV2SideHoleArtifacts_OutDirWritesStableFiles()
{
@@ -1023,7 +1081,7 @@ public sealed class AirTraceCommandTests
using var doc = JsonDocument.Parse(File.ReadAllText(Path.Combine(dir, "manifest.json")));
var root = doc.RootElement;
- Assert.Equal("AIR-FIRMAMENT-X5", root.GetProperty("milestone").GetString());
+ Assert.Equal("AIR-FIRMAMENT-X6", root.GetProperty("milestone").GetString());
Assert.Equal("FirmamentV2", root.GetProperty("syntaxVersion").GetString());
Assert.EndsWith("fixtures/FirmamentV2/Region/valid/side-hole-v2.valid.firmfixture", root.GetProperty("fixture").GetString()!.Replace('\\', '/'), StringComparison.Ordinal);
Assert.Equal("region-parent-integrated", root.GetProperty("stage").GetString());
diff --git a/Aetheris.CLI/AirTrace.cs b/Aetheris.CLI/AirTrace.cs
index 3e53f399..da05ac31 100644
--- a/Aetheris.CLI/AirTrace.cs
+++ b/Aetheris.CLI/AirTrace.cs
@@ -148,7 +148,7 @@ internal static class AirTraceReportBuilder
? null
: new AirTraceConstructiveAirSummary(frontend.ConstructiveAir.NodeKind, frontend.ConstructiveAir.CanonicalForm, frontend.ConstructiveAir.SourceFeatureAirNodeKind, frontend.ConstructiveAir.ProfileKind, frontend.ConstructiveAir.Dimensions.Width, frontend.ConstructiveAir.Dimensions.Depth, frontend.ConstructiveAir.Dimensions.Height, frontend.ConstructiveAir.ExtrusionAxis, frontend.ConstructiveAir.ConstructionIntent, frontend.ConstructiveAir.RouteKind, frontend.ConstructiveAir.StageReached, frontend.ConstructiveAir.Diagnostics, frontend.ConstructiveAir.Guarantees);
- var regions = frontend.FirmamentV2?.SemanticIntent is not null ? AirRegionTraceFactory.ForFaceAttachedSideHoleDeferred() : AirRegionTraceFactory.ForRootBody(actualStage ?? "emitted-brep");
+ var regions = frontend.FirmamentV2?.SemanticIntent is not null ? AirRegionTraceFactory.ForFaceAttachedSideHoleDeferred(frontend.FirmamentV2.SemanticIntent.Radius) : AirRegionTraceFactory.ForRootBody(actualStage ?? "emitted-brep");
fxDiagnostics = Stable([.. fxDiagnostics, .. regions.Diagnostics]).ToArray();
var profileEmission = profileEmissionProbe is null ? null : new AirTraceProfileEmissionSummary(
profileEmissionProbe.WrapperInvoked,
diff --git a/Aetheris.CLI/CliRunner.cs b/Aetheris.CLI/CliRunner.cs
index a7e24eaf..ee2b918f 100644
--- a/Aetheris.CLI/CliRunner.cs
+++ b/Aetheris.CLI/CliRunner.cs
@@ -16,7 +16,7 @@ internal static class SideHoleGoldenPathArtifacts
public static AirTraceArtifactsSummary Write(string outDir, AirTraceReport report)
{
Directory.CreateDirectory(outDir);
- var stem = IsFirmamentV2SideHole(report) ? "side-hole-v2" : "side-hole";
+ var stem = IsFirmamentV2SideHole(report) ? V2Stem(report) : "side-hole";
var artifacts = new AirTraceArtifactsSummary(
Path.Combine(outDir, stem + ".step"),
Path.Combine(outDir, stem + ".trace.json"),
@@ -28,13 +28,16 @@ internal static class SideHoleGoldenPathArtifacts
public static string Manifest(AirTraceReport report, AirTraceArtifactsSummary artifacts) => JsonSerializer.Serialize(new
{
- milestone = IsFirmamentV2SideHole(report) ? "AIR-FIRMAMENT-X5" : "AIR-REGION-X13",
+ milestone = IsFirmamentV2SideHole(report) ? "AIR-FIRMAMENT-X6" : "AIR-REGION-X13",
syntaxVersion = report.FirmamentV2?.SyntaxVersion,
fixture = report.FixturePath,
stage = report.ActualStageReached,
parentIntegration = report.FirmamentV2?.ParentIntegration ?? "Integrated",
shellClosure = report.FirmamentV2?.ShellClosure ?? "Closed",
stepSmoke = report.FirmamentV2?.StepSmoke ?? "Succeeded",
+ radius = report.FirmamentV2?.SemanticIntent?.Radius,
+ tool = report.FirmamentV2?.SemanticIntent?.Tool,
+ throughSelector = report.FirmamentV2?.SemanticIntent is null ? null : $"face({report.FirmamentV2.SemanticIntent.ThroughFace})",
step = Path.GetFileName(artifacts.Step),
traceJson = Path.GetFileName(artifacts.TraceJson),
traceText = Path.GetFileName(artifacts.TraceText),
@@ -46,6 +49,14 @@ internal static class SideHoleGoldenPathArtifacts
private static bool IsFirmamentV2SideHole(AirTraceReport report) =>
report.FirmamentV2 is { SyntaxVersion: "FirmamentV2", SemanticIntent: not null };
+ private static string V2Stem(AirTraceReport report)
+ {
+ var radius = report.FirmamentV2!.SemanticIntent!.Radius;
+ if (Math.Abs(radius - 1.0) < 1e-12) return "side-hole-v2";
+ var token = radius.ToString("0.############", System.Globalization.CultureInfo.InvariantCulture).Replace('.', '_');
+ return $"side-hole-radius-{token}-v2";
+ }
+
private static string StepText(AirTraceReport report, string stem) => "ISO-10303-21;\n" +
"HEADER;\nFILE_DESCRIPTION(('AIR-REGION-X13 controlled side-hole golden path artifact'),'2;1');\n" +
$"FILE_NAME('{stem}.step','2026-06-18T00:00:00Z',('Aetheris'),('Aetheris'),'Aetheris.CLI trace','Aetheris','');\n" +
@@ -55,7 +66,7 @@ internal static class SideHoleGoldenPathArtifacts
"/* stage=region-parent-integrated; parentIntegration=Integrated; shellClosure=Closed; stepSmoke=Succeeded */\n" +
"/* materialized: CutEntryLoop, CutExitLoop, CutWallFace, RegionIntegrationPatchConsumed */\n" +
"/* cylindrical cut wall evidence; CIR analysis-only; Boolean unused/not generally admitted */\n" +
- $"#1=PRODUCT('{(IsFirmamentV2SideHole(report) ? "AIR-FIRMAMENT-X5-SIDE-HOLE-V2" : "AIR-REGION-X13-SIDE-HOLE")}','controlled side-hole golden path','generated-on-demand fixture artifact',());\n" +
+ $"#1=PRODUCT('{(IsFirmamentV2SideHole(report) ? "AIR-FIRMAMENT-X6-SIDE-HOLE-V2" : "AIR-REGION-X13-SIDE-HOLE")}','controlled side-hole golden path','generated-on-demand fixture artifact',());\n" +
"ENDSEC;\nEND-ISO-10303-21;\n";
}
diff --git a/Aetheris.Kernel.Core/Air/AirRegions.cs b/Aetheris.Kernel.Core/Air/AirRegions.cs
index 6635fe2d..17032b68 100644
--- a/Aetheris.Kernel.Core/Air/AirRegions.cs
+++ b/Aetheris.Kernel.Core/Air/AirRegions.cs
@@ -142,7 +142,7 @@ internal static class AirSideHoleBRepPlaceholderPlanner
var elements = new[]
{
Element(region.RegionId + ":parent-face:" + y.Attachment.FaceSelector.ToLowerInvariant(), "AffectedParentFaceReference", "AffectedParentFace", ["SideHoleFeature", "DeferredIntegration", "NotMaterialized"], region, y, "parent-face:+X", "ReferenceOnly", "air-region-x6-affected-parent-face-placeholder-created"),
- Element(region.RegionId + ":entry-loop", "EntryLoopPlaceholder", "CutEntryLoop", ["SideHoleFeature", "DeferredIntegration", "NotMaterialized"], region, y, "profile:Circle(radius=1);frame:side-hole:+x", "NotMaterialized", "air-region-x6-entry-loop-placeholder-created"),
+ Element(region.RegionId + ":entry-loop", "EntryLoopPlaceholder", "CutEntryLoop", ["SideHoleFeature", "DeferredIntegration", "NotMaterialized"], region, y, "profile:Circle(radius=" + y.Profile.Radius.ToString("g", System.Globalization.CultureInfo.InvariantCulture) + ");frame:side-hole:+x", "NotMaterialized", "air-region-x6-entry-loop-placeholder-created"),
Element(region.RegionId + ":exit-loop", "ExitLoopPlaceholder", "CutExitLoop", ["SideHoleFeature", "DeferredIntegration", "NotMaterialized"], region, y, "opposite-side-exit:deferred", "NotMaterialized", "air-region-x6-exit-loop-placeholder-created"),
Element(region.RegionId + ":cut-wall", "CutWallFacePlaceholder", "CutWallFace", ["SideHoleFeature", "DeferredIntegration", "NotMaterialized"], region, y, "cylindrical-cut-wall:intent", "NotMaterialized", "air-region-x6-cut-wall-placeholder-created"),
Element(region.RegionId + ":integration-patch", "IntegrationPatchPlaceholder", "RegionIntegrationPatch", ["SideHoleFeature", "DeferredIntegration", "NotMaterialized"], region, y, "parent-body-local-patch:deferred", "NotMaterialized", "air-region-x6-integration-patch-placeholder-created")
@@ -176,7 +176,7 @@ internal static class AirSideHolePlaceholderMaterializer
Map(byRole["RegionIntegrationPatch"], AirRegionMaterializationStatus.Deferred, "ParentIntegrationPatch", "ParentIntegrationDeferred", null, "air-region-x7-parent-brep-integration-deferred")
};
var diagnostics = Stable(["air-region-x7-materialization-request-created", "air-region-x7-placeholder-plan-consumed", "air-region-x7-side-hole-materialization-started", "air-region-x7-controlled-side-hole-route-selected", "air-region-x7-standalone-patch-materialized", "air-region-x7-parent-integration-not-implemented", "air-region-x7-parent-brep-integration-deferred", "air-region-x7-materialization-partial", "air-region-x7-topology-summary-created", "air-region-x7-step-smoke-unavailable", "air-region-x7-no-production-route-replacement", "air-region-x7-no-general-side-hole-support", "air-region-x7-no-cir-topology-authority", .. mappings.SelectMany(m => m.Diagnostics)]).ToArray();
- return new(region.RegionId, region.Yield.FeatureKind, AirRegionMaterializationStatus.PartiallyMaterialized, "ControlledSideHolePatchMaterialization", mappings, new(true, false, 1, 2, 1, "local-cylinder-patch:x=+5..-5,r=1", ["MaterializedEntryLoop", "MaterializedExitLoop", "CylindricalCutWallFace"]), new(false, false, ["air-region-x7-step-smoke-unavailable", "step smoke not checked because parent integration remains deferred"]), diagnostics, ["parent-brep-integration-not-implemented", "standalone-patch-only", "no-closed-parent-body"], ["controlled fixture only", "no general side-hole support", "no arbitrary face/axis support", "no production route replacement", "no parent topology mutation", "parent integration deferred", "CIR remains analysis-only", "Boolean not generally admitted", "no STEP exporter/importer change"]);
+ return new(region.RegionId, region.Yield.FeatureKind, AirRegionMaterializationStatus.PartiallyMaterialized, "ControlledSideHolePatchMaterialization", mappings, new(true, false, 1, 2, 1, "local-cylinder-patch:x=+5..-5,r=" + region.Yield.Profile.Radius.ToString("g", System.Globalization.CultureInfo.InvariantCulture), ["MaterializedEntryLoop", "MaterializedExitLoop", "CylindricalCutWallFace"]), new(false, false, ["air-region-x7-step-smoke-unavailable", "step smoke not checked because parent integration remains deferred"]), diagnostics, ["parent-brep-integration-not-implemented", "standalone-patch-only", "no-closed-parent-body"], ["controlled fixture only", "no general side-hole support", "no arbitrary face/axis support", "no production route replacement", "no parent topology mutation", "parent integration deferred", "CIR remains analysis-only", "Boolean not generally admitted", "no STEP exporter/importer change"]);
}
@@ -208,7 +208,7 @@ internal static class AirSideHoleParentBRepIntegrationPrototype
if (region.Yield is null) throw new ArgumentException("Side-hole region must carry a yield summary.", nameof(region));
var byRole = placeholders.Elements.ToDictionary(e => e.Role, StringComparer.Ordinal);
var diagnostics = Stable(["air-region-x9-face-split-request-created", "air-region-x9-affected-plus-x-face-selected", "air-region-x9-cut-entry-loop-placeholder-consumed", "air-region-x9-circular-entry-loop-created", "air-region-x9-parent-face-split-created", "air-region-x9-inner-loop-evidence-created", "air-region-x9-face-split-summary-created", "air-region-x9-face-splitting-blocker-cleared", "air-region-x9-parent-integration-still-partial", "air-region-x9-no-general-face-splitting", "air-region-x9-no-production-route-replacement", "air-region-x9-no-boolean"]).ToArray();
- return new(region.RegionId, region.Yield.Attachment.FaceSelector, AirRegionFaceSplitStatus.SplitCreated, AirRegionFaceSplitStatus.EntryLoopMaterialized, "CutEntryLoop", "Circle(radius=1)", region.Yield.Profile.Radius, region.Yield.LocalFrameId, "AffectedParentFace", [byRole["CutEntryLoop"].Id], new(true, 2, 1, 1, "parent-box:+X-face(width=8,height=6);inner-circle:r=1", ["ControlledPlusXFaceSplitEvidence", "MaterializedEntryLoop", "CircularInnerLoopEvidence"]), null, diagnostics, ["controlled fixture only", "affected face is +X", "entry loop evidence only", "no arbitrary face splitting", "no Boolean", "parent integration remains partial"]);
+ return new(region.RegionId, region.Yield.Attachment.FaceSelector, AirRegionFaceSplitStatus.SplitCreated, AirRegionFaceSplitStatus.EntryLoopMaterialized, "CutEntryLoop", "Circle(radius=" + region.Yield.Profile.Radius.ToString("g", System.Globalization.CultureInfo.InvariantCulture) + ")", region.Yield.Profile.Radius, region.Yield.LocalFrameId, "AffectedParentFace", [byRole["CutEntryLoop"].Id], new(true, 2, 1, 1, "parent-box:+X-face(width=8,height=6);inner-circle:r=" + region.Yield.Profile.Radius.ToString("g", System.Globalization.CultureInfo.InvariantCulture), ["ControlledPlusXFaceSplitEvidence", "MaterializedEntryLoop", "CircularInnerLoopEvidence"]), null, diagnostics, ["controlled fixture only", "affected face is +X", "entry loop evidence only", "no arbitrary face splitting", "no Boolean", "parent integration remains partial"]);
}
public static AirRegionExitLoopSummary InsertExitLoop(AirRegionSummary region, AirRegionBRepPlaceholderPlan placeholders, AirRegionFaceSplitSummary entrySplit)
@@ -216,7 +216,7 @@ internal static class AirSideHoleParentBRepIntegrationPrototype
if (region.Yield is null) throw new ArgumentException("Side-hole region must carry a yield summary.", nameof(region));
var byRole = placeholders.Elements.ToDictionary(e => e.Role, StringComparer.Ordinal);
var diagnostics = Stable(["air-region-x10-exit-loop-request-created", "air-region-x10-opposite-face-selected", "air-region-x10-minus-x-exit-face-selected", "air-region-x10-cut-exit-loop-placeholder-consumed", "air-region-x10-circular-exit-loop-created", "air-region-x10-exit-face-split-created", "air-region-x10-inner-exit-loop-evidence-created", "air-region-x10-exit-loop-summary-created", "air-region-x10-exit-loop-insertion-blocker-cleared", "air-region-x10-parent-integration-still-partial", "air-region-x10-no-general-side-hole-support", "air-region-x10-no-production-route-replacement", "air-region-x10-no-boolean"]).ToArray();
- return new(region.RegionId, "-X", AirRegionExitLoopStatus.ExitLoopMaterialized, "CutExitLoop", "Circle(radius=1)", region.Yield.Profile.Radius, region.Yield.LocalFrameId, [byRole["CutExitLoop"].Id], new(true, 2, 1, 1, "parent-box:-X-face(width=8,height=6);inner-circle:r=1", ["ControlledMinusXExitFaceSplitEvidence", "MaterializedExitLoop", "CircularInnerLoopEvidence", .. entrySplit.TopologySummary.EvidenceRoles.Where(r => r == "MaterializedEntryLoop")]), null, diagnostics, ["controlled fixture only", "exit face is -X", "exit loop evidence only", "entry loop evidence preserved", "no arbitrary face splitting", "no Boolean", "parent integration remains partial"]);
+ return new(region.RegionId, "-X", AirRegionExitLoopStatus.ExitLoopMaterialized, "CutExitLoop", "Circle(radius=" + region.Yield.Profile.Radius.ToString("g", System.Globalization.CultureInfo.InvariantCulture) + ")", region.Yield.Profile.Radius, region.Yield.LocalFrameId, [byRole["CutExitLoop"].Id], new(true, 2, 1, 1, "parent-box:-X-face(width=8,height=6);inner-circle:r=" + region.Yield.Profile.Radius.ToString("g", System.Globalization.CultureInfo.InvariantCulture), ["ControlledMinusXExitFaceSplitEvidence", "MaterializedExitLoop", "CircularInnerLoopEvidence", .. entrySplit.TopologySummary.EvidenceRoles.Where(r => r == "MaterializedEntryLoop")]), null, diagnostics, ["controlled fixture only", "exit face is -X", "exit loop evidence only", "entry loop evidence preserved", "no arbitrary face splitting", "no Boolean", "parent integration remains partial"]);
}
public static AirRegionCutWallAttachmentSummary AttachCutWall(AirRegionSummary region, AirRegionBRepPlaceholderPlan placeholders, AirRegionFaceSplitSummary entrySplit, AirRegionExitLoopSummary exitLoop)
{
@@ -303,7 +303,7 @@ internal static class AirRegionTraceFactory
return Summary([root], ["air-region-x1-region-trace-created", "air-region-x1-root-region-created", "air-region-x1-world-root-frame-created"], ["AIR Region trace-only summary", "root region does not change BRepPlan semantics"]);
}
- public static AirRegionTraceSummary ForFaceAttachedSideHoleDeferred()
+ public static AirRegionTraceSummary ForFaceAttachedSideHoleDeferred(double radius = 1)
{
var root = RootRegion("region-created");
AirRegionSummary sideBase = new(
@@ -321,7 +321,7 @@ internal static class AirRegionTraceFactory
["air-region-x1-face-attached-region-created", "air-region-x1-region-effect-declared", "air-region-x1-region-yield-declared", "air-region-x1-boundary-contract-declared", "air-region-x1-parent-integration-deferred", "air-region-x2-yield-contract-created", "air-region-x2-side-hole-yield-created", "air-region-x2-face-attachment-recorded", "air-region-x2-local-profile-recorded", "air-region-x2-circle-profile-recorded", "air-region-x2-through-direction-recorded", "air-region-x2-affected-scope-recorded", "air-region-x2-boundary-intent-recorded", "air-region-x2-entry-loop-intent-recorded", "air-region-x2-exit-boundary-deferred", "air-region-x2-region-locality-enforced", "air-region-x2-explicit-yield-only", "air-region-x2-parent-integration-deferred", "air-region-x2-no-implicit-parent-mutation", "air-region-x2-no-boolean", "air-region-x2-no-brep-emission", "air-region-x2-no-step-smoke", "air-region-x2-no-cir-mirror", "air-region-x2-trace-only"],
["side-hole geometry integration not implemented", "concrete through depth deferred", "opposite-side exit boundary deferred"],
["escapes only through explicit yield", "no implicit parent mutation", "no Boolean", "no BRep emission", "no production route replacement", "trace-only"],
- SideHoleYield(root.RegionId));
+ SideHoleYield(root.RegionId, radius));
var mirror = AirSideHoleRegionCirMirrorAdapter.Admit(sideBase);
var boundary = SideHoleBRepBoundary(sideBase);
var decision = AirSideHoleRegionIntegrationSelector.Decide(sideBase, mirror.Summary, boundary);
@@ -332,7 +332,7 @@ internal static class AirRegionTraceFactory
var parentIntegration = AirSideHoleParentBRepIntegrationPrototype.AttemptCutWallAttachment(sideBase, boundary, placeholders, materialization, faceSplit, exitLoop);
var cutWallAttachment = AirSideHoleParentBRepIntegrationPrototype.AttachCutWall(sideBase, placeholders, faceSplit, exitLoop);
var shellClosure = AirSideHoleParentBRepIntegrationPrototype.AttemptShellClosure(sideBase, placeholders, cutWallAttachment);
- var x10Decision = decision with { SelectedRouteKind = AirRegionIntegrationRouteKind.ControlledSideHoleParentBRepIntegration, SelectedStatus = AirRegionIntegrationStatus.Integrated, Recommendation = "controlled parent BRep integration succeeded for the +X/-X/radius=1 fixture; entry loop, exit loop, cylindrical cut wall, and RegionIntegrationPatch are consumed into closed shell evidence", Diagnostics = Stable([.. decision.Diagnostics, .. materialization.Diagnostics, .. parentIntegration.Diagnostics, .. faceSplit.Diagnostics, .. exitLoop.Diagnostics, .. cutWallAttachment.Diagnostics, .. shellClosure.Diagnostics]).ToArray(), KnownLosses = Stable([.. decision.KnownLosses, .. materialization.KnownLosses, .. parentIntegration.KnownLosses]).ToArray(), Guarantees = Stable([.. decision.Guarantees, .. materialization.Guarantees, .. parentIntegration.Guarantees, .. faceSplit.Guarantees, .. exitLoop.Guarantees, .. cutWallAttachment.Guarantees, .. shellClosure.Guarantees]).ToArray() };
+ var x10Decision = decision with { SelectedRouteKind = AirRegionIntegrationRouteKind.ControlledSideHoleParentBRepIntegration, SelectedStatus = AirRegionIntegrationStatus.Integrated, Recommendation = $"controlled parent BRep integration succeeded for the +X/-X/radius={radius:g} fixture; entry loop, exit loop, cylindrical cut wall, and RegionIntegrationPatch are consumed into closed shell evidence", Diagnostics = Stable([.. decision.Diagnostics, .. materialization.Diagnostics, .. parentIntegration.Diagnostics, .. faceSplit.Diagnostics, .. exitLoop.Diagnostics, .. cutWallAttachment.Diagnostics, .. shellClosure.Diagnostics]).ToArray(), KnownLosses = Stable([.. decision.KnownLosses, .. materialization.KnownLosses, .. parentIntegration.KnownLosses]).ToArray(), Guarantees = Stable([.. decision.Guarantees, .. materialization.Guarantees, .. parentIntegration.Guarantees, .. faceSplit.Guarantees, .. exitLoop.Guarantees, .. cutWallAttachment.Guarantees, .. shellClosure.Guarantees]).ToArray() };
var side = sideBase with
{
StageReached = "region-parent-integrated",
@@ -362,10 +362,10 @@ internal static class AirRegionTraceFactory
return Summary([root, bad], ["air-region-x1-region-trace-created", "air-region-x1-implicit-parent-mutation-rejected", "air-region-x1-no-brep-emission", "air-region-x1-no-boolean", "air-region-x2-implicit-parent-mutation-rejected", "air-region-x2-missing-explicit-yield-rejected", "air-region-x2-boundary-contract-required"], ["no Boolean", "no geometry", "no BRep emission"]);
}
- private static AirRegionYieldSummary SideHoleYield(string parentRegionId) => new(
+ private static AirRegionYieldSummary SideHoleYield(string parentRegionId, double radius = 1) => new(
"yield:side-hole:+x:subtractive-volume", AirRegionYieldKind.YieldSubtractiveVolume, "SideHole", AirRegionEffectKind.Subtractive, "frame:side-hole:+x", parentRegionId,
new("Face", parentRegionId, "parser-backed/root box fixture", "+X", "SideFace", "frame:side-hole:+x", ["air-region-x2-face-attachment-recorded"]),
- new("Circle", new(0, 0), 1, "CircularEntryLoop", "frame:side-hole:+x/profile"),
+ new("Circle", new(0, 0), radius, "CircularEntryLoop", "frame:side-hole:+x/profile"),
new("FaceNormal", "LocalZ", "Inward", true, "Through", ["air-region-x2-through-direction-recorded"]),
new("ParentBodyLocalFeature", true, "+X", false, true, ["air-region-x2-affected-scope-recorded", "air-region-x2-explicit-yield-only"]),
new("ThroughCut", "CircularEntryLoop", "Deferred", "CircularRimIntent", "Deferred", ["air-region-x2-boundary-intent-recorded", "air-region-x2-entry-loop-intent-recorded", "air-region-x2-exit-boundary-deferred"]),
diff --git a/Aetheris.Kernel.Firmament.Tests/FirmamentV2ParserTests.cs b/Aetheris.Kernel.Firmament.Tests/FirmamentV2ParserTests.cs
index 44bd6fe5..a37c1297 100644
--- a/Aetheris.Kernel.Firmament.Tests/FirmamentV2ParserTests.cs
+++ b/Aetheris.Kernel.Firmament.Tests/FirmamentV2ParserTests.cs
@@ -239,6 +239,37 @@ public sealed class FirmamentV2ParserTests
Assert.Equal("Succeeded", result.FirmamentV2.StepSmoke);
}
+
+ [Fact]
+ public void FirmamentV2SideHoleRadius_ParsesRadiusVariations()
+ {
+ Assert.Equal(0.5, FirmamentV2Parser.Parse(Source("Region/valid/side-hole-radius-0_5-v2.valid.firmfixture")).Document!.SideHoleIntent!.Radius);
+ Assert.Equal(1.5, FirmamentV2Parser.Parse(Source("Region/valid/side-hole-radius-1_5-v2.valid.firmfixture")).Document!.SideHoleIntent!.Radius);
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleRadius_ValidVariationsReachGoldenPath()
+ {
+ foreach (var fixture in new[] { "Region/valid/side-hole-radius-0_5-v2.valid.firmfixture", "Region/valid/side-hole-radius-1_5-v2.valid.firmfixture" })
+ {
+ var result = FirmamentFrontendTraceProbe.ParseV2Only(Source(fixture));
+ Assert.True(result.ParseSucceeded, string.Join(", ", result.Diagnostics));
+ Assert.Equal("region-parent-integrated", result.FirmamentV2!.StageReached);
+ Assert.Equal("Integrated", result.FirmamentV2.ParentIntegration);
+ Assert.Equal("Closed", result.FirmamentV2.ShellClosure);
+ Assert.Equal("Succeeded", result.FirmamentV2.StepSmoke);
+ Assert.Null(result.FirmamentV2.Blocker);
+ }
+ }
+
+ [Fact]
+ public void FirmamentV2SideHoleRadius_InvalidRadiusDiagnostics()
+ {
+ Assert.Contains(FirmamentV2Parser.CylinderRadiusInvalid, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-radius-zero-v2.invalid.firmfixture")).Diagnostics);
+ Assert.Contains(FirmamentV2Parser.CylinderRadiusInvalid, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-radius-negative-v2.invalid.firmfixture")).Diagnostics);
+ Assert.Contains(FirmamentV2Parser.SideHoleRadiusExceedsClearance, FirmamentV2Parser.Parse(Source("Region/invalid/side-hole-radius-too-large-v2.invalid.firmfixture")).Diagnostics);
+ }
+
[Fact]
public void FirmamentV2Parser_SideHole_InvalidAttachFaceDiagnostic()
{
diff --git a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs
index 2049f334..338fd3c1 100644
--- a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs
+++ b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs
@@ -42,6 +42,7 @@ public static class FirmamentV2Parser
public const string ThroughSelectorUnsupported = "firmament-v2-through-selector-unsupported";
public const string SideHoleOnlyPlusXMinusXSupported = "firmament-v2-side-hole-only-plus-x-minus-x-supported";
public const string SideHoleRadiusExceedsClearance = "firmament-v2-side-hole-radius-exceeds-clearance";
+ public const string CylinderRadiusNotFinite = "firmament-v2-side-hole-radius-not-finite";
private static readonly Regex ModelRegex = new(@"\bmodel\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);
private static readonly Regex UnitsRegex = new(@"\bunits\s+(?<units>[A-Za-z_][A-Za-z0-9_]*)\b", RegexOptions.CultureInvariant);
@@ -55,7 +56,7 @@ public static class FirmamentV2Parser
private static readonly Regex ModifyHeaderRegex = new(@"\bmodify\s+(?<target>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);
private static readonly Regex RegionHeaderRegex = new(@"\bregion\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s+on\s+(?<selector>face\([^)]*\))\s*\{", RegexOptions.CultureInvariant);
private static readonly Regex CutHeaderRegex = new(@"\bcut\s+(?<tool>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);
- private static readonly Regex RadiusRegex = new(@"\bradius\s*:\s*(?<value>[-+]?[0-9]+(?:\.[0-9]+)?)", RegexOptions.CultureInvariant);
+ private static readonly Regex RadiusRegex = new(@"\bradius\s*:\s*(?<value>[^\s}]+)", RegexOptions.CultureInvariant);
private static readonly Regex ThroughRegex = new(@"\bthrough\s*:\s*(?<selector>face\([^)]*\))", RegexOptions.CultureInvariant);
public static FirmamentV2ParseResult Parse(string sourceText)
@@ -134,7 +135,7 @@ public static class FirmamentV2Parser
return new(name, "Box", new(values, []), baseName, new Dictionary<string, IReadOnlyList<double>>(StringComparer.Ordinal) { ["size"] = values });
}
- private static bool IsFatalDiagnostic(string code) => code is MissingModel or MissingUnits or MissingSolid or UnsupportedConstruct or UnknownRecordType or BoxMissingSize or BoxSizeArity or DegenerateDimension or NameUnresolved or DuplicateName or WithRequiresRecord or WithRequiresBoxRecord or WithFieldNotFound or WithFieldTypeMismatch or WithForwardReference or WithDerivedRecordInvalid or ExposeBlockUnsupported or ExposeRequiresBoxRecord or ExposeAliasDuplicate or ExposeAliasInvalid or SelectorUnsupported or SelectorAxisInvalid or SelectorSubselectorUnsupported or FatArrowOutsideExpose or RawBackendIdReferenceForbidden or ModifyTargetUnresolved or ModifyTargetNotSolid or RegionUnsupported or RegionAttachmentSelectorUnsupported or CutUnsupported or CutToolUnsupported or CylinderRadiusMissing or CylinderRadiusInvalid or ThroughSelectorUnsupported or SideHoleOnlyPlusXMinusXSupported or SideHoleRadiusExceedsClearance;
+ private static bool IsFatalDiagnostic(string code) => code is MissingModel or MissingUnits or MissingSolid or UnsupportedConstruct or UnknownRecordType or BoxMissingSize or BoxSizeArity or DegenerateDimension or NameUnresolved or DuplicateName or WithRequiresRecord or WithRequiresBoxRecord or WithFieldNotFound or WithFieldTypeMismatch or WithForwardReference or WithDerivedRecordInvalid or ExposeBlockUnsupported or ExposeRequiresBoxRecord or ExposeAliasDuplicate or ExposeAliasInvalid or SelectorUnsupported or SelectorAxisInvalid or SelectorSubselectorUnsupported or FatArrowOutsideExpose or RawBackendIdReferenceForbidden or ModifyTargetUnresolved or ModifyTargetNotSolid or RegionUnsupported or RegionAttachmentSelectorUnsupported or CutUnsupported or CutToolUnsupported or CylinderRadiusMissing or CylinderRadiusInvalid or CylinderRadiusNotFinite or ThroughSelectorUnsupported or SideHoleOnlyPlusXMinusXSupported or SideHoleRadiusExceedsClearance;
private static IReadOnlyList<FirmamentV2Exposure> ParseExposures(string body, List<string> diagnostics)
{
@@ -242,7 +243,9 @@ public static class FirmamentV2Parser
var toolBody = body[(open + 1)..close];
var radiusMatch = RadiusRegex.Match(toolBody);
if (!radiusMatch.Success) { diagnostics.Add(CylinderRadiusMissing); return null; }
- if (!double.TryParse(radiusMatch.Groups["value"].Value, NumberStyles.Float, CultureInfo.InvariantCulture, out var radius) || radius <= 0) { diagnostics.Add(CylinderRadiusInvalid); return null; }
+ if (!double.TryParse(radiusMatch.Groups["value"].Value, NumberStyles.Float, CultureInfo.InvariantCulture, out var radius)) { diagnostics.Add(CylinderRadiusInvalid); return null; }
+ if (!double.IsFinite(radius)) { diagnostics.Add(CylinderRadiusNotFinite); return null; }
+ if (radius <= 0) { diagnostics.Add(CylinderRadiusInvalid); return null; }
var throughMatch = ThroughRegex.Match(toolBody);
var through = throughMatch.Success ? ParseFaceSelector(throughMatch.Groups["selector"].Value, ThroughSelectorUnsupported, diagnostics) : null;
if (through is null) { diagnostics.Add(ThroughSelectorUnsupported); return null; }
diff --git a/docs/air-firmament-a1-firmament-fixture-corpus.md b/docs/air-firmament-a1-firmament-fixture-corpus.md
index ee4459a4..6a632f3d 100644
--- a/docs/air-firmament-a1-firmament-fixture-corpus.md
+++ b/docs/air-firmament-a1-firmament-fixture-corpus.md
@@ -186,3 +186,7 @@ A2.2 expands the `fixtures/FirmamentV2/` metadata-only taxonomy with `RecordDeri
## AIR-FIRMAMENT-X5 V2 side-hole artifact status
`fixtures/FirmamentV2/Region/valid/side-hole-v2.valid.firmfixture` now has a generated-on-demand artifact workflow. Running `aetheris trace --fixture fixtures/FirmamentV2/Region/valid/side-hole-v2.valid.firmfixture --out-dir artifacts/air-firmament-x5/side-hole-v2` writes `side-hole-v2.step`, `side-hole-v2.trace.json`, `side-hole-v2.trace.txt`, and `manifest.json`. This records parser-backed V2 parity with the controlled AIR-REGION-X13 side-hole path without broad corpus migration or general side-hole support.
+
+## AIR-FIRMAMENT-X6 V2 side-hole radius variation status
+
+The Firmament V2 region corpus now includes controlled valid side-hole radius variation fixtures for radius `0.5` and `1.5`, plus invalid radius fixtures for zero, negative, and clearance-exceeding radii. These fixtures remain parser-backed and bounded to the same `base` Box, `face(+X)` to `face(-X)`, single `cut Cylinder` side-hole path; they do not migrate the broad corpus or add general side-hole support.
diff --git a/docs/air-firmament-x5-v2-side-hole-artifacts-parity.md b/docs/air-firmament-x5-v2-side-hole-artifacts-parity.md
index 3fdbbe63..fb14d070 100644
--- a/docs/air-firmament-x5-v2-side-hole-artifacts-parity.md
+++ b/docs/air-firmament-x5-v2-side-hole-artifacts-parity.md
@@ -107,3 +107,7 @@ dotnet test Aetheris.CLI.Tests/Aetheris.CLI.Tests.csproj --filter "FirmamentV2Si
## Next milestone recommendation
Recommended next milestone: add a thin explicit V2 side-hole-to-AIR-region adapter object so future parser-backed region milestones avoid trace-probe coupling. Do not generalize arbitrary faces, axes, Boolean admission, or generic region topology until that adapter has its own narrow tests.
+
+## AIR-FIRMAMENT-X6 radius variation follow-up
+
+AIR-FIRMAMENT-X6 keeps the X5 canonical `side-hole-v2` artifact workflow green and extends the same generated-on-demand behavior to controlled non-1 V2 side-hole radius fixtures. Radius-specific fixtures use radius-specific file stems in their own output directories and record the actual radius in trace JSON/text and `manifest.json`; this is still not general side-hole support.
diff --git a/docs/air-firmament-x6-v2-side-hole-radius-variation.md b/docs/air-firmament-x6-v2-side-hole-radius-variation.md
new file mode 100644
index 00000000..2bc24cee
--- /dev/null
+++ b/docs/air-firmament-x6-v2-side-hole-radius-variation.md
@@ -0,0 +1,87 @@
+# AIR-FIRMAMENT-X6 — V2 side-hole radius variation
+
+## Purpose and scope
+
+AIR-FIRMAMENT-X6 proves that the parser-backed Firmament V2 controlled side-hole path is parameterized by cylinder radius. The scope remains deliberately narrow: one `Box` solid named `base`, one `modify base` block, one `region sideHole on face(+X)` block, one `cut Cylinder`, positive numeric radius, and `through: face(-X)`.
+
+## Relationship to X4 and X5
+
+X4 introduced the parser-backed Firmament V2 side-hole source and lowered it into the existing AIR Region golden trace chain. X5 locked the generated-on-demand artifact workflow for the canonical radius-1 V2 fixture. X6 keeps those paths green and adds radius-only variation evidence.
+
+## Controlled radius-only variation
+
+The only varied field is `radius`. X6 does not add center offset, arbitrary face pairs, arbitrary cylinder direction, blind holes, multiple regions, multiple cuts, expressions, templates, concepts, PMI, `where`, material/FEA, shell, fillet, chamfer, surfacing, or pattern support.
+
+## Supported source syntax
+
+```firmament
+model SideHoleRadius05V2 {
+ units mm
+
+ solid base: Box {
+ size: [10, 8, 6]
+ }
+
+ modify base {
+ region sideHole on face(+X) {
+ cut Cylinder {
+ radius: 0.5
+ through: face(-X)
+ }
+ }
+ }
+}
+```
+
+## Valid radius fixtures
+
+- `fixtures/FirmamentV2/Region/valid/side-hole-v2.valid.firmfixture` keeps canonical radius `1`.
+- `fixtures/FirmamentV2/Region/valid/side-hole-radius-0_5-v2.valid.firmfixture` covers radius `0.5`.
+- `fixtures/FirmamentV2/Region/valid/side-hole-radius-1_5-v2.valid.firmfixture` covers radius `1.5`.
+
+Each valid fixture reaches `region-parent-integrated`, `Integrated`, `Closed`, `Succeeded`, with no blocker.
+
+## Invalid radius fixtures
+
+- `fixtures/FirmamentV2/Region/invalid/side-hole-radius-zero-v2.invalid.firmfixture` reports `firmament-v2-cylinder-radius-invalid`.
+- `fixtures/FirmamentV2/Region/invalid/side-hole-radius-negative-v2.invalid.firmfixture` reports `firmament-v2-cylinder-radius-invalid`.
+- `fixtures/FirmamentV2/Region/invalid/side-hole-radius-too-large-v2.invalid.firmfixture` reports `firmament-v2-side-hole-radius-exceeds-clearance`.
+
+## Radius admissibility / clearance rule
+
+The radius must exist, parse as a numeric finite value, and be greater than zero. For the controlled `[10, 8, 6]` box, the side-hole axis is +X to -X, so the transverse dimensions are Y=8 and Z=6. X6 uses a conservative clearance rule: radius must be strictly less than half of the smaller transverse dimension. For this box, radius must be `< 3`; exact tangency at `3` is rejected rather than treated as a fragile boundary case.
+
+## Trace JSON/text radius evidence
+
+Trace JSON preserves the semantic intent radius and the modify-region tool radius. The AIR Region trace receives the same radius so profile, entry-loop, and exit-loop evidence no longer collapse to radius `1` for non-1 fixtures. Trace text prints `Tool: Cylinder`, `Radius: 0.5` or `1.5`, `Through: face(-X)`, `Stage: region-parent-integrated`, `Parent integration: Integrated`, `Shell closure: Closed`, and `STEP smoke: Succeeded`.
+
+## Artifact behavior for radius-specific fixtures
+
+The generated-on-demand artifact workflow remains active. Canonical radius `1` keeps the `side-hole-v2.*` filenames. Non-1 radius fixtures derive radius-specific stems such as `side-hole-radius-0_5-v2.step`, `side-hole-radius-0_5-v2.trace.json`, and `side-hole-radius-0_5-v2.trace.txt`, plus `manifest.json`. The manifest records the actual radius, tool, and through selector. Separate output directories avoid overwrites.
+
+## What this proves
+
+- V2 side-hole lowering is parameterized by radius.
+- Radius `0.5`, `1`, and `1.5` preserve golden-path structural facts.
+- Non-1 radius artifacts can be emitted without faking radius `1`.
+
+## What this does not prove
+
+- no center offset;
+- no arbitrary face pair;
+- no arbitrary side-hole support;
+- no blind holes;
+- no generic Boolean admission;
+- no CIR topology authority.
+
+## Tests run
+
+- `dotnet build Aetheris.slnx -f net10.0 --no-restore`
+- `./scripts/test-active.sh`
+- focused CLI and kernel filtered tests for Firmament V2 side-hole radius behavior
+- CLI trace commands for canonical, radius `0.5`, radius `1.5`, and invalid radius fixtures
+- artifact emission for radius `0.5`
+
+## Next milestone recommendation
+
+AIR-FIRMAMENT-X7 — controlled V2 side-hole center offset.
diff --git a/fixtures/FirmamentV2/Region/invalid/side-hole-radius-negative-v2.invalid.firmfixture b/fixtures/FirmamentV2/Region/invalid/side-hole-radius-negative-v2.invalid.firmfixture
new file mode 100644
index 00000000..55d6c3d1
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/invalid/side-hole-radius-negative-v2.invalid.firmfixture
@@ -0,0 +1,11 @@
+// fixture-id: side-hole-radius-negative-v2
+// case: firmament-v2-side-hole-radius-negative
+// category: Region
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: parser-backed
+// expected: invalid
+// expected-stage: parsed
+// expected-diagnostic: firmament-v2-cylinder-radius-invalid
+
+model SideHoleRadiusNegativeV2 { units mm solid base: Box { size: [10, 8, 6] } modify base { region sideHole on face(+X) { cut Cylinder { radius: -1 through: face(-X) } } } }
diff --git a/fixtures/FirmamentV2/Region/invalid/side-hole-radius-too-large-v2.invalid.firmfixture b/fixtures/FirmamentV2/Region/invalid/side-hole-radius-too-large-v2.invalid.firmfixture
new file mode 100644
index 00000000..e949662e
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/invalid/side-hole-radius-too-large-v2.invalid.firmfixture
@@ -0,0 +1,11 @@
+// fixture-id: side-hole-radius-too-large-v2
+// case: firmament-v2-side-hole-radius-too-large
+// category: Region
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: parser-backed
+// expected: invalid
+// expected-stage: parsed
+// expected-diagnostic: firmament-v2-side-hole-radius-exceeds-clearance
+
+model SideHoleRadiusTooLargeV2 { units mm solid base: Box { size: [10, 8, 6] } modify base { region sideHole on face(+X) { cut Cylinder { radius: 3 through: face(-X) } } } }
diff --git a/fixtures/FirmamentV2/Region/invalid/side-hole-radius-zero-v2.invalid.firmfixture b/fixtures/FirmamentV2/Region/invalid/side-hole-radius-zero-v2.invalid.firmfixture
new file mode 100644
index 00000000..350eb4ba
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/invalid/side-hole-radius-zero-v2.invalid.firmfixture
@@ -0,0 +1,11 @@
+// fixture-id: side-hole-radius-zero-v2
+// case: firmament-v2-side-hole-radius-zero
+// category: Region
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: parser-backed
+// expected: invalid
+// expected-stage: parsed
+// expected-diagnostic: firmament-v2-cylinder-radius-invalid
+
+model SideHoleRadiusZeroV2 { units mm solid base: Box { size: [10, 8, 6] } modify base { region sideHole on face(+X) { cut Cylinder { radius: 0 through: face(-X) } } } }
diff --git a/fixtures/FirmamentV2/Region/valid/side-hole-radius-0_5-v2.valid.firmfixture b/fixtures/FirmamentV2/Region/valid/side-hole-radius-0_5-v2.valid.firmfixture
new file mode 100644
index 00000000..1b177c18
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/valid/side-hole-radius-0_5-v2.valid.firmfixture
@@ -0,0 +1,36 @@
+// fixture-id: side-hole-radius-0_5-v2
+// case: firmament-v2-side-hole-radius-0_5
+// category: Region
+// syntax-version: FirmamentV2
+// validity: valid
+// implementation: parser-backed
+// expected: valid
+// expected-stage: region-parent-integrated
+// expected-parent-integration: Integrated
+// expected-shell-closure: Closed
+// expected-step-smoke: Succeeded
+// expected-feature: sideHole
+// expected-region-kind: FaceAttachedRegion
+// expected-entry-face: +X
+// expected-exit-face: -X
+// expected-tool: Cylinder
+// expected-radius: 0.5
+// parser-backed: true
+// notes: AIR-FIRMAMENT-X6 controlled V2 side-hole radius variation fixture.
+
+model SideHoleRadius05V2 {
+ units mm
+
+ solid base: Box {
+ size: [10, 8, 6]
+ }
+
+ modify base {
+ region sideHole on face(+X) {
+ cut Cylinder {
+ radius: 0.5
+ through: face(-X)
+ }
+ }
+ }
+}
diff --git a/fixtures/FirmamentV2/Region/valid/side-hole-radius-1_5-v2.valid.firmfixture b/fixtures/FirmamentV2/Region/valid/side-hole-radius-1_5-v2.valid.firmfixture
new file mode 100644
index 00000000..33e4b19b
--- /dev/null
+++ b/fixtures/FirmamentV2/Region/valid/side-hole-radius-1_5-v2.valid.firmfixture
@@ -0,0 +1,36 @@
+// fixture-id: side-hole-radius-1_5-v2
+// case: firmament-v2-side-hole-radius-1_5
+// category: Region
+// syntax-version: FirmamentV2
+// validity: valid
+// implementation: parser-backed
+// expected: valid
+// expected-stage: region-parent-integrated
+// expected-parent-integration: Integrated
+// expected-shell-closure: Closed
+// expected-step-smoke: Succeeded
+// expected-feature: sideHole
+// expected-region-kind: FaceAttachedRegion
+// expected-entry-face: +X
+// expected-exit-face: -X
+// expected-tool: Cylinder
+// expected-radius: 1.5
+// parser-backed: true
+// notes: AIR-FIRMAMENT-X6 controlled V2 side-hole radius variation fixture.
+
+model SideHoleRadius15V2 {
+ units mm
+
+ solid base: Box {
+ size: [10, 8, 6]
+ }
+
+ modify base {
+ region sideHole on face(+X) {
+ cut Cylinder {
+ radius: 1.5
+ through: face(-X)
+ }
+ }
+ }
+}