Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Implement Firmament M2c bare validation target feature existence checks

Yuechen Lic2e2231c0866
diff --git a/Aetheris.Kernel.Firmament.Tests/FirmamentDocumentCoherenceValidationTests.cs b/Aetheris.Kernel.Firmament.Tests/FirmamentDocumentCoherenceValidationTests.cs
index d1dc4b31..14bb0372 100644
--- a/Aetheris.Kernel.Firmament.Tests/FirmamentDocumentCoherenceValidationTests.cs
+++ b/Aetheris.Kernel.Firmament.Tests/FirmamentDocumentCoherenceValidationTests.cs
@@ -54,7 +54,7 @@ public sealed class FirmamentDocumentCoherenceValidationTests
}
[Fact]
- public void Compiler_Leaves_ValidationTargets_Unresolved()
+ public void Compiler_Leaves_SelectorShapedValidationTargets_Unresolved()
{
const string source = """
firmament:
@@ -77,7 +77,7 @@ public sealed class FirmamentDocumentCoherenceValidationTests
target: future_feature.top_face
-
op: expect_selectable
- target: ghost_feature
+ target: ghost_feature.side_a
count: 1
""";
diff --git a/Aetheris.Kernel.Firmament.Tests/FirmamentScaffoldTests.cs b/Aetheris.Kernel.Firmament.Tests/FirmamentScaffoldTests.cs
index 8415ecb1..abedd242 100644
--- a/Aetheris.Kernel.Firmament.Tests/FirmamentScaffoldTests.cs
+++ b/Aetheris.Kernel.Firmament.Tests/FirmamentScaffoldTests.cs
@@ -37,7 +37,7 @@ public sealed class FirmamentScaffoldTests
Assert.True(result.Compilation.IsSuccess);
var artifact = result.Compilation.Value;
- Assert.Equal("firmament-validation-target-shape-classified", artifact.ArtifactKind);
+ Assert.Equal("firmament-validation-target-featureid-existence-checked", artifact.ArtifactKind);
Assert.NotNull(artifact.ParsedDocument);
Assert.Equal("1", artifact.ParsedDocument!.Firmament.Version);
Assert.Equal("demo", artifact.ParsedDocument.Model.Name);
@@ -222,7 +222,7 @@ public sealed class FirmamentScaffoldTests
ops[1]:
-
op: expect_exists
- target: base
+ target: base.top_face
""",
1);
@@ -843,12 +843,12 @@ public sealed class FirmamentScaffoldTests
"expect_exists" => """
-
op: expect_exists
- target: b1
+ target: b1.top_face
""",
"expect_selectable" => """
-
op: expect_selectable
- target: b1
+ target: b1.top_face
count: 1
""",
"expect_manifold" => """
diff --git a/Aetheris.Kernel.Firmament.Tests/FirmamentValidationRequiredFieldValidationTests.cs b/Aetheris.Kernel.Firmament.Tests/FirmamentValidationRequiredFieldValidationTests.cs
index 19d219ac..7836f003 100644
--- a/Aetheris.Kernel.Firmament.Tests/FirmamentValidationRequiredFieldValidationTests.cs
+++ b/Aetheris.Kernel.Firmament.Tests/FirmamentValidationRequiredFieldValidationTests.cs
@@ -35,7 +35,7 @@ public sealed class FirmamentValidationRequiredFieldValidationTests
ops[1]:
-
op: expect_selectable
- target: hole
+ target: hole.entry_face
count: 4
""");
diff --git a/Aetheris.Kernel.Firmament.Tests/FirmamentValidationTargetFeatureExistenceTests.cs b/Aetheris.Kernel.Firmament.Tests/FirmamentValidationTargetFeatureExistenceTests.cs
new file mode 100644
index 00000000..442b3851
--- /dev/null
+++ b/Aetheris.Kernel.Firmament.Tests/FirmamentValidationTargetFeatureExistenceTests.cs
@@ -0,0 +1,56 @@
+using Aetheris.Kernel.Firmament.Diagnostics;
+
+namespace Aetheris.Kernel.Firmament.Tests;
+
+public sealed class FirmamentValidationTargetFeatureExistenceTests
+{
+ [Theory]
+ [InlineData("testdata/firmament/fixtures/m2c-valid-expect-exists-bare-target-earlier.firmament")]
+ [InlineData("testdata/firmament/fixtures/m2c-valid-expect-selectable-bare-target-earlier.firmament")]
+ [InlineData("testdata/firmament/fixtures/m2c-valid-mixed-bare-and-selector-targets.firmament")]
+ public void Compiler_Accepts_BareValidationTargets_WhenFeatureDefinedEarlier(string fixturePath)
+ {
+ var result = CompileFixture(fixturePath);
+
+ Assert.True(result.Compilation.IsSuccess);
+ }
+
+ [Theory]
+ [InlineData("testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-nonexistent.firmament", "expect_exists", "missing")]
+ [InlineData("testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-nonexistent.firmament", "expect_selectable", "missing")]
+ [InlineData("testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-forward.firmament", "expect_exists", "later")]
+ [InlineData("testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-forward.firmament", "expect_selectable", "later")]
+ public void Compiler_Rejects_BareValidationTargets_WhenFeatureMissingOrForward(string fixturePath, string opName, string targetId)
+ {
+ var first = CompileFixture(fixturePath);
+ var second = CompileFixture(fixturePath);
+
+ Assert.False(first.Compilation.IsSuccess);
+ Assert.False(second.Compilation.IsSuccess);
+
+ var firstDiagnostic = Assert.Single(first.Compilation.Diagnostics);
+ var secondDiagnostic = Assert.Single(second.Compilation.Diagnostics);
+
+ Assert.Equal(firstDiagnostic.Message, secondDiagnostic.Message);
+ Assert.Equal(
+ $"[{FirmamentDiagnosticCodes.ValidationTargetUnknownFeatureId.Value}] Validation op '{opName}' at index 0 references unknown feature id '{targetId}' via field 'target'.",
+ firstDiagnostic.Message);
+ }
+
+ [Theory]
+ [InlineData("testdata/firmament/fixtures/m2c-valid-expect-exists-selector-target-unresolved.firmament")]
+ [InlineData("testdata/firmament/fixtures/m2c-valid-expect-selectable-selector-target-unresolved.firmament")]
+ public void Compiler_Leaves_SelectorShapedValidationTargets_Unchecked(string fixturePath)
+ {
+ var result = CompileFixture(fixturePath);
+
+ Assert.True(result.Compilation.IsSuccess);
+ }
+
+ private static FirmamentCompileResult CompileFixture(string fixturePath)
+ {
+ var fixtureText = FirmamentCorpusHarness.ReadFixtureText(fixturePath);
+ var compiler = new FirmamentCompiler();
+ return compiler.Compile(new FirmamentCompileRequest(new FirmamentSourceDocument(fixtureText)));
+ }
+}
diff --git a/Aetheris.Kernel.Firmament.Tests/FirmamentValidationTargetShapeClassificationTests.cs b/Aetheris.Kernel.Firmament.Tests/FirmamentValidationTargetShapeClassificationTests.cs
index afce9611..ef1c6083 100644
--- a/Aetheris.Kernel.Firmament.Tests/FirmamentValidationTargetShapeClassificationTests.cs
+++ b/Aetheris.Kernel.Firmament.Tests/FirmamentValidationTargetShapeClassificationTests.cs
@@ -7,29 +7,51 @@ public sealed class FirmamentValidationTargetShapeClassificationTests
[Theory]
[InlineData("expect_exists", "base", "FeatureId")]
[InlineData("expect_exists", "base.top_face", "SelectorShaped")]
- [InlineData("expect_selectable", "mount_hole", "FeatureId")]
+ [InlineData("expect_selectable", "base", "FeatureId")]
[InlineData("expect_selectable", "mount_hole.entry_face", "SelectorShaped")]
public void Compiler_Classifies_ValidationTargets_BySurfaceShape(string opName, string target, string expectedShape)
{
- var source = $$"""
- firmament:
- version: 1
-
- model:
- name: demo
- units: mm
-
- ops[1]:
- -
- op: {{opName}}
- target: {{target}}
- {{(opName == "expect_selectable" ? "count: 1" : string.Empty)}}
- """;
+ var source = string.Equals(expectedShape, "FeatureId", StringComparison.Ordinal)
+ ? $$"""
+ firmament:
+ version: 1
+
+ model:
+ name: demo
+ units: mm
+
+ ops[2]:
+ -
+ op: box
+ id: base
+ size[3]:
+ 1
+ 1
+ 1
+ -
+ op: {{opName}}
+ target: {{target}}
+ {{(opName == "expect_selectable" ? "count: 1" : string.Empty)}}
+ """
+ : $$"""
+ firmament:
+ version: 1
+
+ model:
+ name: demo
+ units: mm
+
+ ops[1]:
+ -
+ op: {{opName}}
+ target: {{target}}
+ {{(opName == "expect_selectable" ? "count: 1" : string.Empty)}}
+ """;
var result = Compile(source);
Assert.True(result.Compilation.IsSuccess);
- var op = Assert.Single(result.Compilation.Value.ParsedDocument!.Ops.Entries);
+ var op = result.Compilation.Value.ParsedDocument!.Ops.Entries[^1];
Assert.NotNull(op.ClassifiedFields);
Assert.Equal(expectedShape, op.ClassifiedFields!["targetShape"]);
}
@@ -87,7 +109,7 @@ public sealed class FirmamentValidationTargetShapeClassificationTests
target: future_feature.top_face
-
op: expect_selectable
- target: ghost_feature
+ target: ghost_feature.edge_a
count: 1
""";
diff --git a/Aetheris.Kernel.Firmament/Diagnostics/FirmamentDiagnosticCodes.cs b/Aetheris.Kernel.Firmament/Diagnostics/FirmamentDiagnosticCodes.cs
index 7f4af366..0f5afe1f 100644
--- a/Aetheris.Kernel.Firmament/Diagnostics/FirmamentDiagnosticCodes.cs
+++ b/Aetheris.Kernel.Firmament/Diagnostics/FirmamentDiagnosticCodes.cs
@@ -25,6 +25,7 @@ public static class FirmamentDiagnosticCodes
public static readonly FirmamentDiagnosticCode ReferenceDuplicateFeatureId = new($"{FirmamentDiagnosticConventions.ReferencePrefix}-0001");
public static readonly FirmamentDiagnosticCode ReferenceUnknownFeatureId = new($"{FirmamentDiagnosticConventions.ReferencePrefix}-0002");
+ public static readonly FirmamentDiagnosticCode ValidationTargetUnknownFeatureId = new($"{FirmamentDiagnosticConventions.ReferencePrefix}-0003");
public static readonly FirmamentDiagnosticCode SelectorPlaceholder = new($"{FirmamentDiagnosticConventions.SelectorPrefix}-0001");
public static readonly FirmamentDiagnosticCode SchemaPlaceholder = new($"{FirmamentDiagnosticConventions.SchemaPrefix}-0001");
public static readonly FirmamentDiagnosticCode LoweringPlaceholder = new($"{FirmamentDiagnosticConventions.LoweringPrefix}-0001");
diff --git a/Aetheris.Kernel.Firmament/FirmamentCompilationArtifact.cs b/Aetheris.Kernel.Firmament/FirmamentCompilationArtifact.cs
index c845a930..63011ea5 100644
--- a/Aetheris.Kernel.Firmament/FirmamentCompilationArtifact.cs
+++ b/Aetheris.Kernel.Firmament/FirmamentCompilationArtifact.cs
@@ -3,5 +3,5 @@ using Aetheris.Kernel.Firmament.ParsedModel;
namespace Aetheris.Kernel.Firmament;
public sealed record FirmamentCompilationArtifact(
- string ArtifactKind = "firmament-validation-target-shape-classified",
+ string ArtifactKind = "firmament-validation-target-featureid-existence-checked",
FirmamentParsedDocument? ParsedDocument = null);
diff --git a/Aetheris.Kernel.Firmament/FirmamentCompiler.cs b/Aetheris.Kernel.Firmament/FirmamentCompiler.cs
index c3bd7e5c..73acbc63 100644
--- a/Aetheris.Kernel.Firmament/FirmamentCompiler.cs
+++ b/Aetheris.Kernel.Firmament/FirmamentCompiler.cs
@@ -38,24 +38,24 @@ public sealed class FirmamentCompiler
KernelResult<FirmamentCompilationArtifact>.Failure(validationValidationResult.Diagnostics));
}
- var documentCoherenceValidationResult = FirmamentDocumentCoherenceValidator.Validate(parseResult.Value);
- if (!documentCoherenceValidationResult.IsSuccess)
+ var targetShapeValidationResult = FirmamentValidationTargetShapeValidator.Validate(parseResult.Value);
+ if (!targetShapeValidationResult.IsSuccess)
{
return new FirmamentCompileResult(
- KernelResult<FirmamentCompilationArtifact>.Failure(documentCoherenceValidationResult.Diagnostics));
+ KernelResult<FirmamentCompilationArtifact>.Failure(targetShapeValidationResult.Diagnostics));
}
- var targetShapeValidationResult = FirmamentValidationTargetShapeValidator.Validate(parseResult.Value);
- if (!targetShapeValidationResult.IsSuccess)
+ var documentCoherenceValidationResult = FirmamentDocumentCoherenceValidator.Validate(targetShapeValidationResult.Value);
+ if (!documentCoherenceValidationResult.IsSuccess)
{
return new FirmamentCompileResult(
- KernelResult<FirmamentCompilationArtifact>.Failure(targetShapeValidationResult.Diagnostics));
+ KernelResult<FirmamentCompilationArtifact>.Failure(documentCoherenceValidationResult.Diagnostics));
}
return new FirmamentCompileResult(
KernelResult<FirmamentCompilationArtifact>.Success(
new FirmamentCompilationArtifact(
- ArtifactKind: "firmament-validation-target-shape-classified",
+ ArtifactKind: "firmament-validation-target-featureid-existence-checked",
ParsedDocument: targetShapeValidationResult.Value)));
}
}
diff --git a/Aetheris.Kernel.Firmament/Validation/FirmamentDocumentCoherenceValidator.cs b/Aetheris.Kernel.Firmament/Validation/FirmamentDocumentCoherenceValidator.cs
index 60b4dc9e..05115eb2 100644
--- a/Aetheris.Kernel.Firmament/Validation/FirmamentDocumentCoherenceValidator.cs
+++ b/Aetheris.Kernel.Firmament/Validation/FirmamentDocumentCoherenceValidator.cs
@@ -19,6 +19,21 @@ internal static class FirmamentDocumentCoherenceValidator
if (entry.Family == FirmamentOpFamily.Validation)
{
+ var targetShape = entry.ClassifiedFields is not null && entry.ClassifiedFields.TryGetValue("targetShape", out var shape)
+ ? shape
+ : null;
+
+ if (string.Equals(targetShape, FirmamentValidationTargetShape.FeatureId.ToString(), StringComparison.Ordinal)
+ && entry.RawFields.TryGetValue("target", out var targetId)
+ && !featureIds.Contains(targetId))
+ {
+ return KernelResult<bool>.Failure([
+ CreateDiagnostic(
+ FirmamentDiagnosticCodes.ValidationTargetUnknownFeatureId,
+ $"Validation op '{entry.OpName}' at index {index} references unknown feature id '{targetId}' via field 'target'.")
+ ]);
+ }
+
continue;
}
diff --git a/testdata/firmament/fixtures/m1c-valid-expect-selectable.firmament b/testdata/firmament/fixtures/m1c-valid-expect-selectable.firmament
index 3494f0f9..9d20b4bb 100644
--- a/testdata/firmament/fixtures/m1c-valid-expect-selectable.firmament
+++ b/testdata/firmament/fixtures/m1c-valid-expect-selectable.firmament
@@ -8,5 +8,5 @@ model:
ops[1]:
-
op: expect_selectable
- target: hole
+ target: hole.entry_face
count: 4
diff --git a/testdata/firmament/fixtures/m2b-valid-expect-exists-bare-target.firmament b/testdata/firmament/fixtures/m2b-valid-expect-exists-bare-target.firmament
index 1adb3be4..c5f56f84 100644
--- a/testdata/firmament/fixtures/m2b-valid-expect-exists-bare-target.firmament
+++ b/testdata/firmament/fixtures/m2b-valid-expect-exists-bare-target.firmament
@@ -5,7 +5,14 @@ model:
name: demo
units: mm
-ops[1]:
+ops[2]:
+ -
+ op: box
+ id: base
+ size[3]:
+ 1
+ 2
+ 3
-
op: expect_exists
target: base
diff --git a/testdata/firmament/fixtures/m2b-valid-expect-selectable-bare-target.firmament b/testdata/firmament/fixtures/m2b-valid-expect-selectable-bare-target.firmament
index 0718cf90..7a5bb2f9 100644
--- a/testdata/firmament/fixtures/m2b-valid-expect-selectable-bare-target.firmament
+++ b/testdata/firmament/fixtures/m2b-valid-expect-selectable-bare-target.firmament
@@ -5,8 +5,12 @@ model:
name: demo
units: mm
-ops[1]:
+ops[2]:
+ -
+ op: sphere
+ id: mount_hole
+ radius: 2
-
op: expect_selectable
target: mount_hole
- count: 1
+ count: 2
diff --git a/testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-forward.firmament b/testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-forward.firmament
new file mode 100644
index 00000000..34eab03a
--- /dev/null
+++ b/testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-forward.firmament
@@ -0,0 +1,18 @@
+firmament:
+ version: 1
+
+model:
+ name: demo
+ units: mm
+
+ops[2]:
+ -
+ op: expect_exists
+ target: later
+ -
+ op: box
+ id: later
+ size[3]:
+ 1
+ 1
+ 1
diff --git a/testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-nonexistent.firmament b/testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-nonexistent.firmament
new file mode 100644
index 00000000..e4610fd8
--- /dev/null
+++ b/testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-nonexistent.firmament
@@ -0,0 +1,11 @@
+firmament:
+ version: 1
+
+model:
+ name: demo
+ units: mm
+
+ops[1]:
+ -
+ op: expect_exists
+ target: missing
diff --git a/testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-forward.firmament b/testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-forward.firmament
new file mode 100644
index 00000000..4f4a271d
--- /dev/null
+++ b/testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-forward.firmament
@@ -0,0 +1,17 @@
+firmament:
+ version: 1
+
+model:
+ name: demo
+ units: mm
+
+ops[2]:
+ -
+ op: expect_selectable
+ target: later
+ count: 1
+ -
+ op: cylinder
+ id: later
+ radius: 1
+ height: 2
diff --git a/testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-nonexistent.firmament b/testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-nonexistent.firmament
new file mode 100644
index 00000000..098dfcc0
--- /dev/null
+++ b/testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-nonexistent.firmament
@@ -0,0 +1,12 @@
+firmament:
+ version: 1
+
+model:
+ name: demo
+ units: mm
+
+ops[1]:
+ -
+ op: expect_selectable
+ target: missing
+ count: 1
diff --git a/testdata/firmament/fixtures/m2c-valid-expect-exists-bare-target-earlier.firmament b/testdata/firmament/fixtures/m2c-valid-expect-exists-bare-target-earlier.firmament
new file mode 100644
index 00000000..c5f56f84
--- /dev/null
+++ b/testdata/firmament/fixtures/m2c-valid-expect-exists-bare-target-earlier.firmament
@@ -0,0 +1,18 @@
+firmament:
+ version: 1
+
+model:
+ name: demo
+ units: mm
+
+ops[2]:
+ -
+ op: box
+ id: base
+ size[3]:
+ 1
+ 2
+ 3
+ -
+ op: expect_exists
+ target: base
diff --git a/testdata/firmament/fixtures/m2c-valid-expect-exists-selector-target-unresolved.firmament b/testdata/firmament/fixtures/m2c-valid-expect-exists-selector-target-unresolved.firmament
new file mode 100644
index 00000000..f4c83eb7
--- /dev/null
+++ b/testdata/firmament/fixtures/m2c-valid-expect-exists-selector-target-unresolved.firmament
@@ -0,0 +1,11 @@
+firmament:
+ version: 1
+
+model:
+ name: demo
+ units: mm
+
+ops[1]:
+ -
+ op: expect_exists
+ target: ghost_feature.top_face
diff --git a/testdata/firmament/fixtures/m2c-valid-expect-selectable-bare-target-earlier.firmament b/testdata/firmament/fixtures/m2c-valid-expect-selectable-bare-target-earlier.firmament
new file mode 100644
index 00000000..a86538d2
--- /dev/null
+++ b/testdata/firmament/fixtures/m2c-valid-expect-selectable-bare-target-earlier.firmament
@@ -0,0 +1,16 @@
+firmament:
+ version: 1
+
+model:
+ name: demo
+ units: mm
+
+ops[2]:
+ -
+ op: sphere
+ id: mount_hole
+ radius: 2
+ -
+ op: expect_selectable
+ target: mount_hole
+ count: 1
diff --git a/testdata/firmament/fixtures/m2c-valid-expect-selectable-selector-target-unresolved.firmament b/testdata/firmament/fixtures/m2c-valid-expect-selectable-selector-target-unresolved.firmament
new file mode 100644
index 00000000..cace7b56
--- /dev/null
+++ b/testdata/firmament/fixtures/m2c-valid-expect-selectable-selector-target-unresolved.firmament
@@ -0,0 +1,12 @@
+firmament:
+ version: 1
+
+model:
+ name: demo
+ units: mm
+
+ops[1]:
+ -
+ op: expect_selectable
+ target: ghost_feature.entry_face
+ count: 1
diff --git a/testdata/firmament/fixtures/m2c-valid-mixed-bare-and-selector-targets.firmament b/testdata/firmament/fixtures/m2c-valid-mixed-bare-and-selector-targets.firmament
new file mode 100644
index 00000000..10d551bb
--- /dev/null
+++ b/testdata/firmament/fixtures/m2c-valid-mixed-bare-and-selector-targets.firmament
@@ -0,0 +1,25 @@
+firmament:
+ version: 1
+
+model:
+ name: demo
+ units: mm
+
+ops[4]:
+ -
+ op: box
+ id: base
+ size[3]:
+ 4
+ 5
+ 6
+ -
+ op: expect_exists
+ target: base
+ -
+ op: expect_selectable
+ target: base.top_face
+ count: 1
+ -
+ op: expect_exists
+ target: future_feature.edge_a
diff --git a/testdata/firmament/manifests/m0c.corpus.json b/testdata/firmament/manifests/m0c.corpus.json
index 67c95d91..5336d967 100644
--- a/testdata/firmament/manifests/m0c.corpus.json
+++ b/testdata/firmament/manifests/m0c.corpus.json
@@ -626,6 +626,80 @@
"kernelCode": "ValidationFailed",
"firmamentCode": "FIRM-STRUCT-0017"
}
+ },
+ {
+ "id": "m2c-valid-expect-exists-bare-target-earlier",
+ "name": "Valid M2c expect_exists bare target references earlier feature",
+ "fixturePath": "testdata/firmament/fixtures/m2c-valid-expect-exists-bare-target-earlier.firmament",
+ "expectedOutcome": "success"
+ },
+ {
+ "id": "m2c-valid-expect-selectable-bare-target-earlier",
+ "name": "Valid M2c expect_selectable bare target references earlier feature",
+ "fixturePath": "testdata/firmament/fixtures/m2c-valid-expect-selectable-bare-target-earlier.firmament",
+ "expectedOutcome": "success"
+ },
+ {
+ "id": "m2c-valid-expect-exists-selector-target-unresolved",
+ "name": "Valid M2c expect_exists selector-shaped target remains unresolved",
+ "fixturePath": "testdata/firmament/fixtures/m2c-valid-expect-exists-selector-target-unresolved.firmament",
+ "expectedOutcome": "success"
+ },
+ {
+ "id": "m2c-valid-expect-selectable-selector-target-unresolved",
+ "name": "Valid M2c expect_selectable selector-shaped target remains unresolved",
+ "fixturePath": "testdata/firmament/fixtures/m2c-valid-expect-selectable-selector-target-unresolved.firmament",
+ "expectedOutcome": "success"
+ },
+ {
+ "id": "m2c-valid-mixed-bare-and-selector-targets",
+ "name": "Valid M2c mixed bare and selector-shaped validation targets",
+ "fixturePath": "testdata/firmament/fixtures/m2c-valid-mixed-bare-and-selector-targets.firmament",
+ "expectedOutcome": "success"
+ },
+ {
+ "id": "m2c-invalid-expect-exists-bare-target-nonexistent",
+ "name": "Invalid M2c expect_exists bare target missing feature",
+ "fixturePath": "testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-nonexistent.firmament",
+ "expectedOutcome": "failure",
+ "expectedDiagnostic": {
+ "source": "firmament",
+ "kernelCode": "ValidationFailed",
+ "firmamentCode": "FIRM-REF-0003"
+ }
+ },
+ {
+ "id": "m2c-invalid-expect-selectable-bare-target-nonexistent",
+ "name": "Invalid M2c expect_selectable bare target missing feature",
+ "fixturePath": "testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-nonexistent.firmament",
+ "expectedOutcome": "failure",
+ "expectedDiagnostic": {
+ "source": "firmament",
+ "kernelCode": "ValidationFailed",
+ "firmamentCode": "FIRM-REF-0003"
+ }
+ },
+ {
+ "id": "m2c-invalid-expect-exists-bare-target-forward",
+ "name": "Invalid M2c expect_exists bare target forward reference",
+ "fixturePath": "testdata/firmament/fixtures/m2c-invalid-expect-exists-bare-target-forward.firmament",
+ "expectedOutcome": "failure",
+ "expectedDiagnostic": {
+ "source": "firmament",
+ "kernelCode": "ValidationFailed",
+ "firmamentCode": "FIRM-REF-0003"
+ }
+ },
+ {
+ "id": "m2c-invalid-expect-selectable-bare-target-forward",
+ "name": "Invalid M2c expect_selectable bare target forward reference",
+ "fixturePath": "testdata/firmament/fixtures/m2c-invalid-expect-selectable-bare-target-forward.firmament",
+ "expectedOutcome": "failure",
+ "expectedDiagnostic": {
+ "source": "firmament",
+ "kernelCode": "ValidationFailed",
+ "firmamentCode": "FIRM-REF-0003"
+ }
}
]
}