Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel
FL2: add 10 friction cases and structured review-aware reporting
Yuechen Lid6b041f55064
diff --git a/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/expected.intent.mdnew file mode 100644index 00000000..76275ffa--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Create a block body.+- Subtract a cylinder with finite depth that does not break through the bottom face.diff --git a/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/part.firmamentnew file mode 100644index 00000000..89ffc687--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/part.firmament@@ -0,0 +1,30 @@+firmament:+ version: 1++model:+ name: fl2_blind_hole_block_deep+ units: mm++ops[2]:+ -+ op: box+ id: block+ size[3]:+ 50+ 50+ 40++ -+ op: subtract+ id: deep_blind_hole+ from: block+ with:+ op: cylinder+ radius: 6+ height: 30+ place:+ on: origin+ offset[3]:+ 0+ 0+ 5diff --git a/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/prompt.mdnew file mode 100644index 00000000..4ea603d1--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a rectangular block with a centered deep blind hole from the top face.diff --git a/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/review.toon b/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/review.toonnew file mode 100644index 00000000..6504581c--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/blind-hole-block-deep/review.toon@@ -0,0 +1,10 @@+case_id: blind-hole-block-deep+possible: partial+awkwardness: medium+pain_points[2]:+ - "Blind-hole depth behavior depends on subtract span constraints that are hard to predict."+ - "Depth intent is concise in source but often rejected during execution."+proposed_features[2]:+ - "Explicit blind-hole primitive with depth and reference-face semantics."+ - "Preflight validation message for allowed subtract span families."+reviewer_verdict: "Authoring is straightforward, but execution support for deep blind holes is incomplete."diff --git a/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/expected.intent.mdnew file mode 100644index 00000000..d62bddf1--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Create a plate body.+- Subtract a larger shallow bore and a smaller through-hole on the same axis.diff --git a/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/part.firmamentnew file mode 100644index 00000000..2abf13b1--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/part.firmament@@ -0,0 +1,39 @@+firmament:+ version: 1++model:+ name: fl2_counterbore_hole+ units: mm++ops[3]:+ -+ op: box+ id: plate+ size[3]:+ 70+ 40+ 16++ -+ op: subtract+ id: counterbore_pocket+ from: plate+ with:+ op: cylinder+ radius: 7+ height: 6+ place:+ on: origin+ offset[3]:+ 0+ 0+ 5++ -+ op: subtract+ id: counterbore_through+ from: counterbore_pocket+ with:+ op: cylinder+ radius: 3.5+ height: 24diff --git a/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/prompt.mdnew file mode 100644index 00000000..4aa87c20--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a plate with one counterbore hole using stacked subtract operations.diff --git a/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/review.toon b/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/review.toonnew file mode 100644index 00000000..f8eb645e--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/counterbore-hole/review.toon@@ -0,0 +1,10 @@+case_id: counterbore-hole+possible: partial+awkwardness: high+pain_points[2]:+ - "Counterbore requires stacked subtract operations without feature-level hole semantics."+ - "Coaxial alignment between bore stages is implicit and fragile."+proposed_features[2]:+ - "Native hole feature supporting counterbore/countersink parameters."+ - "Axis-reuse reference between sequential subtract tools."+reviewer_verdict: "Intent is representable but awkward and sensitive to subtract constraints."diff --git a/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/expected.intent.mdnew file mode 100644index 00000000..83b2965b--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Create an outer box.+- Create an inner offset box and subtract it to leave walls and bottom thickness.diff --git a/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/part.firmamentnew file mode 100644index 00000000..b101db69--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/part.firmament@@ -0,0 +1,32 @@+firmament:+ version: 1++model:+ name: fl2_enclosure_hollow_box+ units: mm++ops[2]:+ -+ op: box+ id: outer+ size[3]:+ 100+ 80+ 50++ -+ op: subtract+ id: shell_cut+ from: outer+ with:+ op: box+ size[3]:+ 88+ 68+ 46+ place:+ on: origin+ offset[3]:+ 0+ 0+ 2diff --git a/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/prompt.mdnew file mode 100644index 00000000..ba2363e0--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a hollow enclosure-style box with constant wall thickness and open top.diff --git a/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/review.toon b/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/review.toonnew file mode 100644index 00000000..f6c0cdde--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/enclosure-hollow-box/review.toon@@ -0,0 +1,10 @@+case_id: enclosure-hollow-box+possible: partial+awkwardness: high+pain_points[2]:+ - "Shelling is emulated by manually sizing and offsetting an inner box."+ - "Wall thickness intent is implicit and easy to break with edits."+proposed_features[2]:+ - "Shell feature with wall thickness and open-face options."+ - "Offset-body operation with topology-aware validation."+reviewer_verdict: "Expressed with primitive subtraction, but true enclosure shell semantics are missing."diff --git a/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/expected.intent.mdnew file mode 100644index 00000000..6bfef541--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Create a flange-like disk shape (approximated with available primitives).+- Subtract a center hole and four equally spaced bolt holes.diff --git a/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/part.firmamentnew file mode 100644index 00000000..7154b4f5--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/part.firmament@@ -0,0 +1,82 @@+firmament:+ version: 1++model:+ name: fl2_flange_bolt_circle+ units: mm++ops[6]:+ -+ op: cylinder+ id: flange+ radius: 40+ height: 12++ -+ op: subtract+ id: center_bore+ from: flange+ with:+ op: cylinder+ radius: 12+ height: 24++ -+ op: subtract+ id: bolt_0+ from: center_bore+ with:+ op: cylinder+ radius: 4+ height: 24+ place:+ on: origin+ offset[3]:+ 25+ 0+ 0++ -+ op: subtract+ id: bolt_90+ from: bolt_0+ with:+ op: cylinder+ radius: 4+ height: 24+ place:+ on: origin+ offset[3]:+ 0+ 25+ 0++ -+ op: subtract+ id: bolt_180+ from: bolt_90+ with:+ op: cylinder+ radius: 4+ height: 24+ place:+ on: origin+ offset[3]:+ -25+ 0+ 0++ -+ op: subtract+ id: bolt_270+ from: bolt_180+ with:+ op: cylinder+ radius: 4+ height: 24+ place:+ on: origin+ offset[3]:+ 0+ -25+ 0diff --git a/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/prompt.mdnew file mode 100644index 00000000..77a11fe6--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a round flange with a central bore and four bolt holes on a bolt circle.diff --git a/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/review.toon b/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/review.toonnew file mode 100644index 00000000..a45e334f--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/flange-bolt-circle/review.toon@@ -0,0 +1,10 @@+case_id: flange-bolt-circle+possible: true+awkwardness: medium+pain_points[2]:+ - "Bolt circle requires fully manual repeated operations and hard-coded angles."+ - "No pattern abstraction for circular feature arrays."+proposed_features[2]:+ - "Polar pattern operation for repeated cuts around an axis."+ - "Parameter blocks for shared hole dimensions."+reviewer_verdict: "Possible today, but repetitive and error-prone for larger bolt counts."diff --git a/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/expected.intent.mdnew file mode 100644index 00000000..3ef98578--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Define two profiles on different planes.+- Create a lofted transition between those profiles.diff --git a/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/part.firmamentnew file mode 100644index 00000000..ec5c5b9d--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/part.firmament@@ -0,0 +1,14 @@+firmament:+ version: 1++model:+ name: fl2_loft_transition_test+ units: mm++ops[1]:+ -+ op: loft+ id: transition+ profiles[2]:+ rectangle_profile+ circle_profilediff --git a/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/prompt.mdnew file mode 100644index 00000000..804e83da--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a smooth loft transition between a rectangle and a circle profile.diff --git a/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/review.toon b/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/review.toonnew file mode 100644index 00000000..5305e689--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/loft-transition-test/review.toon@@ -0,0 +1,10 @@+case_id: loft-transition-test+possible: false+awkwardness: high+pain_points[2]:+ - "Loft between dissimilar profiles is not available in current primitive set."+ - "No profile sketch or multi-section transition construct exists to express intent."+proposed_features[2]:+ - "Profile definition blocks with reusable sketches."+ - "Loft feature supporting multi-section transitions and guide constraints."+reviewer_verdict: "Expected failure: transition loft cannot be authored without missing core shape operations."diff --git a/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/expected.intent.mdnew file mode 100644index 00000000..f1407950--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Create a base plate and an upright plate in an L arrangement.+- Add one through-hole in the base and one through-hole in the upright leg.diff --git a/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/part.firmamentnew file mode 100644index 00000000..292f8c20--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/part.firmament@@ -0,0 +1,62 @@+firmament:+ version: 1++model:+ name: fl2_mounting_bracket_basic+ units: mm++ops[4]:+ -+ op: box+ id: base+ size[3]:+ 60+ 30+ 8++ -+ op: add+ id: bracket+ to: base+ with:+ op: box+ size[3]:+ 8+ 30+ 40+ place:+ on: origin+ offset[3]:+ 26+ 0+ 24++ -+ op: subtract+ id: base_hole+ from: bracket+ with:+ op: cylinder+ radius: 3.5+ height: 20+ place:+ on: origin+ offset[3]:+ -15+ 0+ 0++ -+ op: subtract+ id: upright_hole+ from: base_hole+ with:+ op: cylinder+ radius: 3.5+ height: 20+ place:+ on: origin+ offset[3]:+ 26+ 0+ 18diff --git a/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/prompt.mdnew file mode 100644index 00000000..18d39478--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a basic right-angle mounting bracket with a base, upright leg, and two through-holes for mounting.diff --git a/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/review.toon b/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/review.toonnew file mode 100644index 00000000..dc1a0c08--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/mounting-bracket-basic/review.toon@@ -0,0 +1,10 @@+case_id: mounting-bracket-basic+possible: partial+awkwardness: high+pain_points[2]:+ - "Bracket union requires add behavior that currently fails on non-trivial unions."+ - "Hole placement requires manual offsets with no alignment helper for faces/axes."+proposed_features[2]:+ - "Robust add/union support for simple multi-box bracket construction."+ - "Face/axis placement primitives for hole positioning."+reviewer_verdict: "Intent is clear but blocked by union limitations, so only partial authoring confidence."diff --git a/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/expected.intent.mdnew file mode 100644index 00000000..5ec4c2e4--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Create a rectangular plate.+- Remove a centered shallow rectangular pocket without cutting through.diff --git a/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/part.firmamentnew file mode 100644index 00000000..092b39e3--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/part.firmament@@ -0,0 +1,32 @@+firmament:+ version: 1++model:+ name: fl2_pocketed_plate+ units: mm++ops[2]:+ -+ op: box+ id: plate+ size[3]:+ 90+ 60+ 12++ -+ op: subtract+ id: pocket+ from: plate+ with:+ op: box+ size[3]:+ 60+ 30+ 6+ place:+ on: origin+ offset[3]:+ 0+ 0+ 3diff --git a/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/prompt.mdnew file mode 100644index 00000000..7509788b--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a plate with a rectangular pocket removed from the top region.diff --git a/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/review.toon b/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/review.toonnew file mode 100644index 00000000..b9fff876--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/pocketed-plate/review.toon@@ -0,0 +1,10 @@+case_id: pocketed-plate+possible: partial+awkwardness: medium+pain_points[2]:+ - "Region-removal relies on subtracting another box instead of declaring a pocket intent."+ - "Pocket depth and top-face reference are not explicit first-class concepts."+proposed_features[2]:+ - "Pocket primitive with profile + depth definition."+ - "Feature references for top-face anchored cuts."+reviewer_verdict: "Plate pocket is expressible only as primitive abuse; semantics are missing."diff --git a/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/expected.intent.mdnew file mode 100644index 00000000..7b98aeb3--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Create a base and a vertical wall.+- Add thin ribs between them if this can be done cleanly.diff --git a/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/part.firmamentnew file mode 100644index 00000000..09a9bf1c--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/part.firmament@@ -0,0 +1,32 @@+firmament:+ version: 1++model:+ name: fl2_ribbed_support+ units: mm++ops[2]:+ -+ op: box+ id: base+ size[3]:+ 80+ 40+ 8++ -+ op: add+ id: wall+ to: base+ with:+ op: box+ size[3]:+ 8+ 40+ 36+ place:+ on: origin+ offset[3]:+ 36+ 0+ 22diff --git a/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/prompt.mdnew file mode 100644index 00000000..45cae5c7--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a support block with thin reinforcing ribs between base and vertical wall.diff --git a/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/review.toon b/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/review.toonnew file mode 100644index 00000000..b3737773--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/ribbed-support/review.toon@@ -0,0 +1,10 @@+case_id: ribbed-support+possible: false+awkwardness: high+pain_points[2]:+ - "Thin rib authoring would require brute-force repeated adds with fragile dimensions."+ - "Baseline add for support wall already fails for L-like unions, so rib attempt was intentionally stopped."+proposed_features[2]:+ - "Rib feature with thickness, draft, and anchor references."+ - "Stable additive union support for connected support geometry."+reviewer_verdict: "Stopped per anti-pretzel rule: rib modeling is not cleanly expressible in current surface area."diff --git a/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/expected.intent.mdnew file mode 100644index 00000000..282df63a--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Create a shaft as a cylinder.+- Subtract a rectangular slot aligned to the shaft axis.diff --git a/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/part.firmamentnew file mode 100644index 00000000..3a177672--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/part.firmament@@ -0,0 +1,30 @@+firmament:+ version: 1++model:+ name: fl2_shaft_keyway+ units: mm++ops[2]:+ -+ op: cylinder+ id: shaft+ radius: 15+ height: 80++ -+ op: subtract+ id: keyway+ from: shaft+ with:+ op: box+ size[3]:+ 10+ 6+ 90+ place:+ on: origin+ offset[3]:+ 10+ 0+ 0diff --git a/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/prompt.mdnew file mode 100644index 00000000..a233f830--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a cylindrical shaft with a straight keyway slot cut along its length.diff --git a/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/review.toon b/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/review.toonnew file mode 100644index 00000000..f83a4815--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/shaft-keyway/review.toon@@ -0,0 +1,10 @@+case_id: shaft-keyway+possible: true+awkwardness: medium+pain_points[2]:+ - "Slot alignment to cylinder is offset-based instead of axis/face constrained."+ - "No dedicated keyway helper, so dimensions are manually coordinated."+proposed_features[2]:+ - "Axis-aligned slot primitive for shafts."+ - "Reference constraints against cylindrical faces/axes."+reviewer_verdict: "Possible with existing primitives, but alignment readability is weaker than desired."diff --git a/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/expected.intent.mdnew file mode 100644index 00000000..6ccb060c--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/expected.intent.md@@ -0,0 +1,4 @@+# Expected intent++- Create a shaft body.+- Apply helical thread geometry on the outer surface.diff --git a/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/part.firmamentnew file mode 100644index 00000000..ed3c607f--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/part.firmament@@ -0,0 +1,20 @@+firmament:+ version: 1++model:+ name: fl2_thread_helix_test+ units: mm++ops[2]:+ -+ op: cylinder+ id: shaft+ radius: 8+ height: 40++ -+ op: helix_thread+ id: external_thread+ target: shaft+ pitch: 1.5+ depth: 0.8diff --git a/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/prompt.md b/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/prompt.mdnew file mode 100644index 00000000..f0b84356--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/prompt.md@@ -0,0 +1,3 @@+# Prompt++Author a threaded shaft using a helix-based thread feature.diff --git a/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/review.toon b/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/review.toonnew file mode 100644index 00000000..75324d23--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Cases/thread-helix-test/review.toon@@ -0,0 +1,10 @@+case_id: thread-helix-test+possible: false+awkwardness: high+pain_points[2]:+ - "No helix/thread operation exists in current Firmament operation set."+ - "Approximating thread with many cuts would violate anti-pretzel authoring guidance."+proposed_features[2]:+ - "Helix curve primitive and sweep/subtract support."+ - "High-level thread feature (standard profile + pitch + handedness)."+reviewer_verdict: "Expected failure confirmed: helix-thread authoring is currently unavailable."diff --git a/Aetheris.Firmament.FrictionLab/Harness/FrictionLabRunner.cs b/Aetheris.Firmament.FrictionLab/Harness/FrictionLabRunner.csindex 95593a71..87569980 100644--- a/Aetheris.Firmament.FrictionLab/Harness/FrictionLabRunner.cs+++ b/Aetheris.Firmament.FrictionLab/Harness/FrictionLabRunner.cs@@ -43,13 +43,18 @@ internal sealed class FrictionLabRunnerprivate static FrictionCaseResult RunCase(FrictionLabPaths paths, string caseDirectory){var caseId = Path.GetFileName(caseDirectory);+ var review = ReadReview(caseDirectory, caseId);+var sourcePath = Path.Combine(caseDirectory, "part.firmament");if (!File.Exists(sourcePath)){return new FrictionCaseResult(caseId,- "failure",+ ComputeBuildStatus(false, review),+ false,null,+ review.Possible,+ review.Awkwardness,[new FrictionDiagnostic("ValidationFailed", "Error", "Case is missing required file 'part.firmament'.", "friction-lab")]);}@@ -66,23 +71,108 @@ internal sealed class FrictionLabRunner{return new FrictionCaseResult(caseId,- "failure",+ ComputeBuildStatus(false, review),+ false,null,+ review.Possible,+ review.Awkwardness,exportResult.Diagnostics.Select(MapDiagnostic).ToArray());}File.WriteAllText(artifactPath, exportResult.Value.StepText, new UTF8Encoding(false));- var status = exportResult.Diagnostics.Any(d => d.Severity != KernelDiagnosticSeverity.Info)- ? "partial"- : "success";return new FrictionCaseResult(caseId,- status,+ ComputeBuildStatus(true, review),+ true,ToRepoRelativePath(paths.RepoRoot, artifactPath),+ review.Possible,+ review.Awkwardness,exportResult.Diagnostics.Select(MapDiagnostic).ToArray());}+ private static FrictionCaseReview ReadReview(string caseDirectory, string caseId)+ {+ var reviewPath = Path.Combine(caseDirectory, "review.toon");+ if (!File.Exists(reviewPath))+ {+ return FrictionCaseReview.Missing(caseId);+ }++ var lines = NormalizeLf(File.ReadAllText(reviewPath, Encoding.UTF8)).Split('\n');+ var values = new Dictionary<string, string>(StringComparer.Ordinal);+ var lists = new Dictionary<string, List<string>>(StringComparer.Ordinal);+ string? currentList = null;++ foreach (var raw in lines)+ {+ var line = raw.TrimEnd();+ if (string.IsNullOrWhiteSpace(line))+ {+ continue;+ }++ var trimmed = line.TrimStart();+ if (trimmed.StartsWith("-", StringComparison.Ordinal) && currentList is not null)+ {+ lists[currentList].Add(Unquote(trimmed[1..].Trim()));+ continue;+ }++ currentList = null;+ var separatorIndex = line.IndexOf(':');+ if (separatorIndex < 0)+ {+ continue;+ }++ var key = line[..separatorIndex].Trim();+ var value = line[(separatorIndex + 1)..].Trim();+ if (key.Contains('[', StringComparison.Ordinal))+ {+ var listKey = key[..key.IndexOf('[', StringComparison.Ordinal)];+ lists[listKey] = [];+ currentList = listKey;+ continue;+ }++ values[key] = Unquote(value);+ }++ return new FrictionCaseReview(+ values.GetValueOrDefault("case_id", caseId),+ values.GetValueOrDefault("possible", "partial"),+ values.GetValueOrDefault("awkwardness", "high"),+ lists.GetValueOrDefault("pain_points", []),+ lists.GetValueOrDefault("proposed_features", []),+ values.GetValueOrDefault("reviewer_verdict", "No verdict provided."));+ }++ private static string ComputeBuildStatus(bool exportSuccess, FrictionCaseReview review)+ {+ if (!exportSuccess)+ {+ return review.Possible.Equals("partial", StringComparison.Ordinal) ? "partial" : "failure";+ }++ return review.Possible switch+ {+ "true" => "success",+ "partial" => "partial",+ _ => "failure"+ };+ }++ private static string Unquote(string value)+ {+ if (value.Length >= 2 && value[0] == '"' && value[^1] == '"')+ {+ return value[1..^1];+ }++ return value;+ }+private static FrictionDiagnostic MapDiagnostic(KernelDiagnostic diagnostic) =>new(diagnostic.Code.ToString(),diff --git a/Aetheris.Firmament.FrictionLab/Harness/FrictionLabSummary.cs b/Aetheris.Firmament.FrictionLab/Harness/FrictionLabSummary.csindex cc264402..5e4de9e3 100644--- a/Aetheris.Firmament.FrictionLab/Harness/FrictionLabSummary.cs+++ b/Aetheris.Firmament.FrictionLab/Harness/FrictionLabSummary.cs@@ -27,7 +27,10 @@ internal sealed record FrictionLabSummary(internal sealed record FrictionCaseResult(string CaseId,string BuildStatus,+ bool ArtifactPresent,string? StepArtifactPath,+ string Possible,+ string Awkwardness,IReadOnlyList<FrictionDiagnostic> Diagnostics);internal sealed record FrictionDiagnostic(@@ -35,3 +38,15 @@ internal sealed record FrictionDiagnostic(string Severity,string Message,string? Source);++internal sealed record FrictionCaseReview(+ string CaseId,+ string Possible,+ string Awkwardness,+ IReadOnlyList<string> PainPoints,+ IReadOnlyList<string> ProposedFeatures,+ string ReviewerVerdict)+{+ public static FrictionCaseReview Missing(string caseId) =>+ new(caseId, "partial", "high", ["Missing or invalid review.toon file."], ["Enforce review parsing in harness validation."], "Review metadata missing.");+}diff --git a/Aetheris.Firmament.FrictionLab/README.md b/Aetheris.Firmament.FrictionLab/README.mdindex e11474f6..7b8343a4 100644--- a/Aetheris.Firmament.FrictionLab/README.md+++ b/Aetheris.Firmament.FrictionLab/README.md@@ -9,11 +9,26 @@ Aetheris.Firmament.FrictionLab is an **authoring friction lab** for Firmament, n- Emit STEP artifacts and per-run summary output for quick friction review.- Record authoring friction explicitly in `review.toon` instead of forcing workarounds.-## Rules+## FL2 milestone-- Do not author production kernel or language expansion code here.-- If a case cannot be expressed cleanly in current Firmament, **stop and record the friction**.-- Do not “pretzel” cases into unnatural constructs just to claim success.+FL2 expands the lab with a focused 10-case suite covering brackets, holes, patterns, pockets, support structures, shaft features, shelling, and intentionally missing advanced geometry (thread helix and loft transition).++The suite is designed for measurement, not pass-rate inflation:++- successes identify what is currently easy,+- partials expose awkward or fragile expressions,+- failures document genuinely missing shape capabilities.++## Anti-pretzel rule (mandatory)++If a case cannot be expressed cleanly:++- stop,+- do not build complex hacks,+- do not simulate missing features with unnatural constructions,+- report friction directly in `review.toon`.++Failures are expected and valuable in this phase.## Run@@ -23,4 +38,4 @@ dotnet run --project Aetheris.Firmament.FrictionLab/Aetheris.Firmament.FrictionLOutputs:- `Reports/summary.json`-- `Reports/Artifacts/*.step` (for successful exports)+- `Reports/Artifacts/*.step` (only when export succeeds)diff --git a/Aetheris.Firmament.FrictionLab/Reports/summary.json b/Aetheris.Firmament.FrictionLab/Reports/summary.jsonindex e2e464b1..a6b477b4 100644--- a/Aetheris.Firmament.FrictionLab/Reports/summary.json+++ b/Aetheris.Firmament.FrictionLab/Reports/summary.json@@ -1,13 +1,38 @@{- "totalCases": 3,+ "totalCases": 13,"successCount": 1,- "partialCount": 0,- "failureCount": 2,+ "partialCount": 7,+ "failureCount": 5,"caseResults": [+ {+ "caseId": "blind-hole-block-deep",+ "buildStatus": "partial",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "partial",+ "awkwardness": "medium",+ "diagnostics": [+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Requested boolean feature \u0027deep_blind_hole\u0027 (subtract) could not be executed.",+ "source": "firmament"+ },+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Boolean feature \u0027deep_blind_hole\u0027 (subtract) does not match the supported subtract span family; only through-holes or one-sided blind holes are allowed in this milestone.",+ "source": "BrepBoolean.AnalyticHole.NotFullySpanning"+ }+ ]+ },{"caseId": "blind-hole-mount-block",- "buildStatus": "failure",+ "buildStatus": "partial",+ "artifactPresent": false,"stepArtifactPath": null,+ "possible": "partial",+ "awkwardness": "medium","diagnostics": [{"code": "NotImplemented",@@ -23,16 +48,192 @@}]},+ {+ "caseId": "counterbore-hole",+ "buildStatus": "partial",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "partial",+ "awkwardness": "high",+ "diagnostics": [+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Requested boolean feature \u0027counterbore_pocket\u0027 (subtract) could not be executed.",+ "source": "firmament"+ },+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Boolean feature \u0027counterbore_pocket\u0027 (subtract) does not match the supported subtract span family; only through-holes or one-sided blind holes are allowed in this milestone.",+ "source": "BrepBoolean.AnalyticHole.NotFullySpanning"+ }+ ]+ },+ {+ "caseId": "enclosure-hollow-box",+ "buildStatus": "partial",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "partial",+ "awkwardness": "high",+ "diagnostics": [+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Requested boolean feature \u0027shell_cut\u0027 (subtract) could not be executed.",+ "source": "firmament"+ },+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Boolean feature \u0027shell_cut\u0027 (subtract): Boolean Subtract: box subtraction result is not representable as a single box in M13.",+ "source": "BrepBoolean.RebuildResult"+ }+ ]+ },+ {+ "caseId": "flange-bolt-circle",+ "buildStatus": "failure",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "true",+ "awkwardness": "medium",+ "diagnostics": [+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Requested boolean feature \u0027center_bore\u0027 (subtract) could not be executed.",+ "source": "firmament"+ },+ {+ "code": "ValidationFailed",+ "severity": "Error",+ "message": "Boolean feature \u0027center_bore\u0027 (subtract) cannot re-enter the safe subtract family from \u0027flange\u0027. Safe-hole composition may start only from a box root or continue from a previously validated safe subtract result.",+ "source": "firmament.feature-graph.invalid-composition-order"+ }+ ]+ },{"caseId": "flange-plate-hole-pattern","buildStatus": "success",+ "artifactPresent": true,"stepArtifactPath": "Aetheris.Firmament.FrictionLab/Reports/Artifacts/flange-plate-hole-pattern.step",+ "possible": "true",+ "awkwardness": "low","diagnostics": []},{- "caseId": "simple-bracket",+ "caseId": "loft-transition-test","buildStatus": "failure",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "false",+ "awkwardness": "high",+ "diagnostics": [+ {+ "code": "ValidationFailed",+ "severity": "Error",+ "message": "[FIRM-STRUCT-0008] Operation entry at index 0 has unknown op kind \u0027loft\u0027.",+ "source": "firmament"+ }+ ]+ },+ {+ "caseId": "mounting-bracket-basic",+ "buildStatus": "partial",+ "artifactPresent": false,"stepArtifactPath": null,+ "possible": "partial",+ "awkwardness": "high",+ "diagnostics": [+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Requested boolean feature \u0027bracket\u0027 (add) could not be executed.",+ "source": "firmament"+ },+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Boolean feature \u0027bracket\u0027 (add): Boolean Union: box union is not a single box in M13 (for example L-shaped unions).",+ "source": "BrepBoolean.RebuildResult"+ }+ ]+ },+ {+ "caseId": "pocketed-plate",+ "buildStatus": "partial",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "partial",+ "awkwardness": "medium",+ "diagnostics": [+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Requested boolean feature \u0027pocket\u0027 (subtract) could not be executed.",+ "source": "firmament"+ },+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Boolean feature \u0027pocket\u0027 (subtract): Boolean Subtract: box subtraction result is not representable as a single box in M13.",+ "source": "BrepBoolean.RebuildResult"+ }+ ]+ },+ {+ "caseId": "ribbed-support",+ "buildStatus": "failure",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "false",+ "awkwardness": "high",+ "diagnostics": [+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Requested boolean feature \u0027wall\u0027 (add) could not be executed.",+ "source": "firmament"+ },+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Boolean feature \u0027wall\u0027 (add): Boolean Union: box union is not a single box in M13 (for example L-shaped unions).",+ "source": "BrepBoolean.RebuildResult"+ }+ ]+ },+ {+ "caseId": "shaft-keyway",+ "buildStatus": "failure",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "true",+ "awkwardness": "medium",+ "diagnostics": [+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Requested boolean feature \u0027keyway\u0027 (subtract) could not be executed.",+ "source": "firmament"+ },+ {+ "code": "NotImplemented",+ "severity": "Error",+ "message": "Boolean feature \u0027keyway\u0027 (subtract): Boolean Subtract: M13 only supports recognized axis-aligned boxes from BrepPrimitives.CreateBox(...).",+ "source": "BrepBoolean.RebuildResult"+ }+ ]+ },+ {+ "caseId": "simple-bracket",+ "buildStatus": "partial",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "partial",+ "awkwardness": "high","diagnostics": [{"code": "NotImplemented",@@ -47,6 +248,22 @@"source": "BrepBoolean.RebuildResult"}]+ },+ {+ "caseId": "thread-helix-test",+ "buildStatus": "failure",+ "artifactPresent": false,+ "stepArtifactPath": null,+ "possible": "false",+ "awkwardness": "high",+ "diagnostics": [+ {+ "code": "ValidationFailed",+ "severity": "Error",+ "message": "[FIRM-STRUCT-0008] Operation entry at index 1 has unknown op kind \u0027helix_thread\u0027.",+ "source": "firmament"+ }+ ]}],"summaryPath": "Aetheris.Firmament.FrictionLab/Reports/summary.json"