Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Update stale cylinder-hole expectations to current runtime

Yuechen Lidfb3dceda617
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs
index 3ca860eb..b8208ee6 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs
@@ -80,14 +80,22 @@ public sealed class Step242HoleSemanticsTests
}
[Fact]
- public void ImportBody_MultiLoopCylindricalFace_ReturnsDeterministicCylinderMappingFailure()
+ public void ImportBody_MultiLoopCylindricalFace_Imports_ThenFailsDeterministicallyAtCylinderTrimDegenerateTessellation()
{
var import = Step242Importer.ImportBody(Step242FixtureCorpus.CylindricalFaceWithTwoLoops);
- Assert.False(import.IsSuccess);
- var diagnostic = Assert.Single(import.Diagnostics);
- Assert.Equal(KernelDiagnosticCode.ValidationFailed, diagnostic.Code);
- Assert.Equal("Topology.GraphValidator", diagnostic.Source);
- Assert.StartsWith("Loop ", diagnostic.Message, StringComparison.Ordinal);
+ Assert.True(import.IsSuccess);
+ Assert.Empty(import.Diagnostics);
+
+ var body = import.Value;
+ var validation = BrepBindingValidator.Validate(body, requireAllEdgeAndFaceBindings: true);
+ Assert.True(validation.IsSuccess);
+
+ var tessellation = BrepDisplayTessellator.Tessellate(body);
+ Assert.False(tessellation.IsSuccess);
+ var diagnostic = Assert.Single(tessellation.Diagnostics);
+ Assert.Equal(KernelDiagnosticCode.InvalidArgument, diagnostic.Code);
+ Assert.Equal("Viewer.Tessellation.CylinderTrimDegenerate", diagnostic.Source);
+ Assert.StartsWith("Cylindrical face tessellation derived a degenerate trim patch.", diagnostic.Message, StringComparison.Ordinal);
}
}
diff --git a/testdata/step242/manifests/v0.corpus.json b/testdata/step242/manifests/v0.corpus.json
index 15235ac1..21f6a61c 100644
--- a/testdata/step242/manifests/v0.corpus.json
+++ b/testdata/step242/manifests/v0.corpus.json
@@ -53,9 +53,9 @@
"path": "testdata/step242/generated/v0-expectedfail/cylinder_hole_unsupported.step",
"group": "expectedFail",
"expectedFirstDiagnostic": {
- "code": "ValidationFailed",
- "source": "Topology.GraphValidator",
- "messagePrefix": "Loop "
+ "code": "InvalidArgument",
+ "source": "Viewer.Tessellation.CylinderTrimDegenerate",
+ "messagePrefix": "Cylindrical face tessellation derived a degenerate trim patch."
}
},
{