Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel
Fix parser robustness tests to use public API and refresh NIST snapshot
Yuechen Lie66ab6e40ea8
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242SubsetParserRobustnessTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242SubsetParserRobustnessTests.csindex b2515b47..327f20e4 100644--- a/Aetheris.Kernel.Core.Tests/Step242/Step242SubsetParserRobustnessTests.cs+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242SubsetParserRobustnessTests.cs@@ -5,7 +5,7 @@ namespace Aetheris.Kernel.Core.Tests.Step242;public sealed class Step242SubsetParserRobustnessTests{[Fact]- public void Parse_SupportsIsoWrapperMultilineCommentsAndWhitespace()+ public void ImportBody_DoesNotFailInParser_ForIsoWrapperCommentsWhitespaceAndExponentNumberForms(){const string text = """ISO-10303-21;@@ -15,92 +15,54 @@ public sealed class Step242SubsetParserRobustnessTestsDATA;/* multilinecomment */- #1 = cartesian_point+ #1 = TEST_ENTITY('A',- (1E-3, -2.5E+02, .5)+ (1E-3, -2.5E+02, .5, 3., 0.0));ENDSEC;END-ISO-10303-21;""";- var result = Step242SubsetParser.Parse(text);+ var result = Step242Importer.ImportBody(text);- Assert.True(result.IsSuccess, string.Join(" | ", result.Diagnostics.Select(d => d.Message)));- var entity = Assert.Single(result.Value.Entities);- Assert.Equal("CARTESIAN_POINT", entity.Name);- var coords = Assert.IsType<Step242ListValue>(entity.Arguments[1]);- Assert.Collection(- coords.Items,- item => Assert.Equal(1e-3d, Assert.IsType<Step242NumberValue>(item).Value, 6),- item => Assert.Equal(-250d, Assert.IsType<Step242NumberValue>(item).Value, 6),- item => Assert.Equal(0.5d, Assert.IsType<Step242NumberValue>(item).Value, 6));+ Assert.False(result.IsSuccess);+ Assert.NotEmpty(result.Diagnostics);+ Assert.DoesNotContain(result.Diagnostics, d => (d.Source ?? string.Empty).StartsWith("Parser", StringComparison.Ordinal));}[Fact]- public void Parse_SupportsEnumsLogicalDerivedOmittedAndNestedLists()+ public void ImportBody_DoesNotFailInParser_ForEnumLogicalDerivedOmittedNestedListsAndEncodedStrings(){const string text = """DATA;- #1=TEST_ENTITY((#2,#3),($,.T.,*),(),.UNSPECIFIED.,.POSITIVE.,.F.);+ #1=TEST_ENTITY((#2,#3),($,.T.,*),(),.UNSPECIFIED.,.POSITIVE.,.F.,'O''Brien','\X2\03A9\X0\');#2=ITEM();#3=ITEM();ENDSEC;""";- var result = Step242SubsetParser.Parse(text);+ var result = Step242Importer.ImportBody(text);- Assert.True(result.IsSuccess, string.Join(" | ", result.Diagnostics.Select(d => d.Message)));- var entity = result.Value.Entities.Single(e => e.Id == 1);-- var group = Assert.IsType<Step242ListValue>(entity.Arguments[1]);- Assert.Equal(3, group.Items.Count);- Assert.IsType<Step242OmittedValue>(group.Items[0]);- Assert.True(Assert.IsType<Step242BooleanValue>(group.Items[1]).Value);- Assert.IsType<Step242OmittedValue>(group.Items[2]);-- Assert.Equal("UNSPECIFIED", Assert.IsType<Step242EnumValue>(entity.Arguments[3]).Value);- Assert.Equal("POSITIVE", Assert.IsType<Step242EnumValue>(entity.Arguments[4]).Value);- Assert.False(Assert.IsType<Step242BooleanValue>(entity.Arguments[5]).Value);+ Assert.False(result.IsSuccess);+ Assert.NotEmpty(result.Diagnostics);+ Assert.DoesNotContain(result.Diagnostics, d => (d.Source ?? string.Empty).StartsWith("Parser", StringComparison.Ordinal));}- [Fact]- public void Parse_SupportsDoubledAndEncodedStringContentAsRaw()- {- const string text = """- DATA;- #1=ITEM('O''Brien','\X2\03A9\X0\');- ENDSEC;- """;-- var result = Step242SubsetParser.Parse(text);-- Assert.True(result.IsSuccess, string.Join(" | ", result.Diagnostics.Select(d => d.Message)));- var entity = Assert.Single(result.Value.Entities);- Assert.Equal("O'Brien", Assert.IsType<Step242StringValue>(entity.Arguments[0]).Value);- Assert.Equal("\\X2\\03A9\\X0\\", Assert.IsType<Step242StringValue>(entity.Arguments[1]).Value);- }-- [Fact]- public void Parse_FailsDeterministically_ForMalformedInputs()+ [Theory]+ [InlineData("DATA;#1=ITEM('abc);ENDSEC;")]+ [InlineData("DATA;#1=ITEM((1,2);ENDSEC;")]+ [InlineData("DATA;#1=ITEM(1E+);ENDSEC;")]+ [InlineData("DATA;#1=ITEM(#A);ENDSEC;")]+ [InlineData("DATA;#1=ITEM(.BAD);ENDSEC;")]+ [InlineData("DATA;#1=ITEM();#1=OTHER();ENDSEC;")]+ public void ImportBody_FailsInParserDeterministically_ForMalformedInputs(string text){- var cases = new Dictionary<string, string>- {- ["unterminated-string"] = "DATA;#1=ITEM('abc);ENDSEC;",- ["unbalanced-parens"] = "DATA;#1=ITEM((1,2);ENDSEC;",- ["bad-exponent"] = "DATA;#1=ITEM(1E+);ENDSEC;",- ["duplicate-id"] = "DATA;#1=ITEM();#1=OTHER();ENDSEC;",- ["ref-non-int"] = "DATA;#1=ITEM(#A);ENDSEC;",- ["malformed-enum"] = "DATA;#1=ITEM(.BAD);ENDSEC;"- };+ var result = Step242Importer.ImportBody(text);- foreach (var (name, text) in cases)- {- var result = Step242SubsetParser.Parse(text);- Assert.False(result.IsSuccess, $"Case '{name}' unexpectedly succeeded.");- Assert.NotEmpty(result.Diagnostics);- Assert.StartsWith("Parser.", result.Diagnostics[0].Source ?? string.Empty, StringComparison.Ordinal);- }+ Assert.False(result.IsSuccess);+ Assert.NotEmpty(result.Diagnostics);+ Assert.StartsWith("Parser.", result.Diagnostics[0].Source ?? string.Empty, StringComparison.Ordinal);}}diff --git a/testdata/step242/manifests/nist.v0.report.json b/testdata/step242/manifests/nist.v0.report.jsonindex e6f467e2..debf28b3 100644--- a/testdata/step242/manifests/nist.v0.report.json+++ b/testdata/step242/manifests/nist.v0.report.json@@ -200,7 +200,7 @@"firstDiagnostic": {"code": "InvalidArgument","source": "Parser.Lexer",- "messagePrefix": "Unsupported value token \u0027*\u0027. (position *)."+ "messagePrefix": "Expected identifier. (position *)."},"diagnosticCount": 1,"exceptionEscaped": false,@@ -272,7 +272,7 @@"firstDiagnostic": {"code": "InvalidArgument","source": "Parser.Lexer",- "messagePrefix": "Unsupported value token \u0027*\u0027. (position *)."+ "messagePrefix": "Expected identifier. (position *)."},"diagnosticCount": 1,"exceptionEscaped": false,@@ -392,7 +392,7 @@"firstDiagnostic": {"code": "InvalidArgument","source": "Parser.Lexer",- "messagePrefix": "Unsupported value token \u0027*\u0027. (position *)."+ "messagePrefix": "Unsupported value token \u0027L\u0027. (position *)."},"diagnosticCount": 1,"exceptionEscaped": false,