Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Correct native qualification exit status and macOS directory checks

Yuechen Lie7fcc2b151ee
diff --git a/.github/workflows/portable-release.yml b/.github/workflows/portable-release.yml
index f1fd6dc1..8df30cf5 100644
--- a/.github/workflows/portable-release.yml
+++ b/.github/workflows/portable-release.yml
@@ -6,9 +6,12 @@ on:
- '.github/workflows/portable-release.yml'
- 'scripts/package-portable.ps1'
- 'scripts/Test-PortableBundle.ps1'
+ - 'scripts/Test-ForgeHostTemplates.ps1'
- 'scripts/qualify-cadmata-browser.mts'
- 'scripts/collect-cadmata-licenses.mts'
- 'scripts/Add-PortableReleaseArtifacts.ps1'
+ - 'Aetheris.Kernel.Core.Tests/Step242/Step242NistAuditHarnessTests.cs'
+ - 'testdata/step242/manifests/**'
workflow_dispatch:
inputs:
release_tag:
diff --git a/docs/public/reference/known-issues.md b/docs/public/reference/known-issues.md
index d74f0bb0..01c24853 100644
--- a/docs/public/reference/known-issues.md
+++ b/docs/public/reference/known-issues.md
@@ -8,4 +8,5 @@
- STEP import normalizes recognized declared length units to millimetres, and the parsed document retains the conversion factor. Public engineering measurements use millimetres; imported topology does not preserve the original unit entity as an editable semantic object.
- Standard Library material resolution is qualified for Firmament FEA and authored Sheet Metal. Ordinary prismatic CAD STEP export does not yet persist a general solid-material designation; do not infer one from the geometry artifact.
- Cadmata may emit one Three.js `Clock` deprecation warning in the browser developer console. It does not affect loading, navigation, selection, PMI interaction, or model switching.
+- Canonical STEP byte hashes can differ across operating systems because recovered trim coordinates have tiny floating-point differences. Compare engineering geometry rather than using byte hashes alone for cross-platform CI comparisons; the qualified platforms retain strict separate corpus snapshots.
- Normal validation includes domain-specific engineering preflight. Swept and spline-heavy models can take seconds; parse-only validation is explicitly limited. Expansion source maps are incomplete, so some diagnostics disclose enclosing locations rather than an exact authored token.
diff --git a/scripts/Test-ForgeHostTemplates.ps1 b/scripts/Test-ForgeHostTemplates.ps1
index 19a5b05f..19a584a2 100644
--- a/scripts/Test-ForgeHostTemplates.ps1
+++ b/scripts/Test-ForgeHostTemplates.ps1
@@ -57,3 +57,6 @@ if ($invalid.success -or $invalid.artifacts.Count -ne 0 -or -not ($invalid.diagn
throw "Invalid standoff did not preserve its semantic diagnostic and artifact refusal. See $invalidLog"
}
Write-Output "Qualified $($rows.Count) public Forge templates with their declared defaults."
+# The expected negative test returned 4. Report this script's successful result,
+# rather than leaking that child exit code into its caller/CI shell.
+exit 0
diff --git a/scripts/Test-PortableBundle.ps1 b/scripts/Test-PortableBundle.ps1
index 9a4ef53e..6dbe0d61 100644
--- a/scripts/Test-PortableBundle.ps1
+++ b/scripts/Test-PortableBundle.ps1
@@ -12,7 +12,7 @@ New-Item -ItemType Directory -Path $output | Out-Null
$cli = Join-Path $bundle 'aetheris'
$metadata = Get-Content (Join-Path $bundle 'BUILD-METADATA.json') -Raw | ConvertFrom-Json
if ($metadata.modifiedSource -or $metadata.defaultPresentation -ne 'Browser') { throw 'Invalid portable source/presentation metadata.' }
-if ((Test-Path (Join-Path $bundle 'webview2')) -or (Test-Path (Join-Path $bundle 'cadmata'))) { throw 'Private browser/duplicated server in portable bundle.' }
+if ((Test-Path (Join-Path $bundle 'webview2') -PathType Container) -or (Test-Path (Join-Path $bundle 'cadmata') -PathType Container)) { throw 'Private browser/duplicated server in portable bundle.' }
$env:DOTNET_ROOT = Join-Path $output 'no-installed-dotnet'
& $cli --version
Copy-Item (Join-Path $source 'fixtures/Canonical/Features/Holes/through-hole.firmament') (Join-Path $output 'hole.firmament')