Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

AIR-V3 migrate CreateBox to rectangle extrude path

Yuechen Lif4f197fa1a36
diff --git a/Aetheris.Kernel.Core.Tests/Brep/Primitives/BrepPrimitivesTests.cs b/Aetheris.Kernel.Core.Tests/Brep/Primitives/BrepPrimitivesTests.cs
index 7f143d6a..0ef0be17 100644
--- a/Aetheris.Kernel.Core.Tests/Brep/Primitives/BrepPrimitivesTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Brep/Primitives/BrepPrimitivesTests.cs
@@ -39,6 +39,22 @@ public sealed class BrepPrimitivesTests
Assert.True(validation.IsSuccess);
}
+
+ [Theory]
+ [InlineData(10d, 10d, 10d)]
+ [InlineData(12d, 8d, 6d)]
+ public void CreateBox_RepresentativeDimensions_SucceedWithPlanarFaces(double width, double height, double depth)
+ {
+ var result = BrepPrimitives.CreateBox(width, height, depth);
+
+ Assert.True(result.IsSuccess);
+ var body = result.Value;
+ Assert.Equal(8, body.Topology.Vertices.Count());
+ Assert.Equal(12, body.Topology.Edges.Count());
+ Assert.Equal(6, body.Topology.Faces.Count());
+ Assert.Equal(6, body.Topology.Faces.Count(face => body.GetFaceSurface(face.Id).Kind == SurfaceGeometryKind.Plane));
+ }
+
[Theory]
[InlineData(0d, 1d, 1d)]
[InlineData(1d, 0d, 1d)]
diff --git a/Aetheris.Kernel.Core/Brep/BrepPrimitives.cs b/Aetheris.Kernel.Core/Brep/BrepPrimitives.cs
index 7ad11b19..762af661 100644
--- a/Aetheris.Kernel.Core/Brep/BrepPrimitives.cs
+++ b/Aetheris.Kernel.Core/Brep/BrepPrimitives.cs
@@ -144,105 +144,24 @@ public static class BrepPrimitives
{
return KernelResult<BrepBody>.Failure(diagnostics);
}
-
- var hx = width * 0.5d;
- var hy = height * 0.5d;
- var hz = depth * 0.5d;
-
- var builder = new TopologyBuilder();
-
- var vertices = new[]
- {
- builder.AddVertex(), // 1: (-x,-y,-z)
- builder.AddVertex(), // 2: (+x,-y,-z)
- builder.AddVertex(), // 3: (+x,+y,-z)
- builder.AddVertex(), // 4: (-x,+y,-z)
- builder.AddVertex(), // 5: (-x,-y,+z)
- builder.AddVertex(), // 6: (+x,-y,+z)
- builder.AddVertex(), // 7: (+x,+y,+z)
- builder.AddVertex(), // 8: (-x,+y,+z)
- };
-
- var edges = new[]
- {
- builder.AddEdge(vertices[0], vertices[1]),
- builder.AddEdge(vertices[1], vertices[2]),
- builder.AddEdge(vertices[2], vertices[3]),
- builder.AddEdge(vertices[3], vertices[0]),
- builder.AddEdge(vertices[4], vertices[5]),
- builder.AddEdge(vertices[5], vertices[6]),
- builder.AddEdge(vertices[6], vertices[7]),
- builder.AddEdge(vertices[7], vertices[4]),
- builder.AddEdge(vertices[0], vertices[4]),
- builder.AddEdge(vertices[1], vertices[5]),
- builder.AddEdge(vertices[2], vertices[6]),
- builder.AddEdge(vertices[3], vertices[7]),
- };
-
- var faces = new[]
- {
- AddFaceWithLoop(builder, [EdgeUse.Forward(edges[0]), EdgeUse.Forward(edges[1]), EdgeUse.Forward(edges[2]), EdgeUse.Forward(edges[3])]),
- AddFaceWithLoop(builder, [EdgeUse.Forward(edges[4]), EdgeUse.Forward(edges[5]), EdgeUse.Forward(edges[6]), EdgeUse.Forward(edges[7])]),
- AddFaceWithLoop(builder, [EdgeUse.Forward(edges[0]), EdgeUse.Forward(edges[9]), EdgeUse.Reversed(edges[4]), EdgeUse.Reversed(edges[8])]),
- AddFaceWithLoop(builder, [EdgeUse.Forward(edges[1]), EdgeUse.Forward(edges[10]), EdgeUse.Reversed(edges[5]), EdgeUse.Reversed(edges[9])]),
- AddFaceWithLoop(builder, [EdgeUse.Forward(edges[2]), EdgeUse.Forward(edges[11]), EdgeUse.Reversed(edges[6]), EdgeUse.Reversed(edges[10])]),
- AddFaceWithLoop(builder, [EdgeUse.Forward(edges[3]), EdgeUse.Forward(edges[8]), EdgeUse.Reversed(edges[7]), EdgeUse.Reversed(edges[11])]),
- };
-
- var shell = builder.AddShell(faces);
- builder.AddBody([shell]);
-
- var geometry = new BrepGeometryStore();
-
- var p1 = new Point3D(-hx, -hy, -hz);
- var p2 = new Point3D(hx, -hy, -hz);
- var p3 = new Point3D(hx, hy, -hz);
- var p4 = new Point3D(-hx, hy, -hz);
- var p5 = new Point3D(-hx, -hy, hz);
- var p6 = new Point3D(hx, -hy, hz);
- var p7 = new Point3D(hx, hy, hz);
- var p8 = new Point3D(-hx, hy, hz);
-
- var lineCurves = new[]
- {
- (p1, new Vector3D(width, 0d, 0d)),
- (p2, new Vector3D(0d, height, 0d)),
- (p3, new Vector3D(-width, 0d, 0d)),
- (p4, new Vector3D(0d, -height, 0d)),
- (p5, new Vector3D(width, 0d, 0d)),
- (p6, new Vector3D(0d, height, 0d)),
- (p7, new Vector3D(-width, 0d, 0d)),
- (p8, new Vector3D(0d, -height, 0d)),
- (p1, new Vector3D(0d, 0d, depth)),
- (p2, new Vector3D(0d, 0d, depth)),
- (p3, new Vector3D(0d, 0d, depth)),
- (p4, new Vector3D(0d, 0d, depth)),
- };
-
- for (var i = 0; i < lineCurves.Length; i++)
- {
- geometry.AddCurve(new CurveGeometryId(i + 1), CurveGeometry.FromLine(new Line3Curve(lineCurves[i].Item1, Direction3D.Create(lineCurves[i].Item2))));
- }
-
- geometry.AddSurface(new SurfaceGeometryId(1), SurfaceGeometry.FromPlane(new PlaneSurface(new Point3D(0d, 0d, -hz), Direction3D.Create(new Vector3D(0d, 0d, -1d)), Direction3D.Create(new Vector3D(1d, 0d, 0d)))));
- geometry.AddSurface(new SurfaceGeometryId(2), SurfaceGeometry.FromPlane(new PlaneSurface(new Point3D(0d, 0d, hz), Direction3D.Create(new Vector3D(0d, 0d, 1d)), Direction3D.Create(new Vector3D(1d, 0d, 0d)))));
- geometry.AddSurface(new SurfaceGeometryId(3), SurfaceGeometry.FromPlane(new PlaneSurface(new Point3D(0d, -hy, 0d), Direction3D.Create(new Vector3D(0d, -1d, 0d)), Direction3D.Create(new Vector3D(1d, 0d, 0d)))));
- geometry.AddSurface(new SurfaceGeometryId(4), SurfaceGeometry.FromPlane(new PlaneSurface(new Point3D(hx, 0d, 0d), Direction3D.Create(new Vector3D(1d, 0d, 0d)), Direction3D.Create(new Vector3D(0d, 1d, 0d)))));
- geometry.AddSurface(new SurfaceGeometryId(5), SurfaceGeometry.FromPlane(new PlaneSurface(new Point3D(0d, hy, 0d), Direction3D.Create(new Vector3D(0d, 1d, 0d)), Direction3D.Create(new Vector3D(-1d, 0d, 0d)))));
- geometry.AddSurface(new SurfaceGeometryId(6), SurfaceGeometry.FromPlane(new PlaneSurface(new Point3D(-hx, 0d, 0d), Direction3D.Create(new Vector3D(-1d, 0d, 0d)), Direction3D.Create(new Vector3D(0d, 1d, 0d)))));
-
- var bindings = new BrepBindingModel();
- for (var i = 0; i < edges.Length; i++)
+ var profile = PolylineProfile2D.Create(
+ [
+ new ProfilePoint2D(-width * 0.5d, -height * 0.5d),
+ new ProfilePoint2D(width * 0.5d, -height * 0.5d),
+ new ProfilePoint2D(width * 0.5d, height * 0.5d),
+ new ProfilePoint2D(-width * 0.5d, height * 0.5d),
+ ]);
+ if (!profile.IsSuccess)
{
- bindings.AddEdgeBinding(new EdgeGeometryBinding(edges[i], new CurveGeometryId(i + 1), new ParameterInterval(0d, 1d)));
+ return KernelResult<BrepBody>.Failure(profile.Diagnostics);
}
- for (var i = 0; i < faces.Length; i++)
- {
- bindings.AddFaceBinding(new FaceGeometryBinding(faces[i], new SurfaceGeometryId(i + 1)));
- }
+ var frame = new ExtrudeFrame3D(
+ new Point3D(0d, 0d, -depth * 0.5d),
+ Direction3D.Create(new Vector3D(0d, 0d, 1d)),
+ Direction3D.Create(new Vector3D(1d, 0d, 0d)));
- return ValidateAndReturn(new BrepBody(builder.Model, geometry, bindings));
+ return BrepExtrude.Create(profile.Value, frame, depth);
}
public static KernelResult<BrepBody> CreateCylinder(double radius, double height)
diff --git a/docs/air-v3-box-as-air-extrude-production.md b/docs/air-v3-box-as-air-extrude-production.md
new file mode 100644
index 00000000..bace4290
--- /dev/null
+++ b/docs/air-v3-box-as-air-extrude-production.md
@@ -0,0 +1,58 @@
+# AIR-V3 — Production Box-as-AirExtrude migration
+
+## Context and prior evidence
+
+AIR-V3 consumes prior AIR evidence directly:
+
+- AIR-X3 audit (`docs/air-x3-primitive-as-air-normalization-audit.md`) concluded primitive-as-AIR normalization is viable and recommended box as first migration candidate.
+- AIR-X4 lab (`docs/frictionlab/air-x4-box-as-air-extrude-lab.md`) validated rectangle-profile linear extrusion parity against pre-migration `CreateBox` behavior.
+
+## What changed in production
+
+`BrepPrimitives.CreateBox(width, height, depth)` is now production-routed through the same centered rectangle-profile linear extrusion path proven in AIR-X4:
+
+- build a centered rectangle profile in XY using `width` and `height`;
+- extrude along +Z from `z = -depth/2` with extent `depth`;
+- return the resulting validated BRep body.
+
+Public API signature and semantics remain unchanged.
+
+## Topology and STEP parity contract
+
+For valid dimensions, box output is required to preserve these observable parity contracts:
+
+- closed manifold BRep;
+- deterministic accepted box topology counts: 8 vertices, 12 edges, 6 faces;
+- all six faces planar;
+- STEP/AP242 smoke markers remain present: `ISO-10303-21`, `MANIFOLD_SOLID_BREP`, `ADVANCED_FACE`, `PLANE`;
+- STEP/AP242 must not contain `BREP_WITH_VOIDS` for simple boxes.
+
+AIR-V3 does not modify STEP exporter/importer behavior to achieve this parity.
+
+## Why only box migrated
+
+Box was selected as the lowest-risk first primitive because it is bounded, analytic, and already validated in AIR-X4 with deterministic parity expectations. AIR-V3 intentionally keeps migration narrow to avoid conflating primitive-specific risks.
+
+## Non-goals
+
+- No migration for cylinder, cone, sphere, or torus.
+- No generalized production AIR framework expansion beyond box routing.
+- No Boolean core behavior changes.
+- No STEP exporter/importer behavior changes.
+- No fillet/chamfer/shell or freeform surfacing work.
+
+## Tests run
+
+- `dotnet test Aetheris.Kernel.Core.Tests/Aetheris.Kernel.Core.Tests.csproj --filter "BrepPrimitives|CreateBox|Step242|Primitive|BrepBoolean|SafeComposition"`
+- `dotnet test Aetheris.FrictionLab.Tests/Aetheris.FrictionLab.Tests.csproj -c Release -f net10.0 --filter "AirBoxExtrude|AirProfileStack|ProfileStackExtrude|RecoveryPolicy|CIRLab"`
+- `dotnet test Aetheris.Kernel.Firmament.Tests/Aetheris.Kernel.Firmament.Tests.csproj --filter "FirmamentPrimitive|FirmamentStepExporter|SemanticRecovery|FrepMaterializer|Rematerialize"`
+- `./scripts/test-all.sh`
+
+## Known limitations
+
+- AIR-V3 validates only centered canonical box construction path for production routing.
+- Broader primitive-as-AIR normalization still requires primitive-specific parity lanes.
+
+## Next recommended milestone
+
+Proceed to the next bounded primitive candidate only after introducing an equivalent pre-migration evidence lane and parity contract (topology + STEP smoke) for that primitive.
diff --git a/docs/frictionlab/air-x4-box-as-air-extrude-lab.md b/docs/frictionlab/air-x4-box-as-air-extrude-lab.md
index 1109795b..da22e964 100644
--- a/docs/frictionlab/air-x4-box-as-air-extrude-lab.md
+++ b/docs/frictionlab/air-x4-box-as-air-extrude-lab.md
@@ -7,7 +7,9 @@ AIR-X4 introduces a **lab-only** evidence lane that compares:
1. baseline `BrepPrimitives.CreateBox(width, depth, height)` behavior, and
2. an AIR-style rectangle-profile linear extrusion built with existing `BrepExtrude` helpers.
-No production primitive routing is changed in this milestone.
+No production primitive routing is changed in AIR-X4 itself.
+
+> Postscript (AIR-V3): AIR-V3 consumed this evidence and migrated `BrepPrimitives.CreateBox` to the rectangle-profile extrude path in production.
## AIR-X3 reference
@@ -74,11 +76,11 @@ Per case recommendation is one of:
- `box-air-extrude-ready-for-production-migration`, or
- `box-air-extrude-needs-emitter-parity-work`.
-AIR-X4 remains lab-only; no production migration is performed here.
+AIR-X4 remained lab-only at execution time; AIR-V3 later consumed this lane for production migration.
## Explicit non-goals
-- no production migration of `BrepPrimitives.CreateBox`
+- no production migration is implemented inside AIR-X4 deliverables (migration occurs later in AIR-V3)
- no cylinder/cone/sphere/torus primitive-as-AIR expansion
- no STEP exporter/importer changes
- no Boolean core changes