Skip to content

The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu

fix(endpoint): skip updater repair for non-package installs

shukieshah08ec4c56ae97
diff --git a/cli/beacon/internal/endpoint/lifecycle/lifecycle.go b/cli/beacon/internal/endpoint/lifecycle/lifecycle.go
index c778c78a..6ef5e4e8 100644
--- a/cli/beacon/internal/endpoint/lifecycle/lifecycle.go
+++ b/cli/beacon/internal/endpoint/lifecycle/lifecycle.go
@@ -26,6 +26,7 @@ var (
writeCollectorConfig = endpointcollector.WriteConfig
saveEndpointConfig = endpointconfig.Save
appendInstallEvent = writer.AppendEvent
+ detectUpdaterInstall = selfupdate.DetectInstall
removeUpdaterJob = func() {
updater := service.UpdaterManager{}
_ = updater.Unload()
@@ -306,6 +307,9 @@ func Repair(opts InstallOptions) (InstallResult, error) {
}
func reconcileUpdaterFromConfig(logPath string) error {
+ if !detectUpdaterInstall().SupportsSeamlessUpdate() {
+ return nil
+ }
localMode := ""
if mode, err := autoUpdateModeFromConfigFile(endpointconfig.ConfigPath(false)); err == nil {
localMode = mode
diff --git a/cli/beacon/internal/endpoint/lifecycle/lifecycle_test.go b/cli/beacon/internal/endpoint/lifecycle/lifecycle_test.go
index 4200c585..ca8aac1f 100644
--- a/cli/beacon/internal/endpoint/lifecycle/lifecycle_test.go
+++ b/cli/beacon/internal/endpoint/lifecycle/lifecycle_test.go
@@ -16,6 +16,7 @@ import (
endpointconfig "github.com/asymptote-labs/agent-beacon/cli/beacon/internal/endpoint/config"
"github.com/asymptote-labs/agent-beacon/cli/beacon/internal/endpoint/harness"
"github.com/asymptote-labs/agent-beacon/cli/beacon/internal/endpoint/schema"
+ "github.com/asymptote-labs/agent-beacon/cli/beacon/internal/endpoint/selfupdate"
"github.com/asymptote-labs/agent-beacon/cli/beacon/internal/endpoint/service"
"github.com/asymptote-labs/agent-beacon/cli/beacon/internal/endpoint/writer"
)
@@ -347,6 +348,17 @@ func TestAutoUpdateModeFromConfigFileIgnoresDestinationValidation(t *testing.T)
}
}
+func TestReconcileUpdaterSkipsNonPackageInstalls(t *testing.T) {
+ oldDetect := detectUpdaterInstall
+ t.Cleanup(func() { detectUpdaterInstall = oldDetect })
+ detectUpdaterInstall = func() selfupdate.Install {
+ return selfupdate.Install{Kind: selfupdate.InstallHomebrew, BinaryPath: "/opt/homebrew/bin/beacon"}
+ }
+ if err := reconcileUpdaterFromConfig(filepath.Join(t.TempDir(), "runtime.jsonl")); err != nil {
+ t.Fatalf("reconcileUpdaterFromConfig should ignore non-package install, got %v", err)
+ }
+}
+
func TestDiscoverAndRestoreBackups(t *testing.T) {
dir := t.TempDir()
target := filepath.Join(dir, "settings.json")