The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu
Go agent-ai-cliagent-harnessesagent-securitybrowser-extensionciclaude-codecloudcodexcursordetection-engineeringjevknowledge-basememorymobile-device-managementobservabilitysecuritysecurity-information-and-event-managementsecurity-toolstelemetrytraces
Address CI session review comments
shukieshah276382692aa4
diff --git a/action.yml b/action.ymlindex e4344d7e..549ee0eb 100644--- a/action.yml+++ b/action.yml@@ -161,7 +161,7 @@ runs:shell: bashrun: |set -euo pipefail- log_dir="${RUNNER_TEMP:-$(mktemp -d)}/beacon"+ log_dir="${BEACON_CI_BASE_DIR:-${RUNNER_TEMP:-$(mktemp -d)}/beacon}"mkdir -p "${log_dir}"echo "base-dir=${log_dir}" >> "$GITHUB_OUTPUT"echo "log-path=${log_dir}/runtime.jsonl" >> "$GITHUB_OUTPUT"diff --git a/cli/beacon/cmd/ci.go b/cli/beacon/cmd/ci.goindex c85458fa..6de5af53 100644--- a/cli/beacon/cmd/ci.go+++ b/cli/beacon/cmd/ci.go@@ -306,7 +306,7 @@ func uploadTargets(results []beaconci.UploadResult) string {return strings.Join(targets, ",")}-func writeGitHubEnv(path string, values map[string]string) error {+func writeGitHubEnv(path string, values map[string]string) (err error) {if strings.TrimSpace(path) == "" {path = os.Getenv("GITHUB_ENV")}@@ -317,7 +317,11 @@ func writeGitHubEnv(path string, values map[string]string) error {if err != nil {return err}- defer file.Close()+ defer func() {+ if closeErr := file.Close(); err == nil && closeErr != nil {+ err = closeErr+ }+ }()for key, value := range values {if strings.TrimSpace(key) == "" {continuediff --git a/cli/beacon/internal/ci/session.go b/cli/beacon/internal/ci/session.goindex cae8392a..7102f26b 100644--- a/cli/beacon/internal/ci/session.go+++ b/cli/beacon/internal/ci/session.go@@ -305,7 +305,21 @@ func (s *Session) StopDetached(ctx context.Context) error {return err}if runtime.GOOS == "windows" {- return nil+ done := make(chan error, 1)+ go func() {+ _, err := process.Wait()+ done <- err+ }()+ select {+ case err := <-done:+ if err != nil && !isExpectedStopError(err) {+ return err+ }+ return nil+ case <-ctx.Done():+ _ = process.Kill()+ return ctx.Err()+ }}ticker := time.NewTicker(100 * time.Millisecond)defer ticker.Stop()