Skip to content

The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu

sysacl: a reader refused the lock goes on checking the rest of the log directory

Claude2dad61e357bd
diff --git a/cli/beacon/internal/endpoint/sysacl/restricted_windows.go b/cli/beacon/internal/endpoint/sysacl/restricted_windows.go
index 1f778c25..e48b8260 100644
--- a/cli/beacon/internal/endpoint/sysacl/restricted_windows.go
+++ b/cli/beacon/internal/endpoint/sysacl/restricted_windows.go
@@ -144,10 +144,17 @@ func InspectRestrictedLogDir(dir, base, readersSID string) ([]string, error) {
// Every entry, not only the log family, for the reason SecureRestrictedLogDir resets them all.
for _, entry := range entries {
child := filepath.Join(dir, entry.Name())
+ lock := strings.EqualFold(entry.Name(), base+".lock")
fobj, link, err := readObject(child)
if errors.Is(err, fs.ErrNotExist) {
continue
}
+ // The lock is closed to the readers group, so a reader who runs doctor is refused it while
+ // the rest of the directory is open to them. That refusal is the lock's ACL being right,
+ // not a reason to stop checking what this account can see.
+ if lock && errors.Is(err, fs.ErrPermission) {
+ continue
+ }
if err != nil {
return problems, err
}
@@ -155,7 +162,6 @@ func InspectRestrictedLogDir(dir, base, readersSID string) ([]string, error) {
problems = append(problems, child+" is a link, so writes to it land wherever it points")
continue
}
- lock := strings.EqualFold(entry.Name(), base+".lock")
for _, p := range RestrictedProblems(fobj, readersSID, lock) {
problems = append(problems, child+": "+p)
}