The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu
Go agent-ai-cliagent-harnessesagent-securitybrowser-extensionciclaude-codecloudcodexcursordetection-engineeringjevknowledge-basememorymobile-device-managementobservabilitysecuritysecurity-information-and-event-managementsecurity-toolstelemetrytraces
fix(sdk): end async stream spans when consumption stops early (#829)
Rudy Mizrahi Celekli31f90cfeaa7e
diff --git a/packages/asymptote-sdk-js/src/index.test.ts b/packages/asymptote-sdk-js/src/index.test.tsindex d493d939..ee31437f 100644--- a/packages/asymptote-sdk-js/src/index.test.ts+++ b/packages/asymptote-sdk-js/src/index.test.ts@@ -432,6 +432,19 @@ describe("Asymptote Observe SDK", () => {expect(exporter.getFinishedSpans()[0]?.status.code).toBe(SpanStatusCode.ERROR);});+ it("ends async iterable spans when the caller stops consumption early", async () => {+ const exporter = new InMemorySpanExporter();+ initialize({ spanExporter: exporter, disableDefaultExporter: true, disableBatch: true });+ let cleaned = false;+ const query = wrapClaudeAgentQuery(async function* () {+ try { yield { type: "first" }; yield { type: "second" }; }+ finally { cleaned = true; }+ });+ for await (const _message of query()) { break; }+ await flush();+ expect(cleaned).toBe(true);+ expect(exporter.getFinishedSpans()).toHaveLength(1);+ });it("provides a tracer compatible with Vercel-style telemetry hooks", async () => {const exporter = new InMemorySpanExporter();initialize({ spanExporter: exporter, disableDefaultExporter: true, disableBatch: true });diff --git a/packages/asymptote-sdk-js/src/index.ts b/packages/asymptote-sdk-js/src/index.tsindex f0e0c73d..28e556ef 100644--- a/packages/asymptote-sdk-js/src/index.ts+++ b/packages/asymptote-sdk-js/src/index.ts@@ -598,15 +598,20 @@ function finishResult<T>(result: T, span: Span, options?: ObserveOptions): unkno}async function* finishAsyncIterable(iterable: AsyncIterable<unknown>, span: Span): AsyncGenerator<unknown> {+ let endedWithError = false;try {for await (const item of iterable) {yield item;}span.setStatus({ code: SpanStatusCode.OK });- span.end();} catch (error) {+ endedWithError = true;endSpanWithError(span, error);throw error;+ } finally {+ // A consumer that breaks out early reaches only this block (via return()); end the span here+ // with its status unset, since the stream neither completed nor failed.+ if (!endedWithError) span.end();}}