Skip to content

The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu

Fix ListFilters to scan all matching events for accurate facets

Cursor Agent5bc98407ac1e
diff --git a/cli/beacon/internal/endpoint/activity/activity.go b/cli/beacon/internal/endpoint/activity/activity.go
index da50a6f6..3bc5050e 100644
--- a/cli/beacon/internal/endpoint/activity/activity.go
+++ b/cli/beacon/internal/endpoint/activity/activity.go
@@ -221,10 +221,7 @@ func GetEvent(logPath, id string) (EventResult, error) {
}
func ListFilters(query Query) (FilterValuesResult, error) {
- if query.Limit == 0 {
- query.Limit = 2000
- }
- result, err := read(query)
+ result, err := readAll(query)
if err != nil {
return FilterValuesResult{}, err
}
@@ -296,6 +293,33 @@ func InspectLog(logPath string) (sampledEvents, malformedLines int, archives []s
return len(result.Events), result.MalformedLines, archives, nil
}
+func readAll(query Query) (dashboard.EventResult, error) {
+ if query.LogPath == "" {
+ return dashboard.EventResult{}, fmt.Errorf("runtime log path is required")
+ }
+ return dashboard.ReadEvents(query.LogPath, dashboard.EventQuery{
+ NoLimit: true,
+ Since: query.Since,
+ Until: query.Until,
+ Q: query.Q,
+ Harness: query.Harness,
+ Model: query.Model,
+ Action: query.Action,
+ Severity: query.Severity,
+ Category: query.Category,
+ Repository: query.Repository,
+ Session: query.Session,
+ File: query.File,
+ Command: query.Command,
+ MCP: query.MCP,
+ Approval: query.Approval,
+ Decision: query.Decision,
+ Policy: query.Policy,
+ Review: query.Review,
+ WazuhLevel: query.WazuhLevel,
+ })
+}
+
func read(query Query) (dashboard.EventResult, error) {
if query.LogPath == "" {
return dashboard.EventResult{}, fmt.Errorf("runtime log path is required")
diff --git a/cli/beacon/internal/endpoint/dashboard/events.go b/cli/beacon/internal/endpoint/dashboard/events.go
index c379383c..5fed6fc2 100644
--- a/cli/beacon/internal/endpoint/dashboard/events.go
+++ b/cli/beacon/internal/endpoint/dashboard/events.go
@@ -31,6 +31,7 @@ type EventRecord struct {
type EventQuery struct {
Limit int
+ NoLimit bool
Since time.Time
Until time.Time
Q string
@@ -121,14 +122,16 @@ func readEventsFromSource(source eventSource, query EventQuery, result *EventRes
}
result.TotalMatched++
result.Events = append(result.Events, record)
- sort.SliceStable(result.Events, func(i, j int) bool {
- if result.Events[i].Parsed.Equal(result.Events[j].Parsed) {
- return result.Events[i].ID > result.Events[j].ID
+ if !query.NoLimit {
+ sort.SliceStable(result.Events, func(i, j int) bool {
+ if result.Events[i].Parsed.Equal(result.Events[j].Parsed) {
+ return result.Events[i].ID > result.Events[j].ID
+ }
+ return result.Events[i].Parsed.After(result.Events[j].Parsed)
+ })
+ if len(result.Events) > limit {
+ result.Events = result.Events[:limit]
}
- return result.Events[i].Parsed.After(result.Events[j].Parsed)
- })
- if len(result.Events) > limit {
- result.Events = result.Events[:limit]
}
}
if err := scanner.Err(); err != nil {