Skip to content

The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu

fix(inventory): list skills named build, dist, vendor, tmp or temp (#1074)

Rudy Mizrahi Celekli781a977f89dd
diff --git a/cli/beacon/internal/endpoint/inventory/inventory_test.go b/cli/beacon/internal/endpoint/inventory/inventory_test.go
index 0993a992..3d7e2740 100644
--- a/cli/beacon/internal/endpoint/inventory/inventory_test.go
+++ b/cli/beacon/internal/endpoint/inventory/inventory_test.go
@@ -828,6 +828,30 @@ func TestSkillScanIsBoundedToDirectSkillManifests(t *testing.T) {
}
}
+// A skill is any direct child with a SKILL.md, whatever its name: the runtime loads a skill called
+// build as readily as one called deploy.
+func TestSkillScanKeepsSkillsNamedLikeBuildDirectories(t *testing.T) {
+ home := t.TempDir()
+ work := t.TempDir()
+ names := []string{"build", "dist", "vendor", "tmp", "temp"}
+ for _, name := range names {
+ writeFile(t, filepath.Join(home, ".claude", "skills", name, "SKILL.md"), "# "+name)
+ }
+
+ result := Scan(Options{
+ HomeDir: home,
+ WorkingDir: work,
+ Runtimes: []string{"claude_code"},
+ Now: fixedNow,
+ })
+
+ for _, name := range names {
+ if findSkill(result.Skills, "claude_code", name, filepath.Join(home, ".claude", "skills", name, "SKILL.md")) == nil {
+ t.Errorf("Claude Code skill %q not found", name)
+ }
+ }
+}
+
func TestSkillScanFollowsSymlinkedSkillDirectories(t *testing.T) {
home := t.TempDir()
work := t.TempDir()
diff --git a/cli/beacon/internal/endpoint/inventory/skills.go b/cli/beacon/internal/endpoint/inventory/skills.go
index 0b70f33f..620e0b9e 100644
--- a/cli/beacon/internal/endpoint/inventory/skills.go
+++ b/cli/beacon/internal/endpoint/inventory/skills.go
@@ -130,9 +130,6 @@ func inspectSkillRoot(root skillRoot, redaction string, co contentOptions) []Ski
if len(skills) >= maxSkillsPerRoot {
break
}
- if skipSkillDir(entry.Name()) {
- continue
- }
if !entry.IsDir() && entry.Type()&os.ModeSymlink == 0 {
continue
}
@@ -191,15 +188,6 @@ func inspectSkillManifest(root skillRoot, name, manifestPath, redaction string,
return skill
}
-func skipSkillDir(name string) bool {
- switch name {
- case ".git", "node_modules", "vendor", "dist", "build", "tmp", "temp":
- return true
- default:
- return false
- }
-}
-
func dedupeSkills(skills []Skill) []Skill {
seen := map[string]bool{}
out := make([]Skill, 0, len(skills))