Skip to content

The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu

Fix metadata transform fail-open and buffer flush on privacy mode switch

Cursor Agent9d6bffece82c
diff --git a/cli/beacon/internal/endpoint/asymptote/asymptote_test.go b/cli/beacon/internal/endpoint/asymptote/asymptote_test.go
index 4ba59fe1..38acf4f7 100644
--- a/cli/beacon/internal/endpoint/asymptote/asymptote_test.go
+++ b/cli/beacon/internal/endpoint/asymptote/asymptote_test.go
@@ -214,6 +214,7 @@ func TestRenderVectorConfigSelectsMetadataOnlyTransforms(t *testing.T) {
for _, want := range []string{
`inputs = ["beacon_runtime_metadata"]`,
`inputs = ["beacon_inventory_metadata"]`,
+ `drop_on_abort = true`,
`del(event.prompt)`,
`del(event.command.output)`,
`del(event.file.diff)`,
@@ -224,6 +225,9 @@ func TestRenderVectorConfigSelectsMetadataOnlyTransforms(t *testing.T) {
t.Fatalf("metadata config missing %q:\n%s", want, got)
}
}
+ if strings.Count(got, "drop_on_abort = true") != 2 {
+ t.Fatalf("both metadata transforms must set drop_on_abort = true:\n%s", got)
+ }
if strings.Contains(got, "[sinks.asymptote_runtime]\ntype = \"http\"\ninputs = [\"beacon_runtime\"]") {
t.Fatal("runtime sink bypasses metadata transform")
}
diff --git a/cli/beacon/internal/endpoint/asymptote/connect.go b/cli/beacon/internal/endpoint/asymptote/connect.go
index 4a30cf5f..d431b5d9 100644
--- a/cli/beacon/internal/endpoint/asymptote/connect.go
+++ b/cli/beacon/internal/endpoint/asymptote/connect.go
@@ -153,6 +153,11 @@ func Connect(ctx context.Context, opts ConnectOptions) (*ConnectResult, error) {
}
result.DeviceKey = ""
dataDir := DataDir(opts.UserMode)
+ if previous != nil && previous.PrivacyMode != privacyMode {
+ if err := os.RemoveAll(dataDir); err != nil && !os.IsNotExist(err) {
+ return nil, fmt.Errorf("could not clear the buffer after a privacy mode change: %w", err)
+ }
+ }
if err := os.MkdirAll(dataDir, 0o700); err != nil {
return nil, err
}
diff --git a/cli/beacon/internal/endpoint/asymptote/connect_test.go b/cli/beacon/internal/endpoint/asymptote/connect_test.go
index 245e40f8..c85adb9a 100644
--- a/cli/beacon/internal/endpoint/asymptote/connect_test.go
+++ b/cli/beacon/internal/endpoint/asymptote/connect_test.go
@@ -536,6 +536,62 @@ func TestLoopbackIngestURLIsAcceptedEndToEnd(t *testing.T) {
}
}
+func TestConnectClearsBufferOnPrivacyModeChange(t *testing.T) {
+ home := t.TempDir()
+ t.Setenv("HOME", home)
+ isolateVectorDiscovery(t)
+ fd := newFakeDashboard(t)
+ fwd := &fakeForwarder{supported: true}
+ vector := fakeVector(t, "0.56.0", 0)
+
+ opts := connectOptions(t, fd, fwd, vector)
+ if _, err := Connect(context.Background(), opts); err != nil {
+ t.Fatal(err)
+ }
+ sentinel := filepath.Join(DataDir(true), "buffered-event")
+ if err := os.WriteFile(sentinel, []byte("old-standard-data"), 0o600); err != nil {
+ t.Fatal(err)
+ }
+
+ opts2 := connectOptions(t, fd, fwd, vector)
+ opts2.PrivacyMode = "metadata-only"
+ if _, err := Connect(context.Background(), opts2); err != nil {
+ t.Fatal(err)
+ }
+ if _, err := os.Stat(sentinel); !os.IsNotExist(err) {
+ t.Fatal("switching to metadata-only must clear the buffer directory")
+ }
+ if _, err := os.Stat(DataDir(true)); os.IsNotExist(err) {
+ t.Fatal("data directory must be recreated after clearing")
+ }
+}
+
+func TestConnectPreservesBufferWhenPrivacyModeUnchanged(t *testing.T) {
+ home := t.TempDir()
+ t.Setenv("HOME", home)
+ isolateVectorDiscovery(t)
+ fd := newFakeDashboard(t)
+ fwd := &fakeForwarder{supported: true}
+ vector := fakeVector(t, "0.56.0", 0)
+
+ opts := connectOptions(t, fd, fwd, vector)
+ if _, err := Connect(context.Background(), opts); err != nil {
+ t.Fatal(err)
+ }
+ sentinel := filepath.Join(DataDir(true), "buffered-event")
+ if err := os.WriteFile(sentinel, []byte("in-flight-data"), 0o600); err != nil {
+ t.Fatal(err)
+ }
+
+ opts2 := connectOptions(t, fd, fwd, vector)
+ if _, err := Connect(context.Background(), opts2); err != nil {
+ t.Fatal(err)
+ }
+ if _, err := os.Stat(sentinel); err != nil {
+ t.Fatal("re-connect with the same privacy mode must not clear the buffer")
+ }
+}
+
func TestDisconnectIgnoresALeftoverInstallIDFromACancelledConnect(t *testing.T) {
home := t.TempDir()
t.Setenv("HOME", home)
diff --git a/cli/beacon/internal/endpoint/asymptote/pack/metadata-transforms.toml b/cli/beacon/internal/endpoint/asymptote/pack/metadata-transforms.toml
index 489444d8..c45283f3 100644
--- a/cli/beacon/internal/endpoint/asymptote/pack/metadata-transforms.toml
+++ b/cli/beacon/internal/endpoint/asymptote/pack/metadata-transforms.toml
@@ -1,6 +1,7 @@
[transforms.beacon_runtime_metadata]
type = "remap"
inputs = ["beacon_runtime"]
+drop_on_abort = true
source = '''
event = parse_json!(string!(.message))
del(event.prompt)
@@ -23,6 +24,7 @@ if is_object(event.content) {
[transforms.beacon_inventory_metadata]
type = "remap"
inputs = ["beacon_inventory"]
+drop_on_abort = true
source = '''
event = parse_json!(string!(.message))
if is_array(event.raw.inventory.configs) {