The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu
Go agent-ai-cliagent-harnessesagent-securitybrowser-extensionciclaude-codecloudcodexcursordetection-engineeringjevknowledge-basememorymobile-device-managementobservabilitysecuritysecurity-information-and-event-managementsecurity-toolstelemetrytraces
release-extension: keep a release only when all four files are attached
shukieshaha8050de86b81
diff --git a/.github/workflows/release-extension.yml b/.github/workflows/release-extension.ymlindex 8712c3c6..db2bf83f 100644--- a/.github/workflows/release-extension.yml+++ b/.github/workflows/release-extension.yml@@ -322,15 +322,22 @@ jobs:fi# A re-run rebuilds the zip with new file times and signs different- # bytes, while the live updates.xml pins the published CRX's hash:+ # bytes, while the live updates.xml may pin the published CRX's hash:# replacing it would make Chrome refuse every install until the feed- # caught up. Once a signed build is attached, keep the published pair,- # the way the firefox job keeps an .xpi AMO already signed.+ # caught up. So a release whose four files are all attached is kept as+ # it is, the way the firefox job keeps an .xpi AMO already signed, and+ # one without its CRX gets a fresh, matching set. A CRX attached+ # without the rest (gh uploads files concurrently, so a failed run can+ # leave that) cannot be completed from a rebuild, so it stops here.# Captured first: piping into `grep -q` under pipefail can fail the# pipeline with SIGPIPE on a match and read as "not attached".assets="$(gh release view "$TAG" --repo "$REPO" --json assets --jq '.assets[].name')"- if printf '%s\n' "$assets" | grep -qxF "$CRX"; then- echo "::notice title=Signed build kept::$CRX is already attached to $TAG; the published zip and CRX are left as they are."+ attached() { printf '%s\n' "$assets" | grep -qxF "$1"; }+ if attached "$CRX" && attached "$CRX.sha256" && attached "$NAME" && attached "$NAME.sha256"; then+ echo "::notice title=Signed build kept::$TAG already has its zip, CRX and checksums; they are left as they are."+ elif attached "$CRX"; then+ echo "::error title=Partial release::$TAG has $CRX but not all of $NAME, $NAME.sha256 and $CRX.sha256. A rebuild would sign different bytes, so this run cannot complete the set. If updates.xml does not offer this version yet, delete $CRX from the release and re-run; otherwise attach the missing files from the run that built $CRX."+ exit 1elsegh release upload "$TAG" "$NAME" "$NAME.sha256" "$CRX" "$CRX.sha256" \--repo "$REPO" --clobberdiff --git a/CLAUDE.md b/CLAUDE.mdindex 804d026e..ff026292 100644--- a/CLAUDE.md+++ b/CLAUDE.md@@ -678,9 +678,10 @@ without first shipping a version whose `update_url` names the new place. The jobrefuses to offer a lower version than the feed already does, so re-running an oldtag cannot roll fleets back (a failure to read the current feed fails the jobrather than skipping that check), and reads the feed back through that URL-before finishing. A re-run of a release that already has its CRX keeps the-published zip and CRX: the rebuilt zip has new file times, so a re-signed CRX-would no longer match the hash the live feed pins.+before finishing. A re-run of a release that already has its zip, CRX and both+checksums keeps them: the rebuilt zip has new file times, so a re-signed CRX+would no longer match the hash the live feed pins. A release left with its CRX+but not the rest fails the run with instructions instead of re-signing.The zip is unsigned, so its `.sha256` is its integrity check, the same posture asthe Windows MSI; Chrome checks the CRX's signature against its ID when it installs