The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu
Go agent-ai-cliagent-harnessesagent-securitybrowser-extensionciclaude-codecloudcodexcursordetection-engineeringjevknowledge-basememorymobile-device-managementobservabilitysecuritysecurity-information-and-event-managementsecurity-toolstelemetrytraces
Fix memory search limit ordering
Justin D'Souzaaba38e81ac93
diff --git a/cli/beacon/internal/learning/store.go b/cli/beacon/internal/learning/store.goindex 1d8981d4..9da5a0af 100644--- a/cli/beacon/internal/learning/store.go+++ b/cli/beacon/internal/learning/store.go@@ -430,20 +430,19 @@ func (s *Store) ListMemories(query Query) ([]asymptoteobserve.LearningMemoryV1,where += ` AND (superseded_by IS NULL OR superseded_by = '')`}hasTextFilter := strings.TrimSpace(query.Q) != ""- sql := `SELECT memory_json FROM memories` + where + ` ORDER BY updated_at DESC`- if hasTextFilter {- args = append(args, -1, offset(query))- sql += ` LIMIT ? OFFSET ?`- } else {+ sqlQuery := `SELECT memory_json FROM memories` + where + ` ORDER BY updated_at DESC`+ if !hasTextFilter {args = append(args, normalizeLimit(query.Limit), offset(query))- sql += ` LIMIT ? OFFSET ?`+ sqlQuery += ` LIMIT ? OFFSET ?`}- rows, err := db.Query(sql, args...)+ rows, err := db.Query(sqlQuery, args...)if err != nil {return nil, err}defer rows.Close()limit := normalizeLimit(query.Limit)+ skip := offset(query)+ matches := 0var out []asymptoteobserve.LearningMemoryV1for rows.Next() {var raw string@@ -458,6 +457,10 @@ func (s *Store) ListMemories(query Query) ([]asymptoteobserve.LearningMemoryV1,if !matchesText(query.Q, value.ID, value.Title, value.Body, value.Kind) {continue}+ matches+++ if matches <= skip {+ continue+ }out = append(out, value)if len(out) >= limit {break@@ -466,7 +469,10 @@ func (s *Store) ListMemories(query Query) ([]asymptoteobserve.LearningMemoryV1,out = append(out, value)}}- return out, rows.Err()+ if err := rows.Err(); err != nil {+ return nil, err+ }+ return out, nil}func (s *Store) GetMemory(id string) (asymptoteobserve.LearningMemoryV1, bool, error) {diff --git a/cli/beacon/internal/learning/store_test.go b/cli/beacon/internal/learning/store_test.goindex 387ebfa1..11e09e33 100644--- a/cli/beacon/internal/learning/store_test.go+++ b/cli/beacon/internal/learning/store_test.go@@ -184,3 +184,52 @@ func TestStoreScopesByProject(t *testing.T) {t.Fatalf("project scoped memories = %#v", memories)}}++func TestListMemoriesAppliesTextMatchBeforeLimit(t *testing.T) {+ store := Open(filepath.Join(t.TempDir(), "memory.db"))+ project := asymptoteobserve.LearningProjectV1{ID: "project-1"}+ if err := store.PutMemory(asymptoteobserve.LearningMemoryV1{+ ID: "memory-older-match",+ CandidateID: "candidate-older-match",+ Kind: asymptoteobserve.LearningMemoryKindDebuggingPattern,+ Title: "Older matching memory",+ Body: "Remember the rare unique-needle recovery step.",+ Project: project,+ }); err != nil {+ t.Fatal(err)+ }+ setMemoryUpdatedAt(t, store, "memory-older-match", "2026-01-01T00:00:00Z")+ for i := 0; i < 5; i++ {+ id := "memory-newer-" + string(rune('a'+i))+ if err := store.PutMemory(asymptoteobserve.LearningMemoryV1{+ ID: id,+ CandidateID: "candidate-" + id,+ Kind: asymptoteobserve.LearningMemoryKindConvention,+ Title: "Newer unrelated memory",+ Body: "Use the ordinary local workflow.",+ Project: project,+ }); err != nil {+ t.Fatal(err)+ }+ setMemoryUpdatedAt(t, store, id, "2026-01-02T00:00:0"+string(rune('0'+i))+"Z")+ }+ memories, err := store.ListMemories(Query{ProjectID: "project-1", Q: "unique-needle", Limit: 5})+ if err != nil {+ t.Fatalf("ListMemories: %v", err)+ }+ if len(memories) != 1 || memories[0].ID != "memory-older-match" {+ t.Fatalf("memories = %#v", memories)+ }+}++func setMemoryUpdatedAt(t *testing.T, store *Store, id, updatedAt string) {+ t.Helper()+ db, err := store.db()+ if err != nil {+ t.Fatal(err)+ }+ defer db.Close()+ if _, err := db.Exec(`UPDATE memories SET updated_at = ? WHERE id = ?`, updatedAt, id); err != nil {+ t.Fatal(err)+ }+}diff --git a/cli/beacon/internal/mcpserver/server_test.go b/cli/beacon/internal/mcpserver/server_test.goindex 66835c90..1ae33370 100644--- a/cli/beacon/internal/mcpserver/server_test.go+++ b/cli/beacon/internal/mcpserver/server_test.go@@ -2,7 +2,9 @@ package mcpserverimport ("bytes"+ "database/sql""encoding/json"+ "fmt""net/http""net/http/httptest""os"@@ -118,6 +120,67 @@ func TestMCPMemoryToolsSearchGetAndContext(t *testing.T) {}}+func TestMCPMemoryToolsSearchOlderMatchesBeforeLimit(t *testing.T) {+ logPath := filepath.Join(t.TempDir(), "endpoint", "logs", "runtime.jsonl")+ if err := os.MkdirAll(filepath.Dir(logPath), 0755); err != nil {+ t.Fatal(err)+ }+ store := learning.Open(learning.PathForRuntimeLog(logPath))+ project := asymptoteobserve.LearningProjectV1{ID: "project-1"}+ if err := store.PutMemory(asymptoteobserve.LearningMemoryV1{+ ID: "memory-older-match",+ CandidateID: "candidate-older-match",+ Kind: asymptoteobserve.LearningMemoryKindDebuggingPattern,+ Title: "Older matching memory",+ Body: "Use the unique-needle recovery step when package smoke flakes.",+ Project: project,+ }); err != nil {+ t.Fatal(err)+ }+ setStoredMemoryUpdatedAt(t, store.Path(), "memory-older-match", "2026-01-01T00:00:00Z")+ for i := 0; i < 5; i++ {+ id := fmt.Sprintf("memory-newer-%d", i)+ if err := store.PutMemory(asymptoteobserve.LearningMemoryV1{+ ID: id,+ CandidateID: "candidate-" + id,+ Kind: asymptoteobserve.LearningMemoryKindConvention,+ Title: "Newer unrelated memory",+ Body: "Use the ordinary local workflow.",+ Project: project,+ }); err != nil {+ t.Fatal(err)+ }+ setStoredMemoryUpdatedAt(t, store.Path(), id, fmt.Sprintf("2026-01-02T00:00:0%dZ", i))+ }+ server := New(Options{LogPath: logPath})+ search, err := server.callTool(t.Context(), callToolParams{Name: "search_memory", Arguments: map[string]interface{}{"project_id": "project-1", "q": "unique-needle", "limit": 5}})+ if err != nil {+ t.Fatalf("search_memory: %v", err)+ }+ if !strings.Contains(search.Content[0].Text, "memory-older-match") {+ t.Fatalf("search_memory missing older match: %s", search.Content[0].Text)+ }+ context, err := server.callTool(t.Context(), callToolParams{Name: "get_memory_context", Arguments: map[string]interface{}{"project_id": "project-1", "task": "unique-needle"}})+ if err != nil {+ t.Fatalf("get_memory_context: %v", err)+ }+ if !strings.Contains(context.Content[0].Text, "memory-older-match") {+ t.Fatalf("get_memory_context missing older match: %s", context.Content[0].Text)+ }+}++func setStoredMemoryUpdatedAt(t *testing.T, dbPath, id, updatedAt string) {+ t.Helper()+ db, err := sql.Open("sqlite", "file:"+filepath.ToSlash(dbPath)+"?_pragma=busy_timeout(5000)")+ if err != nil {+ t.Fatal(err)+ }+ defer db.Close()+ if _, err := db.Exec(`UPDATE memories SET updated_at = ? WHERE id = ?`, updatedAt, id); err != nil {+ t.Fatal(err)+ }+}+func writeTestLog(t *testing.T, path string, events ...schema.Event) {t.Helper()var data []byte