The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu
Go agent-ai-cliagent-harnessesagent-securitybrowser-extensionciclaude-codecloudcodexcursordetection-engineeringjevknowledge-basememorymobile-device-managementobservabilitysecuritysecurity-information-and-event-managementsecurity-toolstelemetrytraces
fix(dashboard): keep the latest activity filter response (#826)
Rudy Mizrahi Celeklib442d258d88c
diff --git a/cli/beacon/internal/endpoint/dashboard/static/app.js b/cli/beacon/internal/endpoint/dashboard/static/app.jsindex 044fc0b2..44474773 100644--- a/cli/beacon/internal/endpoint/dashboard/static/app.js+++ b/cli/beacon/internal/endpoint/dashboard/static/app.js@@ -185,7 +185,15 @@ function updateURL(query) {window.history.replaceState(null, "", next);}+let activityLoadGeneration = 0;+let activityLoadInFlight = false;+async function load({ updateLocation = false, mode = "replace" } = {}) {+ // Do not let the poll timer continually supersede a slow local log scan.+ // Explicit filter changes still start immediately and replace the old view.+ if (mode === "poll" && activityLoadInFlight) return;+ const generation = ++activityLoadGeneration;+ activityLoadInFlight = true;const query = queryFromFilters();if (updateLocation) updateURL(query);const suffix = query ? `?${query}` : "";@@ -201,6 +209,7 @@ async function load({ updateLocation = false, mode = "replace" } = {}) {getJSON(`/api/summary${suffix}`),getJSON(`${activityPath}${suffix}`),]);+ if (generation !== activityLoadGeneration) return;const previousEvents = state.events;const previousQuery = state.currentQuery;state.status = status;@@ -216,10 +225,13 @@ async function load({ updateLocation = false, mode = "replace" } = {}) {rendered = true;}} catch (err) {- state.error = err;+ if (generation === activityLoadGeneration) state.error = err;} finally {- state.loading = false;- if (!rendered) render();+ if (generation === activityLoadGeneration) {+ activityLoadInFlight = false;+ state.loading = false;+ if (!rendered) render();+ }}}diff --git a/cli/beacon/internal/endpoint/dashboard/testdata/lens-e2e/tests/activity-request-order.spec.ts b/cli/beacon/internal/endpoint/dashboard/testdata/lens-e2e/tests/activity-request-order.spec.tsnew file mode 100644index 00000000..9efbaf6a--- /dev/null+++ b/cli/beacon/internal/endpoint/dashboard/testdata/lens-e2e/tests/activity-request-order.spec.ts@@ -0,0 +1,79 @@+import { expect, test } from '@playwright/test';++for (const staleFailure of [false, true]) {+ test(`activity keeps the latest filter after an older request ${staleFailure ? 'fails' : 'succeeds'}`, async ({ page }) => {+ let releaseOlder!: () => void;+ let observedOlder!: () => void;+ const olderStarted = new Promise<void>((resolve) => { observedOlder = resolve; });+ const olderReleased = new Promise<void>((resolve) => { releaseOlder = resolve; });+ await page.route('**/api/status', (route) => route.fulfill({ json: {} }));+ await page.route('**/api/summary?*', (route) => route.fulfill({ json: {} }));+ await page.route('**/api/sessions?*', async (route) => {+ const query = new URL(route.request().url()).searchParams.get('q');+ if (query === 'older') {+ observedOlder();+ await olderReleased;+ if (staleFailure) {+ await route.fulfill({ status: 503, json: { error: 'older request failed' } });+ return;+ }+ }+ await route.fulfill({ json: { sessions: [{ id: `session-${query || 'initial'}`, event_count: 1 }] } });+ });+ await page.goto('/');+ await expect(page.locator('#events tr')).toHaveAttribute('data-session-id', 'session-initial');+ const search = page.locator('[name="q"]');+ await search.fill('older');+ await page.locator('#filters').evaluate((form) => form.dispatchEvent(new Event('submit', { cancelable: true })));+ await olderStarted;+ await search.fill('newer');+ await page.locator('#filters').evaluate((form) => form.dispatchEvent(new Event('submit', { cancelable: true })));+ await expect(page.locator('#events tr')).toHaveAttribute('data-session-id', 'session-newer');+ // Wait for the old response and let fetch continuations render before+ // checking that neither its success nor its error replaced the new view.+ const olderSettled = page.waitForResponse((response) => {+ const url = new URL(response.url());+ return url.pathname === '/api/sessions' && url.searchParams.get('q') === 'older';+ });+ releaseOlder();+ const response = await olderSettled;+ await response.finished();+ await page.evaluate(() => new Promise<void>((resolve) => requestAnimationFrame(() => requestAnimationFrame(() => resolve()))));+ await expect(page.locator('#events tr')).toHaveAttribute('data-session-id', 'session-newer');+ await expect(search).toHaveValue('newer');+ await expect(page).toHaveURL(/q=newer/);+ await expect(page.locator('body')).not.toContainText('older request failed');+ });+}++test('polling lets an in-flight filter load finish', async ({ page }) => {+ await page.clock.install();+ let release!: () => void;+ let started!: () => void;+ const held = new Promise<void>((resolve) => { release = resolve; });+ const requested = new Promise<void>((resolve) => { started = resolve; });+ let pendingRequests = 0;+ await page.route('**/api/status', (route) => route.fulfill({ json: {} }));+ await page.route('**/api/summary?*', (route) => route.fulfill({ json: {} }));+ await page.route('**/api/sessions?*', async (route) => {+ const query = new URL(route.request().url()).searchParams.get('q');+ if (query === 'slow') {+ pendingRequests++;+ started();+ await held;+ }+ await route.fulfill({ json: { sessions: [{ id: `session-${query || 'initial'}`, event_count: 1 }] } });+ });+ await page.goto('/');+ await expect(page.locator('#events tr')).toHaveAttribute('data-session-id', 'session-initial');+ await page.locator('[name="q"]').fill('slow');+ await page.locator('#filters').evaluate((form) => form.dispatchEvent(new Event('submit', { cancelable: true })));+ await requested;+ await page.clock.runFor(30_000);+ expect(pendingRequests).toBe(1);+ release();+ await expect(page.locator('#events tr')).toHaveAttribute('data-session-id', 'session-slow');+ // Once the request finishes, the next timer tick must resume refreshing.+ await page.clock.runFor(10_000);+ await expect.poll(() => pendingRequests).toBe(2);+});