Skip to content

The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu

fix

Justin D'Souzabf0ba5569c77
diff --git a/cli/beacon/cmd/cloud_s3.go b/cli/beacon/cmd/cloud_s3.go
index 99d68b20..e6918ef6 100644
--- a/cli/beacon/cmd/cloud_s3.go
+++ b/cli/beacon/cmd/cloud_s3.go
@@ -46,7 +46,7 @@ func runCloudS3Setup(cmd *cobra.Command, args []string) error {
if err := ensureS3Bucket(cloudOpts.bucket, cloudOpts.region); err != nil {
return err
}
- if err := runAWS("aws", "s3api", "put-public-access-block", "--bucket", cloudOpts.bucket, "--public-access-block-configuration", "BlockPublicAcls=true,IgnorePublicAcls=true,BlockPublicPolicy=true,RestrictPublicBuckets=true"); err != nil {
+ if err := runAWS(s3PutPublicAccessBlockCommand(cloudOpts.bucket, cloudOpts.region)...); err != nil {
return err
}
if err := ensureIAMUser(cloudOpts.iamUser); err != nil {
@@ -82,7 +82,7 @@ func s3SetupCommands(bucket, region, prefix, iamUser string) ([][]string, error)
commands := [][]string{
{"aws", "s3api", "head-bucket", "--bucket", bucket},
s3CreateBucketCommand(bucket, region),
- {"aws", "s3api", "put-public-access-block", "--bucket", bucket, "--public-access-block-configuration", "BlockPublicAcls=true,IgnorePublicAcls=true,BlockPublicPolicy=true,RestrictPublicBuckets=true"},
+ s3PutPublicAccessBlockCommand(bucket, region),
{"aws", "iam", "get-user", "--user-name", iamUser},
{"aws", "iam", "create-user", "--user-name", iamUser},
{"aws", "iam", "put-user-policy", "--user-name", iamUser, "--policy-name", s3InlinePolicyName, "--policy-document", policy},
@@ -99,6 +99,10 @@ func s3CreateBucketCommand(bucket, region string) []string {
return args
}
+func s3PutPublicAccessBlockCommand(bucket, region string) []string {
+ return []string{"aws", "s3api", "put-public-access-block", "--bucket", bucket, "--region", region, "--public-access-block-configuration", "BlockPublicAcls=true,IgnorePublicAcls=true,BlockPublicPolicy=true,RestrictPublicBuckets=true"}
+}
+
func s3UploadPolicy(bucket, prefix string) (string, error) {
prefix = strings.Trim(prefix, "/")
resource := "arn:aws:s3:::" + bucket + "/*"
diff --git a/cli/beacon/cmd/cloud_test.go b/cli/beacon/cmd/cloud_test.go
index a7002d11..f6a39fbb 100644
--- a/cli/beacon/cmd/cloud_test.go
+++ b/cli/beacon/cmd/cloud_test.go
@@ -189,7 +189,7 @@ func TestS3SetupCommandsUseLeastPrivilegePolicy(t *testing.T) {
for _, want := range []string{
"aws s3api head-bucket --bucket bucket",
"aws s3api create-bucket --bucket bucket --region us-west-2 --create-bucket-configuration LocationConstraint=us-west-2",
- "aws s3api put-public-access-block --bucket bucket",
+ "aws s3api put-public-access-block --bucket bucket --region us-west-2",
"aws iam create-user --user-name beacon-uploader",
"aws iam put-user-policy --user-name beacon-uploader --policy-name BeaconCloudTraceUpload",
"aws iam create-access-key --user-name beacon-uploader --output json",