The cross-harness, self-improving memory layer for AI agents. Join our community: https://discord.com/invite/zdNChS2fBu
Go agent-ai-cliagent-harnessesagent-securitybrowser-extensionciclaude-codecloudcodexcursordetection-engineeringjevknowledge-basememorymobile-device-managementobservabilitysecuritysecurity-information-and-event-managementsecurity-toolstelemetrytraces
fix(sdk): preserve cancellation errors when cleanup throws synchronously (#998)
xiaoheiai4719-collabe706f24214d9
diff --git a/packages/asymptote-sdk-js/src/index.ts b/packages/asymptote-sdk-js/src/index.tsindex bc55030a..6f8f6e0b 100644--- a/packages/asymptote-sdk-js/src/index.ts+++ b/packages/asymptote-sdk-js/src/index.ts@@ -579,7 +579,11 @@ function finishResult<T>(result: T, span: Span, options?: ObserveOptions): unknooutcome = await settled;} catch (error) {// The consumer's error takes precedence over a cleanup failure.- await Promise.resolve(typeof close === "function" ? close.call(result) : undefined).catch(() => {});+ try {+ if (typeof close === "function") await close.call(result);+ } catch {+ // Cleanup can throw before returning its promise, or reject afterward.+ }endSpanWithError(span, error);throw error;}diff --git a/packages/asymptote-sdk-js/src/stream-cancellation.test.ts b/packages/asymptote-sdk-js/src/stream-cancellation.test.tsindex 0697f443..17291753 100644--- a/packages/asymptote-sdk-js/src/stream-cancellation.test.ts+++ b/packages/asymptote-sdk-js/src/stream-cancellation.test.ts@@ -2,7 +2,7 @@ import { SpanStatusCode } from "@opentelemetry/api";import { InMemorySpanExporter } from "@opentelemetry/sdk-trace-base";import { afterEach, expect, it } from "vitest";-import { flush, initialize, shutdown, wrapClaudeAgentQuery } from "./index.js";+import { flush, initialize, observe, shutdown, wrapClaudeAgentQuery } from "./index.js";afterEach(async () => { await shutdown(); });@@ -100,6 +100,32 @@ it.each([false, true])("preserves a rejected return value when cleanup rejects (expect(exporter.getFinishedSpans()[0]?.status).toEqual({ code: SpanStatusCode.ERROR, message: valueFailure.message });});+it.each(["throw", "return"])("preserves %s errors when cleanup throws synchronously before the first next", async operation => {+ const closeFailure = new Error("source close threw synchronously");+ const consumerFailure = new Error(`${operation} failed`);+ let returnCalls = 0;+ const source = {+ [Symbol.asyncIterator]() { return this; },+ async next(): Promise<IteratorResult<string>> { return { value: "message", done: false }; },+ return(_value?: unknown): Promise<IteratorResult<string>> {+ returnCalls++;+ throw closeFailure;+ },+ async throw(error?: unknown): Promise<IteratorResult<string>> { throw error; },+ };+ const exporter = new InMemorySpanExporter();+ initialize({ spanExporter: exporter, disableDefaultExporter: true, disableBatch: true, disableInstrumentations: true });+ const stream = observe({ name: "custom.iterator" }, () => source)();+ const cancellation = operation === "throw"+ ? stream.throw(consumerFailure)+ : stream.return(Promise.reject(consumerFailure));+ await expect.soft(cancellation).rejects.toBe(consumerFailure);+ expect(returnCalls).toBe(1);+ expect.soft(exporter.getFinishedSpans()).toHaveLength(1);+ expect.soft(exporter.getFinishedSpans()[0]?.status).toEqual({ code: SpanStatusCode.ERROR, message: consumerFailure.message });+ expect(await stream.next()).toEqual({ value: undefined, done: true });+});+it.each([false, true])("uses existing close semantics when source return yields (started=%s)", async started => {const { stream, exporter, counts } = queryResource(async () => ({ value: "cleanup yield", done: false }));if (started) await stream.next();