Skip to content

An always-on second brain you talk to. Voice notes in Telegram → typed, linked knowledge in your Obsidian vault. Runs 24/7 on the Claude subscription you already have.

fix(doctor): non-zero exit on a failed health report

smixsc5c56d4c7178
diff --git a/src/d_brain/services/doctor.py b/src/d_brain/services/doctor.py
index df91f00..ff6d292 100644
--- a/src/d_brain/services/doctor.py
+++ b/src/d_brain/services/doctor.py
@@ -113,6 +113,15 @@ def check_env(settings: Any) -> CheckResult:
)
+def run_cli(session: Any, *, checks: list, alert: Any) -> int:
+ """Run the checks, deliver the report, map health to an exit code —
+ upgrade.sh and the systemd OnFailure= hook key off that code."""
+ report = Doctor(session, checks=checks).run()
+ alert(report.to_telegram())
+ logger.info("doctor: ok=%s", report.ok)
+ return 0 if report.ok else 1
+
+
def main() -> None: # pragma: no cover
logging.basicConfig(level=logging.INFO)
from d_brain.config import get_settings
@@ -126,9 +135,9 @@ def main() -> None: # pragma: no cover
lambda: check_claude_version(),
lambda: check_env(settings),
]
- report = Doctor(session, checks=checks).run()
- _telegram_alerter(settings)(report.to_telegram())
- logger.info("doctor: ok=%s", report.ok)
+ raise SystemExit(
+ run_cli(session, checks=checks, alert=_telegram_alerter(settings))
+ )
if __name__ == "__main__":
diff --git a/tests/test_doctor.py b/tests/test_doctor.py
index e5afc34..879d3ef 100644
--- a/tests/test_doctor.py
+++ b/tests/test_doctor.py
@@ -54,3 +54,17 @@ def test_report_telegram_green_and_red():
red = Doctor(sess, checks=[_bad_check]).run().to_telegram()
assert "🔴" in red
assert "❌" in red
+
+
+def test_run_cli_exit_codes_follow_report():
+ # upgrade.sh and the systemd OnFailure= hook key off the exit code —
+ # a failing canary must be visible as a non-zero exit.
+ from d_brain.services.doctor import run_cli
+
+ sent = []
+ ok_sess = FakeSession(AskResult("ok", reply="DBRAIN_OK"))
+ assert run_cli(ok_sess, checks=[_ok_check], alert=sent.append) == 0
+
+ bad_sess = FakeSession(AskResult("logged_out"))
+ assert run_cli(bad_sess, checks=[], alert=sent.append) == 1
+ assert len(sent) == 2 # the telegram report goes out either way