Agent Zero AI framework
perf(sidebar-folders): reuse rendered rows during dragging
Alessandro1b2165714d25
diff --git a/plugins/_sidebar_folders/AGENTS.md b/plugins/_sidebar_folders/AGENTS.mdindex ed654001b..591aa5faf 100644--- a/plugins/_sidebar_folders/AGENTS.md+++ b/plugins/_sidebar_folders/AGENTS.md@@ -18,6 +18,7 @@- Default sorting is creation time, newest first, in both views; message activity must not reorder chats unless recent-activity sorting is explicitly selected.- Reordering folders, chats, or tasks by drag and drop automatically selects and saves manual sorting.- Neighboring folder/thread/task drops select the insertion edge that swaps their order; longer moves use the hovered row's midpoint for before/after placement.+- Drag hover reuses the rendered sections and rows; do not regroup chat families on each pointer event or republish an unchanged drop target.- Both sides of a gap share one insertion target at the following row's top edge, with a bottom edge only after the last row. Drop indicators and released drops use that same target; dragged rows do not target themselves.- Folder containers receive drops across their padding and expanded contents. Thread-list gaps resolve to the nearest thread, including the last thread's bottom edge; folder headers remain project-move targets for chats. Folder insertion markers surround the whole folder, including its workers, and clear when the drag leaves the list.- Pin state and row indicators belong to `_pin_to_top`. Each list groups pins above all project folders, including pinned **No project**, with a separator and no subtitle. Pins retain their project/color, appear only once, and return to their own folder when unpinned; project filters also apply to pins.diff --git a/plugins/_sidebar_folders/tests/test_frontend.mjs b/plugins/_sidebar_folders/tests/test_frontend.mjsindex 57593e8b4..ee99e04c4 100644--- a/plugins/_sidebar_folders/tests/test_frontend.mjs+++ b/plugins/_sidebar_folders/tests/test_frontend.mjs@@ -109,6 +109,17 @@ const event = {target: { closest: () => null },dataTransfer: { setData() {} }, currentTarget: { getBoundingClientRect: () => ({ top: 0, height: 40 }) }, clientY: 35,};+const groups = store.groups;+const renderedGroup = groups.call(store, "chat").find((group) => group.id === "beta");+store.groups = () => assert.fail("drag hover must reuse the rendered rows");+store.drag = { kind: "chat", id: "b", project: "alpha" };+store.dragOver(event, "chat", "beta", contexts[0], event.currentTarget, renderedGroup.rows);+const stableTarget = store.dropTarget;+for (let i = 0; i < 100; i++) store.dragOver(event, "chat", "beta", contexts[0], event.currentTarget, renderedGroup.rows);+assert.equal(store.dropTarget, stableTarget, "repeated hover does not republish the drop target");+store.groups = groups;+store.endDrag();+prevented = false;store.drag = { kind: "task", id: "task", project: "alpha" };store.dragOver(event, "task", "beta");assert.equal(prevented, false, "task project moves stay disallowed");diff --git a/plugins/_sidebar_folders/webui/folder-list.html b/plugins/_sidebar_folders/webui/folder-list.htmlindex 8dab8aa08..cade230e4 100644--- a/plugins/_sidebar_folders/webui/folder-list.html+++ b/plugins/_sidebar_folders/webui/folder-list.html@@ -1,19 +1,20 @@<html><head></head><body>- <div x-data class="sidebar-folder-host">+ <div x-data="{ sections: [] }" class="sidebar-folder-host"><template x-if="$store.sidebarFolders && $store.sidebarFolders.config.folder_view"><div class="sidebar-folder-host" x-effect="$store.sidebarFolders.revealSelection(kind, $store.chats.selected)"><ul class="config-list sidebar-folder-list no-scrollbar" :class="kind === 'chat' ? 'chats-config-list' : 'tasks-config-list'"+ x-effect="sections = $store.sidebarFolders.sections(kind)":aria-label="kind === 'chat' ? 'Chat folders' : 'Task folders'" @dragend="$store.sidebarFolders.endDrag()"@dragleave="if (!$el.contains($event.relatedTarget)) $store.sidebarFolders.dropTarget = null">- <template x-for="group in $store.sidebarFolders.sections(kind)" :key="group.pinned ? 'pinned' : 'project:' + group.id">+ <template x-for="group in sections" :key="group.pinned ? 'pinned' : 'project:' + group.id"><li class="sidebar-folder" :class="[group.pinned ? 'sidebar-pinned-group' : '',$store.sidebarFolders.drag?.kind === 'project' ? $store.sidebarFolders.dropClass(kind, group.id) : '',].join(' ')":data-folder-id="group.id" :data-pinned-kind="group.pinned ? kind : null"- @dragover="$store.sidebarFolders.dragOverFolder($event, kind, group)"+ @dragover="$store.sidebarFolders.dragOverFolder($event, kind, group, sections)"@drop="$store.sidebarFolders.drop($event, kind, group.id)"><template x-if="!group.pinned"><div class="sidebar-folder-row" draggable="true" x-data="{ actionsFocused: false }"@@ -52,7 +53,7 @@!group.pinned && $store.sidebar.hasRowDividerBefore(kind, item, itemIndex, group.rows) ? 'sidebar-list-divider' : '',].join(' ')" :data-folder-thread="item.id" draggable="true"@dragstart.stop="$store.sidebarFolders.startDrag($event, kind, item.id, item.project?.name || '')"- @dragover="$store.sidebarFolders.dragOver($event, kind, group.id, item)"+ @dragover="$store.sidebarFolders.dragOver($event, kind, group.id, item, $event.currentTarget, group.rows)"@drop="$store.sidebarFolders.drop($event, kind, group.id, item)"><template x-if="kind === 'chat'"><div class="sidebar-folder-host" x-data="{ get context() { return item; } }">@@ -74,7 +75,7 @@</li></template></ul>- <div class="empty-list-message" x-show="!$store.sidebarFolders.sections(kind).length">+ <div class="empty-list-message" x-show="!sections.length"><p x-text="kind === 'chat' ? 'No matching chats.' : 'No matching tasks.'"></p></div></div>diff --git a/plugins/_sidebar_folders/webui/sidebar-folders-store.js b/plugins/_sidebar_folders/webui/sidebar-folders-store.jsindex 5f20aa754..5379536ba 100644--- a/plugins/_sidebar_folders/webui/sidebar-folders-store.js+++ b/plugins/_sidebar_folders/webui/sidebar-folders-store.js@@ -352,45 +352,51 @@ export const store = createStore("sidebarFolders", {? `folder-drop-${target.side}` : "";},- dragOverFolder(event, kind, group) {+ dragOverFolder(event, kind, group, sections = null) {if (this.drag?.kind !== "project" && !event.target.closest(".sidebar-folder-row")) {const rows = [...event.currentTarget.querySelectorAll(".sidebar-folder-thread")];const row = rows.find((row) => event.clientY < row.getBoundingClientRect().bottom) || rows.at(-1);if (row) {const item = group.rows.find((item) => item.id === row.dataset.folderThread);- return this.dragOver(event, kind, group.id, item, row);+ return this.dragOver(event, kind, group.id, item, row, group.rows);}}if (group.pinned) {this.dropTarget = null;return;}- this.dragOver(event, kind, group.id);+ this.dragOver(event, kind, group.id, null, event.currentTarget, sections?.filter((section) => !section.pinned));},- dragOver(event, kind, project, item = null, element = event.currentTarget) {- this.dropTarget = null;- const drag = this.drag;- if (!drag || this.busy) return;- event.dataTransfer.dropEffect = "none";- if (drag.kind !== "project" && drag.kind !== kind) return;- if (drag.kind === "task" && project !== null && drag.project !== project) return;- if (drag.kind === "project" && item) return;- if (item && !!drag.pinned !== (project === null)) return;- if (!item && drag.kind !== "project") {- this.dropTarget = { kind, project, side: "inside" };+ dragOver(event, kind, project, item = null, element = event.currentTarget, rows = null) {+ const target = this.findDropTarget(event, kind, project, item, element, rows);+ const previous = this.dropTarget;+ if (target?.kind !== previous?.kind || target?.project !== previous?.project+ || target?.id !== previous?.id || target?.side !== previous?.side) this.dropTarget = target;+ event.dataTransfer.dropEffect = target ? "move" : "none";+ if (target) {event.preventDefault();event.stopPropagation();- event.dataTransfer.dropEffect = "move";- return;}- const rows = item+ },++ findDropTarget(event, kind, project, item, element, rows) {+ const drag = this.drag;+ if (!drag || this.busy) return null;+ if (drag.kind !== "project" && drag.kind !== kind) return null;+ if (drag.kind === "task" && project !== null && drag.project !== project) return null;+ if (drag.kind === "project" && item) return null;+ if (item && !!drag.pinned !== (project === null)) return null;+ if (!item && drag.kind !== "project") {+ return { kind, project, side: "inside" };+ }+ rows ??= item? project === null ? this.pinnedRows(kind) : this.groups(kind).find((group) => group.id === project)?.rows || []: this.groups(kind);const id = item ? item.id : project;- if (id === drag.id) return;+ if (id === drag.id) return null;const to = rows.findIndex((row) => row.id === id);- if (to < 0) return;+ if (to < 0) return null;const rect = element.getBoundingClientRect();let after = event.clientY > rect.top + rect.height / 2;if (!item || project === null || drag.project === project) {@@ -401,18 +407,15 @@ export const store = createStore("sidebarFolders", {if (drag.kind === "project") {const pinnedCount = rows.filter((row) => pins.isProjectPinned(row.id)).length;const index = to + Number(after);- if (pins.isProjectPinned(drag.id) ? index > pinnedCount : index < pinnedCount) return;+ if (pins.isProjectPinned(drag.id) ? index > pinnedCount : index < pinnedCount) return null;}// Both sides of a gap use the following row's top edge.const anchor = after && rows[to + 1] ? rows[to + 1] : rows[to];- if (anchor.id === drag.id) return;- this.dropTarget = {+ if (anchor.id === drag.id) return null;+ return {kind, project: item ? project : anchor.id, id: item ? anchor.id : undefined,side: after && !rows[to + 1] ? "after" : "before",};- event.preventDefault();- event.stopPropagation();- event.dataTransfer.dropEffect = "move";},async drop(event, kind, project, item = null) {