Skip to content

Agent Zero AI framework

Restore legacy assistant history call compatibility

Alessandro1b6fecdcb858
diff --git a/AGENTS.md b/AGENTS.md
index 95090ed9f..142eca2be 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -15,7 +15,7 @@
## Root Ownership
- `agent.py` owns `Agent`, `AgentContext`, and loop data.
-- `Agent.hist_add_ai_response` owns Responses-API state advancement: it calls `_remember_llm_result_state` internally and requires an `LLMResult` (empty for non-LLM turns like greetings or intervention progress). Callers must not invoke `_remember_llm_result_state` manually.
+- `Agent.hist_add_ai_response` owns Responses-API state advancement: it calls `_remember_llm_result_state` internally. Model turns pass an `LLMResult`; omitted results and legacy positional string IDs use the non-LLM sentinel. Callers must not invoke `_remember_llm_result_state` manually.
- `initialize.py` owns framework initialization.
- `models.py` owns model-provider configuration and LiteLLM integration.
- `run_ui.py` is the WebUI entry point.
diff --git a/agent.py b/agent.py
index e76132650..dfa55f665 100644
--- a/agent.py
+++ b/agent.py
@@ -770,8 +770,14 @@ class Agent:
@extension.extensible
def hist_add_ai_response(
- self, message: str, llm_result: LLMResult, id: str = ""
+ self, message: str, llm_result: LLMResult | str | None = None, id: str = ""
):
+ if isinstance(llm_result, str):
+ if id:
+ raise TypeError("History message ID supplied twice")
+ id, llm_result = llm_result, None
+ if llm_result is None:
+ llm_result = LLMResult.non_llm()
self.loop_data.last_response = message
content = self.parse_prompt("fw.ai_response.md", message=message)
msg = self.hist_add_message(
diff --git a/tests/test_responses_architecture.py b/tests/test_responses_architecture.py
index 87ea15264..e42bd328a 100644
--- a/tests/test_responses_architecture.py
+++ b/tests/test_responses_architecture.py
@@ -12,7 +12,7 @@ if str(PROJECT_ROOT) not in sys.path:
import models
from agent import Agent, AgentConfig, AgentContextType, LoopData
-from helpers import extract_tools, history, litellm_transport
+from helpers import extension, extract_tools, history, litellm_transport
from helpers.log import Log
from helpers.llm_result import LLMResult, result_from_metadata
from helpers.persist_chat import _collect_response_ids
@@ -75,6 +75,53 @@ def test_llm_result_missing_mode_keeps_legacy_default(data):
assert LLMResult.from_dict(data).mode == "responses"
[email protected]("call_form", [
+ "message", "legacy_id", "keyword_id", "result", "result_id", "keywords",
+])
+def test_history_response_call_compatibility_preserves_state(monkeypatch, call_form):
+ monkeypatch.setattr(extension, "call_extensions_sync", lambda *args, **kwargs: None)
+ agent = object.__new__(Agent)
+ agent.data = {}
+ agent.loop_data = LoopData()
+ agent.history = history.History(agent)
+ agent.parse_prompt = lambda template, **kwargs: kwargs["message"]
+ agent.hist_add_message = agent.history.add_message
+ remembered = []
+
+ def remember(result, message):
+ remembered.append(result)
+ Agent._remember_llm_result_state(agent, result, message)
+
+ agent._remember_llm_result_state = remember
+ result = LLMResult(response_id="resp_1", provider_model_key="test/model")
+ args, kwargs = {
+ "message": ((), {}),
+ "legacy_id": (("message_id",), {}),
+ "keyword_id": ((), {"id": "message_id"}),
+ "result": ((result,), {}),
+ "result_id": ((result, "message_id"), {}),
+ "keywords": ((), {"llm_result": result, "id": "message_id"}),
+ }[call_form]
+ message = agent.hist_add_ai_response("hello", *args, **kwargs)
+ expected = result if call_form in {"result", "result_id", "keywords"} else LLMResult.non_llm()
+ assert remembered == [expected]
+ assert result_from_metadata(message.metadata) == expected
+ assert agent.history.all_messages() == [message]
+ assert agent.loop_data.last_response == "hello"
+ if call_form not in {"message", "result"}:
+ assert message.id == "message_id"
+ state = agent.get_data(Agent.DATA_NAME_RESPONSES_STATE)
+ if expected.response_id:
+ assert state["response_ids"] == ["resp_1"]
+ assert state["history_counter"] == message.sequence
+ else:
+ assert state is None
+
+ with pytest.raises(TypeError, match="ID supplied twice"):
+ agent.hist_add_ai_response("invalid", "first", id="second")
+ assert agent.history.all_messages() == [message]
+
+
def test_llm_result_persists_only_durable_responses_metadata():
result = LLMResult.from_response(
{