Agent Zero AI framework
Skip broken symlinks in usr update backups
Alessandro29c829b389be
diff --git a/docker/run/fs/exe/self_update_manager.py b/docker/run/fs/exe/self_update_manager.pyindex 18502fa0d..f02558885 100644--- a/docker/run/fs/exe/self_update_manager.py+++ b/docker/run/fs/exe/self_update_manager.py@@ -366,6 +366,9 @@ def create_usr_backup(root_path = Path(root)for filename in files:source_file = root_path / filename+ if source_file.is_symlink() and not source_file.exists():+ logger.log(f"Skipping broken symlink during usr backup: {source_file}")+ continuearchive_name = Path("usr") / source_file.relative_to(usr_dir)archive.write(source_file, archive_name.as_posix())diff --git a/tests/test_self_update_tag_filter.py b/tests/test_self_update_tag_filter.pyindex ef1e3b0a2..a0e8ef701 100644--- a/tests/test_self_update_tag_filter.py+++ b/tests/test_self_update_tag_filter.py@@ -1,6 +1,7 @@import importlib.utilimport sysimport types+import zipfilefrom pathlib import Pathimport pytest@@ -755,6 +756,31 @@ def test_self_update_manager_queues_update_with_main_latest_defaults(monkeypatchassert captured["payload"]["tag"] == "latest"+def test_self_update_manager_usr_backup_skips_broken_symlinks(tmp_path):+ manager = load_self_update_manager()+ repo_dir = tmp_path / "repo"+ usr_dir = repo_dir / "usr"+ venv_bin = usr_dir / "workdir" / "reachy-mini-mcp" / ".venv" / "bin"+ venv_bin.mkdir(parents=True)+ (usr_dir / "settings.json").write_text('{"ok": true}\n', encoding="utf-8")+ broken_symlink = venv_bin / "python"+ broken_symlink.symlink_to("/missing/host/python")++ backup_path = manager.create_usr_backup(+ repo_dir=repo_dir,+ backup_path=str(tmp_path / "backups"),+ backup_name="usr-backup.zip",+ conflict_policy="rename",+ logger=manager.NullLogger(),+ )++ with zipfile.ZipFile(backup_path) as archive:+ names = set(archive.namelist())++ assert "usr/settings.json" in names+ assert "usr/workdir/reachy-mini-mcp/.venv/bin/python" not in names++def test_self_update_manager_latest_on_main_uses_current_major_release(monkeypatch):manager = load_self_update_manager()monkeypatch.setattr(