Skip to content

Agent Zero AI framework

Remove obsolete preset API key warning

Alessandro4b906561cd19
diff --git a/plugins/_model_config/AGENTS.md b/plugins/_model_config/AGENTS.md
index 51e7faead..33939ae95 100644
--- a/plugins/_model_config/AGENTS.md
+++ b/plugins/_model_config/AGENTS.md
@@ -19,6 +19,7 @@
- Preserve scoped plugin resolution order and fall back invalid or missing scope/chat references to `Default`.
- Project Settings `llm` payloads are owned here through the generic `helpers.projects` project extension-data hooks; keep project helper code agnostic to `_model_config` paths, presets, and inheritance rules.
- Keep provider metadata and API-key checks safe around secrets.
+- Check API-key readiness only for the effective model configuration; unused global presets must not produce Welcome-screen warnings.
- Coordinate OAuth-backed providers with `_oauth` instead of hardcoding provider-specific auth here.
- `model_config_get` exposes `model_configured` as a derived chat-model readiness flag from provider, model name, and API-key availability.
- Non-default presets may inherit omitted slots or durable tuning from `Default`, but must replace or clear per-slot `kwargs` so provider-specific extra params never leak across model providers.
diff --git a/plugins/_model_config/extensions/python/banners/_20_missing_api_key.py b/plugins/_model_config/extensions/python/banners/_20_missing_api_key.py
index cf7c589e3..7c1ef9bdf 100644
--- a/plugins/_model_config/extensions/python/banners/_20_missing_api_key.py
+++ b/plugins/_model_config/extensions/python/banners/_20_missing_api_key.py
@@ -5,7 +5,6 @@ from plugins._model_config.helpers import model_config
class MissingApiKeyCheck(Extension):
"""Check if API keys are configured for selected model providers."""
- LOCAL_PROVIDERS = {"ollama", "lm_studio", "llama_cpp", "omlx", "vllm"}
ONBOARDING_MODAL_PATH = "/plugins/_onboarding/webui/onboarding.html"
ONBOARDING_CTA_TEXT = "Start Onboarding"
@@ -27,50 +26,3 @@ class MissingApiKeyCheck(Extension):
# For programmatic clients (e.g. chat composer) reusing this banner pipeline
"missing_providers": missing_providers,
})
-
- # Check preset providers for missing API keys (warning level)
- preset_missing = []
- seen = set()
- for preset in model_config.get_presets():
- preset_name = preset.get("name", "Unnamed")
- for slot_key, slot_label, model_type in [
- ("chat", "Main", "chat"),
- ("utility", "Utility", "chat"),
- ("embedding", "Embedding", "embedding"),
- ]:
- slot = preset.get(slot_key, {})
- provider = slot.get("provider", "")
- if not provider:
- continue
- provider_lower = provider.lower()
- identity = (provider_lower, model_type)
- if (
- provider_lower in self.LOCAL_PROVIDERS
- or model_type == "embedding"
- and provider_lower in model_config.LOCAL_EMBEDDING
- or identity in seen
- ):
- continue
- if slot.get("api_key", "").strip():
- continue
- if not model_config.has_provider_api_key(
- provider_lower,
- model_type=model_type,
- ):
- seen.add(identity)
- preset_missing.append(f"{preset_name}/{slot_label} ({provider})")
-
- if preset_missing:
- preset_list = ", ".join(preset_missing)
- banners.append({
- "id": "missing-preset-api-key",
- "type": "warning",
- "priority": 90,
- "title": "Missing API Key for model presets",
- "html": f"""No API key configured for preset models: {preset_list}.<br>
- These presets will not work until you provide the required API keys.""",
- "cta_text": self.ONBOARDING_CTA_TEXT,
- "cta_action": f"open-modal:{self.ONBOARDING_MODAL_PATH}",
- "dismissible": True,
- "source": "backend"
- })
diff --git a/tests/test_model_config_api_keys.py b/tests/test_model_config_api_keys.py
index 3be694f79..6f8fba928 100644
--- a/tests/test_model_config_api_keys.py
+++ b/tests/test_model_config_api_keys.py
@@ -90,16 +90,23 @@ def test_chat_model_configured_requires_identity_and_key(monkeypatch):
@pytest.mark.asyncio
-async def test_missing_api_key_banner_exposes_missing_providers(monkeypatch):
+async def test_missing_api_key_banner_exposes_only_effective_missing_providers(monkeypatch):
from plugins._model_config.helpers import model_config
fake = [{"model_type": "Chat Model", "provider": "openai"}]
monkeypatch.setattr(model_config, "get_missing_api_key_providers", lambda: fake)
+ monkeypatch.setattr(
+ model_config,
+ "get_presets",
+ lambda: [{"name": "Efficiency", "chat": {"provider": "openrouter"}}],
+ )
+ monkeypatch.setattr(model_config, "has_provider_api_key", lambda *args, **kwargs: False)
banners = []
await missing_key_banner.MissingApiKeyCheck(agent=None).execute(
banners=banners, frontend_context={}
)
+ assert [banner["id"] for banner in banners] == ["missing-api-key"]
row = next(b for b in banners if b.get("id") == "missing-api-key")
assert row.get("missing_providers") == fake
assert row["cta_text"] == "Start Onboarding"
@@ -515,9 +522,6 @@ def test_provider_key_modes_for_local_and_ollama_cloud():
assert model_config.provider_requires_api_key("vllm") is False
assert model_config.provider_requires_api_key("other") is False
assert model_config.provider_requires_api_key("ollama_cloud") is True
- assert "llama_cpp" in missing_key_banner.MissingApiKeyCheck.LOCAL_PROVIDERS
- assert "omlx" in missing_key_banner.MissingApiKeyCheck.LOCAL_PROVIDERS
- assert "vllm" in missing_key_banner.MissingApiKeyCheck.LOCAL_PROVIDERS
def test_local_provider_defaults_are_docker_friendly():