Agent Zero AI framework
Mask runtime .env values in agent output
Alessandro55456df29443
diff --git a/helpers/secrets.py b/helpers/secrets.pyindex bc86b3512..8bd6f58f2 100644--- a/helpers/secrets.py+++ b/helpers/secrets.py@@ -7,7 +7,7 @@ from dataclasses import dataclassfrom typing import Dict, Optional, List, Literal, Set, Callable, Tuple, TYPE_CHECKINGfrom dotenv.parser import parse_streamfrom helpers.errors import RepairableException-from helpers import files+from helpers import dotenv, filesfrom helpers.extension import extensibleif TYPE_CHECKING:@@ -509,8 +509,8 @@ class SecretsManager:def get_secrets_manager(context: "AgentContext|None" = None) -> SecretsManager:from helpers import projects- # default secrets file- secret_files = [DEFAULT_SECRETS_FILE]+ # Agent-facing masking covers the secret store and runtime credentials in usr/.env.+ secret_files = [DEFAULT_SECRETS_FILE, dotenv.get_dotenv_file_path()]# use AgentContext from contextvars if no context providedif not context:@@ -542,4 +542,4 @@ def get_project_secrets_manager(project_name: str, merge_with_global: bool = Fal@extensibledef get_default_secrets_manager() -> SecretsManager:- return SecretsManager.get_instance()\ No newline at end of file+ return SecretsManager.get_instance()diff --git a/helpers/secrets.py.dox.md b/helpers/secrets.py.dox.mdindex 2824362aa..e0db5017b 100644--- a/helpers/secrets.py.dox.md+++ b/helpers/secrets.py.dox.md@@ -34,13 +34,14 @@## Runtime Contracts- Helper modules own reusable framework APIs and must preserve public callers unless all callers, tests, and docs are updated together.+- The agent-facing `get_secrets_manager` masks and unpacks values from `usr/.env`, the global `usr/secrets.env`, and the active project's `secrets.env`; `get_default_secrets_manager` remains scoped to the single writable `usr/secrets.env` file.- Update this file whenever public functions, classes, persistence behavior, path/security assumptions, side effects, or cross-module contracts change.- Observed side-effect areas: filesystem reads, filesystem writes, filesystem deletion, WebSocket state, settings/state persistence, secret handling.- Imported dependency areas include: `dataclasses`, `dotenv.parser`, `helpers`, `helpers.errors`, `helpers.extension`, `io`, `os`, `re`, `threading`, `time`, `typing`.## Key Concepts-- Important called helpers/classes observed in the source: `key.upper`, `placeholder.format`, `SecretsManager.get_instance`, `self._replace_full_values`, `self._longest_suffix_prefix`, `threading.RLock`, `join`, `files.write_file`, `self._invalidate_all_caches`, `self.load_secrets`, `self.read_secrets_raw`, `self.parse_env_lines`, `self._serialize_env_lines`, `StreamingSecretsFilter`, `re.sub`, `self.parse_env_content`, `parse_stream`, `AgentContext.current`, `projects.get_context_project_name`, `files.get_abs_path`.+- Important called helpers/classes observed in the source: `key.upper`, `placeholder.format`, `SecretsManager.get_instance`, `self._replace_full_values`, `self._longest_suffix_prefix`, `threading.RLock`, `join`, `files.write_file`, `self._invalidate_all_caches`, `self.load_secrets`, `self.read_secrets_raw`, `self.parse_env_lines`, `self._serialize_env_lines`, `StreamingSecretsFilter`, `re.sub`, `self.parse_env_content`, `parse_stream`, `AgentContext.current`, `projects.get_context_project_name`, `files.get_abs_path`, `dotenv.get_dotenv_file_path`.- Keep request/response, tool, or helper semantics documented here at the same time as source changes.## Work Guidancediff --git a/tests/test_secrets.py b/tests/test_secrets.pynew file mode 100644index 000000000..a351dfcb8--- /dev/null+++ b/tests/test_secrets.py@@ -0,0 +1,23 @@+from helpers import secrets+++class _Context:+ def get_data(self, key: str):+ return None+++def test_agent_secret_manager_masks_runtime_dotenv_values(monkeypatch):+ monkeypatch.setattr(secrets.SecretsManager, "_instances", {})+ monkeypatch.setattr(secrets.dotenv, "get_dotenv_file_path", lambda: "usr/.env")++ contents = {+ "usr/secrets.env": "PROJECT_SECRET=project-value\n",+ "usr/.env": "LLM_API_KEY=llm-secret-value\n",+ }+ monkeypatch.setattr(secrets.files, "read_file", contents.__getitem__)++ manager = secrets.get_secrets_manager(_Context())++ assert manager.mask_values("key=llm-secret-value") == (+ "key=§§secret(LLM_API_KEY)"+ )