Skip to content

Agent Zero AI framework

feat: Deduplicate and optimize memory similarity threshold (#389)

ehl0wr0ld6eeb706cb1fb
diff --git a/python/tools/knowledge_tool.py b/python/tools/knowledge_tool.py
index a90997eab..f28d26c63 100644
--- a/python/tools/knowledge_tool.py
+++ b/python/tools/knowledge_tool.py
@@ -5,8 +5,11 @@ from python.helpers.tool import Tool, Response
from python.helpers.print_style import PrintStyle
from python.helpers.errors import handle_error
from python.helpers.searxng import search as searxng
+from python.tools.memory_load import DEFAULT_THRESHOLD as DEFAULT_MEMORY_THRESHOLD
SEARCH_ENGINE_RESULTS = 10
+
+
class Knowledge(Tool):
async def execute(self, question="", **kwargs):
# Create tasks for all three search methods
@@ -66,7 +69,7 @@ class Knowledge(Tool):
async def mem_search(self, question: str):
db = await memory.Memory.get(self.agent)
docs = await db.search_similarity_threshold(
- query=question, limit=5, threshold=0.5
+ query=question, limit=5, threshold=DEFAULT_MEMORY_THRESHOLD
)
text = memory.Memory.format_docs_plain(docs)
return "\n\n".join(text)
diff --git a/python/tools/memory_delete.py b/python/tools/memory_delete.py
index a45f9c8bb..7b13935a7 100644
--- a/python/tools/memory_delete.py
+++ b/python/tools/memory_delete.py
@@ -1,12 +1,13 @@
from python.helpers.memory import Memory
from python.helpers.tool import Tool, Response
-class MemoryForget(Tool):
+
+class MemoryDelete(Tool):
async def execute(self, ids="", **kwargs):
db = await Memory.get(self.agent)
ids = [id.strip() for id in ids.split(",") if id.strip()]
dels = await db.delete_documents_by_ids(ids=ids)
- result = self.agent.read_prompt("fw.memories_deleted.md", memory_count=len(dels))
- return Response(message=result, break_loop=False)
\ No newline at end of file
+ result = self.agent.read_prompt("fw.memories_deleted.md", memory_count=len(dels))
+ return Response(message=result, break_loop=False)
diff --git a/python/tools/memory_forget.py b/python/tools/memory_forget.py
index dd97a95ec..48c012d9d 100644
--- a/python/tools/memory_forget.py
+++ b/python/tools/memory_forget.py
@@ -1,7 +1,7 @@
from python.helpers.memory import Memory
from python.helpers.tool import Tool, Response
+from python.tools.memory_load import DEFAULT_THRESHOLD
-DEFAULT_THRESHOLD = 0.75
class MemoryForget(Tool):
@@ -9,5 +9,5 @@ class MemoryForget(Tool):
db = await Memory.get(self.agent)
dels = await db.delete_documents_by_query(query=query, threshold=threshold, filter=filter)
- result = self.agent.read_prompt("fw.memories_deleted.md", memory_count=len(dels))
- return Response(message=result, break_loop=False)
\ No newline at end of file
+ result = self.agent.read_prompt("fw.memories_deleted.md", memory_count=len(dels))
+ return Response(message=result, break_loop=False)
diff --git a/python/tools/memory_load.py b/python/tools/memory_load.py
index de08459fd..5fc7d6126 100644
--- a/python/tools/memory_load.py
+++ b/python/tools/memory_load.py
@@ -1,9 +1,10 @@
from python.helpers.memory import Memory
from python.helpers.tool import Tool, Response
-DEFAULT_THRESHOLD = 0.6
+DEFAULT_THRESHOLD = 0.7
DEFAULT_LIMIT = 10
+
class MemoryLoad(Tool):
async def execute(self, query="", threshold=DEFAULT_THRESHOLD, limit=DEFAULT_LIMIT, filter="", **kwargs):
@@ -16,4 +17,4 @@ class MemoryLoad(Tool):
text = "\n\n".join(Memory.format_docs_plain(docs))
result = str(text)
- return Response(message=result, break_loop=False)
\ No newline at end of file
+ return Response(message=result, break_loop=False)
diff --git a/python/tools/memory_save.py b/python/tools/memory_save.py
index b2ae1bbdf..31f00ca29 100644
--- a/python/tools/memory_save.py
+++ b/python/tools/memory_save.py
@@ -1,8 +1,6 @@
from python.helpers.memory import Memory
from python.helpers.tool import Tool, Response
-DEFAULT_THRESHOLD = 0.5
-DEFAULT_LIMIT = 5
class MemorySave(Tool):