Agent Zero AI framework
fix(stream): tolerate partial response snapshots
Alessandro87bafe10e02c
diff --git a/extensions/python/response_stream/AGENTS.md b/extensions/python/response_stream/AGENTS.mdindex 53a42df09..5da570f6b 100644--- a/extensions/python/response_stream/AGENTS.md+++ b/extensions/python/response_stream/AGENTS.md@@ -11,6 +11,8 @@## Local Contracts- Keep streaming output synchronized with UI log items.+- Treat parsed stream snapshots as partial data; nested tool fields may be `None`+ until their values arrive.- Preserve include-alias replacement semantics where prompts/tools rely on them.- Do not expose unmasked secrets in live responses.diff --git a/extensions/python/response_stream/_10_log_from_stream.py b/extensions/python/response_stream/_10_log_from_stream.pyindex 4df102b51..91621dbe9 100644--- a/extensions/python/response_stream/_10_log_from_stream.py+++ b/extensions/python/response_stream/_10_log_from_stream.py@@ -53,20 +53,22 @@ class LogFromStream(Extension):if parsed is not None and "tool_name" in parsed and parsed["tool_name"]:kvps["step"] = f"Using {parsed['tool_name']}..." # using tool XYif parsed["tool_name"]=="code_execution_tool":- if "tool_args" in parsed and "runtime" in parsed["tool_args"]:+ tool_args = parsed.get("tool_args")+ if isinstance(tool_args, dict) and "runtime" in tool_args:length = ""- if "code" in parsed["tool_args"]:- length = f"({len(parsed['tool_args']['code'])})"+ code = tool_args.get("code")+ if isinstance(code, str):+ length = f"({len(code)})"kvps["step"] = f"Writing code... {length}"- if parsed["tool_args"]["runtime"] == "python":+ if tool_args["runtime"] == "python":kvps["step"] = f"Writing Python code... {length}"- elif parsed["tool_args"]["runtime"] == "nodejs":+ elif tool_args["runtime"] == "nodejs":kvps["step"] = f"Writing Node.js code... {length}"- elif parsed["tool_args"]["runtime"] == "terminal":+ elif tool_args["runtime"] == "terminal":kvps["step"] = f"Writing terminal command... {length}"kvps.update(parsed)# update the log item- log_item.update(heading=heading, content=text, kvps=kvps)\ No newline at end of file+ log_item.update(heading=heading, content=text, kvps=kvps)diff --git a/extensions/python/response_stream/_20_live_response.py b/extensions/python/response_stream/_20_live_response.pyindex 3d7fafb1b..f206bd98f 100644--- a/extensions/python/response_stream/_20_live_response.py+++ b/extensions/python/response_stream/_20_live_response.py@@ -21,7 +21,14 @@ class LiveResponse(Extension):try:tool_name, tool_args = extract_tools.normalize_tool_request(parsed)- if tool_name != "response" or not tool_args.get("text"):+ message = tool_args.get("text")+ if not isinstance(message, str) or not message.strip():+ message = tool_args.get("message")+ if (+ tool_name != "response"+ or not isinstance(message, str)+ or not message.strip()+ ):return # not a response# create log message and store it in loop data temporary params@@ -39,6 +46,6 @@ class LiveResponse(Extension):# update log messagelog_item = loop_data.params_temporary["log_item_response"]- log_item.update(content=tool_args["text"])+ log_item.update(content=message)except Exception as e:passdiff --git a/tests/test_plain_response_logging.py b/tests/test_plain_response_logging.pyindex 7a0d6322e..974288ccf 100644--- a/tests/test_plain_response_logging.py+++ b/tests/test_plain_response_logging.py@@ -1,11 +1,17 @@-import pytestfrom types import SimpleNamespace-from helpers.log import Log-from extensions.python.response_stream._20_live_response import LiveResponse+import pytest++from agent import LoopDatafrom extensions.python._functions.agent.Agent.hist_add_ai_response.end._10_log_plain_responses import (LogPlainResponses,)+from extensions.python.response_stream._10_log_from_stream import (+ LogFromStream as StreamLog,+)+from extensions.python.response_stream._20_live_response import LiveResponse+from helpers.dirty_json import DirtyJson+from helpers.log import Logdef _agent_with_generating_log():@@ -105,3 +111,64 @@ async def test_live_response_renders_single_action_wrapper():assert response.type == "response"assert response.content == "wrapper works"assert response.id == "msg-1"+++async def test_live_response_renders_legacy_message_argument():+ log = Log()+ generating = log.log(type="agent", id="msg-1")+ loop_data = SimpleNamespace(params_temporary={"log_item_generating": generating})+ agent = SimpleNamespace(+ context=SimpleNamespace(log=log),+ agent_name="A0",+ )++ await LiveResponse(agent=agent).execute(+ loop_data=loop_data,+ parsed={"tool_name": "response", "tool_args": {"message": "legacy works"}},+ )++ response = loop_data.params_temporary["log_item_response"]+ assert response.content == "legacy works"+ assert response.id == "msg-1"+++ ("stream", "expected_step"),+ [+ (+ '{"tool_name":"code_execution_tool","tool_args":',+ "Using code_execution_tool...",+ ),+ (+ '{"tool_name":"code_execution_tool","tool_args":'+ '{"runtime":"python","code":',+ "Writing Python code... ",+ ),+ (+ '{"tool_name":"code_execution_tool","tool_args":'+ '{"runtime":"python","code":"pri',+ "Writing Python code... (3)",+ ),+ ],+)+async def test_stream_log_tolerates_partial_tool_arguments(+ stream: str,+ expected_step: str,+):+ log = Log()+ loop_data = LoopData()+ agent = SimpleNamespace(+ context=SimpleNamespace(log=log),+ agent_name="A0",+ )++ await StreamLog(agent=agent).execute(+ loop_data=loop_data,+ text=stream,+ parsed=DirtyJson.parse_string(stream),+ )++ item = loop_data.params_temporary["log_item_generating"]+ assert item.kvps["step"] == expected_step