Agent Zero AI framework
refactor: clean up banner extensions
keyboardstaff99a2a94813f8
diff --git a/python/api/banners.py b/python/api/banners.pyindex a84f683f1..590ce3ad2 100644--- a/python/api/banners.py+++ b/python/api/banners.py@@ -1,6 +1,5 @@from python.helpers.api import ApiHandler, Request, Response-from python.helpers.extension import Extension-from python.helpers import files, extract_tools+from python.helpers.extension import call_extensionsclass GetBanners(ApiHandler):@@ -12,36 +11,12 @@ class GetBanners(ApiHandler):async def process(self, input: dict, request: Request) -> dict | Response:frontend_banners = input.get("banners", [])frontend_context = input.get("context", {})- backend_banners = await self._run_banner_extensions(frontend_context, frontend_banners)- return {"banners": backend_banners}-- async def _run_banner_extensions(self, context: dict, frontend_banners: list) -> list[dict]:- """Run all banner checks via extension point system."""++ # Banners array passed by reference - extensions append directly to itbanners = []- for cls in self._get_banner_extensions():- try:- result = await cls(agent=None).execute(context=context, frontend_banners=frontend_banners)- if result:- banners.extend(result if isinstance(result, list) else [result])- except Exception as e:- print(f"Banner check failed ({cls.__name__}): {e}")- return banners-- def _get_banner_extensions(self) -> list[type[Extension]]:- """Load banner extension classes from extensions folders."""- all_exts = []- for path in ["python/extensions/banners", "usr/extensions/banners"]:- abs_path = files.get_abs_path(path)- if files.exists(abs_path):- all_exts.extend(extract_tools.load_classes_from_folder(abs_path, "*", Extension))+ await call_extensions("banners", agent=None, banners=banners, context=frontend_context, frontend_banners=frontend_banners)- # Deduplicate by filename (usr overrides default), sort by name- unique = {}- for cls in all_exts:- file = cls.__module__.split(".")[-1]- if file not in unique:- unique[file] = cls- return sorted(unique.values(), key=lambda c: c.__module__.split(".")[-1])+ return {"banners": banners}@classmethoddef get_methods(cls) -> list[str]:diff --git a/python/extensions/banners/_10_unsecured_connection.py b/python/extensions/banners/_10_unsecured_connection.pyindex 90a40d594..c662a5cfa 100644--- a/python/extensions/banners/_10_unsecured_connection.py+++ b/python/extensions/banners/_10_unsecured_connection.py@@ -6,8 +6,7 @@ import reclass UnsecuredConnectionCheck(Extension):"""Check: non-local without credentials, or credentials over non-HTTPS."""- async def execute(self, context: dict = {}, **kwargs) -> dict | list | None:- banners = []+ async def execute(self, banners: list = [], context: dict = {}, **kwargs):hostname = context.get("hostname", "")protocol = context.get("protocol", "")@@ -42,8 +41,6 @@ class UnsecuredConnectionCheck(Extension):"dismissible": True,"source": "backend"})-- return banners if banners else Nonedef _is_localhost(self, hostname: str) -> bool:local_patterns = ["localhost", "127.0.0.1", "::1", "0.0.0.0"]diff --git a/python/extensions/banners/_20_missing_api_key.py b/python/extensions/banners/_20_missing_api_key.pyindex b0e8ed1fc..7029440f9 100644--- a/python/extensions/banners/_20_missing_api_key.py+++ b/python/extensions/banners/_20_missing_api_key.py@@ -7,7 +7,7 @@ class MissingApiKeyCheck(Extension):"""Check if API keys are configured for selected model providers."""LOCAL_PROVIDERS = ["ollama", "lm_studio"]- HUGGINGFACE_LOCAL_FOR_EMBEDDING = ["huggingface"]+ LOCAL_EMBEDDING = ["huggingface"]MODEL_TYPE_NAMES = {"chat": "Chat Model","utility": "Utility Model",@@ -15,7 +15,7 @@ class MissingApiKeyCheck(Extension):"embedding": "Embedding Model",}- async def execute(self, context: dict = {}, **kwargs) -> dict | None:+ async def execute(self, banners: list = [], context: dict = {}, **kwargs):current_settings = settings_helper.get_settings()model_providers = {"chat": current_settings.get("chat_model_provider", ""),@@ -33,7 +33,7 @@ class MissingApiKeyCheck(Extension):provider_lower = provider.lower()if provider_lower in self.LOCAL_PROVIDERS:continue- if model_type == "embedding" and provider_lower in self.HUGGINGFACE_LOCAL_FOR_EMBEDDING:+ if model_type == "embedding" and provider_lower in self.LOCAL_EMBEDDING:continueapi_key = models.get_api_key(provider_lower)@@ -44,13 +44,13 @@ class MissingApiKeyCheck(Extension):})if not missing_providers:- return None+ returnmodel_list = ", ".join(f"{p['model_type']} ({p['provider']})" for p in missing_providers)- return {+ banners.append({"id": "missing-api-key","type": "error","priority": 100,@@ -61,4 +61,4 @@ class MissingApiKeyCheck(Extension):Add your API key</a> in Settings → External Services → API Keys.""","dismissible": False,"source": "backend"- }+ })