Agent Zero AI framework
Restart browser runtime after stale context
Alessandrod37500967f8c
diff --git a/plugins/_browser/helpers/runtime.py b/plugins/_browser/helpers/runtime.pyindex ff5fc0691..3b98d4277 100644--- a/plugins/_browser/helpers/runtime.py+++ b/plugins/_browser/helpers/runtime.py@@ -658,17 +658,70 @@ class _BrowserRuntimeCore:return Path(files.get_abs_path("usr/downloads/browser"))async def ensure_started(self) -> None:- if self.context:+ if self._context_is_alive():return+ if self.context:+ await self._discard_stale_context("Browser context is stale; restarting.")if self._start_lock is None:self._start_lock = asyncio.Lock()async with self._start_lock:- if self.context:+ if self._context_is_alive():return+ if self.context:+ await self._discard_stale_context("Browser context is stale; restarting.")+ elif self.playwright and not self._closing:+ await self._stop_playwright("Browser context closed; restarting Playwright.")await self._start()+ def _context_is_alive(self) -> bool:+ if not self.context:+ return False+ try:+ pages = getattr(self.context, "pages")+ len(pages() if callable(pages) else pages)+ return True+ except AttributeError:+ # Lightweight test doubles may not model Playwright's pages property.+ return True+ except Exception:+ return False++ async def _discard_stale_context(self, message: str) -> None:+ PrintStyle.warning(message)+ self._discard_context_state()+ await self._stop_playwright("Playwright stop after Browser context loss failed")++ def _discard_context_state(self) -> None:+ for waiter in self._pending_popups:+ if not waiter.done():+ waiter.set_exception(RuntimeError("Browser context closed."))+ self._pending_popups.clear()+ self._background_popup_pages.clear()+ self.pages.clear()+ self.last_interacted_browser_id = None+ for screencast in self.screencasts.values():+ screencast.stopped = True+ screencast._drop_queued_frames()+ with contextlib.suppress(asyncio.QueueFull):+ screencast.queue.put_nowait(None)+ for task in list(screencast._ack_tasks):+ task.cancel()+ screencast._ack_tasks.clear()+ self.screencasts.clear()+ self.context = None++ async def _stop_playwright(self, warning: str) -> None:+ if not self.playwright:+ return+ try:+ await self.playwright.stop()+ except Exception as exc:+ PrintStyle.warning(f"{warning}: {exc}")+ finally:+ self.playwright = None+async def _start(self) -> None:from playwright.async_api import async_playwright@@ -711,6 +764,7 @@ class _BrowserRuntimeCore:raiseself.context.set_default_timeout(30000)self.context.set_default_navigation_timeout(30000)+ self.context.on("close", self._on_context_closed)self.context.on("page", self._on_new_page_sync)await self.context.add_init_script(self._shadow_dom_script())await self.context.add_init_script(path=str(CONTENT_HELPER_PATH))@@ -1507,6 +1561,12 @@ class _BrowserRuntimeCore:if delete_profile:shutil.rmtree(self.profile_dir, ignore_errors=True)+ def _on_context_closed(self) -> None:+ if self._closing or self.context is None:+ return+ PrintStyle.warning("Browser context closed unexpectedly; will restart on next use.")+ self._discard_context_state()+async def _reference_action(self,helper_method: str,diff --git a/tests/test_browser_agent_regressions.py b/tests/test_browser_agent_regressions.pyindex fba109ead..2140371f5 100644--- a/tests/test_browser_agent_regressions.py+++ b/tests/test_browser_agent_regressions.py@@ -1174,6 +1174,57 @@ def test_browser_runtime_removes_stale_profile_singletons(monkeypatch, tmp_path))+async def test_browser_runtime_restarts_when_cached_context_is_stale():+ starts = []+ stopped = []++ class StaleContext:+ @property+ def pages(self):+ raise RuntimeError("Target page, context or browser has been closed")++ class LiveContext:+ pages = []++ class FakePlaywright:+ async def stop(self):+ stopped.append(True)++ core = _BrowserRuntimeCore("ctx")+ core.context = StaleContext()+ core.playwright = FakePlaywright()+ core.pages[4] = browser_runtime_module.BrowserPage(id=4, page=object())+ core.last_interacted_browser_id = 4++ async def fake_start():+ starts.append(True)+ core.context = LiveContext()++ core._start = fake_start++ await core.ensure_started()++ assert starts == [True]+ assert stopped == [True]+ assert isinstance(core.context, LiveContext)+ assert core.pages == {}+ assert core.last_interacted_browser_id is None+++def test_browser_runtime_context_close_event_clears_cached_state():+ core = _BrowserRuntimeCore("ctx")+ core.context = object()+ core.pages[4] = browser_runtime_module.BrowserPage(id=4, page=object())+ core.last_interacted_browser_id = 4++ core._on_context_closed()++ assert core.context is None+ assert core.pages == {}+ assert core.last_interacted_browser_id is None++def test_browser_save_plugin_config_restarts_runtimes_on_change(monkeypatch, tmp_path):extension_dir = tmp_path / "extension"extension_dir.mkdir()