Skip to content

#1 Persistent memory for AI coding agents based on real-world benchmarks

fix: address CodeRabbit critical and major findings

Rohit Ghumare1c1870bc2441
diff --git a/src/config.ts b/src/config.ts
index 17439471..fcc6491a 100644
--- a/src/config.ts
+++ b/src/config.ts
@@ -97,25 +97,27 @@ export function getEnvVar(key: string): string | undefined {
export function loadEmbeddingConfig(): EmbeddingConfig {
const env = getMergedEnv();
+ const bm25Weight = parseFloat(env["BM25_WEIGHT"] || "0.4");
+ const vectorWeight = parseFloat(env["VECTOR_WEIGHT"] || "0.6");
return {
provider: env["EMBEDDING_PROVIDER"] || undefined,
- bm25Weight: parseFloat(env["BM25_WEIGHT"] || "0.4"),
- vectorWeight: parseFloat(env["VECTOR_WEIGHT"] || "0.6"),
+ bm25Weight: isNaN(bm25Weight) ? 0.4 : bm25Weight,
+ vectorWeight: isNaN(vectorWeight) ? 0.6 : vectorWeight,
};
}
export function detectEmbeddingProvider(
env?: Record<string, string>,
): string | null {
- const merged = getMergedEnv(env);
- const forced = merged["EMBEDDING_PROVIDER"];
+ const source = env ?? getMergedEnv();
+ const forced = source["EMBEDDING_PROVIDER"];
if (forced) return forced;
- if (merged["GEMINI_API_KEY"]) return "gemini";
- if (merged["OPENAI_API_KEY"]) return "openai";
- if (merged["VOYAGE_API_KEY"]) return "voyage";
- if (merged["COHERE_API_KEY"]) return "cohere";
- if (merged["OPENROUTER_API_KEY"]) return "openrouter";
+ if (source["GEMINI_API_KEY"]) return "gemini";
+ if (source["OPENAI_API_KEY"]) return "openai";
+ if (source["VOYAGE_API_KEY"]) return "voyage";
+ if (source["COHERE_API_KEY"]) return "cohere";
+ if (source["OPENROUTER_API_KEY"]) return "openrouter";
return null;
}
diff --git a/src/functions/auto-forget.ts b/src/functions/auto-forget.ts
index 96259026..510c51aa 100644
--- a/src/functions/auto-forget.ts
+++ b/src/functions/auto-forget.ts
@@ -38,11 +38,13 @@ export function registerAutoForgetFunction(sdk: ISdk, kv: StateKV): void {
};
const memories = await kv.list<Memory>(KV.memories);
+ const deletedIds = new Set<string>();
for (const mem of memories) {
if (mem.forgetAfter) {
const expiry = new Date(mem.forgetAfter).getTime();
if (now > expiry) {
result.ttlExpired.push(mem.id);
+ deletedIds.add(mem.id);
if (!dryRun) {
await kv.delete(KV.memories, mem.id);
}
@@ -50,7 +52,9 @@ export function registerAutoForgetFunction(sdk: ISdk, kv: StateKV): void {
}
}
- const latestMemories = memories.filter((m) => m.isLatest !== false);
+ const latestMemories = memories.filter(
+ (m) => m.isLatest !== false && !deletedIds.has(m.id),
+ );
for (let i = 0; i < latestMemories.length; i++) {
for (let j = i + 1; j < latestMemories.length; j++) {
const sim = jaccardSimilarity(
diff --git a/src/functions/evict.ts b/src/functions/evict.ts
index 4fa788a6..905a6a55 100644
--- a/src/functions/evict.ts
+++ b/src/functions/evict.ts
@@ -128,18 +128,24 @@ export function registerEvictFunction(sdk: ISdk, kv: StateKV): void {
}
const memories = await kv.list<Memory>(KV.memories).catch(() => []);
+ const evictedMemIds = new Set<string>();
for (const mem of memories) {
if (mem.forgetAfter) {
const expiry = new Date(mem.forgetAfter).getTime();
if (now > expiry) {
stats.expiredMemories++;
+ evictedMemIds.add(mem.id);
if (!dryRun) {
await kv.delete(KV.memories, mem.id).catch(() => {});
}
}
}
- if (mem.isLatest === false && mem.createdAt) {
+ if (
+ !evictedMemIds.has(mem.id) &&
+ mem.isLatest === false &&
+ mem.createdAt
+ ) {
const age = now - new Date(mem.createdAt).getTime();
if (age > cfg.lowImportanceMaxDays * MS_PER_DAY) {
stats.nonLatestMemories++;
diff --git a/src/functions/relations.ts b/src/functions/relations.ts
index 0155678c..910c9ea1 100644
--- a/src/functions/relations.ts
+++ b/src/functions/relations.ts
@@ -6,7 +6,10 @@ import { StateKV } from "../state/kv.js";
export function registerRelationsFunction(sdk: ISdk, kv: StateKV): void {
sdk.registerFunction(
- { id: "mem::relate", description: "Create a relationship between memories" },
+ {
+ id: "mem::relate",
+ description: "Create a relationship between memories",
+ },
async (data: {
sourceId: string;
targetId: string;
@@ -66,9 +69,6 @@ export function registerRelationsFunction(sdk: ISdk, kv: StateKV): void {
return { success: false, error: "memory not found" };
}
- existing.isLatest = false;
- await kv.set(KV.memories, existing.id, existing);
-
const now = new Date().toISOString();
const evolved: Memory = {
...existing,
@@ -85,6 +85,9 @@ export function registerRelationsFunction(sdk: ISdk, kv: StateKV): void {
await kv.set(KV.memories, evolved.id, evolved);
+ existing.isLatest = false;
+ await kv.set(KV.memories, existing.id, existing);
+
const relation: MemoryRelation = {
type: "supersedes",
sourceId: evolved.id,
@@ -132,7 +135,17 @@ export function registerRelationsFunction(sdk: ISdk, kv: StateKV): void {
const relatedIds = memory.relatedIds || [];
const supersedes = memory.supersedes || [];
const parentId = memory.parentId ? [memory.parentId] : [];
- const allLinks = [...new Set([...relatedIds, ...supersedes, ...parentId])];
+
+ const kvRelations = await kv
+ .list<MemoryRelation>(KV.relations)
+ .catch(() => []);
+ const kvLinked = kvRelations
+ .filter((r) => r.sourceId === current.id || r.targetId === current.id)
+ .map((r) => (r.sourceId === current.id ? r.targetId : r.sourceId));
+
+ const allLinks = [
+ ...new Set([...relatedIds, ...supersedes, ...parentId, ...kvLinked]),
+ ];
for (const nextId of allLinks) {
if (!visited.has(nextId)) {
diff --git a/src/functions/remember.ts b/src/functions/remember.ts
index 02d27592..4206d28b 100644
--- a/src/functions/remember.ts
+++ b/src/functions/remember.ts
@@ -59,7 +59,10 @@ export function registerRememberFunction(sdk: ISdk, kv: StateKV): void {
files: data.files || [],
sessionIds: [],
strength: 7,
- version: supersededId ? 2 : 1,
+ version: supersededId
+ ? (existingMemories.find((m) => m.id === supersededId)?.version ??
+ 1) + 1
+ : 1,
parentId: supersededId,
supersedes: supersededId ? [supersededId] : [],
isLatest: true,
diff --git a/src/functions/smart-search.ts b/src/functions/smart-search.ts
index eb369725..7c59c6e6 100644
--- a/src/functions/smart-search.ts
+++ b/src/functions/smart-search.ts
@@ -47,11 +47,11 @@ export function registerSmartSearchFunction(
return { mode: "expanded", results: expanded };
}
- if (!data.query) {
+ if (!data.query || typeof data.query !== "string" || !data.query.trim()) {
return { mode: "compact", results: [], error: "query is required" };
}
- const limit = data.limit ?? 20;
+ const limit = Math.max(1, Math.min(data.limit ?? 20, 100));
const hybridResults = await searchFn(data.query, limit);
const compact: CompactSearchResult[] = hybridResults.map((r) => ({
diff --git a/src/functions/timeline.ts b/src/functions/timeline.ts
index 668b650a..b3f89902 100644
--- a/src/functions/timeline.ts
+++ b/src/functions/timeline.ts
@@ -1,6 +1,10 @@
import type { ISdk } from "iii-sdk";
import { getContext } from "iii-sdk";
-import type { CompressedObservation, Session, TimelineEntry } from "../types.js";
+import type {
+ CompressedObservation,
+ Session,
+ TimelineEntry,
+} from "../types.js";
import { KV } from "../state/schema.js";
import { StateKV } from "../state/kv.js";
@@ -17,15 +21,26 @@ export function registerTimelineFunction(sdk: ISdk, kv: StateKV): void {
after?: number;
}) => {
const ctx = getContext();
- const before = data.before ?? 5;
- const after = data.after ?? 5;
+ const before = Math.max(0, Math.floor(data.before ?? 5));
+ const after = Math.max(0, Math.floor(data.after ?? 5));
+
+ if (!data.anchor || typeof data.anchor !== "string") {
+ return { entries: [], anchor: data.anchor, reason: "invalid_anchor" };
+ }
let anchorTime: number;
const isoPattern = /^\d{4}-\d{2}-\d{2}/;
if (isoPattern.test(data.anchor)) {
anchorTime = new Date(data.anchor).getTime();
+ if (isNaN(anchorTime)) {
+ return { entries: [], anchor: data.anchor, reason: "invalid_date" };
+ }
} else {
- const searchResults = await findByKeyword(kv, data.anchor, data.project);
+ const searchResults = await findByKeyword(
+ kv,
+ data.anchor,
+ data.project,
+ );
if (searchResults.length === 0) {
return { entries: [], anchor: data.anchor, reason: "no_match" };
}
@@ -118,7 +133,6 @@ async function findByKeyword(
}
return matches.sort(
- (a, b) =>
- new Date(b.timestamp).getTime() - new Date(a.timestamp).getTime(),
+ (a, b) => new Date(b.timestamp).getTime() - new Date(a.timestamp).getTime(),
);
}
diff --git a/src/index.ts b/src/index.ts
index 198619fd..897242fc 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -136,7 +136,10 @@ async function main() {
const indexPersistence = new IndexPersistence(kv, bm25Index, vectorIndex);
- const loaded = await indexPersistence.load().catch(() => null);
+ const loaded = await indexPersistence.load().catch((err) => {
+ console.warn(`[agentmemory] Failed to load persisted index:`, err);
+ return null;
+ });
if (loaded?.bm25) {
const restoredCount = loaded.bm25.size;
if (restoredCount > 0) {
@@ -147,7 +150,10 @@ async function main() {
}
if (!loaded?.bm25 || loaded.bm25.size === 0) {
- const indexCount = await rebuildIndex(kv).catch(() => 0);
+ const indexCount = await rebuildIndex(kv).catch((err) => {
+ console.warn(`[agentmemory] Failed to rebuild search index:`, err);
+ return 0;
+ });
if (indexCount > 0) {
console.log(
`[agentmemory] Search index rebuilt: ${indexCount} observations`,
diff --git a/src/state/hybrid-search.ts b/src/state/hybrid-search.ts
index 4d33b0cc..a4a61cf8 100644
--- a/src/state/hybrid-search.ts
+++ b/src/state/hybrid-search.ts
@@ -36,7 +36,21 @@ export class HybridSearch {
);
}
- const queryEmbedding = await this.embeddingProvider.embed(query);
+ let queryEmbedding: Float32Array;
+ try {
+ queryEmbedding = await this.embeddingProvider.embed(query);
+ } catch {
+ return this.enrichResults(
+ bm25Results.map((r) => ({
+ obsId: r.obsId,
+ sessionId: r.sessionId,
+ bm25Score: r.score,
+ vectorScore: 0,
+ combinedScore: r.score,
+ })),
+ limit,
+ );
+ }
const vectorResults = this.vector.search(queryEmbedding, limit * 2);
const scores = new Map<
diff --git a/src/triggers/api.ts b/src/triggers/api.ts
index 234f2cd1..518cb77c 100644
--- a/src/triggers/api.ts
+++ b/src/triggers/api.ts
@@ -411,6 +411,8 @@ export function registerApiTriggers(
sdk.registerFunction(
{ id: "api::profile" },
async (req: ApiRequest): Promise<Response> => {
+ const authErr = checkAuth(req, secret);
+ if (authErr) return authErr;
const project = req.query_params["project"] as string;
if (!project) {
return {