#1 Persistent memory for AI coding agents based on real-world benchmarks
TypeScript agentmemoryagentsaiclaudeclaudecodecodexcopilotcursorgenaiharnesshermesmemoryompopenclawopencodepi
fix: ignore unknown session end events (#1252)
zc1c520555ffc3
diff --git a/src/triggers/api.ts b/src/triggers/api.tsindex ff8261bd..09512679 100644--- a/src/triggers/api.ts+++ b/src/triggers/api.ts@@ -1000,12 +1000,23 @@ export function registerApiTriggers(body: { error: "sessionId is required and must be a non-empty string" },};}- await withKeyedLock(`obs:${sessionId}`, () =>- kv.update(KV.sessions, sessionId, [+ const endResult = await withKeyedLock(`obs:${sessionId}`, async () => {+ const session = await kv.get<Session>(KV.sessions, sessionId);+ if (!session || session.id !== sessionId) return "not_found" as const;+ if (session.status === "completed") return "already_completed" as const;++ await kv.update(KV.sessions, sessionId, [{ type: "set", path: "endedAt", value: new Date().toISOString() },{ type: "set", path: "status", value: "completed" },- ]),- );+ ]);+ return "ended" as const;+ });+ if (endResult !== "ended") {+ return {+ status_code: 200,+ body: { success: true, ended: false, reason: endResult },+ };+ }// Fan out session-stopped lifecycle (non-blocking).try {sdk.trigger({@@ -1019,7 +1030,7 @@ export function registerApiTriggers(error: err instanceof Error ? err.message : String(err),});}- return { status_code: 200, body: { success: true } };+ return { status_code: 200, body: { success: true, ended: true } };},);sdk.registerTrigger({@@ -1188,6 +1199,13 @@ export function registerApiTriggers(const authErr = checkAuth(req, secret);if (authErr) return authErr;const sessions = await kv.list<Session>(KV.sessions);+ const validSessions = sessions.filter(+ (session): session is Session =>+ !!session &&+ typeof session === "object" &&+ typeof session.id === "string" &&+ session.id.length > 0,+ );const normalizedAgentId =typeof req.query_params?.["agentId"] === "string"? req.query_params["agentId"].trim()@@ -1201,14 +1219,14 @@ export function registerApiTriggers((isAgentScopeIsolated() ? getAgentId() : undefined);const listQuery = parseListQuery(req.query_params);let filtered = filterAgentId- ? sessions.filter((s) => s.agentId === filterAgentId)- : sessions;+ ? validSessions.filter((s) => s.agentId === filterAgentId)+ : validSessions;const facets =req.query_params?.["facets"] === "true"? sessionFacets(!wildcardAgent && isAgentScopeIsolated()- ? sessions.filter((s) => s.agentId === getAgentId())- : sessions,+ ? validSessions.filter((s) => s.agentId === getAgentId())+ : validSessions,): undefined;if (listQuery.project) filtered = filtered.filter((s) => s.project === listQuery.project);diff --git a/src/triggers/events.ts b/src/triggers/events.tsindex 42c058c8..9a271ce3 100644--- a/src/triggers/events.ts+++ b/src/triggers/events.ts@@ -184,13 +184,24 @@ export function registerEventTriggers(sdk: IIIClient, kv: StateKV): void {sdk.registerFunction("event::session::ended",async (data: { sessionId: string }) => {- await withKeyedLock(`obs:${data.sessionId}`, () =>- kv.update(KV.sessions, data.sessionId, [+ const sessionId = data?.sessionId;+ if (typeof sessionId !== "string" || sessionId.length === 0) {+ return { success: true, ended: false, reason: "not_found" as const };+ }+ const endResult = await withKeyedLock(`obs:${sessionId}`, async () => {+ const session = await kv.get<Session>(KV.sessions, sessionId);+ if (!session || session.id !== sessionId) return "not_found" as const;+ if (session.status === "completed") return "already_completed" as const;+ await kv.update(KV.sessions, sessionId, [{ type: "set", path: "endedAt", value: new Date().toISOString() },{ type: "set", path: "status", value: "completed" },- ]),- );- return { success: true };+ ]);+ return "ended" as const;+ });+ if (endResult !== "ended") {+ return { success: true, ended: false, reason: endResult };+ }+ return { success: true, ended: true };},);sdk.registerTrigger({diff --git a/test/session-lifecycle-api.test.ts b/test/session-lifecycle-api.test.tsnew file mode 100644index 00000000..0fe7081f--- /dev/null+++ b/test/session-lifecycle-api.test.ts@@ -0,0 +1,246 @@+import { describe, expect, it, vi } from "vitest";++vi.mock("iii-sdk", async (importOriginal) => {+ const actual = await importOriginal<typeof import("iii-sdk")>();+ return {+ ...actual,+ TriggerAction: {+ ...actual.TriggerAction,+ Void: vi.fn(() => ({ type: "void" })),+ },+ };+});++import { registerApiTriggers } from "../src/triggers/api.js";+import { registerEventTriggers } from "../src/triggers/events.js";+import { KV } from "../src/state/schema.js";+import type { Session } from "../src/types.js";++type ApiResponse = {+ status_code: number;+ body: Record<string, unknown>;+};++function makeHarness(sessionRows: Array<[string, unknown]> = []) {+ const store = new Map<string, Map<string, unknown>>([+ [KV.sessions, new Map(sessionRows)],+ [KV.summaries, new Map()],+ ]);+ const functions = new Map<string, Function>();+ const trigger = vi.fn(async () => undefined);+ const update = vi.fn(+ async (+ scope: string,+ key: string,+ ops: Array<{ type: "set" | "remove"; path: string; value?: unknown }>,+ ) => {+ const values = store.get(scope) ?? new Map<string, unknown>();+ store.set(scope, values);+ const existing = values.get(key);+ const next =+ existing && typeof existing === "object"+ ? { ...(existing as Record<string, unknown>) }+ : {};+ for (const op of ops) {+ if (op.type === "remove") delete next[op.path];+ else next[op.path] = op.value;+ }+ values.set(key, next);+ return next;+ },+ );+ const kv = {+ get: vi.fn(async (scope: string, key: string) => {+ if (typeof key !== "string" || key.length === 0) {+ throw new Error("state::get requires a non-empty key");+ }+ return store.get(scope)?.get(key) ?? null;+ }),+ set: vi.fn(),+ update,+ delete: vi.fn(),+ list: vi.fn(async (scope: string) =>+ Array.from(store.get(scope)?.values() ?? []),+ ),+ };+ const sdk = {+ registerFunction: (id: string, handler: Function) => functions.set(id, handler),+ registerTrigger: vi.fn(),+ trigger,+ };++ registerApiTriggers(sdk as never, kv as never);+ registerEventTriggers(sdk as never, kv as never);++ return { functions, kv, store, trigger, update };+}++function session(id: string, status: Session["status"] = "active"): Session {+ return {+ id,+ project: "test-project",+ cwd: "/tmp/test-project",+ startedAt: "2026-08-26T00:00:00.000Z",+ status,+ observationCount: 1,+ };+}++describe("session lifecycle API", () => {+ it("treats ending an unknown session as a no-op without creating a partial row", async () => {+ const harness = makeHarness();+ const handler = harness.functions.get("api::session::end")!;++ const response = (await handler({+ body: { sessionId: "agent:dmp-pm:direct:test" },+ })) as ApiResponse;++ expect(response).toEqual({+ status_code: 200,+ body: { success: true, ended: false, reason: "not_found" },+ });+ expect(harness.update).not.toHaveBeenCalled();+ expect(harness.store.get(KV.sessions)).toEqual(new Map());+ expect(harness.trigger).not.toHaveBeenCalledWith(+ expect.objectContaining({ function_id: "event::session::stopped" }),+ );+ });++ it("does not treat an existing partial row as a valid session", async () => {+ const sessionId = "agent:dmp-pm:direct:partial";+ const harness = makeHarness([+ [sessionId, { status: "completed", endedAt: "2026-08-26T00:00:00.000Z" }],+ ]);+ const handler = harness.functions.get("api::session::end")!;++ const response = (await handler({ body: { sessionId } })) as ApiResponse;++ expect(response.body).toEqual({+ success: true,+ ended: false,+ reason: "not_found",+ });+ expect(harness.update).not.toHaveBeenCalled();+ });++ it("treats ending an already-completed session as a no-op", async () => {+ const sessionId = "agent:dmp-pm:direct:completed";+ const harness = makeHarness([[sessionId, session(sessionId, "completed")]]);+ const handler = harness.functions.get("api::session::end")!;++ const response = (await handler({ body: { sessionId } })) as ApiResponse;++ expect(response).toEqual({+ status_code: 200,+ body: { success: true, ended: false, reason: "already_completed" },+ });+ expect(harness.update).not.toHaveBeenCalled();+ expect(harness.trigger).not.toHaveBeenCalled();+ });++ it("ends an existing session and publishes the stopped lifecycle once", async () => {+ const sessionId = "agent:dmp-pm:direct:existing";+ const harness = makeHarness([[sessionId, session(sessionId)]]);+ const handler = harness.functions.get("api::session::end")!;++ const response = (await handler({ body: { sessionId } })) as ApiResponse;++ expect(response.body).toEqual({ success: true, ended: true });+ expect(harness.store.get(KV.sessions)?.get(sessionId)).toMatchObject({+ id: sessionId,+ status: "completed",+ endedAt: expect.any(String),+ });+ expect(harness.trigger).toHaveBeenCalledTimes(1);+ expect(harness.trigger).toHaveBeenCalledWith(+ expect.objectContaining({+ function_id: "event::session::stopped",+ payload: { sessionId },+ }),+ );+ });++ it("skips malformed rows when listing sessions and never reads an undefined summary key", async () => {+ const valid = session("ses_valid", "completed");+ const harness = makeHarness([+ [valid.id, valid],+ ["agent:dmp-pm:direct:partial", { status: "completed", endedAt: "2026-08-26T00:00:00.000Z" }],+ ]);+ const handler = harness.functions.get("api::sessions")!;++ const response = (await handler({+ headers: {},+ query_params: { agentId: "*" },+ })) as ApiResponse;++ expect(response.status_code).toBe(200);+ expect(response.body.sessions).toEqual([valid]);+ expect(harness.kv.get).toHaveBeenCalledWith(KV.summaries, valid.id);+ expect(harness.kv.get).not.toHaveBeenCalledWith(KV.summaries, undefined);+ });+});++describe("event::session::ended", () => {+ it("ignores an unknown session without creating a partial row", async () => {+ const harness = makeHarness();+ const handler = harness.functions.get("event::session::ended")!;++ const result = await handler({ sessionId: "agent:dmp-pm:direct:test" });++ expect(result).toEqual({ success: true, ended: false, reason: "not_found" });+ expect(harness.update).not.toHaveBeenCalled();+ expect(harness.store.get(KV.sessions)).toEqual(new Map());+ });++ it("ignores a malformed session id", async () => {+ const harness = makeHarness();+ const handler = harness.functions.get("event::session::ended")!;++ const result = await handler({});++ expect(result).toEqual({ success: true, ended: false, reason: "not_found" });+ expect(harness.kv.get).not.toHaveBeenCalled();+ expect(harness.update).not.toHaveBeenCalled();+ });++ it("does not treat an existing partial row as a valid session", async () => {+ const sessionId = "agent:dmp-pm:direct:partial";+ const harness = makeHarness([[sessionId, { status: "active" }]]);+ const handler = harness.functions.get("event::session::ended")!;++ const result = await handler({ sessionId });++ expect(result).toEqual({ success: true, ended: false, reason: "not_found" });+ expect(harness.update).not.toHaveBeenCalled();+ });++ it("leaves an already-completed session untouched", async () => {+ const sessionId = "agent:dmp-pm:direct:completed";+ const harness = makeHarness([[sessionId, session(sessionId, "completed")]]);+ const handler = harness.functions.get("event::session::ended")!;++ const result = await handler({ sessionId });++ expect(result).toEqual({+ success: true,+ ended: false,+ reason: "already_completed",+ });+ expect(harness.update).not.toHaveBeenCalled();+ });++ it("completes an existing active session", async () => {+ const sessionId = "agent:dmp-pm:direct:existing";+ const harness = makeHarness([[sessionId, session(sessionId)]]);+ const handler = harness.functions.get("event::session::ended")!;++ const result = await handler({ sessionId });++ expect(result).toEqual({ success: true, ended: true });+ expect(harness.store.get(KV.sessions)?.get(sessionId)).toMatchObject({+ id: sessionId,+ status: "completed",+ endedAt: expect.any(String),+ });+ });+});