Skip to content

#1 Persistent memory for AI coding agents based on real-world benchmarks

fix(config): strip inline `#` comments and route /config/flags through merged env

Rohit Ghumare293e008756c1
diff --git a/src/config.ts b/src/config.ts
index 09bf2290..733ecf7c 100644
--- a/src/config.ts
+++ b/src/config.ts
@@ -30,11 +30,14 @@ function loadEnvFile(): Record<string, string> {
if (eqIdx === -1) continue;
const key = trimmed.slice(0, eqIdx).trim();
let val = trimmed.slice(eqIdx + 1).trim();
- if (
+ const quoted =
(val.startsWith('"') && val.endsWith('"')) ||
- (val.startsWith("'") && val.endsWith("'"))
- ) {
+ (val.startsWith("'") && val.endsWith("'"));
+ if (quoted) {
val = val.slice(1, -1);
+ } else {
+ const hashIdx = val.indexOf(" #");
+ if (hashIdx !== -1) val = val.slice(0, hashIdx).trim();
}
vars[key] = val;
}
diff --git a/src/triggers/api.ts b/src/triggers/api.ts
index d4bd5f9b..ac7c74e8 100644
--- a/src/triggers/api.ts
+++ b/src/triggers/api.ts
@@ -14,6 +14,7 @@ import {
isAutoCompressEnabled,
isContextInjectionEnabled,
detectEmbeddingProvider,
+ getEnvVar,
} from "../config.js";
type Response = {
@@ -153,8 +154,13 @@ export function registerApiTriggers(
async (req: ApiRequest): Promise<Response> => {
const authErr = checkAuth(req, secret);
if (authErr) return authErr;
- const env = process.env;
- const providerKind = env["ANTHROPIC_API_KEY"] || env["GEMINI_API_KEY"] || env["OPENROUTER_API_KEY"] || env["MINIMAX_API_KEY"] ? "llm" : "noop";
+ const providerKind =
+ getEnvVar("ANTHROPIC_API_KEY") ||
+ getEnvVar("GEMINI_API_KEY") ||
+ getEnvVar("OPENROUTER_API_KEY") ||
+ getEnvVar("MINIMAX_API_KEY")
+ ? "llm"
+ : "noop";
const embeddingProvider = detectEmbeddingProvider() ? "embeddings" : "none";
const flags = [
{
diff --git a/test/env-loader.test.ts b/test/env-loader.test.ts
new file mode 100644
index 00000000..ceb8c321
--- /dev/null
+++ b/test/env-loader.test.ts
@@ -0,0 +1,71 @@
+import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
+import { mkdtempSync, writeFileSync, mkdirSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+const ORIGINAL_HOME = process.env["HOME"];
+const ORIGINAL_USERPROFILE = process.env["USERPROFILE"];
+
+let sandboxHome: string;
+
+async function freshConfig() {
+ vi.resetModules();
+ return await import("../src/config.js");
+}
+
+function writeEnv(contents: string) {
+ const dir = join(sandboxHome, ".agentmemory");
+ mkdirSync(dir, { recursive: true });
+ writeFileSync(join(dir, ".env"), contents);
+}
+
+describe("loadEnvFile", () => {
+ beforeEach(() => {
+ sandboxHome = mkdtempSync(join(tmpdir(), "agentmemory-env-"));
+ process.env["HOME"] = sandboxHome;
+ process.env["USERPROFILE"] = sandboxHome;
+ delete process.env["AGENTMEMORY_AUTO_COMPRESS"];
+ delete process.env["CONSOLIDATION_ENABLED"];
+ delete process.env["GRAPH_EXTRACTION_ENABLED"];
+ delete process.env["TOKEN"];
+ delete process.env["HASHVAL"];
+ });
+
+ afterEach(() => {
+ process.env["HOME"] = ORIGINAL_HOME;
+ process.env["USERPROFILE"] = ORIGINAL_USERPROFILE;
+ rmSync(sandboxHome, { recursive: true, force: true });
+ });
+
+ it("strips trailing inline # comments on unquoted values", async () => {
+ writeEnv(
+ [
+ "AGENTMEMORY_AUTO_COMPRESS=true # opt in to LLM compression",
+ "CONSOLIDATION_ENABLED=true # daily summarization",
+ "GRAPH_EXTRACTION_ENABLED=true # entity graph",
+ ].join("\n"),
+ );
+ const cfg = await freshConfig();
+ expect(cfg.isAutoCompressEnabled()).toBe(true);
+ expect(cfg.isConsolidationEnabled()).toBe(true);
+ expect(cfg.isGraphExtractionEnabled()).toBe(true);
+ });
+
+ it("preserves # inside double-quoted values", async () => {
+ writeEnv('TOKEN="abc#def"');
+ const cfg = await freshConfig();
+ expect(cfg.getEnvVar("TOKEN")).toBe("abc#def");
+ });
+
+ it("preserves # inside single-quoted values", async () => {
+ writeEnv("TOKEN='abc#def'");
+ const cfg = await freshConfig();
+ expect(cfg.getEnvVar("TOKEN")).toBe("abc#def");
+ });
+
+ it("treats hash without leading space as part of value", async () => {
+ writeEnv("HASHVAL=abc#def");
+ const cfg = await freshConfig();
+ expect(cfg.getEnvVar("HASHVAL")).toBe("abc#def");
+ });
+});