Skip to content

#1 Persistent memory for AI coding agents based on real-world benchmarks

fix: route semantic memory eviction to correct KV store using source tracking

Tanmay-0083445314c50e9
diff --git a/src/functions/retention.ts b/src/functions/retention.ts
index 27753fdc..ed4e0b10 100644
--- a/src/functions/retention.ts
+++ b/src/functions/retention.ts
@@ -110,6 +110,7 @@ export function registerRetentionFunctions(
reinforcementBoost: 0,
lastAccessed: mem.updatedAt,
accessCount: 0,
+ source: "episodic",
};
scores.push(entry);
@@ -145,6 +146,7 @@ export function registerRetentionFunctions(
),
lastAccessed: sem.lastAccessedAt,
accessCount: sem.accessCount,
+ source: "semantic",
};
scores.push(entry);
@@ -216,9 +218,15 @@ export function registerRetentionFunctions(
let evicted = 0;
for (const candidate of candidates) {
try {
- await kv.delete(KV.memories, candidate.memoryId);
- await kv.delete(KV.retentionScores, candidate.memoryId);
- evicted++;
+ if (candidate.source === "semantic") {
+ await kv.delete(KV.semantic, candidate.memoryId);
+ await kv.delete(KV.retentionScores, candidate.memoryId);
+ evicted++;
+ } else {
+ await kv.delete(KV.memories, candidate.memoryId);
+ await kv.delete(KV.retentionScores, candidate.memoryId);
+ evicted++;
+ }
} catch {
continue;
}
diff --git a/src/types.ts b/src/types.ts
index 8a600651..27ba680d 100644
--- a/src/types.ts
+++ b/src/types.ts
@@ -435,39 +435,39 @@ export interface AuditEntry {
id: string;
timestamp: string;
operation:
- | "observe"
- | "compress"
- | "remember"
- | "forget"
- | "evolve"
- | "consolidate"
- | "share"
- | "delete"
- | "import"
- | "export"
- | "action_create"
- | "action_update"
- | "lease_acquire"
- | "lease_release"
- | "routine_run"
- | "signal_send"
- | "checkpoint_resolve"
- | "mesh_sync"
- | "sentinel_create"
- | "sentinel_trigger"
- | "sketch_create"
- | "sketch_promote"
- | "sketch_discard"
- | "crystallize"
- | "diagnose"
- | "heal"
- | "facet_tag"
- | "lesson_save"
- | "lesson_recall"
- | "lesson_strengthen"
- | "obsidian_export"
- | "reflect"
- | "insight_search";
+ | "observe"
+ | "compress"
+ | "remember"
+ | "forget"
+ | "evolve"
+ | "consolidate"
+ | "share"
+ | "delete"
+ | "import"
+ | "export"
+ | "action_create"
+ | "action_update"
+ | "lease_acquire"
+ | "lease_release"
+ | "routine_run"
+ | "signal_send"
+ | "checkpoint_resolve"
+ | "mesh_sync"
+ | "sentinel_create"
+ | "sentinel_trigger"
+ | "sketch_create"
+ | "sketch_promote"
+ | "sketch_discard"
+ | "crystallize"
+ | "diagnose"
+ | "heal"
+ | "facet_tag"
+ | "lesson_save"
+ | "lesson_recall"
+ | "lesson_strengthen"
+ | "obsidian_export"
+ | "reflect"
+ | "insight_search";
userId?: string;
functionId: string;
targetIds: string[];
@@ -779,6 +779,7 @@ export interface RetentionScore {
reinforcementBoost: number;
lastAccessed: string;
accessCount: number;
+ source?: "episodic" | "semantic";
}
export interface DecayConfig {
diff --git a/test/retention.test.ts b/test/retention.test.ts
index 70932b6c..f9346584 100644
--- a/test/retention.test.ts
+++ b/test/retention.test.ts
@@ -242,4 +242,37 @@ describe("RetentionScoring", () => {
const sem2 = result.scores.find((s: any) => s.memoryId === "sem_2");
expect(sem1.score).toBeGreaterThan(sem2.score);
});
+
+ it("evicts both episodic and semantic memories from correct stores", async () => {
+ const { registerRetentionFunctions } = await import(
+ "../src/functions/retention.js"
+ );
+
+ const memories = [
+ makeMemory("mem_old", "fact", 1000),
+ ];
+ const semanticMems = [
+ makeSemanticMemory("sem_old", 1000, 0),
+ ];
+
+ const sdk = mockSdk();
+ const kv = mockKV(memories, semanticMems);
+ registerRetentionFunctions(sdk as never, kv as never);
+
+ await sdk.trigger("mem::retention-score", {});
+
+ expect((await kv.list("mem:memories")).length).toBe(1);
+ expect((await kv.list("mem:semantic")).length).toBe(1);
+
+ const evictResult = (await sdk.trigger("mem::retention-evict", {
+ threshold: 0.5,
+ dryRun: false,
+ })) as any;
+
+ expect(evictResult.success).toBe(true);
+ expect(evictResult.evicted).toBe(2);
+
+ expect((await kv.list("mem:memories")).length).toBe(0);
+ expect((await kv.list("mem:semantic")).length).toBe(0);
+ });
});