#1 Persistent memory for AI coding agents based on real-world benchmarks
TypeScript agentmemoryagentsaiclaudeclaudecodecodexcopilotcursorgenaiharnesshermesmemoryompopenclawopencodepi
fix(config): handle quoted values with trailing inline comments + reuse provider detection
Rohit Ghumare47184fdf171f
diff --git a/src/config.ts b/src/config.tsindex 733ecf7c..2898552d 100644--- a/src/config.ts+++ b/src/config.ts@@ -30,11 +30,10 @@ function loadEnvFile(): Record<string, string> {if (eqIdx === -1) continue;const key = trimmed.slice(0, eqIdx).trim();let val = trimmed.slice(eqIdx + 1).trim();- const quoted =- (val.startsWith('"') && val.endsWith('"')) ||- (val.startsWith("'") && val.endsWith("'"));- if (quoted) {- val = val.slice(1, -1);+ const quoteChar = val[0] === '"' || val[0] === "'" ? val[0] : "";+ if (quoteChar) {+ const closeIdx = val.indexOf(quoteChar, 1);+ if (closeIdx !== -1) val = val.slice(1, closeIdx);} else {const hashIdx = val.indexOf(" #");if (hashIdx !== -1) val = val.slice(0, hashIdx).trim();@@ -150,6 +149,20 @@ export function getEnvVar(key: string): string | undefined {return getMergedEnv()[key];}+export function detectLlmProviderKind(): "llm" | "noop" {+ const env = getMergedEnv();+ if (+ hasRealValue(env["ANTHROPIC_API_KEY"]) ||+ hasRealValue(env["GEMINI_API_KEY"]) ||+ hasRealValue(env["GOOGLE_API_KEY"]) ||+ hasRealValue(env["OPENROUTER_API_KEY"]) ||+ hasRealValue(env["MINIMAX_API_KEY"])+ ) {+ return "llm";+ }+ return "noop";+}+export function loadEmbeddingConfig(): EmbeddingConfig {const env = getMergedEnv();let bm25Weight = parseFloat(env["BM25_WEIGHT"] || "0.4");diff --git a/src/triggers/api.ts b/src/triggers/api.tsindex ac7c74e8..75549a9a 100644--- a/src/triggers/api.ts+++ b/src/triggers/api.ts@@ -14,7 +14,7 @@ import {isAutoCompressEnabled,isContextInjectionEnabled,detectEmbeddingProvider,- getEnvVar,+ detectLlmProviderKind,} from "../config.js";type Response = {@@ -154,13 +154,7 @@ export function registerApiTriggers(async (req: ApiRequest): Promise<Response> => {const authErr = checkAuth(req, secret);if (authErr) return authErr;- const providerKind =- getEnvVar("ANTHROPIC_API_KEY") ||- getEnvVar("GEMINI_API_KEY") ||- getEnvVar("OPENROUTER_API_KEY") ||- getEnvVar("MINIMAX_API_KEY")- ? "llm"- : "noop";+ const providerKind = detectLlmProviderKind();const embeddingProvider = detectEmbeddingProvider() ? "embeddings" : "none";const flags = [{diff --git a/test/env-loader.test.ts b/test/env-loader.test.tsindex ceb8c321..9c6f2955 100644--- a/test/env-loader.test.ts+++ b/test/env-loader.test.ts@@ -32,8 +32,10 @@ describe("loadEnvFile", () => {});afterEach(() => {- process.env["HOME"] = ORIGINAL_HOME;- process.env["USERPROFILE"] = ORIGINAL_USERPROFILE;+ if (ORIGINAL_HOME === undefined) delete process.env["HOME"];+ else process.env["HOME"] = ORIGINAL_HOME;+ if (ORIGINAL_USERPROFILE === undefined) delete process.env["USERPROFILE"];+ else process.env["USERPROFILE"] = ORIGINAL_USERPROFILE;rmSync(sandboxHome, { recursive: true, force: true });});@@ -68,4 +70,16 @@ describe("loadEnvFile", () => {const cfg = await freshConfig();expect(cfg.getEnvVar("HASHVAL")).toBe("abc#def");});++ it("strips inline comment after a quoted value and unwraps quotes", async () => {+ writeEnv('TOKEN="abc" # trailing comment');+ const cfg = await freshConfig();+ expect(cfg.getEnvVar("TOKEN")).toBe("abc");+ });++ it("strips inline comment after a single-quoted value and unwraps quotes", async () => {+ writeEnv("TOKEN='abc' # trailing comment");+ const cfg = await freshConfig();+ expect(cfg.getEnvVar("TOKEN")).toBe("abc");+ });});