Skip to content

#1 Persistent memory for AI coding agents based on real-world benchmarks

fix: viewer security hardening and evolve write ordering (#69)

Rohit Ghumare4a3f1ca6bb47
diff --git a/src/functions/relations.ts b/src/functions/relations.ts
index ebdc38c1..d2958253 100644
--- a/src/functions/relations.ts
+++ b/src/functions/relations.ts
@@ -128,11 +128,11 @@ export function registerRelationsFunction(sdk: ISdk, kv: StateKV): void {
isLatest: true,
};
- await kv.set(KV.memories, evolved.id, evolved);
-
existing.isLatest = false;
await kv.set(KV.memories, existing.id, existing);
+ await kv.set(KV.memories, evolved.id, evolved);
+
const relation: MemoryRelation = {
type: "supersedes",
sourceId: evolved.id,
diff --git a/src/viewer/server.ts b/src/viewer/server.ts
index 961e099d..b0b597fb 100644
--- a/src/viewer/server.ts
+++ b/src/viewer/server.ts
@@ -25,6 +25,7 @@ import type { StateKV } from "../state/kv.js";
import { getLatestHealth } from "../health/monitor.js";
import type { MetricsStore } from "../eval/metrics-store.js";
import type { ResilientProvider } from "../providers/resilient.js";
+import { timingSafeCompare, VIEWER_CSP } from "../auth.js";
const ALLOWED_ORIGINS = (
process.env.VIEWER_ALLOWED_ORIGINS ||
@@ -81,7 +82,9 @@ function readBody(req: IncomingMessage): Promise<string> {
function checkAuth(req: IncomingMessage, secret: string | undefined): boolean {
if (!secret) return true;
const auth = req.headers["authorization"] || "";
- return auth === `Bearer ${secret}`;
+ return (
+ typeof auth === "string" && timingSafeCompare(auth, `Bearer ${secret}`)
+ );
}
function gid(prefix: string): string {
@@ -422,6 +425,7 @@ export function startViewerServer(
const html = readFileSync(p, "utf-8");
res.writeHead(200, {
"Content-Type": "text/html; charset=utf-8",
+ "Content-Security-Policy": VIEWER_CSP,
"Cache-Control": "no-cache",
});
res.end(html);
@@ -684,6 +688,11 @@ async function handleApiRoute(
}
if (method === "POST") {
+ const ct = req.headers["content-type"] || "";
+ if (ct && !ct.includes("application/json")) {
+ json(res, 415, { error: "Content-Type must be application/json" }, req);
+ return;
+ }
let body: Record<string, unknown> = {};
try {
const raw = await readBody(req);
@@ -785,6 +794,11 @@ async function handleApiRoute(
}
if (method === "DELETE" && path === "governance/memories") {
+ const ct = req.headers["content-type"] || "";
+ if (ct && !ct.includes("application/json")) {
+ json(res, 415, { error: "Content-Type must be application/json" }, req);
+ return;
+ }
let body: Record<string, unknown> = {};
try {
const raw = await readBody(req);