Skip to content

#1 Persistent memory for AI coding agents based on real-world benchmarks

fix(embeddings): ignore OpenRouter variant suffixes in the dimension lookup (#1502)

Nanami55542d9bdd12
diff --git a/src/providers/embedding/_dimensions.ts b/src/providers/embedding/_dimensions.ts
index f264e8a9..01ac9811 100644
--- a/src/providers/embedding/_dimensions.ts
+++ b/src/providers/embedding/_dimensions.ts
@@ -20,12 +20,15 @@ const MODEL_DIMENSIONS: Record<string, number> = {
const DEFAULT_DIMENSIONS = 1536;
-function lookupModelDimensions(model: string): number | undefined {
- if (model in MODEL_DIMENSIONS) return MODEL_DIMENSIONS[model];
+function lookupModelDimensions(rawModel: string): number | undefined {
+ // OpenRouter variant suffixes (":floor", ":nitro") pick a provider, not a
+ // different model, so the vectors keep the base model's width.
+ const model = rawModel.replace(/:[^/:]+$/, "");
+ if (Object.hasOwn(MODEL_DIMENSIONS, model)) return MODEL_DIMENSIONS[model];
const slash = model.indexOf("/");
if (slash === -1) return undefined;
const bare = model.slice(slash + 1);
- return MODEL_DIMENSIONS[bare];
+ return Object.hasOwn(MODEL_DIMENSIONS, bare) ? MODEL_DIMENSIONS[bare] : undefined;
}
export function resolveDimensions(
diff --git a/test/embedding-dimensions.test.ts b/test/embedding-dimensions.test.ts
index 51b3b084..0f57183e 100644
--- a/test/embedding-dimensions.test.ts
+++ b/test/embedding-dimensions.test.ts
@@ -37,6 +37,16 @@ describe("resolveDimensions", () => {
);
});
+ it("ignores an OpenRouter variant suffix on the model id", () => {
+ expect(resolveDimensions("openai/text-embedding-3-large:floor", undefined, ENV)).toBe(3072);
+ expect(resolveDimensions("openai/text-embedding-3-large:nitro", undefined, ENV)).toBe(3072);
+ expect(resolveDimensions("text-embedding-3-large:floor", undefined, ENV)).toBe(3072);
+ expect(resolveDimensions("acme/unknown-embed:floor", undefined, ENV)).toBe(1536);
+ expect(resolveDimensions("acme/constructor:floor", undefined, ENV)).toBe(1536);
+ expect(resolveDimensions("toString", undefined, ENV)).toBe(1536);
+ expect(resolveDimensions("openai/text-embedding-3-large:floor", "256", ENV)).toBe(256);
+ });
+
it("falls back to the default (1536) for unknown models", () => {
expect(resolveDimensions("mystery-self-hosted-model", undefined, ENV)).toBe(1536);
expect(resolveDimensions("someprovider/unknown-model", undefined, ENV)).toBe(1536);