#1 Persistent memory for AI coding agents based on real-world benchmarks
TypeScript agentmemoryagentsaiclaudeclaudecodecodexcopilotcursorgenaiharnesshermesmemoryompopenclawopencodepi
fix: address remaining CodeRabbit findings from second review
Rohit Ghumare580bad98339d
diff --git a/src/config.ts b/src/config.tsindex fcc6491a..b9545a5e 100644--- a/src/config.ts+++ b/src/config.ts@@ -97,12 +97,16 @@ export function getEnvVar(key: string): string | undefined {export function loadEmbeddingConfig(): EmbeddingConfig {const env = getMergedEnv();- const bm25Weight = parseFloat(env["BM25_WEIGHT"] || "0.4");- const vectorWeight = parseFloat(env["VECTOR_WEIGHT"] || "0.6");+ let bm25Weight = parseFloat(env["BM25_WEIGHT"] || "0.4");+ let vectorWeight = parseFloat(env["VECTOR_WEIGHT"] || "0.6");+ bm25Weight =+ isNaN(bm25Weight) || bm25Weight < 0 ? 0.4 : Math.min(bm25Weight, 1);+ vectorWeight =+ isNaN(vectorWeight) || vectorWeight < 0 ? 0.6 : Math.min(vectorWeight, 1);return {provider: env["EMBEDDING_PROVIDER"] || undefined,- bm25Weight: isNaN(bm25Weight) ? 0.4 : bm25Weight,- vectorWeight: isNaN(vectorWeight) ? 0.6 : vectorWeight,+ bm25Weight,+ vectorWeight,};}@@ -121,12 +125,22 @@ export function detectEmbeddingProvider(return null;}+const VALID_PROVIDERS = new Set([+ "anthropic",+ "gemini",+ "openrouter",+ "agent-sdk",+]);+export function loadFallbackConfig(): FallbackConfig {const env = getMergedEnv();const raw = env["FALLBACK_PROVIDERS"] || "";const providers = raw.split(",").map((p) => p.trim())- .filter(Boolean) as FallbackConfig["providers"];+ .filter(+ (p): p is FallbackConfig["providers"][number] =>+ Boolean(p) && VALID_PROVIDERS.has(p),+ );return { providers };}diff --git a/src/functions/remember.ts b/src/functions/remember.tsindex 4206d28b..739f6331 100644--- a/src/functions/remember.ts+++ b/src/functions/remember.ts@@ -33,17 +33,19 @@ export function registerRememberFunction(sdk: ISdk, kv: StateKV): void {const existingMemories = await kv.list<Memory>(KV.memories);let supersededId: string | undefined;+ let supersededVersion = 1;+ let supersededMemory: Memory | undefined;const lowerContent = data.content.toLowerCase();for (const existing of existingMemories) {- if (!existing.isLatest) continue;+ if (existing.isLatest === false) continue;const similarity = jaccardSimilarity(lowerContent,existing.content.toLowerCase(),);if (similarity > 0.7) {- existing.isLatest = false;- await kv.set(KV.memories, existing.id, existing);supersededId = existing.id;+ supersededVersion = existing.version ?? 1;+ supersededMemory = existing;break;}}@@ -59,16 +61,17 @@ export function registerRememberFunction(sdk: ISdk, kv: StateKV): void {files: data.files || [],sessionIds: [],strength: 7,- version: supersededId- ? (existingMemories.find((m) => m.id === supersededId)?.version ??- 1) + 1- : 1,+ version: supersededId ? supersededVersion + 1 : 1,parentId: supersededId,supersedes: supersededId ? [supersededId] : [],isLatest: true,};await kv.set(KV.memories, memory.id, memory);+ if (supersededMemory) {+ supersededMemory.isLatest = false;+ await kv.set(KV.memories, supersededMemory.id, supersededMemory);+ }ctx.logger.info("Memory saved", {memId: memory.id,diff --git a/src/index.ts b/src/index.tsindex 897242fc..90c120f4 100644--- a/src/index.ts+++ b/src/index.ts@@ -149,7 +149,12 @@ async function main() {}}- if (!loaded?.bm25 || loaded.bm25.size === 0) {+ const needsRebuild =+ !loaded?.bm25 ||+ loaded.bm25.size === 0 ||+ (embeddingProvider && vectorIndex && vectorIndex.size === 0);++ if (needsRebuild) {const indexCount = await rebuildIndex(kv).catch((err) => {console.warn(`[agentmemory] Failed to rebuild search index:`, err);return 0;@@ -172,7 +177,9 @@ async function main() {healthMonitor.stop();dedupMap.stop();indexPersistence.stop();- await indexPersistence.save().catch(() => {});+ await indexPersistence.save().catch((err) => {+ console.warn(`[agentmemory] Failed to save index on shutdown:`, err);+ });await sdk.shutdown();process.exit(0);};diff --git a/src/state/hybrid-search.ts b/src/state/hybrid-search.tsindex a4a61cf8..b09d0d1e 100644--- a/src/state/hybrid-search.ts+++ b/src/state/hybrid-search.ts@@ -114,14 +114,19 @@ export class HybridSearch {}>,limit: number,): Promise<HybridSearchResult[]> {+ const sliced = results.slice(0, limit);+ const observations = await Promise.all(+ sliced.map((r) =>+ this.kv+ .get<CompressedObservation>(KV.observations(r.sessionId), r.obsId)+ .catch(() => null),+ ),+ );const enriched: HybridSearchResult[] = [];- for (const r of results.slice(0, limit)) {- const obs = await this.kv.get<CompressedObservation>(- KV.observations(r.sessionId),- r.obsId,- );+ for (let i = 0; i < sliced.length; i++) {+ const obs = observations[i];if (obs) {- enriched.push({ observation: obs, ...r });+ enriched.push({ observation: obs, ...sliced[i] });}}return enriched;diff --git a/src/triggers/api.ts b/src/triggers/api.tsindex 518cb77c..20078ee0 100644--- a/src/triggers/api.ts+++ b/src/triggers/api.ts@@ -373,6 +373,15 @@ export function registerApiTriggers(): Promise<Response> => {const authErr = checkAuth(req, secret);if (authErr) return authErr;+ if (+ !req.body?.query &&+ (!req.body?.expandIds || req.body.expandIds.length === 0)+ ) {+ return {+ status_code: 400,+ body: { error: "query or expandIds is required" },+ };+ }const result = await sdk.trigger("mem::smart-search", req.body);return { status_code: 200, body: result };},